From nobody Wed Apr 15 13:30:11 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2369EC43219 for ; Thu, 17 Nov 2022 00:24:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232846AbiKQAYD (ORCPT ); Wed, 16 Nov 2022 19:24:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57214 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234170AbiKQAYA (ORCPT ); Wed, 16 Nov 2022 19:24:00 -0500 Received: from mail-pj1-x104a.google.com (mail-pj1-x104a.google.com [IPv6:2607:f8b0:4864:20::104a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CBE5B61BBB for ; Wed, 16 Nov 2022 16:23:58 -0800 (PST) Received: by mail-pj1-x104a.google.com with SMTP id b1-20020a17090a10c100b0020da29fa5e5so227314pje.2 for ; Wed, 16 Nov 2022 16:23:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:from:to:cc:subject:date:message-id:reply-to; bh=f1KDr+rH3XIqQLVQCEwig1RrLbtV2JH7CIwItqPq0uE=; b=Sb0CLlnDvxGcJjdPFEdXu3sQ7ExS0J2DsrUa96MG+x30pOPo41C8wX8lnkjEvFu692 o3pvJ4nlLGDjV9D5+o/Xc1NHyPs2MuqEv5vvIqZ+sqZzIL/ssXgFKRuEh3ykOWsb8Aof 8NuSb0SC0FoNWARBXd8nIP1nNXh5DasKaX+CcaBKFNHtvZl56/253TE6fwjP5JoMpiim gUPzWrrXnAvNi8nnM084PxpxGvTGH19Xn+GRoqghoBS14moljDfd44Cr3RqglOvym254 gzMKd+B+aCWjFP6TQW5RMTEuFyf2CyJjQHrsUsqBJWG2Qn401exrcaqrEcOx43Ax6pEw +BbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=f1KDr+rH3XIqQLVQCEwig1RrLbtV2JH7CIwItqPq0uE=; b=PHLgzBinkcVhsyCqQGNVoBNxpwUc26rTiZeag3/erwEKzfmzehITTf0OYG7Oj84soy JoM50KXzT+baHF/Dgk+w+0pJEDJbtGd2UuvpqffCL2/GB3ulUqS7gGoM+6OYgo7tFv3k BQrHGb/iwGK7Ue8dX40kHuVzeDR7xYj2cCiRlmi+5j7LCOmjhE1kb5JDIe0hDx2BLM9U jCjhQVXNzfNky0Hg43ww53N4nWyGiYUm4EGhO/MqviYLEXpL7gQ19LjJUnAVhlDQAoHG SkCdPLC/yay7DNs+yfj/FeTDrtv0tWAapQXVShgXtFQoiqeaWov/AUnhGUtJkbUIqrSA EWrA== X-Gm-Message-State: ANoB5pmMp+V3iDMWBeQ7fDbhq9z7oW85j1aH3INDtFTFqe3sfw7C1bxx rUPNkW4BiA9hdh4xdAq4qI7iQ9JCnfI= X-Google-Smtp-Source: AA0mqf413lvrUg1TdHwZHTgN7XZflJ1bKJMT3jX1WCVJjGcPVxVBe4WRIWEnFUWoG+XWNbACIBeMBtLtEhE= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a17:90b:a17:b0:213:2708:8dc3 with SMTP id gg23-20020a17090b0a1700b0021327088dc3mr636229pjb.2.1668644638088; Wed, 16 Nov 2022 16:23:58 -0800 (PST) Reply-To: Sean Christopherson Date: Thu, 17 Nov 2022 00:23:49 +0000 In-Reply-To: <20221117002350.2178351-1-seanjc@google.com> Mime-Version: 1.0 References: <20221117002350.2178351-1-seanjc@google.com> X-Mailer: git-send-email 2.38.1.431.g37b22c650d-goog Message-ID: <20221117002350.2178351-2-seanjc@google.com> Subject: [PATCH 1/2] KVM: arm64: selftests: Disable single-step with correct KVM define From: Sean Christopherson To: Marc Zyngier Cc: James Morse , Alexandru Elisei , Suzuki K Poulose , Oliver Upton , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, Reiji Watanabe , Sean Christopherson Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Disable single-step by setting debug.control to KVM_GUESTDBG_ENABLE, not to SINGLE_STEP_DISABLE. The latter is an arbitrary test enum that just happens to have the same value as KVM_GUESTDBG_ENABLE, and so effectively disables single-step debug. No functional change intended. Cc: Reiji Watanabe Fixes: b18e4d4aebdd ("KVM: arm64: selftests: Add a test case for KVM_GUESTD= BG_SINGLESTEP") Signed-off-by: Sean Christopherson Acked-by: Marc Zyngier Reviewed-by: Oliver Upton Reviewed-by: Reiji Watanabe --- tools/testing/selftests/kvm/aarch64/debug-exceptions.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/kvm/aarch64/debug-exceptions.c b/tools= /testing/selftests/kvm/aarch64/debug-exceptions.c index 947bd201435c..91f55b45dfc7 100644 --- a/tools/testing/selftests/kvm/aarch64/debug-exceptions.c +++ b/tools/testing/selftests/kvm/aarch64/debug-exceptions.c @@ -369,7 +369,7 @@ void test_single_step_from_userspace(int test_cnt) KVM_GUESTDBG_SINGLESTEP; ss_enable =3D true; } else { - debug.control =3D SINGLE_STEP_DISABLE; + debug.control =3D KVM_GUESTDBG_ENABLE; ss_enable =3D false; } =20 --=20 2.38.1.431.g37b22c650d-goog From nobody Wed Apr 15 13:30:11 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8DF4C4332F for ; Thu, 17 Nov 2022 00:24:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234402AbiKQAYF (ORCPT ); Wed, 16 Nov 2022 19:24:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57236 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234346AbiKQAYB (ORCPT ); Wed, 16 Nov 2022 19:24:01 -0500 Received: from mail-pj1-x104a.google.com (mail-pj1-x104a.google.com [IPv6:2607:f8b0:4864:20::104a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4DA28627C1 for ; Wed, 16 Nov 2022 16:24:00 -0800 (PST) Received: by mail-pj1-x104a.google.com with SMTP id v10-20020a17090a7c0a00b00215deac75b4so226248pjf.3 for ; Wed, 16 Nov 2022 16:24:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:from:to:cc:subject:date:message-id:reply-to; bh=OQIty0gkGvimYsfAtcoPy8df73fwY+kl22+jSnaHr3Q=; b=XawF3gkr8CSKZ24fVYfQH/likVJmqrI6J+VgfY0e5oCqzv9OjobeFrDLWibgksGjp1 bpT/73ID8XYCUWtDkHG2HllTtEz582TclewSThnNE0l3c5yF0jvFHZ1/ZL/wudSFnfNc 22czahecA+4YL4y5BIk2STkzJ4Sl4F0uiU6ADlDXxHmn4GtTD2LizNnfounT0TGHV1ul /PifA+5TNyMgrcAklqK6NQw2i1wpsS5JW7doMrokg2FmWTpQJbyYBuHmTEcGBLiW9ITd 7j6WcKeXgdmwApf4zSyXL5jmPW52XoIa3JdjF+0UF72NtCpSP+95c3KKIAP0X74sDOd8 MIUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=OQIty0gkGvimYsfAtcoPy8df73fwY+kl22+jSnaHr3Q=; b=6csuKWjYzXG6UOEy7wQWRLlXe+IpgqQ5h4Na+xm0hb1IDaE7j46y4dXeAh1O2imtng XvjxkkVmb5MD1G6Y2Skj4MUDY3nX0Di4rusUIwRviwxu5VSvicPuQTt+3mViYsg8PQ86 RdbQL/7N57X7gKRXKvNP742HhMfSYkLASttoOqRi41P/qEp4LG8yMePy/RDnNxpSgRqP 9/ezDVn/l2C0iwqa++ImyEqWs/kp7sewfqEmgJVQM5P1uN2v1cjO3cEJNbLY4mhcH28S Rx1bg1jx40+f8lT/spGr1vg645h1D7TfIy3cCwOUE7ViGkQ080xQnphLggo+YSa6+dbq 5cBA== X-Gm-Message-State: ANoB5pmEDwNkfTfWrYrfetMdZQwFCjGYeMCES/ubzyjkH/CiwDkZC+Ed M/Ej0t5VDcVVnNxb1Mnf22FC2sP16fY= X-Google-Smtp-Source: AA0mqf6UG7Saff0XvDUGklOofeYsmwntM1MGQ71SgLhPhHqsgDLhnxcroheVO1wVLxnzQCCJ1Ru+MrMvNxE= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:aa7:9628:0:b0:56d:c3af:2d7f with SMTP id r8-20020aa79628000000b0056dc3af2d7fmr464212pfg.64.1668644639816; Wed, 16 Nov 2022 16:23:59 -0800 (PST) Reply-To: Sean Christopherson Date: Thu, 17 Nov 2022 00:23:50 +0000 In-Reply-To: <20221117002350.2178351-1-seanjc@google.com> Mime-Version: 1.0 References: <20221117002350.2178351-1-seanjc@google.com> X-Mailer: git-send-email 2.38.1.431.g37b22c650d-goog Message-ID: <20221117002350.2178351-3-seanjc@google.com> Subject: [PATCH 2/2] KVM: arm64: selftests: Disable single-step without relying on ucall() From: Sean Christopherson To: Marc Zyngier Cc: James Morse , Alexandru Elisei , Suzuki K Poulose , Oliver Upton , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, Reiji Watanabe , Sean Christopherson Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Automatically disable single-step when the guest reaches the end of the verified section instead of using an explicit ucall() to ask userspace to disable single-step. An upcoming change to implement a pool-based scheme for ucall() will add an atomic operation (bit test and set) in the guest ucall code, and if the compiler generate "old school" atomics, e.g. 40e57c: c85f7c20 ldxr x0, [x1] 40e580: aa100011 orr x17, x0, x16 40e584: c80ffc31 stlxr w15, x17, [x1] 40e588: 35ffffaf cbnz w15, 40e57c <__aarch64_ldset8_sync+= 0x1c> the guest will hang as the local exclusive monitor is reset by eret, i.e. the stlxr will always fail due to the VM-Exit for the debug exception. Link: https://lore.kernel.org/all/20221006003409.649993-8-seanjc@google.com Cc: Oliver Upton Cc: Marc Zyngier Signed-off-by: Sean Christopherson Acked-by: Marc Zyngier Reviewed-by: Oliver Upton Reviewed-by: Reiji Watanabe --- .../selftests/kvm/aarch64/debug-exceptions.c | 28 ++++++++++--------- 1 file changed, 15 insertions(+), 13 deletions(-) diff --git a/tools/testing/selftests/kvm/aarch64/debug-exceptions.c b/tools= /testing/selftests/kvm/aarch64/debug-exceptions.c index 91f55b45dfc7..65cd7e4f07fa 100644 --- a/tools/testing/selftests/kvm/aarch64/debug-exceptions.c +++ b/tools/testing/selftests/kvm/aarch64/debug-exceptions.c @@ -241,7 +241,6 @@ static void guest_svc_handler(struct ex_regs *regs) =20 enum single_step_op { SINGLE_STEP_ENABLE =3D 0, - SINGLE_STEP_DISABLE =3D 1, }; =20 static void guest_code_ss(int test_cnt) @@ -258,7 +257,7 @@ static void guest_code_ss(int test_cnt) GUEST_SYNC(SINGLE_STEP_ENABLE); =20 /* - * The userspace will veriry that the pc is as expected during + * The userspace will verify that the pc is as expected during * single step execution between iter_ss_begin and iter_ss_end. */ asm volatile("iter_ss_begin:nop\n"); @@ -268,11 +267,9 @@ static void guest_code_ss(int test_cnt) bvr =3D read_sysreg(dbgbvr0_el1); wvr =3D read_sysreg(dbgwvr0_el1); =20 + /* Userspace disables Single Step when the end is nigh. */ asm volatile("iter_ss_end:\n"); =20 - /* Disable Single Step execution */ - GUEST_SYNC(SINGLE_STEP_DISABLE); - GUEST_ASSERT(bvr =3D=3D w_bvr); GUEST_ASSERT(wvr =3D=3D w_wvr); } @@ -364,15 +361,12 @@ void test_single_step_from_userspace(int test_cnt) TEST_ASSERT(cmd =3D=3D UCALL_SYNC, "Unexpected ucall cmd 0x%lx", cmd); =20 - if (uc.args[1] =3D=3D SINGLE_STEP_ENABLE) { - debug.control =3D KVM_GUESTDBG_ENABLE | - KVM_GUESTDBG_SINGLESTEP; - ss_enable =3D true; - } else { - debug.control =3D KVM_GUESTDBG_ENABLE; - ss_enable =3D false; - } + TEST_ASSERT(uc.args[1] =3D=3D SINGLE_STEP_ENABLE, + "Unexpected ucall action 0x%lx", uc.args[1]); =20 + debug.control =3D KVM_GUESTDBG_ENABLE | + KVM_GUESTDBG_SINGLESTEP; + ss_enable =3D true; vcpu_guest_debug_set(vcpu, &debug); continue; } @@ -385,6 +379,14 @@ void test_single_step_from_userspace(int test_cnt) "Unexpected pc 0x%lx (expected 0x%lx)", pc, test_pc); =20 + if ((pc + 4) =3D=3D (uint64_t)&iter_ss_end) { + test_pc =3D 0; + debug.control =3D KVM_GUESTDBG_ENABLE; + ss_enable =3D false; + vcpu_guest_debug_set(vcpu, &debug); + continue; + } + /* * If the current pc is between iter_ss_bgin and * iter_ss_end, the pc for the next KVM_EXIT_DEBUG should --=20 2.38.1.431.g37b22c650d-goog