From nobody Sun Feb 8 06:08:07 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11CACC433FE for ; Wed, 16 Nov 2022 20:54:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238989AbiKPUyj (ORCPT ); Wed, 16 Nov 2022 15:54:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36452 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234639AbiKPUxu (ORCPT ); Wed, 16 Nov 2022 15:53:50 -0500 Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3DEBC26F6 for ; Wed, 16 Nov 2022 12:53:31 -0800 (PST) Received: by mail-ej1-x632.google.com with SMTP id bj12so47076715ejb.13 for ; Wed, 16 Nov 2022 12:53:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qMp0tWmayQFDCuQozvTUDpU6JW1zD9b9gmw4AkF62cg=; b=DfeLSauoK/xGMIYKQS8dUtNF5Y18jC4Dz7wPaMBhY5Wz7+f37x4ilwFFQVnDpFTXSy RKqXurBocAzbyzMqPdiS6IFjDxXzj+E3RZZQepcFM0ml8inFXsUQmDvg0Hy2EsCOITDH JHZYC75OVUxxK1+3P2am1KYY0AVX41vaxmwed/okFMyJDFu0zoFRlpFGwsO6hKrIPbwS inW4U/bJrq78cR6BOJhNepOxNwuQ/Qzlt8apxkk1uMwSP5visMZepMGF+j0smMOFVL/n NTjVi45THe7cCOGS1X7kkLDZg9X3Ivh5BUibveo9ryklA21H8QR8Gt0Or4XILbIIvTJT 23jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qMp0tWmayQFDCuQozvTUDpU6JW1zD9b9gmw4AkF62cg=; b=fVLJ7ZIwwaDGE9XNG7ZgN/XDhpegPhS+zLbKU63FoXD2VS5sp6qcEWtVYxupU26UtD wH482xTjL8xHp2g5B3MXipLOoAFuytaYa/m/UEqRtGB8J+kqkIq5BxzTfK0Wi6PxWHp/ YClVCRUvoTRewjFiBfTJL7Ldxx9ulEBKPMyzoDpzKmtubWARjqlU9TVA/JdxSDKLbYuf F7lsAmEItCC7pBFztYhQdPdTn1n9qP/XLOhZ7MfcnTtA05WOk5NzSwU86Pupd1U7ikcD ZwdNzcrrS5mlQQ//cDbTVlcgDFQsqVOCRsq2eizaaMW1hAtRB55nNE7fojm7Vm3FTbvW 2MHg== X-Gm-Message-State: ANoB5plQ9K49PRId9PUeIBcE0oOhpx3v70tmNI/wetRONfeC72slgvjL 7P0K2E+zCjJIB01letWXMLWfsQ== X-Google-Smtp-Source: AA0mqf5UtYQOtXnOHStEcoyycrgqiCBoL8jfnYcxOSZJ0kartEU1g5NyzH2ae4zG0NlZQX+qHgcbWQ== X-Received: by 2002:a17:907:cc9d:b0:7ac:ef6b:1ef4 with SMTP id up29-20020a170907cc9d00b007acef6b1ef4mr20163923ejc.104.1668632009629; Wed, 16 Nov 2022 12:53:29 -0800 (PST) Received: from blmsp.fritz.box ([2001:4090:a244:804b:353b:565:addf:3aa7]) by smtp.gmail.com with ESMTPSA id kv17-20020a17090778d100b007aece68483csm6782828ejc.193.2022.11.16.12.53.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Nov 2022 12:53:29 -0800 (PST) From: Markus Schneider-Pargmann To: Chandrasekar Ramakrishnan , Marc Kleine-Budde , Wolfgang Grandegger Cc: linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Markus Schneider-Pargmann Subject: [PATCH 07/15] can: m_can: Read register PSR only on error Date: Wed, 16 Nov 2022 21:53:00 +0100 Message-Id: <20221116205308.2996556-8-msp@baylibre.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221116205308.2996556-1-msp@baylibre.com> References: <20221116205308.2996556-1-msp@baylibre.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Only read register PSR if there is an error indicated in irqstatus. Signed-off-by: Markus Schneider-Pargmann --- drivers/net/can/m_can/m_can.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/net/can/m_can/m_can.c b/drivers/net/can/m_can/m_can.c index 0efa6dee0617..1d15beaea920 100644 --- a/drivers/net/can/m_can/m_can.c +++ b/drivers/net/can/m_can/m_can.c @@ -901,7 +901,6 @@ static int m_can_rx_handler(struct net_device *dev, int= quota, u32 irqstatus) struct m_can_classdev *cdev =3D netdev_priv(dev); int rx_work_or_err; int work_done =3D 0; - u32 psr; =20 if (!irqstatus) goto end; @@ -927,13 +926,13 @@ static int m_can_rx_handler(struct net_device *dev, i= nt quota, u32 irqstatus) } } =20 - psr =3D m_can_read(cdev, M_CAN_PSR); - if (irqstatus & IR_ERR_STATE) - work_done +=3D m_can_handle_state_errors(dev, psr); + work_done +=3D m_can_handle_state_errors(dev, + m_can_read(cdev, M_CAN_PSR)); =20 if (irqstatus & IR_ERR_BUS_30X) - work_done +=3D m_can_handle_bus_errors(dev, irqstatus, psr); + work_done +=3D m_can_handle_bus_errors(dev, irqstatus, + m_can_read(cdev, M_CAN_PSR)); =20 if (irqstatus & IR_RF0N) { rx_work_or_err =3D m_can_do_rx_poll(dev, (quota - work_done)); --=20 2.38.1