From nobody Mon Apr 13 18:34:13 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25723C4332F for ; Wed, 16 Nov 2022 09:12:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230075AbiKPJM5 (ORCPT ); Wed, 16 Nov 2022 04:12:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37496 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233540AbiKPJMl (ORCPT ); Wed, 16 Nov 2022 04:12:41 -0500 X-Greylist: delayed 122 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Wed, 16 Nov 2022 01:12:39 PST Received: from mx6.didiglobal.com (mx6.didiglobal.com [111.202.70.123]) by lindbergh.monkeyblade.net (Postfix) with SMTP id 96FE32B2 for ; Wed, 16 Nov 2022 01:12:39 -0800 (PST) Received: from mail.didiglobal.com (unknown [10.79.64.13]) by mx6.didiglobal.com (Maildata Gateway V2.8) with ESMTPS id 3DB59110243202; Wed, 16 Nov 2022 17:10:35 +0800 (CST) Received: from localhost.localdomain (10.79.64.101) by ZJY01-ACTMBX-03.didichuxing.com (10.79.64.13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.17; Wed, 16 Nov 2022 17:10:34 +0800 X-MD-Sfrom: wanghonglei@didiglobal.com X-MD-SrcIP: 10.79.64.13 From: Honglei Wang To: Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , Valentin Schneider , CC: Honglei Wang Subject: [PATCH] sched/core: use correct cpu_capacity in wake_affine_weight() Date: Wed, 16 Nov 2022 17:10:27 +0800 Message-ID: <20221116091027.78906-1-wanghonglei@didiglobal.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.79.64.101] X-ClientProxiedBy: ZJY03-PUBMBX-01.didichuxing.com (10.79.71.12) To ZJY01-ACTMBX-03.didichuxing.com (10.79.64.13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" It seems make more sense to do the load weight calculation with respective cpu_capacity. Signed-off-by: Honglei Wang --- kernel/sched/fair.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index e4a0b8bd941c..a9f75040969b 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -6262,13 +6262,13 @@ wake_affine_weight(struct sched_domain *sd, struct = task_struct *p, this_eff_load +=3D task_load; if (sched_feat(WA_BIAS)) this_eff_load *=3D 100; - this_eff_load *=3D capacity_of(prev_cpu); + this_eff_load *=3D capacity_of(this_cpu); =20 prev_eff_load =3D cpu_load(cpu_rq(prev_cpu)); prev_eff_load -=3D task_load; if (sched_feat(WA_BIAS)) prev_eff_load *=3D 100 + (sd->imbalance_pct - 100) / 2; - prev_eff_load *=3D capacity_of(this_cpu); + prev_eff_load *=3D capacity_of(prev_cpu); =20 /* * If sync, adjust the weight of prev_eff_load such that if --=20 2.14.1