From nobody Mon Apr 13 20:18:00 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8695C4332F for ; Wed, 16 Nov 2022 07:13:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231311AbiKPHN2 (ORCPT ); Wed, 16 Nov 2022 02:13:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41268 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232715AbiKPHNR (ORCPT ); Wed, 16 Nov 2022 02:13:17 -0500 Received: from mail-yw1-x114a.google.com (mail-yw1-x114a.google.com [IPv6:2607:f8b0:4864:20::114a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 32B8E20F59 for ; Tue, 15 Nov 2022 23:13:13 -0800 (PST) Received: by mail-yw1-x114a.google.com with SMTP id 00721157ae682-385bbf9bc8fso38274697b3.23 for ; Tue, 15 Nov 2022 23:13:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:references:mime-version:message-id:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=wK54JSKXe0LqXOZ3d575hQDmq52LEert5D/pS8cJUkE=; b=U1d7MimG9gAoAlzFe+38ukpZbqtI6+WSbYJnASee2xaNcWt9opU7e/VTdFaLjmpQZ2 X6zxHepXPQVF/knczaV0Pk8JFjDlEBpBHbz22Y4XJdOcTCUABE2+IndsM8s4fHNawIC9 MD1gxzR8AmL78bWa8wfA+IVoUCxS5DHItTEtHlR2nrlphjwbkXfl+hxyZdBarRoMrzr3 NLndOR5LqnrWjzZmVrvhyHo143J9+5KkXgPEmb1ylBLCZkMwVDWkTAftNfK6J3O5TMag GaUcHNH+DaKajLT22/xCtcYz0jKRXgawxf9IPirCd6aZfH/lds7D6x85YrlWF35ZX96L V0Fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:references:mime-version:message-id:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wK54JSKXe0LqXOZ3d575hQDmq52LEert5D/pS8cJUkE=; b=JKjGTNSjhIyfJSxKCKo4RN9LROrDMz7pZnTtJH2zsxlNFnkICNPCYXrLOhv9pI7US8 FdvQWWLeh9X4qkMZnZ3N5iUeqSvpajLywOM6JWWw0w6r5HfWHTZzZK34wmNBHwW4uODC 5gIEpYKXtTIyHp+Ad1DBGbxyRQM/IaFWLmhhIKPQlcFXFG/mUaYiiToezfofC3kyhsUg 3FsOiReGkJx18pJBzbCgx2ldySlkPQtxgglVBG15e4YJwkoL2mToL+f/kOB75siLAsf8 Y4oHl03psuknSsjjCeqBsH6EBuQV7cRrSqOVl88x1W2LN5rxypAPzTW/es6Wy8LboXPY LPzw== X-Gm-Message-State: ANoB5pnQDhAyJDhj8VEl4IQfkhT8TKUWDP/l8TKObKqRC1+vg3W8WCmR JUBjEClK3opCvYrEloUQVvwjCtDLliOX X-Google-Smtp-Source: AA0mqf4Owhg9TSF5BqPmkokKmNN1T62eQp1AeaL0nFC6RJ1ulWDmRb4Tbo2Zj8w/ORKb01IV4bsRzBTCf1i+ X-Received: from irogers.svl.corp.google.com ([2620:15c:2d4:203:bf0f:58f3:342e:c1ec]) (user=irogers job=sendgmr) by 2002:a05:690c:e:b0:388:2fb:57d9 with SMTP id bc14-20020a05690c000e00b0038802fb57d9mr4675335ywb.371.1668582792508; Tue, 15 Nov 2022 23:13:12 -0800 (PST) Date: Tue, 15 Nov 2022 23:12:59 -0800 In-Reply-To: <20221116071259.2832681-1-irogers@google.com> Message-Id: <20221116071259.2832681-5-irogers@google.com> Mime-Version: 1.0 References: <20221116071259.2832681-1-irogers@google.com> X-Mailer: git-send-email 2.38.1.431.g37b22c650d-goog Subject: [PATCH v1 4/4] perf list: List callback support for libpfm From: Ian Rogers To: Weilin Wang , Perry Taylor , Caleb Biggers , Leo Yan , Adrian Hunter , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Sandipan Das , Kajol Jain , Zhengjun Xing , Kan Liang , Ravi Bangoria , Xin Gao , Rob Herring , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Cc: Stephane Eranian , Ian Rogers Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Missed previously, add libpfm support for 'perf list' callbacks and thereby json support. Fixes: df936cadfb58ba93 ("perf stat: Add JSON output option") Signed-off-by: Ian Rogers --- tools/perf/util/pfm.c | 154 ++++++++++++++++++------------------------ tools/perf/util/pfm.h | 6 +- 2 files changed, 70 insertions(+), 90 deletions(-) diff --git a/tools/perf/util/pfm.c b/tools/perf/util/pfm.c index f0bcfcab1a93..ac3227ba769c 100644 --- a/tools/perf/util/pfm.c +++ b/tools/perf/util/pfm.c @@ -12,6 +12,7 @@ #include "util/parse-events.h" #include "util/pmu.h" #include "util/pfm.h" +#include "util/strbuf.h" =20 #include #include @@ -130,53 +131,36 @@ static const char *srcs[PFM_ATTR_CTRL_MAX] =3D { }; =20 static void -print_attr_flags(pfm_event_attr_info_t *info) +print_attr_flags(struct strbuf *buf, const pfm_event_attr_info_t *info) { - int n =3D 0; + if (info->is_dfl) + strbuf_addf(buf, "[default] "); =20 - if (info->is_dfl) { - printf("[default] "); - n++; - } - - if (info->is_precise) { - printf("[precise] "); - n++; - } - - if (!n) - printf("- "); + if (info->is_precise) + strbuf_addf(buf, "[precise] "); } =20 static void -print_libpfm_events_detailed(pfm_event_info_t *info, bool long_desc) +print_libpfm_event(const struct print_callbacks *print_cb, void *print_sta= te, + const pfm_pmu_info_t *pinfo, const pfm_event_info_t *info, + struct strbuf *buf) { - pfm_event_attr_info_t ainfo; - const char *src; int j, ret; + char topic[80], name[80]; =20 - ainfo.size =3D sizeof(ainfo); + strbuf_setlen(buf, 0); + snprintf(topic, sizeof(topic), "pfm %s", pinfo->name); =20 - printf(" %s\n", info->name); - printf(" [%s]\n", info->desc); - if (long_desc) { - if (info->equiv) - printf(" Equiv: %s\n", info->equiv); + snprintf(name, sizeof(name), "%s::%s", pinfo->name, info->name); + strbuf_addf(buf, "Code: 0x%"PRIx64"\n", info->code); =20 - printf(" Code : 0x%"PRIx64"\n", info->code); - } pfm_for_each_event_attr(j, info) { - ret =3D pfm_get_event_attr_info(info->idx, j, - PFM_OS_PERF_EVENT_EXT, &ainfo); - if (ret !=3D PFM_SUCCESS) - continue; - - if (ainfo.type =3D=3D PFM_ATTR_UMASK) { - printf(" %s:%s\n", info->name, ainfo.name); - printf(" [%s]\n", ainfo.desc); - } + pfm_event_attr_info_t ainfo; + const char *src; =20 - if (!long_desc) + ainfo.size =3D sizeof(ainfo); + ret =3D pfm_get_event_attr_info(info->idx, j, PFM_OS_PERF_EVENT_EXT, &ai= nfo); + if (ret !=3D PFM_SUCCESS) continue; =20 if (ainfo.ctrl >=3D PFM_ATTR_CTRL_MAX) @@ -184,64 +168,74 @@ print_libpfm_events_detailed(pfm_event_info_t *info, = bool long_desc) =20 src =3D srcs[ainfo.ctrl]; switch (ainfo.type) { - case PFM_ATTR_UMASK: - printf(" Umask : 0x%02"PRIx64" : %s: ", - ainfo.code, src); - print_attr_flags(&ainfo); - putchar('\n'); + case PFM_ATTR_UMASK: /* Ignore for now */ break; case PFM_ATTR_MOD_BOOL: - printf(" Modif : %s: [%s] : %s (boolean)\n", src, - ainfo.name, ainfo.desc); + strbuf_addf(buf, " Modif: %s: [%s] : %s (boolean)\n", src, + ainfo.name, ainfo.desc); break; case PFM_ATTR_MOD_INTEGER: - printf(" Modif : %s: [%s] : %s (integer)\n", src, - ainfo.name, ainfo.desc); + strbuf_addf(buf, " Modif: %s: [%s] : %s (integer)\n", src, + ainfo.name, ainfo.desc); break; case PFM_ATTR_NONE: case PFM_ATTR_RAW_UMASK: case PFM_ATTR_MAX: default: - printf(" Attr : %s: [%s] : %s\n", src, - ainfo.name, ainfo.desc); + strbuf_addf(buf, " Attr: %s: [%s] : %s\n", src, + ainfo.name, ainfo.desc); } } -} + print_cb->print_event(print_state, + pinfo->name, + topic, + name, info->equiv, + /*scale_unit=3D*/NULL, + /*deprecated=3D*/NULL, "PFM event", + info->desc, /*long_desc=3D*/NULL, + /*encoding_desc=3D*/buf->buf, + /*metric_name=3D*/NULL, /*metric_expr=3D*/NULL); =20 -/* - * list all pmu::event:umask, pmu::event - * printed events may not be all valid combinations of umask for an event - */ -static void -print_libpfm_events_raw(pfm_pmu_info_t *pinfo, pfm_event_info_t *info) -{ - pfm_event_attr_info_t ainfo; - int j, ret; - bool has_umask =3D false; + pfm_for_each_event_attr(j, info) { + pfm_event_attr_info_t ainfo; + const char *src; =20 - ainfo.size =3D sizeof(ainfo); + strbuf_setlen(buf, 0); =20 - pfm_for_each_event_attr(j, info) { - ret =3D pfm_get_event_attr_info(info->idx, j, - PFM_OS_PERF_EVENT_EXT, &ainfo); + ainfo.size =3D sizeof(ainfo); + ret =3D pfm_get_event_attr_info(info->idx, j, PFM_OS_PERF_EVENT_EXT, &ai= nfo); if (ret !=3D PFM_SUCCESS) continue; =20 - if (ainfo.type !=3D PFM_ATTR_UMASK) - continue; + if (ainfo.ctrl >=3D PFM_ATTR_CTRL_MAX) + ainfo.ctrl =3D PFM_ATTR_CTRL_UNKNOWN; =20 - printf("%s::%s:%s\n", pinfo->name, info->name, ainfo.name); - has_umask =3D true; + src =3D srcs[ainfo.ctrl]; + if (ainfo.type =3D=3D PFM_ATTR_UMASK) { + strbuf_addf(buf, "Umask: 0x%02"PRIx64" : %s: ", + ainfo.code, src); + print_attr_flags(buf, &ainfo); + snprintf(name, sizeof(name), "%s::%s:%s", + pinfo->name, info->name, ainfo.name); + print_cb->print_event(print_state, + pinfo->name, + topic, + name, /*alias=3D*/NULL, + /*scale_unit=3D*/NULL, + /*deprecated=3D*/NULL, "PFM event", + ainfo.desc, /*long_desc=3D*/NULL, + /*encoding_desc=3D*/buf->buf, + /*metric_name=3D*/NULL, /*metric_expr=3D*/NULL); + } } - if (!has_umask) - printf("%s::%s\n", pinfo->name, info->name); } =20 -void print_libpfm_events(bool name_only, bool long_desc) +void print_libpfm_events(const struct print_callbacks *print_cb, void *pri= nt_state) { pfm_event_info_t info; pfm_pmu_info_t pinfo; - int i, p, ret; + int p, ret; + struct strbuf storage; =20 libpfm_initialize(); =20 @@ -249,12 +243,9 @@ void print_libpfm_events(bool name_only, bool long_des= c) info.size =3D sizeof(info); pinfo.size =3D sizeof(pinfo); =20 - if (!name_only) - puts("\nList of pre-defined events (to be used in --pfm-events):\n"); + strbuf_init(&storage, 2048); =20 pfm_for_all_pmus(p) { - bool printed_pmu =3D false; - ret =3D pfm_get_pmu_info(p, &pinfo); if (ret !=3D PFM_SUCCESS) continue; @@ -267,25 +258,14 @@ void print_libpfm_events(bool name_only, bool long_de= sc) if (pinfo.pmu =3D=3D PFM_PMU_PERF_EVENT) continue; =20 - for (i =3D pinfo.first_event; i !=3D -1; - i =3D pfm_get_event_next(i)) { - + for (int i =3D pinfo.first_event; i !=3D -1; i =3D pfm_get_event_next(i)= ) { ret =3D pfm_get_event_info(i, PFM_OS_PERF_EVENT_EXT, &info); if (ret !=3D PFM_SUCCESS) continue; =20 - if (!name_only && !printed_pmu) { - printf("%s:\n", pinfo.name); - printed_pmu =3D true; - } - - if (!name_only) - print_libpfm_events_detailed(&info, long_desc); - else - print_libpfm_events_raw(&pinfo, &info); + print_libpfm_event(print_cb, print_state, &pinfo, &info, &storage); } - if (!name_only && printed_pmu) - putchar('\n'); } + strbuf_release(&storage); } diff --git a/tools/perf/util/pfm.h b/tools/perf/util/pfm.h index 7d70dda87012..9cc9bb1e0949 100644 --- a/tools/perf/util/pfm.h +++ b/tools/perf/util/pfm.h @@ -7,13 +7,14 @@ #ifndef __PERF_PFM_H #define __PERF_PFM_H =20 +#include "print-events.h" #include =20 #ifdef HAVE_LIBPFM int parse_libpfm_events_option(const struct option *opt, const char *str, int unset); =20 -void print_libpfm_events(bool name_only, bool long_desc); +void print_libpfm_events(const struct print_callbacks *print_cb, void *pri= nt_state); =20 #else #include @@ -26,8 +27,7 @@ static inline int parse_libpfm_events_option( return 0; } =20 -static inline void print_libpfm_events(bool name_only __maybe_unused, - bool long_desc __maybe_unused) +static inline void print_libpfm_events(const struct print_callbacks *print= _cb, void *print_state) { } =20 --=20 2.38.1.431.g37b22c650d-goog