From nobody Mon Apr 13 18:37:03 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 776CEC433FE for ; Wed, 16 Nov 2022 07:00:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232066AbiKPHAi (ORCPT ); Wed, 16 Nov 2022 02:00:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34358 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231547AbiKPHAg (ORCPT ); Wed, 16 Nov 2022 02:00:36 -0500 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B1BF917E3F; Tue, 15 Nov 2022 23:00:31 -0800 (PST) Received: from kwepemi500008.china.huawei.com (unknown [172.30.72.57]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4NBv4K1RdpzJnlG; Wed, 16 Nov 2022 14:57:21 +0800 (CST) Received: from huawei.com (10.67.175.83) by kwepemi500008.china.huawei.com (7.221.188.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 16 Nov 2022 15:00:29 +0800 From: ruanjinjie To: , , , , CC: Subject: [PATCH v2] dmaengine: ste_dma40: use devm_request_irq to avoid missing free_irq() in error path Date: Wed, 16 Nov 2022 14:57:17 +0800 Message-ID: <20221116065717.3069712-1-ruanjinjie@huawei.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.67.175.83] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To kwepemi500008.china.huawei.com (7.221.188.139) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" free_irq() is missing in some cases of error in d40_probe(), use devm_request_irq to fix that. Fixes: d7b7ecce4bcb ("ste_dma40: Rename a jump label in d40_probe()") Signed-off-by: ruanjinjie Reviewed-by: Linus Walleij --- v2: - use devm_request_irq instead of adding free_irq() to fix the problem. --- drivers/dma/ste_dma40.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma/ste_dma40.c b/drivers/dma/ste_dma40.c index f093e08c23b1..3214d2cb027e 100644 --- a/drivers/dma/ste_dma40.c +++ b/drivers/dma/ste_dma40.c @@ -3598,7 +3598,7 @@ static int __init d40_probe(struct platform_device *p= dev) =20 base->irq =3D platform_get_irq(pdev, 0); =20 - ret =3D request_irq(base->irq, d40_handle_interrupt, 0, D40_NAME, base); + ret =3D devm_request_irq(&pdev->dev, base->irq, d40_handle_interrupt, 0, = D40_NAME, base); if (ret) { d40_err(&pdev->dev, "No IRQ defined\n"); goto destroy_cache; --=20 2.25.1