From nobody Sat Apr 11 21:24:15 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52964C433FE for ; Tue, 15 Nov 2022 11:03:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238466AbiKOLDr (ORCPT ); Tue, 15 Nov 2022 06:03:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41656 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238514AbiKOLCW (ORCPT ); Tue, 15 Nov 2022 06:02:22 -0500 Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E56EFB5C for ; Tue, 15 Nov 2022 03:02:12 -0800 (PST) Received: (Authenticated sender: alexandre.belloni@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 4BB276001A; Tue, 15 Nov 2022 11:02:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1668510131; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=vmdLqqdX83NrVxFfCs3G+u/+UCwYeudzJBMjz9k4QTU=; b=nX4wxGfs+5xQ+rXbSCCo8OZlM7CyBO8xL4MEtGtnnnP4Qk8wly2COTihpqMx6xxNvQRbCZ ddzF5FjxcZzBxMYNIrAp587hJfLgDKdlkbT59+jOmlecTkp2CBW6M7Hp3Z2pqWqXyQvn5B FBymAvSlplEI2NacPEasYHfzCSnQMDNZrqe6fmNVl8AVhj3TkDVGAhi/HLsdPZfzUTxxfN 9lDY0/7yxn4GuPTYXqG10RC8mwMJBitkgtdWlzUsPAfMlMxRrpwVxNP8NKeNJhP0p9XOXu LjYUkhLy1zYI/0nT2VFpagt7SiVRq5OSI/G5sI5+V4X7UfiXiix/cAo7uIqEwQ== From: alexandre.belloni@bootlin.com To: Paolo Bonzini , Sean Christopherson , Nick Desaulniers Cc: Alexandre Belloni , linux-kernel@vger.kernel.org Subject: [PATCH v2] init/Kconfig: fix CC_HAS_ASM_GOTO_TIED_OUTPUT test with dash Date: Tue, 15 Nov 2022 12:01:58 +0100 Message-Id: <20221115110158.2207117-1-alexandre.belloni@bootlin.com> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Alexandre Belloni When using dash as /bin/sh, the CC_HAS_ASM_GOTO_TIED_OUTPUT test fails with a syntax error which is not the one we are looking for: : In function =E2=80=98foo=E2=80=99: :1:29: warning: missing terminating " character :1:29: error: missing terminating " character :2:5: error: expected =E2=80=98:=E2=80=99 before =E2=80=98+=E2=80=99= token :2:7: warning: missing terminating " character :2:7: error: missing terminating " character :2:5: error: expected declaration or statement at end of input Removing '\n' solves this. Fixes: 1aa0e8b144b6 ("Kconfig: Add option for asm goto w/ tied outputs to w= orkaround clang-13 bug") Signed-off-by: Alexandre Belloni Reviewed-by: Sean Christopherson --- init/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/init/Kconfig b/init/Kconfig index 694f7c160c9c..13e93bcbc807 100644 --- a/init/Kconfig +++ b/init/Kconfig @@ -87,7 +87,7 @@ config CC_HAS_ASM_GOTO_OUTPUT config CC_HAS_ASM_GOTO_TIED_OUTPUT depends on CC_HAS_ASM_GOTO_OUTPUT # Detect buggy gcc and clang, fixed in gcc-11 clang-14. - def_bool $(success,echo 'int foo(int *x) { asm goto (".long (%l[bar]) - .= \n": "+m"(*x) ::: bar); return *x; bar: return 0; }' | $CC -x c - -c -o /de= v/null) + def_bool $(success,echo 'int foo(int *x) { asm goto (".long (%l[bar]) - .= ": "+m"(*x) ::: bar); return *x; bar: return 0; }' | $CC -x c - -c -o /dev/= null) =20 config TOOLS_SUPPORT_RELR def_bool $(success,env "CC=3D$(CC)" "LD=3D$(LD)" "NM=3D$(NM)" "OBJCOPY=3D= $(OBJCOPY)" $(srctree)/scripts/tools-support-relr.sh) --=20 2.38.1