From nobody Mon Apr 13 17:01:21 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F66AC433FE for ; Mon, 14 Nov 2022 16:30:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237680AbiKNQak (ORCPT ); Mon, 14 Nov 2022 11:30:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35898 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237565AbiKNQ3u (ORCPT ); Mon, 14 Nov 2022 11:29:50 -0500 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0E8302183B for ; Mon, 14 Nov 2022 08:29:43 -0800 (PST) From: John Ogness DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1668443381; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jtDlGuAbTSSJEMWTvdI9kPHsEwopJ5BO8AfeZI8Xzok=; b=jkUNUusOa/rDiW2kEjSYqIAHPvnAj0abKXtBCPnj584XACyyvzV5ZH44XLMH/6YFLzlBpm 307DWV5o/1MAT/hEvez85x/1QquMLgESndw0eclq3j6Pl8c23CjghF1wKJNCzuacJPoWMm t4lJOQJJ4MDdacZSgV+Kwz402KPfe/3kuN+oETlDp7DOce4+lG9OxxB68naMHDidDwUy0o /L7PY47fuINkEYgNlN2EdKuwEO0KabdJjQeWzq5vzOhggaizQ3HgoY36jS9DInC4A3aOVs 6+eiz2LZey/G0NOThgwe9aQm3JzXt9RX2zSI+J8CpRa/b2S7s/HIto/+ipbQUQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1668443381; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jtDlGuAbTSSJEMWTvdI9kPHsEwopJ5BO8AfeZI8Xzok=; b=6DT15jpBvvNOo7s7TIRJhL3KxV1amiVrLZFlRKfmiI6C04XMwZ2GNcWmwUPxZgcpSlkNs7 wUeDm3Q+7LaGrqBQ== To: Petr Mladek Cc: Sergey Senozhatsky , Steven Rostedt , Thomas Gleixner , linux-kernel@vger.kernel.org Subject: [PATCH printk v4 17/39] printk: console_unblank: use srcu console list iterator Date: Mon, 14 Nov 2022 17:35:10 +0106 Message-Id: <20221114162932.141883-18-john.ogness@linutronix.de> In-Reply-To: <20221114162932.141883-1-john.ogness@linutronix.de> References: <20221114162932.141883-1-john.ogness@linutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Use srcu console list iteration for console list traversal. Document why the console_lock is still necessary. Note that this is a preparatory change for when console_lock no longer provides synchronization for the console list. Signed-off-by: John Ogness Reviewed-by: Petr Mladek --- kernel/printk/printk.c | 17 +++++++++++++---- 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c index bc563972e468..7304cbcd6dd4 100644 --- a/kernel/printk/printk.c +++ b/kernel/printk/printk.c @@ -2999,10 +2999,14 @@ EXPORT_SYMBOL(console_conditional_schedule); void console_unblank(void) { struct console *c; + int cookie; =20 /* - * console_unblank can no longer be called in interrupt context unless - * oops_in_progress is set to 1.. + * Stop console printing because the unblank() callback may + * assume the console is not within its write() callback. + * + * If @oops_in_progress is set, this may be an atomic context. + * In that case, attempt a trylock as best-effort. */ if (oops_in_progress) { if (down_trylock_console_sem() !=3D 0) @@ -3012,9 +3016,14 @@ void console_unblank(void) =20 console_locked =3D 1; console_may_schedule =3D 0; - for_each_console(c) - if ((c->flags & CON_ENABLED) && c->unblank) + + cookie =3D console_srcu_read_lock(); + for_each_console_srcu(c) { + if ((console_srcu_read_flags(c) & CON_ENABLED) && c->unblank) c->unblank(); + } + console_srcu_read_unlock(cookie); + console_unlock(); =20 if (!oops_in_progress) --=20 2.30.2