From nobody Fri Dec 19 17:51:28 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DC07C4332F for ; Mon, 14 Nov 2022 11:45:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236394AbiKNLpP (ORCPT ); Mon, 14 Nov 2022 06:45:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41790 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236517AbiKNLoj (ORCPT ); Mon, 14 Nov 2022 06:44:39 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B053B1D655 for ; Mon, 14 Nov 2022 03:44:28 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 34A71B80E6C for ; Mon, 14 Nov 2022 11:44:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BE33AC433D6; Mon, 14 Nov 2022 11:44:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668426265; bh=mZy59RfMp+d1UJJbf+o4C0WWNhptP9zLv0Zp8nxmYqg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FPYVlpz368y2BvR4VAyLp0saq8tF6P5Cp+4m0jbJhjQgB9H7x7DfN3vURZR+wYkC/ GBWAYSbKB6NYboPLqd1Rnnwtv6/IoJ4+ARtKrns+0fztif2QW7WsCr5Iw1NFJjmKup y8grnvSS2m/5cppYeNVgrNJETBDHGJSdNjFhE4s0j/dLKVfjdkkTgo7Tqi+pEQfsyf 5In4dDX+Pf1RaDEjZMXsT5w/J3HQBXMZfEWDzorQ8r2uDq8J84W6ev0qhlT9a3whu+ nW1oGTYQdFMtRHOhzEVCWZbJtpOLOTved+3Xr9wXJXB0xL7BBCqPCGFkmylbq6s2f/ D6ZFfLFn8tJyw== From: "Jiri Slaby (SUSE)" To: linux-kernel@vger.kernel.org Cc: Andi Kleen , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , x86@kernel.org, Martin Liska , Jiri Slaby Subject: [PATCH 13/46] x86/preempt, lto: Mark preempt_schedule_*thunk() as __visible Date: Mon, 14 Nov 2022 12:43:11 +0100 Message-Id: <20221114114344.18650-14-jirislaby@kernel.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221114114344.18650-1-jirislaby@kernel.org> References: <20221114114344.18650-1-jirislaby@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Andi Kleen Symbols referenced from assembler (either directly or e.f. from DEFINE_STATIC_KEY()) need to be global and visible in gcc LTO because they could end up in a different object file than the assembler. This can lead to linker errors without this patch. So mark preempt_schedule_thunk() and preempt_schedule_notrace_thunk() as __visible. Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Borislav Petkov Cc: Dave Hansen Cc: "H. Peter Anvin" Cc: x86@kernel.org Signed-off-by: Andi Kleen Signed-off-by: Martin Liska Signed-off-by: Jiri Slaby --- arch/x86/include/asm/preempt.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/include/asm/preempt.h b/arch/x86/include/asm/preempt.h index 5f6daea1ee24..c76ec881b23c 100644 --- a/arch/x86/include/asm/preempt.h +++ b/arch/x86/include/asm/preempt.h @@ -106,13 +106,13 @@ static __always_inline bool should_resched(int preemp= t_offset) #ifdef CONFIG_PREEMPTION =20 extern asmlinkage void preempt_schedule(void); -extern asmlinkage void preempt_schedule_thunk(void); +extern __visible asmlinkage void preempt_schedule_thunk(void); =20 #define preempt_schedule_dynamic_enabled preempt_schedule_thunk #define preempt_schedule_dynamic_disabled NULL =20 extern asmlinkage void preempt_schedule_notrace(void); -extern asmlinkage void preempt_schedule_notrace_thunk(void); +extern __visible asmlinkage void preempt_schedule_notrace_thunk(void); =20 #define preempt_schedule_notrace_dynamic_enabled preempt_schedule_notrace_= thunk #define preempt_schedule_notrace_dynamic_disabled NULL --=20 2.38.1