From nobody Mon Apr 13 20:08:48 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 517E8C433FE for ; Wed, 16 Nov 2022 10:20:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233635AbiKPKUR (ORCPT ); Wed, 16 Nov 2022 05:20:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55958 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233286AbiKPKUJ (ORCPT ); Wed, 16 Nov 2022 05:20:09 -0500 Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6E61912A9D for ; Wed, 16 Nov 2022 02:20:08 -0800 (PST) Received: by mail-wm1-x32f.google.com with SMTP id 5so11556193wmo.1 for ; Wed, 16 Nov 2022 02:20:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=abLnCQfmT+XQT6aD06ckoOE5xV2tdrjNEbUU00A7GbU=; b=uS7ki5F34mhuwfL0SfdXPitiKSVZkMAIG7y611sNMJi6qXzh6/BTOuMINJQRLMJIyU QUwLURyU7Vw6Bxo7JaOSPYdBszqOdWabEau/5fZPFDbE5TFXS2ztTF/4RiPI2ohPNQWM jPU6mjdbhRu82oOrRcOB4urwV7n+kdnJozJ2rWBwbEjI7M9gfNt2a7PlHu6GGcXkaS5i 4qNfDomQp8jdSMowJrj6AV08ZsuVjnUYmR+B92OTXFrf0BXnyHBo1YjPK+q9Ohw+fmQu r0Gq2kpd/h9Gk/mHER2m2kOuQ1b56u5xBpsmQBvTxZovoJlWCmnECpJ7OsJwKf/L+157 5PDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=abLnCQfmT+XQT6aD06ckoOE5xV2tdrjNEbUU00A7GbU=; b=XO8DLln31v0qkAbYjPM7Bd+9cG12eo9Em6I+LlbF2JW//brB3GLYHO+lHAH1j+aBxF 3ZifOYSbxN4uWIqvql8NkS7/Y3N3gp1eTgOLipgm2dcCDarTc2PKL1XLwCLmA/DSf+zT Bt7ZqBoeTBuoPu+ZA6VOOXyO/q4+dgq84ykpNZm3DWy3+1o1ltDKijgX1lOH1Tut0dah SkwdBQqa7nz6eG/egp6B+pMtlJFmCCX+yX4IX+Zwqe71D6t2HzECTj7hzizKUSRDbKOp XahesR04n8MDTWz72Q3xRITkfmcUcWVb/UXc9F5MX7/ZTSbHEI4Q6s8ykBiPq9tklOIX x4eA== X-Gm-Message-State: ANoB5pmRksBr7L9Ff436Okpt4iZx4fADY+FPwZd1oP8djBpIQrUPnEIf g8GhCBlo8WhJgLqterenh6g9Hg== X-Google-Smtp-Source: AA0mqf5gF84ZE8euD1zwPwjPj7xUiFfdK2JpKCMpW1Ikx2XVN8KYsocbCrdhtuQEUP6hNGg1Fmiswg== X-Received: by 2002:a05:600c:524a:b0:3cf:6a41:9aec with SMTP id fc10-20020a05600c524a00b003cf6a419aecmr1644226wmb.159.1668594006964; Wed, 16 Nov 2022 02:20:06 -0800 (PST) Received: from arrakeen.starnux.net ([2a01:e0a:982:cbb0:52eb:f6ff:feb3:451a]) by smtp.gmail.com with ESMTPSA id l18-20020a05600c4f1200b003c6f3f6675bsm1709900wmq.26.2022.11.16.02.20.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Nov 2022 02:20:06 -0800 (PST) From: Neil Armstrong Date: Wed, 16 Nov 2022 11:20:04 +0100 Subject: [PATCH 1/4] dt-bindings: remoteproc: qcom: adsp: document sm8550 adsp, cdsp & mpss compatible MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20221114-narmstrong-sm8550-upstream-remoteproc-v1-1-104c34cb3b91@linaro.org> References: <20221114-narmstrong-sm8550-upstream-remoteproc-v1-0-104c34cb3b91@linaro.org> In-Reply-To: <20221114-narmstrong-sm8550-upstream-remoteproc-v1-0-104c34cb3b91@linaro.org> To: Krzysztof Kozlowski , Bjorn Andersson , Konrad Dybcio , Andy Gross , Manivannan Sadhasivam , Amol Maheshwari , Srinivas Kandagatla , Rob Herring , Mathieu Poirier Cc: devicetree@vger.kernel.org, Abel Vesa , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, Neil Armstrong X-Mailer: b4 0.10.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This documents the compatible for the component used to boot the aDSP, cDSP and MPSS on the SM8550 SoC. The SM8550 boot process on SM8550 now requires a secondary "Devicetree" firmware to be passed along the main Firmware, and the cDSP a new power domain named "NSP". Signed-off-by: Neil Armstrong --- .../devicetree/bindings/remoteproc/qcom,adsp.yaml | 60 ++++++++++++++++++= +++- 1 file changed, 59 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml b/= Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml index db9e0f0c2bea..678cb73f10de 100644 --- a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml +++ b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml @@ -55,6 +55,9 @@ properties: - qcom,sm8450-cdsp-pas - qcom,sm8450-mpss-pas - qcom,sm8450-slpi-pas + - qcom,sm8550-adsp-pas + - qcom,sm8550-cdsp-pas + - qcom,sm8550-mpss-pas =20 reg: maxItems: 1 @@ -116,8 +119,13 @@ properties: $ref: /schemas/types.yaml#/definitions/string description: Firmware name for the Hexagon core =20 + qcom,dtb-firmware-name: + $ref: /schemas/types.yaml#/definitions/string + description: Devicetree Firmware name for the Hexagon core + memory-region: - maxItems: 1 + minItems: 1 + maxItems: 2 description: Reference to the reserved-memory for the Hexagon core =20 qcom,qmp: @@ -212,6 +220,9 @@ allOf: - qcom,sm8450-cdsp-pas - qcom,sm8450-slpi-pas - qcom,sm8450-mpss-pas + - qcom,sm8550-adsp-pas + - qcom,sm8550-cdsp-pas + - qcom,sm8550-mpss-pas then: properties: clocks: @@ -327,6 +338,8 @@ allOf: - qcom,sm8450-adsp-pas - qcom,sm8450-cdsp-pas - qcom,sm8450-slpi-pas + - qcom,sm8550-adsp-pas + - qcom,sm8550-cdsp-pas then: properties: interrupts: @@ -347,6 +360,7 @@ allOf: - qcom,sm8150-mpss-pas - qcom,sm8350-mpss-pas - qcom,sm8450-mpss-pas + - qcom,sm8550-mpss-pas then: properties: interrupts: @@ -448,6 +462,7 @@ allOf: - qcom,sm8150-mpss-pas - qcom,sm8350-mpss-pas - qcom,sm8450-mpss-pas + - qcom,sm8550-mpss-pas then: properties: power-domains: @@ -475,6 +490,7 @@ allOf: - qcom,sm8350-slpi-pas - qcom,sm8450-adsp-pas - qcom,sm8450-slpi-pas + - qcom,sm8550-adsp-pas then: properties: power-domains: @@ -504,6 +520,25 @@ allOf: - const: cx - const: mxc =20 + - if: + properties: + compatible: + contains: + enum: + - qcom,sm8550-cdsp-pas + then: + properties: + power-domains: + items: + - description: CX power domain + - description: MXC power domain + - description: NSP power domain + power-domain-names: + items: + - const: cx + - const: mxc + - const: nsp + - if: properties: compatible: @@ -573,6 +608,29 @@ allOf: properties: qcom,qmp: false =20 + - if: + properties: + compatible: + contains: + enum: + - qcom,sm8550-adsp-pas + - qcom,sm8550-cdsp-pas + - qcom,sm8550-mpss-pas + then: + properties: + memory-region: + minItems: 2 + description: + First entry is a phandle for a reserved memory area that holds + the main Firmware for authentication, and second entry a phand= le for a + reserved memory area that holds the Devicetree Firmware for au= thentication. + else: + properties: + qcom,dtb-firmware-name: false + + memory-region: + maxItems: 1 + examples: - | #include --=20 b4 0.10.1 From nobody Mon Apr 13 20:08:48 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89A30C433FE for ; Wed, 16 Nov 2022 10:20:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236019AbiKPKU2 (ORCPT ); Wed, 16 Nov 2022 05:20:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55992 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233389AbiKPKUK (ORCPT ); Wed, 16 Nov 2022 05:20:10 -0500 Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6276A2126B for ; Wed, 16 Nov 2022 02:20:09 -0800 (PST) Received: by mail-wr1-x434.google.com with SMTP id o4so28983976wrq.6 for ; Wed, 16 Nov 2022 02:20:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=pcm4FzP5Zqll4vx+qLC4Zs+d3QrWbatabIiC6u6r60g=; b=kxws/zHmdiQFoJ0eF54UCY9nbuWQ9mbC4IGNSA5IcisVZ6M5MY0eJjRgoKDOYUZGym iIzr9SUaDi695Pbvz8Xy1rfbUY1tVLVTefUErWMIspw50cwFD4WhuhFcsaARZcEcI2Xd 98iyUzINb+keCA5Tbb/0AIL55TNLylh/2WX9HlzpXZ9vZaQZnnfMSoGHHIVzRQw+hdU4 Su5B1NdY+FtUfKFRqZ5VhPNPd+o1roQm5b5kIwarQ6/CwDbDp8iOUuwF8VW+F+SWWxso yUKgjQVt9IDuI0qW2Akh36oX87ER3t2Yv+wy6WD/C1y4+Mjmh4hJ0tvCV/DfHI04Mqcz am+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pcm4FzP5Zqll4vx+qLC4Zs+d3QrWbatabIiC6u6r60g=; b=ey0ZFzqDlQd9XYR7JyKArj+4KXbLhkWmxhRu8UEwwrgoRiPv4l3VYRP8imr8PyRdqo JwnxTXvEH/chZsRhizpeWPCBgTYgzhP3pXBmhRv35BL7XSA3BScc1N/sWU5T5jxvXoQ0 gRNWrjXreYwr2832HaZHt5wZZ5HQ0+HL3m5JZpCykktm9kTnfWIrqdN4dmNDClykhPsw GwmnK3l6aryWR/it+/OXJGoP9MleDL8gPlhIv3/UQQEdjQYgPiZAzuau/lTfayVHv499 25KVZFVIzfrynxanlaFrF6kT9qlj5ZP9VLeGmJ5Yi8+g5eozF9qC3j01ZG4gpTmSqSYT i5Yw== X-Gm-Message-State: ANoB5plGNjDPamZAzVinmNMsetin5IrF9AfIYpvkPsmkwabtMxybHF6V ahe2A5I7xDsTp3UxObJIne3qOA== X-Google-Smtp-Source: AA0mqf7OyflAEmqc6dCA8VV2BTVg5hL8XYlI7G/+OCSqOxDy+T3BLdadJXZXgwOKDU/Y47R45OBB4A== X-Received: by 2002:adf:fbcd:0:b0:22e:304b:cf66 with SMTP id d13-20020adffbcd000000b0022e304bcf66mr13304375wrs.308.1668594007976; Wed, 16 Nov 2022 02:20:07 -0800 (PST) Received: from arrakeen.starnux.net ([2a01:e0a:982:cbb0:52eb:f6ff:feb3:451a]) by smtp.gmail.com with ESMTPSA id l18-20020a05600c4f1200b003c6f3f6675bsm1709900wmq.26.2022.11.16.02.20.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Nov 2022 02:20:07 -0800 (PST) From: Neil Armstrong Date: Wed, 16 Nov 2022 11:20:05 +0100 Subject: [PATCH 2/4] dt-bindings: misc: qcom,fastrpc: increase allowed iommus entries MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20221114-narmstrong-sm8550-upstream-remoteproc-v1-2-104c34cb3b91@linaro.org> References: <20221114-narmstrong-sm8550-upstream-remoteproc-v1-0-104c34cb3b91@linaro.org> In-Reply-To: <20221114-narmstrong-sm8550-upstream-remoteproc-v1-0-104c34cb3b91@linaro.org> To: Krzysztof Kozlowski , Bjorn Andersson , Konrad Dybcio , Andy Gross , Manivannan Sadhasivam , Amol Maheshwari , Srinivas Kandagatla , Rob Herring , Mathieu Poirier Cc: devicetree@vger.kernel.org, Abel Vesa , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, Neil Armstrong X-Mailer: b4 0.10.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Abel Vesa The fastrpc components on the SM8550 SoC can require up to 3 IOMMU entries, this bumps the maxItems to 3 for this purpose. Signed-off-by: Abel Vesa Signed-off-by: Neil Armstrong Reviewed-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml b/Doc= umentation/devicetree/bindings/misc/qcom,fastrpc.yaml index d7576f8ac94b..1ab9588cdd89 100644 --- a/Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml +++ b/Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml @@ -79,7 +79,7 @@ patternProperties: =20 iommus: minItems: 1 - maxItems: 2 + maxItems: 3 =20 qcom,nsessions: $ref: /schemas/types.yaml#/definitions/uint32 --=20 b4 0.10.1 From nobody Mon Apr 13 20:08:48 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5623BC4332F for ; Wed, 16 Nov 2022 10:20:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236257AbiKPKUh (ORCPT ); Wed, 16 Nov 2022 05:20:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55992 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233538AbiKPKUL (ORCPT ); Wed, 16 Nov 2022 05:20:11 -0500 Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6AFD522299 for ; Wed, 16 Nov 2022 02:20:10 -0800 (PST) Received: by mail-wr1-x436.google.com with SMTP id l14so29123661wrw.2 for ; Wed, 16 Nov 2022 02:20:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=cYqc7qOp0vDZbB74DPEwdJqhwcxbDqw4f19kHt+4faI=; b=DMwUZkXoDp8R2G4cWfzFiWt0n3e+8NoCdSm9+Sd4pT1DONWsbAslB4lAx2KhlEHBfv zt+LiJ8it68uEJCxaaIH1TbLtJ2oYKHxgwLkWD/IFLuZr/REGmIeQl3Sq9JJ5zgBTbQM QKAf/MhFXZZeQdEprKmulrcIFlZQyZQjoIq+agCSp0mMqcrPb2mpDjDPRZ7frVqNJSYk 5FpWMG+yJVHQt8WWu4wZ+KlOo2wn6+WZZuPE+X6eM1cWhNlkjXxe/ofng5COoKiovRzM +Kb+GpQZB+ChZZl+dnnTsWCKhglc12sMX+TebK1vgsOpJTVXPLiNZrOEXbrtxNe0ey1q XPwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cYqc7qOp0vDZbB74DPEwdJqhwcxbDqw4f19kHt+4faI=; b=bjODq6kLxhjCGAV4lwf3dAOy2EdInH8wIrqOUFSuwqFGAPAW2gzP83nEXDaPoAXM6u CUUjbB3CsEF5qDZ34zkn43rp5djuXfDmmZvk1toPuDDv1XOgrVtnDziPdqY6DIFICjlg omxHkfxTESWMkG0bkBFwFOlM6ZrE0sWausSBIaNaJTH50UcXq4WnFfPvmsMOqkL9g+bK DajdJG1svB4e9N6l598qyhfhE/5/3RM9nOAxEppQ5X3BLih2mlfMVIg4TL+xh9uKt1Vr RR/4bv7V2XQ9noxNDsaJM60BygGwf8nRKIg5/L0ZTWaRLyVzhvtYncBYBBwJt559ePEW hbjA== X-Gm-Message-State: ANoB5pkA7sH4/phSft+3ypG2pRhLZpVCVOA3eRRc/8/QBeTSwWMMIvKW PrRNARl/O7EROrhJYNBgmMVBvQ== X-Google-Smtp-Source: AA0mqf6glDZPaKQw/oYtSgPnqtqfz6XPO+eJZw01I2gjqQiExvFuw8LhIOCTWMjlbhGUN1+Jn0jkwQ== X-Received: by 2002:a5d:4091:0:b0:236:4a87:2c25 with SMTP id o17-20020a5d4091000000b002364a872c25mr12954545wrp.19.1668594008965; Wed, 16 Nov 2022 02:20:08 -0800 (PST) Received: from arrakeen.starnux.net ([2a01:e0a:982:cbb0:52eb:f6ff:feb3:451a]) by smtp.gmail.com with ESMTPSA id l18-20020a05600c4f1200b003c6f3f6675bsm1709900wmq.26.2022.11.16.02.20.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Nov 2022 02:20:08 -0800 (PST) From: Neil Armstrong Date: Wed, 16 Nov 2022 11:20:06 +0100 Subject: [PATCH 3/4] remoteproc: qcom_q6v5_pas: add support for dtb co-firmware loading MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20221114-narmstrong-sm8550-upstream-remoteproc-v1-3-104c34cb3b91@linaro.org> References: <20221114-narmstrong-sm8550-upstream-remoteproc-v1-0-104c34cb3b91@linaro.org> In-Reply-To: <20221114-narmstrong-sm8550-upstream-remoteproc-v1-0-104c34cb3b91@linaro.org> To: Krzysztof Kozlowski , Bjorn Andersson , Konrad Dybcio , Andy Gross , Manivannan Sadhasivam , Amol Maheshwari , Srinivas Kandagatla , Rob Herring , Mathieu Poirier Cc: devicetree@vger.kernel.org, Abel Vesa , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, Neil Armstrong X-Mailer: b4 0.10.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Starting from the SM8550 SoC, starting the aDSP, cDSP and MPSS will require loading a separate "Devicetree" firmware. In order to satisfy the load & authentication order required by the SM8550 SoC, the following is implemented: - "Devicetree" firmware request & load in dedicated memory - Q6V5 prepare - Power Domain & Clocks enable - "Devicetree" firmware authentication - Main firmware load in dedicated memory - Main firmware authentication - Q6V5 startup - "Devicetree" firmware metadata release - Main metadata release When booting older platforms, the "Devicetree" steps would be bypassed and the load & authentication order would still be valid. Signed-off-by: Neil Armstrong --- drivers/remoteproc/qcom_q6v5_pas.c | 134 +++++++++++++++++++++++++++++++++= ---- 1 file changed, 121 insertions(+), 13 deletions(-) diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q= 6v5_pas.c index 6afd0941e552..e79a5fcbc986 100644 --- a/drivers/remoteproc/qcom_q6v5_pas.c +++ b/drivers/remoteproc/qcom_q6v5_pas.c @@ -35,7 +35,9 @@ struct adsp_data { int crash_reason_smem; const char *firmware_name; + const char *dtb_firmware_name; int pas_id; + int dtb_pas_id; unsigned int minidump_id; bool has_aggre2_clk; bool auto_boot; @@ -65,20 +67,29 @@ struct qcom_adsp { =20 int proxy_pd_count; =20 + const char *dtb_firmware_name; int pas_id; + int dtb_pas_id; unsigned int minidump_id; int crash_reason_smem; bool has_aggre2_clk; bool decrypt_shutdown; const char *info_name; =20 + const struct firmware *firmware; + const struct firmware *dtb_firmware; + struct completion start_done; struct completion stop_done; =20 phys_addr_t mem_phys; + phys_addr_t dtb_mem_phys; phys_addr_t mem_reloc; + phys_addr_t dtb_mem_reloc; void *mem_region; + void *dtb_mem_region; size_t mem_size; + size_t dtb_mem_size; =20 struct qcom_rproc_glink glink_subdev; struct qcom_rproc_subdev smd_subdev; @@ -86,6 +97,7 @@ struct qcom_adsp { struct qcom_sysmon *sysmon; =20 struct qcom_scm_pas_metadata pas_metadata; + struct qcom_scm_pas_metadata dtb_pas_metadata; }; =20 static void adsp_minidump(struct rproc *rproc) @@ -160,6 +172,8 @@ static int adsp_unprepare(struct rproc *rproc) * here. */ qcom_scm_pas_metadata_release(&adsp->pas_metadata); + if (adsp->dtb_pas_id) + qcom_scm_pas_metadata_release(&adsp->dtb_pas_metadata); =20 return 0; } @@ -169,20 +183,40 @@ static int adsp_load(struct rproc *rproc, const struc= t firmware *fw) struct qcom_adsp *adsp =3D (struct qcom_adsp *)rproc->priv; int ret; =20 - ret =3D qcom_mdt_pas_init(adsp->dev, fw, rproc->firmware, adsp->pas_id, - adsp->mem_phys, &adsp->pas_metadata); - if (ret) - return ret; + /* Store firmware handle to be used in adsp_start() */ + adsp->firmware =3D fw; =20 - ret =3D qcom_mdt_load_no_init(adsp->dev, fw, rproc->firmware, adsp->pas_i= d, - adsp->mem_region, adsp->mem_phys, adsp->mem_size, - &adsp->mem_reloc); - if (ret) - return ret; + if (adsp->dtb_pas_id) { + ret =3D request_firmware(&adsp->dtb_firmware, adsp->dtb_firmware_name, a= dsp->dev); + if (ret) { + dev_err(adsp->dev, "request_firmware failed for %s: %d\n", + adsp->dtb_firmware_name, ret); + return ret; + } =20 - qcom_pil_info_store(adsp->info_name, adsp->mem_phys, adsp->mem_size); + ret =3D qcom_mdt_pas_init(adsp->dev, adsp->dtb_firmware, adsp->dtb_firmw= are_name, + adsp->dtb_pas_id, adsp->dtb_mem_phys, + &adsp->dtb_pas_metadata); + if (ret) + goto release_dtb_firmware; + + ret =3D qcom_mdt_load_no_init(adsp->dev, adsp->dtb_firmware, adsp->dtb_f= irmware_name, + adsp->dtb_pas_id, adsp->dtb_mem_region, + adsp->dtb_mem_phys, adsp->dtb_mem_size, + &adsp->dtb_mem_reloc); + if (ret) + goto release_dtb_metadata; + } =20 return 0; + +release_dtb_metadata: + qcom_scm_pas_metadata_release(&adsp->dtb_pas_metadata); + +release_dtb_firmware: + release_firmware(adsp->dtb_firmware); + + return ret; } =20 static int adsp_start(struct rproc *rproc) @@ -218,24 +252,55 @@ static int adsp_start(struct rproc *rproc) goto disable_cx_supply; } =20 + if (adsp->dtb_pas_id) { + ret =3D qcom_scm_pas_auth_and_reset(adsp->dtb_pas_id); + if (ret) { + dev_err(adsp->dev, + "failed to authenticate dtb image and release reset\n"); + goto disable_px_supply; + } + } + + ret =3D qcom_mdt_pas_init(adsp->dev, adsp->firmware, rproc->firmware, ads= p->pas_id, + adsp->mem_phys, &adsp->pas_metadata); + if (ret) + goto disable_px_supply; + + ret =3D qcom_mdt_load_no_init(adsp->dev, adsp->firmware, rproc->firmware,= adsp->pas_id, + adsp->mem_region, adsp->mem_phys, adsp->mem_size, + &adsp->mem_reloc); + if (ret) + goto release_pas_metadata; + + qcom_pil_info_store(adsp->info_name, adsp->mem_phys, adsp->mem_size); + ret =3D qcom_scm_pas_auth_and_reset(adsp->pas_id); if (ret) { dev_err(adsp->dev, "failed to authenticate image and release reset\n"); - goto disable_px_supply; + goto release_pas_metadata; } =20 ret =3D qcom_q6v5_wait_for_start(&adsp->q6v5, msecs_to_jiffies(5000)); if (ret =3D=3D -ETIMEDOUT) { dev_err(adsp->dev, "start timed out\n"); qcom_scm_pas_shutdown(adsp->pas_id); - goto disable_px_supply; + goto release_pas_metadata; } =20 qcom_scm_pas_metadata_release(&adsp->pas_metadata); + if (adsp->dtb_pas_id) + qcom_scm_pas_metadata_release(&adsp->dtb_pas_metadata); + + /* Remove pointer to the loaded firmware, only valid in adsp_load() & ads= p_start() */ + adsp->firmware =3D NULL; =20 return 0; =20 +release_pas_metadata: + qcom_scm_pas_metadata_release(&adsp->pas_metadata); + if (adsp->dtb_pas_id) + qcom_scm_pas_metadata_release(&adsp->dtb_pas_metadata); disable_px_supply: if (adsp->px_supply) regulator_disable(adsp->px_supply); @@ -251,6 +316,9 @@ static int adsp_start(struct rproc *rproc) disable_irqs: qcom_q6v5_unprepare(&adsp->q6v5); =20 + /* Remove pointer to the loaded firmware, only valid in adsp_load() & ads= p_start() */ + adsp->firmware =3D NULL; + return ret; } =20 @@ -284,6 +352,12 @@ static int adsp_stop(struct rproc *rproc) if (ret) dev_err(adsp->dev, "failed to shutdown: %d\n", ret); =20 + if (adsp->dtb_pas_id) { + ret =3D qcom_scm_pas_shutdown(adsp->dtb_pas_id); + if (ret) + dev_err(adsp->dev, "failed to shutdown dtb: %d\n", ret); + } + handover =3D qcom_q6v5_unprepare(&adsp->q6v5); if (handover) qcom_pas_handover(&adsp->q6v5); @@ -461,6 +535,28 @@ static int adsp_alloc_memory_region(struct qcom_adsp *= adsp) return -EBUSY; } =20 + if (!adsp->dtb_pas_id) + return 0; + + node =3D of_parse_phandle(adsp->dev->of_node, "memory-region", 1); + if (!node) { + dev_err(adsp->dev, "no dtb memory-region specified\n"); + return -EINVAL; + } + + ret =3D of_address_to_resource(node, 0, &r); + if (ret) + return ret; + + adsp->dtb_mem_phys =3D adsp->dtb_mem_reloc =3D r.start; + adsp->dtb_mem_size =3D resource_size(&r); + adsp->dtb_mem_region =3D devm_ioremap_wc(adsp->dev, adsp->dtb_mem_phys, a= dsp->dtb_mem_size); + if (!adsp->dtb_mem_region) { + dev_err(adsp->dev, "unable to map dtb memory region: %pa+%zx\n", + &r.start, adsp->dtb_mem_size); + return -EBUSY; + } + return 0; } =20 @@ -469,7 +565,7 @@ static int adsp_probe(struct platform_device *pdev) const struct adsp_data *desc; struct qcom_adsp *adsp; struct rproc *rproc; - const char *fw_name; + const char *fw_name, *dtb_fw_name =3D NULL; const struct rproc_ops *ops =3D &adsp_ops; int ret; =20 @@ -486,6 +582,14 @@ static int adsp_probe(struct platform_device *pdev) if (ret < 0 && ret !=3D -EINVAL) return ret; =20 + if (desc->dtb_firmware_name) { + dtb_fw_name =3D desc->dtb_firmware_name; + ret =3D of_property_read_string(pdev->dev.of_node, "qcom,dtb-firmware-na= me", + &dtb_fw_name); + if (ret < 0 && ret !=3D -EINVAL) + return ret; + } + if (desc->minidump_id) ops =3D &adsp_minidump_ops; =20 @@ -507,6 +611,10 @@ static int adsp_probe(struct platform_device *pdev) adsp->has_aggre2_clk =3D desc->has_aggre2_clk; adsp->info_name =3D desc->sysmon_name; adsp->decrypt_shutdown =3D desc->decrypt_shutdown; + if (dtb_fw_name) { + adsp->dtb_firmware_name =3D dtb_fw_name; + adsp->dtb_pas_id =3D desc->dtb_pas_id; + } platform_set_drvdata(pdev, adsp); =20 ret =3D device_init_wakeup(adsp->dev, true); --=20 b4 0.10.1 From nobody Mon Apr 13 20:08:48 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85879C43217 for ; Wed, 16 Nov 2022 10:20:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238325AbiKPKUm (ORCPT ); Wed, 16 Nov 2022 05:20:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56000 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233389AbiKPKUe (ORCPT ); Wed, 16 Nov 2022 05:20:34 -0500 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8F8372126B for ; Wed, 16 Nov 2022 02:20:11 -0800 (PST) Received: by mail-wm1-x32c.google.com with SMTP id ja4-20020a05600c556400b003cf6e77f89cso2776734wmb.0 for ; Wed, 16 Nov 2022 02:20:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=ibv+5YEHVAYxDSspsvnfANXTqnasTlWYJgau3UGpbZg=; b=oqwKO0I4oUXU/WX3HEjhUkL3jbBmIiKg/61u7OXDVcOxweWRas/AE/BwkSrn/jpxdg UI5PEwwWlHkBh6grH+IYllAJBT51uRmLx68VUqiKXVjezJEfvOf/EZbzmKPxgIDnRiRs 4ZJQSBLkDX3p5VjaDbR1HM9eT/jAgRQSt8Tg5rJvTFNDRcCAdKjMkGzoSQNjdBrkPHs7 8UB24gSxoLXdgy/StL/IWW8R43CeOe61zvZy0hC06POFhZjYhKkKZBGUYJTdt+EuXEn5 yXoGZWRKL7bed5AbgsnSGCQ36nf6WBV72EcnlIFyiU3u3rGrc3+n7asKEtQwWik6IxeU uARA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ibv+5YEHVAYxDSspsvnfANXTqnasTlWYJgau3UGpbZg=; b=ZRytqw5Vg/W7S1u5J9MH7eYEpLt34MBtOU4uqmOBMC4PKahknONs+Z+/KSZ8qedkuO 1A8/pgaXNgv0zkcu2Ad4asDZQ+6i2BOQO7GffZLCMjsUKODf6usFmpD27nHkwf5GQXaT XWbBcOOV4Yz4xDJM29fyGgUroc17/Se8vf4UYtl0MR3XrvMyXWFScptSsFxkextBOOOR QjPi4Y35PLaq2EBf0ywNw6HqcX+MB0S4iRgZQL7BACBq3WS14Ba8WFFv2AkUAIm47HCi +SgvP+wRNfOISbCsWqsdZ0OrwV4omW1fS8whEw6IQrXfl1V+MpLM8F5MiXZdUPnzOlPj BPUw== X-Gm-Message-State: ANoB5plTuFd1AaYOA39AjlydN85b+D8EaQR3EJ0sDK11LPW7sCfe4op4 XPA0u9zyhOi1GwTbQw4CPaoNLA== X-Google-Smtp-Source: AA0mqf6fM7ZsDPtfpP7ah663PmKAcCanlgICfSh207kSCgxvqhSn88+AGeuSSxUDdN2XSjFioPrWRw== X-Received: by 2002:a7b:c04d:0:b0:3cf:a8a5:63ab with SMTP id u13-20020a7bc04d000000b003cfa8a563abmr1608489wmc.101.1668594010071; Wed, 16 Nov 2022 02:20:10 -0800 (PST) Received: from arrakeen.starnux.net ([2a01:e0a:982:cbb0:52eb:f6ff:feb3:451a]) by smtp.gmail.com with ESMTPSA id l18-20020a05600c4f1200b003c6f3f6675bsm1709900wmq.26.2022.11.16.02.20.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Nov 2022 02:20:09 -0800 (PST) From: Neil Armstrong Date: Wed, 16 Nov 2022 11:20:07 +0100 Subject: [PATCH 4/4] remoteproc: qcom_q6v5_pas: add sm8550 adsp, cdsp & mpss compatible & data MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20221114-narmstrong-sm8550-upstream-remoteproc-v1-4-104c34cb3b91@linaro.org> References: <20221114-narmstrong-sm8550-upstream-remoteproc-v1-0-104c34cb3b91@linaro.org> In-Reply-To: <20221114-narmstrong-sm8550-upstream-remoteproc-v1-0-104c34cb3b91@linaro.org> To: Krzysztof Kozlowski , Bjorn Andersson , Konrad Dybcio , Andy Gross , Manivannan Sadhasivam , Amol Maheshwari , Srinivas Kandagatla , Rob Herring , Mathieu Poirier Cc: devicetree@vger.kernel.org, Abel Vesa , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, Neil Armstrong X-Mailer: b4 0.10.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This adds the compatible & data for the aDSP, cDSP and MPSS found in the SM8550 SoC. This platform requires the "Devicetree" firmware to be loaded along the main firmware. Signed-off-by: Neil Armstrong --- drivers/remoteproc/qcom_q6v5_pas.c | 65 ++++++++++++++++++++++++++++++++++= ++++ 1 file changed, 65 insertions(+) diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q= 6v5_pas.c index e79a5fcbc986..15e740815da0 100644 --- a/drivers/remoteproc/qcom_q6v5_pas.c +++ b/drivers/remoteproc/qcom_q6v5_pas.c @@ -1054,6 +1054,68 @@ static const struct adsp_data sm8450_mpss_resource = =3D { .ssctl_id =3D 0x12, }; =20 +static const struct adsp_data sm8550_adsp_resource =3D { + .crash_reason_smem =3D 423, + .firmware_name =3D "adsp.mdt", + .dtb_firmware_name =3D "adsp_dtb.mdt", + .pas_id =3D 1, + .dtb_pas_id =3D 0x24, + .minidump_id =3D 5, + .has_aggre2_clk =3D false, + .auto_boot =3D false, + .proxy_pd_names =3D (char*[]){ + "lcx", + "lmx", + NULL + }, + .load_state =3D "adsp", + .ssr_name =3D "lpass", + .sysmon_name =3D "adsp", + .ssctl_id =3D 0x14, +}; + +static const struct adsp_data sm8550_cdsp_resource =3D { + .crash_reason_smem =3D 601, + .firmware_name =3D "cdsp.mdt", + .dtb_firmware_name =3D "cdsp_dtb.mdt", + .pas_id =3D 18, + .dtb_pas_id =3D 0x25, + .minidump_id =3D 7, + .has_aggre2_clk =3D false, + .auto_boot =3D false, + .proxy_pd_names =3D (char*[]){ + "cx", + "mxc", + "nsp", + NULL + }, + .load_state =3D "cdsp", + .ssr_name =3D "cdsp", + .sysmon_name =3D "cdsp", + .ssctl_id =3D 0x17, +}; + +static const struct adsp_data sm8550_mpss_resource =3D { + .crash_reason_smem =3D 421, + .firmware_name =3D "modem.mdt", + .dtb_firmware_name =3D "modem_dtb.mdt", + .pas_id =3D 4, + .dtb_pas_id =3D 0x26, + .minidump_id =3D 3, + .has_aggre2_clk =3D false, + .auto_boot =3D false, + .decrypt_shutdown =3D true, + .proxy_pd_names =3D (char*[]){ + "cx", + "mss", + NULL + }, + .load_state =3D "modem", + .ssr_name =3D "mpss", + .sysmon_name =3D "modem", + .ssctl_id =3D 0x12, +}; + static const struct of_device_id adsp_of_match[] =3D { { .compatible =3D "qcom,msm8226-adsp-pil", .data =3D &adsp_resource_init}, { .compatible =3D "qcom,msm8974-adsp-pil", .data =3D &adsp_resource_init}, @@ -1094,6 +1156,9 @@ static const struct of_device_id adsp_of_match[] =3D { { .compatible =3D "qcom,sm8450-cdsp-pas", .data =3D &sm8350_cdsp_resource= }, { .compatible =3D "qcom,sm8450-slpi-pas", .data =3D &sm8350_slpi_resource= }, { .compatible =3D "qcom,sm8450-mpss-pas", .data =3D &sm8450_mpss_resource= }, + { .compatible =3D "qcom,sm8550-adsp-pas", .data =3D &sm8550_adsp_resource= }, + { .compatible =3D "qcom,sm8550-cdsp-pas", .data =3D &sm8550_cdsp_resource= }, + { .compatible =3D "qcom,sm8550-mpss-pas", .data =3D &sm8550_mpss_resource= }, { }, }; MODULE_DEVICE_TABLE(of, adsp_of_match); --=20 b4 0.10.1