From nobody Wed Apr 8 08:21:32 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC8E0C4332F for ; Sat, 12 Nov 2022 10:58:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234843AbiKLK6j (ORCPT ); Sat, 12 Nov 2022 05:58:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57342 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234794AbiKLK6a (ORCPT ); Sat, 12 Nov 2022 05:58:30 -0500 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B92F5A473 for ; Sat, 12 Nov 2022 02:58:29 -0800 (PST) Received: from dggpemm500021.china.huawei.com (unknown [172.30.72.57]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4N8Xc63NMczRp4M; Sat, 12 Nov 2022 18:58:14 +0800 (CST) Received: from dggpemm100009.china.huawei.com (7.185.36.113) by dggpemm500021.china.huawei.com (7.185.36.109) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Sat, 12 Nov 2022 18:58:19 +0800 Received: from huawei.com (10.175.113.32) by dggpemm100009.china.huawei.com (7.185.36.113) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Sat, 12 Nov 2022 18:58:19 +0800 From: Liu Shixin To: Christoph Lameter , Pekka Enberg , "David Rientjes" , Joonsoo Kim , "Andrew Morton" , Vlastimil Babka , "Roman Gushchin" , Hyeonggon Yoo <42.hyeyoo@gmail.com> CC: , , Liu Shixin Subject: [PATCH v4 1/3] mm/slab_common: Move cache_name to create_cache() Date: Sat, 12 Nov 2022 19:46:00 +0800 Message-ID: <20221112114602.1268989-2-liushixin2@huawei.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221112114602.1268989-1-liushixin2@huawei.com> References: <20221112114602.1268989-1-liushixin2@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.113.32] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpemm100009.china.huawei.com (7.185.36.113) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The string cache_name and its kmem_cache have same life cycle. The latter is allocated in create_cache() so move cache_name to create_cache() too for better error handing. Signed-off-by: Liu Shixin --- mm/slab_common.c | 34 ++++++++++++++-------------------- 1 file changed, 14 insertions(+), 20 deletions(-) diff --git a/mm/slab_common.c b/mm/slab_common.c index 33b1886b06eb..e5f430a17d95 100644 --- a/mm/slab_common.c +++ b/mm/slab_common.c @@ -209,17 +209,21 @@ static struct kmem_cache *create_cache(const char *na= me, struct kmem_cache *root_cache) { struct kmem_cache *s; - int err; + const char *cache_name; + int err =3D -ENOMEM; =20 if (WARN_ON(useroffset + usersize > object_size)) useroffset =3D usersize =3D 0; =20 - err =3D -ENOMEM; s =3D kmem_cache_zalloc(kmem_cache, GFP_KERNEL); if (!s) - goto out; + return ERR_PTR(err); =20 - s->name =3D name; + cache_name =3D kstrdup_const(name, GFP_KERNEL); + if (!cache_name) + goto out_free_cache; + + s->name =3D cache_name; s->size =3D s->object_size =3D object_size; s->align =3D align; s->ctor =3D ctor; @@ -228,18 +232,17 @@ static struct kmem_cache *create_cache(const char *na= me, =20 err =3D __kmem_cache_create(s, flags); if (err) - goto out_free_cache; + goto out_free_name; =20 s->refcount =3D 1; list_add(&s->list, &slab_caches); -out: - if (err) - return ERR_PTR(err); return s; =20 +out_free_name: + kfree_const(s->name); out_free_cache: kmem_cache_free(kmem_cache, s); - goto out; + return ERR_PTR(err); } =20 /** @@ -278,7 +281,6 @@ kmem_cache_create_usercopy(const char *name, void (*ctor)(void *)) { struct kmem_cache *s =3D NULL; - const char *cache_name; int err; =20 #ifdef CONFIG_SLUB_DEBUG @@ -326,19 +328,11 @@ kmem_cache_create_usercopy(const char *name, if (s) goto out_unlock; =20 - cache_name =3D kstrdup_const(name, GFP_KERNEL); - if (!cache_name) { - err =3D -ENOMEM; - goto out_unlock; - } - - s =3D create_cache(cache_name, size, + s =3D create_cache(name, size, calculate_alignment(flags, align, size), flags, useroffset, usersize, ctor, NULL); - if (IS_ERR(s)) { + if (IS_ERR(s)) err =3D PTR_ERR(s); - kfree_const(cache_name); - } =20 out_unlock: mutex_unlock(&slab_mutex); --=20 2.25.1