From nobody Thu Apr 9 14:58:09 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2AA7C4332F for ; Mon, 7 Nov 2022 11:07:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231624AbiKGLHm (ORCPT ); Mon, 7 Nov 2022 06:07:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60040 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231400AbiKGLH0 (ORCPT ); Mon, 7 Nov 2022 06:07:26 -0500 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 316AA18386; Mon, 7 Nov 2022 03:07:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1667819246; x=1699355246; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=UtD5WjXlvt+YGgcDoYJMysEl6WyGK5Ld+p1WXJ0fxvY=; b=n28fkNWLHfIASasA6zjuz0HHBIObVZ3prF4BeJY27HUS16Jl5gXbKbeW G/sn44dMeIPapAxm/pxzVB3aUgiUkywnrj3VzMjPo+lckKfvb+hh0LzM3 xakZdCJad2TZQ/vV1LD0URjhAwO/SeVn7GqVXyx9yw04dS3bQTQC9d+j1 UFIDxhzPbAVPIJSbO5U7HSpbePdJGrBdTqquedKMK9lTL3NXw+KbLK0Gm 8YCbD3CAKpmEv9qZcQJVx5DrRXujjF/SHwVQ/bVfrfRITkJsuqTkyP8Wn BpIqCNghusdhthPp9jkRxMXlBIxeRmmj06ca5mgPGwZx7hMZGZZZD7QIY Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10523"; a="290773022" X-IronPort-AV: E=Sophos;i="5.96,143,1665471600"; d="scan'208";a="290773022" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Nov 2022 03:07:25 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10523"; a="586932344" X-IronPort-AV: E=Sophos;i="5.96,143,1665471600"; d="scan'208";a="586932344" Received: from gschoede-mobl1.ger.corp.intel.com (HELO ijarvine-MOBL2.ger.corp.intel.com) ([10.252.46.211]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Nov 2022 03:07:23 -0800 From: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= To: Andy Shevchenko , Greg Kroah-Hartman , Jiri Slaby , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= Cc: stable Subject: [PATCH 2/4] serial: 8250_lpss: Configure DMA also w/o DMA filter Date: Mon, 7 Nov 2022 13:07:06 +0200 Message-Id: <20221107110708.58223-3-ilpo.jarvinen@linux.intel.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221107110708.58223-1-ilpo.jarvinen@linux.intel.com> References: <20221107110708.58223-1-ilpo.jarvinen@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If the platform doesn't use DMA device filter (as is the case with Elkhart Lake), whole lpss8250_dma_setup() setup is skipped. This results in skipping also *_maxburst setup which is undesirable. Refactor lpss8250_dma_setup() to configure DMA even if filter is not setup. Cc: stable Signed-off-by: Ilpo J=C3=A4rvinen --- drivers/tty/serial/8250/8250_lpss.c | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/drivers/tty/serial/8250/8250_lpss.c b/drivers/tty/serial/8250/= 8250_lpss.c index 44cc755b1a29..ed281445a97d 100644 --- a/drivers/tty/serial/8250/8250_lpss.c +++ b/drivers/tty/serial/8250/8250_lpss.c @@ -277,8 +277,10 @@ static int lpss8250_dma_setup(struct lpss8250 *lpss, s= truct uart_8250_port *port struct dw_dma_slave *rx_param, *tx_param; struct device *dev =3D port->port.dev; =20 - if (!lpss->dma_param.dma_dev) - return 0; + if (!lpss->dma_param.dma_dev) { + dma =3D port->dma; + goto confonly; + } =20 rx_param =3D devm_kzalloc(dev, sizeof(*rx_param), GFP_KERNEL); if (!rx_param) @@ -289,16 +291,20 @@ static int lpss8250_dma_setup(struct lpss8250 *lpss, = struct uart_8250_port *port return -ENOMEM; =20 *rx_param =3D lpss->dma_param; - dma->rxconf.src_maxburst =3D lpss->dma_maxburst; - *tx_param =3D lpss->dma_param; - dma->txconf.dst_maxburst =3D lpss->dma_maxburst; =20 dma->fn =3D lpss8250_dma_filter; dma->rx_param =3D rx_param; dma->tx_param =3D tx_param; =20 port->dma =3D dma; + +confonly: + if (dma) { + dma->rxconf.src_maxburst =3D lpss->dma_maxburst; + dma->txconf.dst_maxburst =3D lpss->dma_maxburst; + } + return 0; } =20 --=20 2.30.2