From nobody Thu Apr 9 12:26:01 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6672AC4332F for ; Sat, 5 Nov 2022 10:18:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229567AbiKEKSH (ORCPT ); Sat, 5 Nov 2022 06:18:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39316 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229486AbiKEKSE (ORCPT ); Sat, 5 Nov 2022 06:18:04 -0400 Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [IPv6:2607:f8b0:4864:20::1032]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AC6E51F2D8; Sat, 5 Nov 2022 03:18:02 -0700 (PDT) Received: by mail-pj1-x1032.google.com with SMTP id b11so6548237pjp.2; Sat, 05 Nov 2022 03:18:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=30MWZ/QAU7ucYr6chFrQAelaY4GfUj5j6UgBAnY7lFI=; b=FDPbz3+19IIyhmm+7vQeQZOGmnCyOif87dleZhv96SxcydSqMrcXRUO1T/luCKU5sy YDeZ2hxAVCyyYoKH+zMCROkQdAr+1B+oZBvX8CGGxtD5toIDHcKKFyjoPJhooy7Grihs /AoJE2fQKhheNBOGBy45zZILJ9rskZg8OJ5Teq2prhIYBJxeZKrJuEt4qViYYxVeNPqW 4jruKBq2MsN3whxKEvXyfiTuE2uVm2k7zHXVq86uLpNMx3AU1ZQ7lndaGXk8KHoJjByL Szu35lEpzcAhiF3ZgsM2xu0YzKJoZ9zA5Y/wA8+WvVwBtxU4WuDwwMIj6F3tqRFxqVKK G41w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=30MWZ/QAU7ucYr6chFrQAelaY4GfUj5j6UgBAnY7lFI=; b=zm7PXMPezqBZG5zxWHS1E3kpqS1f0axIIcXl5b1ZlvuT84zLEt3j000J5IVx6lK8mH CfdWGnjTsMfaa0JTqFHYjOEHTu7bs3LrVGaEGdIoBm2wsvb2668+CN4tWYi6f+bsjtXm 0l6nWYCxXvU/EGn0ixy5+FLuvsG/cSjtt9GFVvl4lSsKQ69IwhWaPydw7oxeCVfx6F82 b3ZtGJCzFrpTtaEPF2Fg8tYTisfemPg2k65EsN9kz2MkZj9P2p8JKOtyvysfiG4QFliK ozpcNjiyj3kJCBSWEWruS2SuB+g41Sz8J1waQxXHnu+uQ4WZFWHizl3V8KNL7rlrhy9u q/SQ== X-Gm-Message-State: ACrzQf0t1lROIh/fNlXGunRyM283QED8l2ksXCHygidV5Bt8oPwmhw+s 7tJZC28WBVrrV5OXAIAxSuk= X-Google-Smtp-Source: AMsMyM6KeDbNMjpPHBjhckNCbykdnuthE8h6iW05TrKkv2fNp2b0H4kBpKwicIbh4pPzRtKo8C+dNg== X-Received: by 2002:a17:903:240d:b0:183:9bab:9c3 with SMTP id e13-20020a170903240d00b001839bab09c3mr39992059plo.48.1667643482051; Sat, 05 Nov 2022 03:18:02 -0700 (PDT) Received: from uftrace.. ([14.5.161.231]) by smtp.gmail.com with ESMTPSA id i4-20020a056a00004400b00562cfc80864sm1014334pfk.36.2022.11.05.03.17.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 05 Nov 2022 03:18:01 -0700 (PDT) From: Kang Minchul To: =?UTF-8?q?Bj=C3=B6rn=20T=C3=B6pel?= , Maciej Fijalkowski , Jonathan Lemon Cc: Martin KaFai Lau , Song Liu , Yonghong Song , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Kang Minchul Subject: [PATCH] selftests/bpf: Fix unsigned expression compared with zero Date: Sat, 5 Nov 2022 19:17:55 +0900 Message-Id: <20221105101755.79848-1-tegongkang@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Variable ret is compared with zero even though it have set as u32. So u32 to int conversion is needed. Signed-off-by: Kang Minchul --- tools/testing/selftests/bpf/xskxceiver.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/bpf/xskxceiver.c b/tools/testing/selft= ests/bpf/xskxceiver.c index 681a5db80dae..162d3a516f2c 100644 --- a/tools/testing/selftests/bpf/xskxceiver.c +++ b/tools/testing/selftests/bpf/xskxceiver.c @@ -1006,7 +1006,8 @@ static int __send_pkts(struct ifobject *ifobject, u32= *pkt_nb, struct pollfd *fd { struct xsk_socket_info *xsk =3D ifobject->xsk; bool use_poll =3D ifobject->use_poll; - u32 i, idx =3D 0, ret, valid_pkts =3D 0; + u32 i, idx =3D 0, valid_pkts =3D 0; + int ret; =20 while (xsk_ring_prod__reserve(&xsk->tx, BATCH_SIZE, &idx) < BATCH_SIZE) { if (use_poll) { --=20 2.34.1