From nobody Thu Apr 9 12:27:32 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B4AFC433FE for ; Fri, 4 Nov 2022 14:59:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232359AbiKDO7C (ORCPT ); Fri, 4 Nov 2022 10:59:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41782 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232282AbiKDO6G (ORCPT ); Fri, 4 Nov 2022 10:58:06 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 555122EF7B for ; Fri, 4 Nov 2022 07:58:00 -0700 (PDT) From: Anna-Maria Behnsen DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1667573879; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7kvCElohZyUyNJGM2JneGjqwOan7vBCE2nbaLgbbE24=; b=0tuI8buTxcQd683GsIeTB2XnvF+yOTjJCOWEzNfR1pfDAmxN20GCUlC36qmFby74aWOo0b Jp1pe1Q7/zkmL1fCF/v8jjHO/UnzxZdHgcX30pQ1tKzk6X8wc2gLBVlzbzXJjm2b2EIBat 3X/5b3IX+EnjHS62nyFo7zcHS6aH4obDW2HKWCTptp8wZmLJ7xSwvEUJWpmr2mrBsM4TWl UGgmRmBnZYt7IehlzhAi2yyc0IIs/QMzUu8oK2fbAVu2DNu+Eks43tEEvRG6Zjhkz8Tn8l Ytxjkl84wObu9x6ASDBdLLk7xl4tToDtB8igF2/YNn2ShanmE65Dc86xxB7fUg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1667573879; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7kvCElohZyUyNJGM2JneGjqwOan7vBCE2nbaLgbbE24=; b=XvrogLHg8qBegViDEiUEOPcLE9nQosfe7dI6/vK+t49B/gbCFUaDJ8+tS/0F7HBSAJperm ZSI2edb40Ftv/oCg== To: linux-kernel@vger.kernel.org Cc: Peter Zijlstra , John Stultz , Thomas Gleixner , Eric Dumazet , "Rafael J . Wysocki" , Arjan van de Ven , "Paul E . McKenney" , Frederic Weisbecker , Rik van Riel , "Richard Cochran (linutronix GmbH)" , Anna-Maria Behnsen Subject: [PATCH v4 13/16] tick/sched: Split out jiffies update helper function Date: Fri, 4 Nov 2022 15:57:34 +0100 Message-Id: <20221104145737.71236-14-anna-maria@linutronix.de> In-Reply-To: <20221104145737.71236-1-anna-maria@linutronix.de> References: <20221104145737.71236-1-anna-maria@linutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: "Richard Cochran (linutronix GmbH)" The logic to get the time of the last jiffies update will be needed by the timer pull model as well. Move the code into a global funtion in anticipation of the new caller. No functional change. Signed-off-by: Richard Cochran (linutronix GmbH) Signed-off-by: Anna-Maria Behnsen --- kernel/time/tick-internal.h | 1 + kernel/time/tick-sched.c | 20 ++++++++++++++++---- 2 files changed, 17 insertions(+), 4 deletions(-) diff --git a/kernel/time/tick-internal.h b/kernel/time/tick-internal.h index 7b65abc9d803..8f99e35e75b4 100644 --- a/kernel/time/tick-internal.h +++ b/kernel/time/tick-internal.h @@ -158,6 +158,7 @@ static inline void tick_nohz_init(void) { } #ifdef CONFIG_NO_HZ_COMMON extern unsigned long tick_nohz_active; extern void timers_update_nohz(void); +extern u64 get_jiffies_update(unsigned long *basej); # ifdef CONFIG_SMP extern struct static_key_false timers_migration_enabled; # endif diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c index 7f7bfe8b498d..868679ff3421 100644 --- a/kernel/time/tick-sched.c +++ b/kernel/time/tick-sched.c @@ -782,19 +782,31 @@ static inline bool local_timer_softirq_pending(void) return local_softirq_pending() & BIT(TIMER_SOFTIRQ); } =20 -static ktime_t tick_nohz_next_event(struct tick_sched *ts, int cpu) +/* + * Read jiffies and the time when jiffies were updated last + */ +u64 get_jiffies_update(unsigned long *basej) { - struct timer_events tevt =3D { .local =3D KTIME_MAX, .global =3D KTIME_MA= X }; - u64 basemono, delta, expires; unsigned long basejiff; unsigned int seq; + u64 basemono; =20 - /* Read jiffies and the time when jiffies were updated last */ do { seq =3D read_seqcount_begin(&jiffies_seq); basemono =3D last_jiffies_update; basejiff =3D jiffies; } while (read_seqcount_retry(&jiffies_seq, seq)); + *basej =3D basejiff; + return basemono; +} + +static ktime_t tick_nohz_next_event(struct tick_sched *ts, int cpu) +{ + struct timer_events tevt =3D { .local =3D KTIME_MAX, .global =3D KTIME_MA= X }; + u64 basemono, delta, expires; + unsigned long basejiff; + + basemono =3D get_jiffies_update(&basejiff); ts->last_jiffies =3D basejiff; ts->timer_expires_base =3D basemono; =20 --=20 2.30.2