From nobody Thu Apr 9 04:44:01 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40C60C43217 for ; Wed, 2 Nov 2022 18:40:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231310AbiKBSkR (ORCPT ); Wed, 2 Nov 2022 14:40:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35234 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230526AbiKBSkO (ORCPT ); Wed, 2 Nov 2022 14:40:14 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 526D42FA for ; Wed, 2 Nov 2022 11:40:13 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id DC822B82433 for ; Wed, 2 Nov 2022 18:40:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 84177C433D6; Wed, 2 Nov 2022 18:40:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1667414410; bh=QDzLlEsdJgBZfwCe8fdmspQ4lio25AEQNSzuvHZI6ZU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=oOPiGX/M5djAqWhXtUaku0rxJ5mAilaYczj6k7j7MtJo6Tmkwc1sYfYOlgYiI27Nk VnRB6Maz1sSNTubTnml6bEBh90vY+rh5txbOgv8DEOfj2d/sAXLCww17SYH82X5YkS yXO2z8MApivd7vyuDAsZyf1c/JtHoatzZ3Rv0V/K+O26jcejH8sdHtSnpUJXbbgx6K dfJuyj2Sk9+/eGw+y+Gi88/Y8eVCGOpxTwyKKU8SkAWirAk7Gk8rgGFnA+Tj7iPbk1 RywLpHvtNsuL9+Si2Vmeb8Bny9cjpkAlPviby8mubnG22nkQ0D0IJilU0j3O62GT/U E/Fc5tBi0PiOw== Received: by paulmck-ThinkPad-P17-Gen-1.home (Postfix, from userid 1000) id 3F37B5C1813; Wed, 2 Nov 2022 11:40:10 -0700 (PDT) From: "Paul E. McKenney" To: tglx@linutronix.de Cc: linux-kernel@vger.kernel.org, john.stultz@linaro.org, sboyd@kernel.org, corbet@lwn.net, Mark.Rutland@arm.com, maz@kernel.org, kernel-team@meta.com, neeraju@codeaurora.org, ak@linux.intel.com, feng.tang@intel.com, zhengjun.xing@intel.com, "Paul E. McKenney" , John Stultz , Waiman Long Subject: [PATCH clocksource 1/2] clocksource: Add comments to classify bogus measurements Date: Wed, 2 Nov 2022 11:40:08 -0700 Message-Id: <20221102184009.1306751-1-paulmck@kernel.org> X-Mailer: git-send-email 2.31.1.189.g2e36527f23 In-Reply-To: <20221102184001.GA1306489@paulmck-ThinkPad-P17-Gen-1> References: <20221102184001.GA1306489@paulmck-ThinkPad-P17-Gen-1> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" An extremely busy system can delay the clocksource watchdog, so that the corresponding too-long bogus-measurement error does not necessarily imply an error in the system. However, a too-short bogus-measurement error likely indicates a bug in hardware, firmware or software. Therefore, add comments clarifying these bogus-measurement pr_warn()s. Reported-by: Feng Tang Signed-off-by: Paul E. McKenney Cc: John Stultz Cc: Thomas Gleixner Cc: Stephen Boyd Cc: Feng Tang Cc: Waiman Long Reviewed-by: Feng Tang Reviewed-by: Waiman Long --- kernel/time/clocksource.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/kernel/time/clocksource.c b/kernel/time/clocksource.c index dcaf38c062161..3f5317faf891f 100644 --- a/kernel/time/clocksource.c +++ b/kernel/time/clocksource.c @@ -443,10 +443,12 @@ static void clocksource_watchdog(struct timer_list *u= nused) /* Check for bogus measurements. */ wdi =3D jiffies_to_nsecs(WATCHDOG_INTERVAL); if (wd_nsec < (wdi >> 2)) { + /* This usually indicates broken timer code or hardware. */ pr_warn("timekeeping watchdog on CPU%d: Watchdog clocksource '%s' advan= ced only %lld ns during %d-jiffy time interval, skipping watchdog check.\n"= , smp_processor_id(), watchdog->name, wd_nsec, WATCHDOG_INTERVAL); continue; } if (wd_nsec > (wdi << 2)) { + /* This can happen on busy systems, which can delay the watchdog. */ pr_warn("timekeeping watchdog on CPU%d: Watchdog clocksource '%s' advan= ced an excessive %lld ns during %d-jiffy time interval, probable CPU overut= ilization, skipping watchdog check.\n", smp_processor_id(), watchdog->name,= wd_nsec, WATCHDOG_INTERVAL); continue; } --=20 2.31.1.189.g2e36527f23 From nobody Thu Apr 9 04:44:01 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C109C43217 for ; Wed, 2 Nov 2022 18:40:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231360AbiKBSkV (ORCPT ); Wed, 2 Nov 2022 14:40:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35244 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231211AbiKBSkP (ORCPT ); Wed, 2 Nov 2022 14:40:15 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5293831A for ; Wed, 2 Nov 2022 11:40:13 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id E89DFB82437 for ; Wed, 2 Nov 2022 18:40:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 886BFC433C1; Wed, 2 Nov 2022 18:40:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1667414410; bh=SaIxDonz7jxIjNGEnJ7dwqSnqRS3l2440YhJ0ssJuBw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Kov6kfM75q2SWRX1ME+CRswKJu3gMjUkIPttchOTUJmiWdjGywmC5DZOozwtM1ifP mTkaZddazjVVesBcV2Ha+G93BUI4LAdnsgI1iItRo4JES9GatHV5SZZLgVT1AxvXGA bFPUDn8/Ym3Jx+KYXZD90JWTV6q5mh5KDL2700RLTkkcaqzuoxWJUeCTtOk3Yge1gA VeHchcw4DsR4edRDmz2PnmUg01rYCwVuzQT6Vv0Nik7SxjSRIDZ+ZGYJlkH0QDRGhY /JeKgDro1PnkiI6e+RryEbkZYE0w1zj9m7FYRlJzcRm/X1pCzm31xjmBmEtEqr7qPg dMHpaCMOlx4EQ== Received: by paulmck-ThinkPad-P17-Gen-1.home (Postfix, from userid 1000) id 41F415C18FC; Wed, 2 Nov 2022 11:40:10 -0700 (PDT) From: "Paul E. McKenney" To: tglx@linutronix.de Cc: linux-kernel@vger.kernel.org, john.stultz@linaro.org, sboyd@kernel.org, corbet@lwn.net, Mark.Rutland@arm.com, maz@kernel.org, kernel-team@meta.com, neeraju@codeaurora.org, ak@linux.intel.com, feng.tang@intel.com, zhengjun.xing@intel.com, "Paul E. McKenney" , Waiman Long , John Stultz Subject: [PATCH clocksource 2/2] clocksource: Exponential backoff for load-induced bogus watchdog reads Date: Wed, 2 Nov 2022 11:40:09 -0700 Message-Id: <20221102184009.1306751-2-paulmck@kernel.org> X-Mailer: git-send-email 2.31.1.189.g2e36527f23 In-Reply-To: <20221102184001.GA1306489@paulmck-ThinkPad-P17-Gen-1> References: <20221102184001.GA1306489@paulmck-ThinkPad-P17-Gen-1> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The clocksource watchdog will reject measurements that are excessively delayed, that is, by more than 1.5 seconds beyond the intended 0.5-second watchdog interval. On an extremely busy system, this can result in a console message being printed every two seconds. This is excessively noisy for a non-error condition. Therefore, apply exponential backoff to these messages. This exponential backoff is capped at 1024 times the watchdog interval, which comes to not quite one message per ten minutes. Please note that the bogus watchdog reads that occur when the watchdog interval is less than 0.125 seconds are still printed unconditionally because these likely correspond to a serious error condition in the timer code or hardware. [ paulmck: Apply Feng Tang feedback. ] Reported-by: Waiman Long Reported-by: Feng Tang Signed-off-by: Paul E. McKenney Cc: John Stultz Cc: Thomas Gleixner Cc: Stephen Boyd Cc: Feng Tang Cc: Waiman Long Reviewed-by: Feng Tang Reviewed-by: Waiman Long --- include/linux/clocksource.h | 4 ++++ kernel/time/clocksource.c | 31 +++++++++++++++++++++++++------ 2 files changed, 29 insertions(+), 6 deletions(-) diff --git a/include/linux/clocksource.h b/include/linux/clocksource.h index 1d42d4b173271..daac05aedf56a 100644 --- a/include/linux/clocksource.h +++ b/include/linux/clocksource.h @@ -125,6 +125,10 @@ struct clocksource { struct list_head wd_list; u64 cs_last; u64 wd_last; + u64 wd_last_bogus; + int wd_bogus_shift; + unsigned long wd_bogus_count; + unsigned long wd_bogus_count_last; #endif struct module *owner; }; diff --git a/kernel/time/clocksource.c b/kernel/time/clocksource.c index 3f5317faf891f..de8047b6720f5 100644 --- a/kernel/time/clocksource.c +++ b/kernel/time/clocksource.c @@ -442,14 +442,33 @@ static void clocksource_watchdog(struct timer_list *u= nused) =20 /* Check for bogus measurements. */ wdi =3D jiffies_to_nsecs(WATCHDOG_INTERVAL); - if (wd_nsec < (wdi >> 2)) { - /* This usually indicates broken timer code or hardware. */ - pr_warn("timekeeping watchdog on CPU%d: Watchdog clocksource '%s' advan= ced only %lld ns during %d-jiffy time interval, skipping watchdog check.\n"= , smp_processor_id(), watchdog->name, wd_nsec, WATCHDOG_INTERVAL); + if (wd_nsec > (wdi << 2) || cs_nsec > (wdi << 2)) { + bool needwarn =3D false; + u64 wd_lb; + + cs->wd_bogus_count++; + if (!cs->wd_bogus_shift) { + needwarn =3D true; + } else { + delta =3D clocksource_delta(wdnow, cs->wd_last_bogus, watchdog->mask); + wd_lb =3D clocksource_cyc2ns(delta, watchdog->mult, watchdog->shift); + if ((1 << cs->wd_bogus_shift) * wdi <=3D wd_lb) + needwarn =3D true; + } + if (needwarn) { + /* This can happen on busy systems, which can delay the watchdog. */ + pr_warn("timekeeping watchdog on CPU%d: Watchdog clocksource '%s' adva= nced an excessive %lld ns during %d-jiffy time interval (%lu additional), p= robable CPU overutilization, skipping watchdog check.\n", smp_processor_id(= ), watchdog->name, wd_nsec, WATCHDOG_INTERVAL, cs->wd_bogus_count - cs->wd_= bogus_count_last); + cs->wd_last_bogus =3D wdnow; + if (cs->wd_bogus_shift < 10) + cs->wd_bogus_shift++; + cs->wd_bogus_count_last =3D cs->wd_bogus_count; + } continue; } - if (wd_nsec > (wdi << 2)) { - /* This can happen on busy systems, which can delay the watchdog. */ - pr_warn("timekeeping watchdog on CPU%d: Watchdog clocksource '%s' advan= ced an excessive %lld ns during %d-jiffy time interval, probable CPU overut= ilization, skipping watchdog check.\n", smp_processor_id(), watchdog->name,= wd_nsec, WATCHDOG_INTERVAL); + /* Check too-short measurements second to handle wrap. */ + if (wd_nsec < (wdi >> 2) || cs_nsec < (wdi >> 2)) { + /* This usually indicates broken timer code or hardware. */ + pr_warn("timekeeping watchdog on CPU%d: Watchdog clocksource '%s' advan= ced only %lld ns during %d-jiffy time interval, skipping watchdog check.\n"= , smp_processor_id(), watchdog->name, wd_nsec, WATCHDOG_INTERVAL); continue; } =20 --=20 2.31.1.189.g2e36527f23