From nobody Fri Apr 10 10:55:19 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79CC8C43217 for ; Wed, 2 Nov 2022 18:20:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231475AbiKBSUW (ORCPT ); Wed, 2 Nov 2022 14:20:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45702 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231524AbiKBSUN (ORCPT ); Wed, 2 Nov 2022 14:20:13 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 53BD42F392; Wed, 2 Nov 2022 11:20:11 -0700 (PDT) Received: from notapiano.myfiosgateway.com (unknown [IPv6:2600:4041:5b1a:cd00:524d:e95d:1a9c:492a]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by madras.collabora.co.uk (Postfix) with ESMTPSA id 3C37566028E7; Wed, 2 Nov 2022 18:20:08 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1667413209; bh=iEfgs5/IYGmZLK5vLu7xq05AP6DxnckLW0sEoea0frY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JtRxA8W7bF4/NcHMNMq2PIygyK9OwqM6gojFJZtfrdzUWgCwWIJ1+icj6wGwudqt5 PzNGvMHcirjs4x71srNeg+LokD8kJ4nvjbmjdOivqdkqInWpfUs/GM8VqsNmlOHzbp JwS/5eEcJr9cxAOuuexzZdLbtJPFJpykDI24zVXWa5xn7N+VQLCLXU8rRrtO+maI5P exexpzKigGQt9GvuLvJqvVuVpI1EnaxFRg4GxpYR3kkAgwNjaOkLR+xLywCidA0C6D jFQOHCp5jR2W32OxAgZVMbOGTKBkd+diQMDc3qGY+5yQzbIR00tXUIY8rPaJR0eJcs Vu4KhtT3aze1g== From: =?UTF-8?q?N=C3=ADcolas=20F=2E=20R=2E=20A=2E=20Prado?= To: Mark Brown , Bjorn Andersson Cc: kernel@collabora.com, AngeloGioacchino Del Regno , Chen-Yu Tsai , =?UTF-8?q?N=C3=ADcolas=20F=2E=20R=2E=20A=2E=20Prado?= , Derek Fang , Krzysztof Kozlowski , Liam Girdwood , Rob Herring , alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/8] ASoC: dt-bindings: realtek,rt5682s: Add AVDD and MICVDD supplies Date: Wed, 2 Nov 2022 14:19:55 -0400 Message-Id: <20221102182002.255282-2-nfraprado@collabora.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221102182002.255282-1-nfraprado@collabora.com> References: <20221102182002.255282-1-nfraprado@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The rt5682s codec has two supplies - AVDD and MICVDD - which are already used by sc7180-trogdor-kingoftown.dtsi. Document them in the binding. Acked-by: Krzysztof Kozlowski Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: N=C3=ADcolas F. R. A. Prado --- (no changes since v1) .../devicetree/bindings/sound/realtek,rt5682s.yaml | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml b= /Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml index 1c0b06d82369..b7338bfc0f5a 100644 --- a/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml +++ b/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml @@ -90,11 +90,20 @@ properties: "#sound-dai-cells": const: 1 =20 + AVDD-supply: + description: Regulator supplying analog power through the AVDD pin. + + MICVDD-supply: + description: Regulator supplying power for the microphone bias through= the + MICVDD pin. + additionalProperties: false =20 required: - compatible - reg + - AVDD-supply + - MICVDD-supply =20 examples: - | @@ -120,5 +129,8 @@ examples: =20 clocks =3D <&osc>; clock-names =3D "mclk"; + + AVDD-supply =3D <&avdd_reg>; + MICVDD-supply =3D <&micvdd_reg>; }; }; --=20 2.38.1 From nobody Fri Apr 10 10:55:19 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 201E2C43217 for ; Wed, 2 Nov 2022 18:20:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231552AbiKBSUb (ORCPT ); Wed, 2 Nov 2022 14:20:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45818 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231530AbiKBSUN (ORCPT ); Wed, 2 Nov 2022 14:20:13 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CF0E72F648; Wed, 2 Nov 2022 11:20:12 -0700 (PDT) Received: from notapiano.myfiosgateway.com (unknown [IPv6:2600:4041:5b1a:cd00:524d:e95d:1a9c:492a]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by madras.collabora.co.uk (Postfix) with ESMTPSA id F00BF66028C5; Wed, 2 Nov 2022 18:20:09 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1667413211; bh=XreP8pLNPdmHQfo0+zus9VHh3oAKdgBVqoqtrPoAkGE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=DzrG8eadOfxEzZBS9K6GzlezW9SFPw4pfPCJF8Og2axj/E7qE8ax0bfb/iLBTQzXm 1CtK92x5oD8NiBEyf/uzIT0fhfoAeJxS0brRuKQf7lTDXSciMlhi37GYvfXuExdvTe LFP3yaxPBLiEA6IrTYnIncu2tfW6esFBimzicYLWt//iV+Yes8+ahiPzalbteNGJWM vL/P3xTOQGQEKMSxqHV8K+iYuLYGI6GvrcBRsh8NadLFrWAY4ZXtKzY7gPHSyBTjm9 V19JXyACh5qP45pZHiUrPElIRXHjyno3qlh9MP3KdthKIQ8v9OnHwOaQ1wtshGZmTD DkEO754P4pjRA== From: =?UTF-8?q?N=C3=ADcolas=20F=2E=20R=2E=20A=2E=20Prado?= To: Mark Brown , Bjorn Andersson Cc: kernel@collabora.com, AngeloGioacchino Del Regno , Chen-Yu Tsai , =?UTF-8?q?N=C3=ADcolas=20F=2E=20R=2E=20A=2E=20Prado?= , Derek Fang , Krzysztof Kozlowski , Liam Girdwood , Rob Herring , alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 2/8] ASoC: dt-bindings: realtek,rt5682s: Add DBVDD and LDO1-IN supplies Date: Wed, 2 Nov 2022 14:19:56 -0400 Message-Id: <20221102182002.255282-3-nfraprado@collabora.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221102182002.255282-1-nfraprado@collabora.com> References: <20221102182002.255282-1-nfraprado@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The rt5682s codec has two additional power supply pins, DBVDD and LDO1_IN, that aren't currently described in the binding. Add them. Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: N=C3=ADcolas F. R. A. Prado Reviewed-by: Rob Herring --- Changes in v2: - Made names uppercase .../devicetree/bindings/sound/realtek,rt5682s.yaml | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml b= /Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml index b7338bfc0f5a..dc418652f241 100644 --- a/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml +++ b/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml @@ -97,6 +97,13 @@ properties: description: Regulator supplying power for the microphone bias through= the MICVDD pin. =20 + DBVDD-supply: + description: Regulator supplying I/O power through the DBVDD pin. + + LDO1-IN-supply: + description: Regulator supplying power to the digital core and charge = pump + through the LDO1_IN pin. + additionalProperties: false =20 required: @@ -104,6 +111,8 @@ required: - reg - AVDD-supply - MICVDD-supply + - DBVDD-supply + - LDO1-IN-supply =20 examples: - | @@ -132,5 +141,7 @@ examples: =20 AVDD-supply =3D <&avdd_reg>; MICVDD-supply =3D <&micvdd_reg>; + DBVDD-supply =3D <&dbvdd_reg>; + LDO1-IN-supply =3D <&ldo1_in_reg>; }; }; --=20 2.38.1 From nobody Fri Apr 10 10:55:19 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9415EC433FE for ; Wed, 2 Nov 2022 18:20:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231501AbiKBSU1 (ORCPT ); Wed, 2 Nov 2022 14:20:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45398 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231204AbiKBSUO (ORCPT ); Wed, 2 Nov 2022 14:20:14 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 33C0E2F02A; Wed, 2 Nov 2022 11:20:14 -0700 (PDT) Received: from notapiano.myfiosgateway.com (unknown [IPv6:2600:4041:5b1a:cd00:524d:e95d:1a9c:492a]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by madras.collabora.co.uk (Postfix) with ESMTPSA id AFC3066028E3; Wed, 2 Nov 2022 18:20:11 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1667413213; bh=aHKXHg5yRWCszz4RN5TUFELZQbFWp0LXSet1RHes8lw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LqLVraj7daBs/qNGOyMgszO7PYrOjdyFfjnFJkoiTC/1Jxm/fdHpn0MZNNjV/xUG1 b3Z+YeiUD0HOls+xF1xUB8EfRTcIy/2diBZJonReDRRWGhA0t29hD/yq0j1MYKI4b9 eu/eJZCBtewDSvaKdl0j7KdrJS72+y7SaCc1xlT2boF2tHuejdDD0xlja5TjdcC/ol 1y6pTQcLfzmyYA6AMGsydD7QgHx/yyqfVxIa9rZx24pTRUl/i1MuQ8gZh2ET6VQzFF MNb1qX2O0oXwypUhidFIpRE4syMtSyg6o0s4pUfbFJxnVhvCW0C5V1aav0HiKUUUMh iDE4Mo2/OxTPA== From: =?UTF-8?q?N=C3=ADcolas=20F=2E=20R=2E=20A=2E=20Prado?= To: Mark Brown , Bjorn Andersson Cc: kernel@collabora.com, AngeloGioacchino Del Regno , Chen-Yu Tsai , =?UTF-8?q?N=C3=ADcolas=20F=2E=20R=2E=20A=2E=20Prado?= , Krzysztof Kozlowski , Liam Girdwood , Rob Herring , alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 3/8] ASoC: dt-bindings: rt5682: Add AVDD, MICVDD and VBAT supplies Date: Wed, 2 Nov 2022 14:19:57 -0400 Message-Id: <20221102182002.255282-4-nfraprado@collabora.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221102182002.255282-1-nfraprado@collabora.com> References: <20221102182002.255282-1-nfraprado@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The rt5682 codec has three supplies - AVDD, MICVDD and VBAT - which are already used by sc7180-trogdor.dtsi. Document them in the binding. Acked-by: Krzysztof Kozlowski Signed-off-by: N=C3=ADcolas F. R. A. Prado --- (no changes since v1) Documentation/devicetree/bindings/sound/rt5682.txt | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/Documentation/devicetree/bindings/sound/rt5682.txt b/Documenta= tion/devicetree/bindings/sound/rt5682.txt index 6b87db68337c..89e6245b870e 100644 --- a/Documentation/devicetree/bindings/sound/rt5682.txt +++ b/Documentation/devicetree/bindings/sound/rt5682.txt @@ -8,6 +8,15 @@ Required properties: =20 - reg : The I2C address of the device. =20 +- AVDD-supply: phandle to the regulator supplying analog power through the + AVDD pin + +- MICVDD-supply: phandle to the regulator supplying power for the micropho= ne + bias through the MICVDD pin. Either MICVDD or VBAT should be present. + +- VBAT-supply: phandle to the regulator supplying battery power through the + VBAT pin. Either MICVDD or VBAT should be present. + Optional properties: =20 - interrupts : The CODEC's interrupt output. @@ -75,4 +84,7 @@ rt5682 { =20 clocks =3D <&osc>; clock-names =3D "mclk"; + + AVDD-supply =3D <&avdd_reg>; + MICVDD-supply =3D <&micvdd_reg>; }; --=20 2.38.1 From nobody Fri Apr 10 10:55:19 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 461BCC433FE for ; Wed, 2 Nov 2022 18:20:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231431AbiKBSUh (ORCPT ); Wed, 2 Nov 2022 14:20:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45746 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231378AbiKBSUQ (ORCPT ); Wed, 2 Nov 2022 14:20:16 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C7BBC2F3A4; Wed, 2 Nov 2022 11:20:15 -0700 (PDT) Received: from notapiano.myfiosgateway.com (unknown [IPv6:2600:4041:5b1a:cd00:524d:e95d:1a9c:492a]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by madras.collabora.co.uk (Postfix) with ESMTPSA id 4DB7C6602946; Wed, 2 Nov 2022 18:20:13 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1667413214; bh=nT5ZYip6ykx0KuIPyyYFqsRIdtNMhO9TwzCn0g2rnOA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=U6T/zZ1oQgFPo591b9rXyFM7G48u1J0BMKzZX6A9EFo+URmWGIwR2nTi8wsKoK5/P MrcxZzjRmBjDyj7NkA4ZR28MVBcMeibpOQj8qwzIeDa3o4ETcBOoWjCw5xMJjjoJdR 5ULSNgo0+OulqriO4/fo91kCBOXktrAwxJ6b1y7ua9HbDHNNJ7U8gbzd+QrWLw7yJb YxJx1CI3Lqz6s01sdYBAQMptNzMbGhqDGsQrS2YYfqwc+s0lgOUArJw/Qgpl/MP+QJ GHWCJbnJGStTBzsU4zvHjzZ6LHwmBnms42KdhIg0SIOxR36R8TS/H9qVRKMpvnhsJn tZnQoq5zmvaZg== From: =?UTF-8?q?N=C3=ADcolas=20F=2E=20R=2E=20A=2E=20Prado?= To: Mark Brown , Bjorn Andersson Cc: kernel@collabora.com, AngeloGioacchino Del Regno , Chen-Yu Tsai , =?UTF-8?q?N=C3=ADcolas=20F=2E=20R=2E=20A=2E=20Prado?= , Krzysztof Kozlowski , Liam Girdwood , Rob Herring , alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 4/8] ASoC: dt-bindings: rt5682: Add DBVDD and LDO1-IN supplies Date: Wed, 2 Nov 2022 14:19:58 -0400 Message-Id: <20221102182002.255282-5-nfraprado@collabora.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221102182002.255282-1-nfraprado@collabora.com> References: <20221102182002.255282-1-nfraprado@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The rt5682 codec has two additional power supply pins, DBVDD and LDO1_IN, that aren't currently described in the binding. Add them. Signed-off-by: N=C3=ADcolas F. R. A. Prado Reviewed-by: Rob Herring --- Changes in v2: - Made names uppercase Documentation/devicetree/bindings/sound/rt5682.txt | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/Documentation/devicetree/bindings/sound/rt5682.txt b/Documenta= tion/devicetree/bindings/sound/rt5682.txt index 89e6245b870e..5e1d08de18a5 100644 --- a/Documentation/devicetree/bindings/sound/rt5682.txt +++ b/Documentation/devicetree/bindings/sound/rt5682.txt @@ -17,6 +17,12 @@ Required properties: - VBAT-supply: phandle to the regulator supplying battery power through the VBAT pin. Either MICVDD or VBAT should be present. =20 +- DBVDD-supply: phandle to the regulator supplying I/O power through the D= BVDD + pin. + +- LDO1-IN-supply: phandle to the regulator supplying power to the digital = core + and charge pump through the LDO1_IN pin. + Optional properties: =20 - interrupts : The CODEC's interrupt output. @@ -87,4 +93,6 @@ rt5682 { =20 AVDD-supply =3D <&avdd_reg>; MICVDD-supply =3D <&micvdd_reg>; + DBVDD-supply =3D <&dbvdd_reg>; + LDO1-IN-supply =3D <&ldo1_in_reg>; }; --=20 2.38.1 From nobody Fri Apr 10 10:55:19 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40F6EC433FE for ; Wed, 2 Nov 2022 18:20:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231630AbiKBSUm (ORCPT ); Wed, 2 Nov 2022 14:20:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45706 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231408AbiKBSUS (ORCPT ); Wed, 2 Nov 2022 14:20:18 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 734772F03B for ; Wed, 2 Nov 2022 11:20:17 -0700 (PDT) Received: from notapiano.myfiosgateway.com (unknown [IPv6:2600:4041:5b1a:cd00:524d:e95d:1a9c:492a]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by madras.collabora.co.uk (Postfix) with ESMTPSA id E344E6602948; Wed, 2 Nov 2022 18:20:14 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1667413216; bh=OfMwEPRyzP69cf0RbqYMeq7wYptVsG5Ag1i1BjFEAS4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=T8GiEKHc8UtFOYUTrPUOVTnAL1fBOP0leZVHpAvJGznyzxuomjwzC3xFcrlqgcaZc NH9gSfQTB9k1f8OysAGYkJ1DakMgh5w2EA9ZxzAx/3ryKYPQB7RBMefBi6dvDuHkLY H919o8MLhJMWZcghrXV0ISVX8ePMgHnBUbjBXSpl8GWUdvqbYuT8ZQAn7TpMMaJGLH 5IoTZBAQm/H5616oyeO4wl9DmQCCQrT/CVSXHFmquP5cc/KCe4Ai1OeGrQYhcs0Xqy X3VHib7o3BtzrR0Fup7JIMtXosIlpWL+RsME7YyYkpXgRJKOWs3LFVNrhxREIdRDW7 pZ16b9a1UcSfw== From: =?UTF-8?q?N=C3=ADcolas=20F=2E=20R=2E=20A=2E=20Prado?= To: Mark Brown , Bjorn Andersson Cc: kernel@collabora.com, AngeloGioacchino Del Regno , Chen-Yu Tsai , =?UTF-8?q?N=C3=ADcolas=20F=2E=20R=2E=20A=2E=20Prado?= , Jaroslav Kysela , Liam Girdwood , Oder Chiou , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 5/8] ASoC: rt5682s: Support DBVDD and LDO1-IN supplies Date: Wed, 2 Nov 2022 14:19:59 -0400 Message-Id: <20221102182002.255282-6-nfraprado@collabora.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221102182002.255282-1-nfraprado@collabora.com> References: <20221102182002.255282-1-nfraprado@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add support for the DBVDD and LDO1-IN supplies. Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: N=C3=ADcolas F. R. A. Prado --- Changes in v2: - Made names uppercase sound/soc/codecs/rt5682s.c | 22 ++++++++++++++++++++++ sound/soc/codecs/rt5682s.h | 2 ++ 2 files changed, 24 insertions(+) diff --git a/sound/soc/codecs/rt5682s.c b/sound/soc/codecs/rt5682s.c index 80c673aa14db..f5e5dbc3b0f0 100644 --- a/sound/soc/codecs/rt5682s.c +++ b/sound/soc/codecs/rt5682s.c @@ -44,6 +44,8 @@ static const struct rt5682s_platform_data i2s_default_pla= tform_data =3D { static const char *rt5682s_supply_names[RT5682S_NUM_SUPPLIES] =3D { [RT5682S_SUPPLY_AVDD] =3D "AVDD", [RT5682S_SUPPLY_MICVDD] =3D "MICVDD", + [RT5682S_SUPPLY_DBVDD] =3D "DBVDD", + [RT5682S_SUPPLY_LDO1_IN] =3D "LDO1-IN", }; =20 static const struct reg_sequence patch_list[] =3D { @@ -3089,6 +3091,14 @@ static void rt5682s_i2c_disable_regulators(void *dat= a) if (ret) dev_err(dev, "Failed to disable supply AVDD: %d\n", ret); =20 + ret =3D regulator_disable(rt5682s->supplies[RT5682S_SUPPLY_DBVDD].consume= r); + if (ret) + dev_err(dev, "Failed to disable supply DBVDD: %d\n", ret); + + ret =3D regulator_disable(rt5682s->supplies[RT5682S_SUPPLY_LDO1_IN].consu= mer); + if (ret) + dev_err(dev, "Failed to disable supply LDO1-IN: %d\n", ret); + usleep_range(1000, 1500); =20 ret =3D regulator_disable(rt5682s->supplies[RT5682S_SUPPLY_MICVDD].consum= er); @@ -3150,6 +3160,18 @@ static int rt5682s_i2c_probe(struct i2c_client *i2c) return ret; } =20 + ret =3D regulator_enable(rt5682s->supplies[RT5682S_SUPPLY_DBVDD].consumer= ); + if (ret) { + dev_err(&i2c->dev, "Failed to enable supply DBVDD: %d\n", ret); + return ret; + } + + ret =3D regulator_enable(rt5682s->supplies[RT5682S_SUPPLY_LDO1_IN].consum= er); + if (ret) { + dev_err(&i2c->dev, "Failed to enable supply LDO1-IN: %d\n", ret); + return ret; + } + if (gpio_is_valid(rt5682s->pdata.ldo1_en)) { if (devm_gpio_request_one(&i2c->dev, rt5682s->pdata.ldo1_en, GPIOF_OUT_INIT_HIGH, "rt5682s")) diff --git a/sound/soc/codecs/rt5682s.h b/sound/soc/codecs/rt5682s.h index 45464a041765..67f86a38a1cc 100644 --- a/sound/soc/codecs/rt5682s.h +++ b/sound/soc/codecs/rt5682s.h @@ -1438,6 +1438,8 @@ struct pll_calc_map { enum { RT5682S_SUPPLY_AVDD, RT5682S_SUPPLY_MICVDD, + RT5682S_SUPPLY_DBVDD, + RT5682S_SUPPLY_LDO1_IN, RT5682S_NUM_SUPPLIES, }; =20 --=20 2.38.1 From nobody Fri Apr 10 10:55:19 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 817BAC43217 for ; Wed, 2 Nov 2022 18:20:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231652AbiKBSUt (ORCPT ); Wed, 2 Nov 2022 14:20:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45818 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229954AbiKBSUU (ORCPT ); Wed, 2 Nov 2022 14:20:20 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0EB9E2F395 for ; Wed, 2 Nov 2022 11:20:19 -0700 (PDT) Received: from notapiano.myfiosgateway.com (unknown [IPv6:2600:4041:5b1a:cd00:524d:e95d:1a9c:492a]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by madras.collabora.co.uk (Postfix) with ESMTPSA id 8E717660294A; Wed, 2 Nov 2022 18:20:16 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1667413217; bh=XepAn8pB00cuXojd4bCKRy311k713d3dutRJPgty0oM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FXJbnowpj5fivK9/7RYMlEUHYX3i70/CGppSC/K753X5zCcVnZIVSNe5eQzrbpUGK o6MQKi59CXaw7joeYP7u9foYRYffcqjpO076/MIWUY3U3TLJDxB4knOsD2/WnjUqLn 703LFdCLHYCGp+Lg4yfaFjoKytN3Lk4kYeAqgpvcD9AxjviRW68Q3mn324xqCmX2vS nObwWqX4yLwAQtlcgK0GJ5UFUgjVDQ6V8cOz0Bz9AaGR0Jx5VpN74vO70aZUgfyLV4 tXqyONUQ66Po4vvYuVZFWZZVcKmBOc1R3eEA+MVAwGDHsDdLxaFDKFNUw2tYCG4PYB zg9xSGElm4ILg== From: =?UTF-8?q?N=C3=ADcolas=20F=2E=20R=2E=20A=2E=20Prado?= To: Mark Brown , Bjorn Andersson Cc: kernel@collabora.com, AngeloGioacchino Del Regno , Chen-Yu Tsai , =?UTF-8?q?N=C3=ADcolas=20F=2E=20R=2E=20A=2E=20Prado?= , Jaroslav Kysela , Liam Girdwood , Oder Chiou , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 6/8] ASoC: rt5682: Support DBVDD and LDO1-IN supplies Date: Wed, 2 Nov 2022 14:20:00 -0400 Message-Id: <20221102182002.255282-7-nfraprado@collabora.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221102182002.255282-1-nfraprado@collabora.com> References: <20221102182002.255282-1-nfraprado@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add support for the DBVDD and LDO1-IN supplies. Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: N=C3=ADcolas F. R. A. Prado --- Changes in v2: - Made names uppercase sound/soc/codecs/rt5682.c | 2 ++ sound/soc/codecs/rt5682.h | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/sound/soc/codecs/rt5682.c b/sound/soc/codecs/rt5682.c index 2df95e792900..7e3eb65afe16 100644 --- a/sound/soc/codecs/rt5682.c +++ b/sound/soc/codecs/rt5682.c @@ -35,6 +35,8 @@ const char *rt5682_supply_names[RT5682_NUM_SUPPLIES] =3D { "AVDD", "MICVDD", "VBAT", + "DBVDD", + "LDO1-IN", }; EXPORT_SYMBOL_GPL(rt5682_supply_names); =20 diff --git a/sound/soc/codecs/rt5682.h b/sound/soc/codecs/rt5682.h index 52ff0d9c36c5..d568c6993c33 100644 --- a/sound/soc/codecs/rt5682.h +++ b/sound/soc/codecs/rt5682.h @@ -1424,7 +1424,7 @@ enum { RT5682_CLK_SEL_I2S2_ASRC, }; =20 -#define RT5682_NUM_SUPPLIES 3 +#define RT5682_NUM_SUPPLIES 5 =20 struct rt5682_priv { struct snd_soc_component *component; --=20 2.38.1 From nobody Fri Apr 10 10:55:19 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BAA51C433FE for ; Wed, 2 Nov 2022 18:20:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231246AbiKBSUv (ORCPT ); Wed, 2 Nov 2022 14:20:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45270 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231362AbiKBSUW (ORCPT ); Wed, 2 Nov 2022 14:20:22 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C801B2F39D; Wed, 2 Nov 2022 11:20:20 -0700 (PDT) Received: from notapiano.myfiosgateway.com (unknown [IPv6:2600:4041:5b1a:cd00:524d:e95d:1a9c:492a]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by madras.collabora.co.uk (Postfix) with ESMTPSA id 4A87C66028C5; Wed, 2 Nov 2022 18:20:18 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1667413219; bh=Y/oGfF2ZKbAfSuy9UNRSZc4k47fY8VQOpolmGqIEoTI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ataL7fEpHIx9UT+p1PoG0b8SvfuivGEoZFd9lfIONLl+K7lT0D5NlMPzrmJfneVnj qt3AGL2wbHVYDvZUoEF691Cue4hiO8rvqxAauJu/vYrdimN8i4uF22fvW4NrBoi8tS 0pYRq/fk1iEMqPbqORY+6GddiE6gqarBd2QFzDTfOepbbfB0EedeBt6sCiawM/hfEW cfwy9FZym/2BdlL2nxxuCnFqMVEWl4I6B4eXCClbkjzc+DDxB2Dab7rM2bZ+OZufpp 1wJfvYc/oT46wZ9SnfR9YWcFfsD8aa3Pvad7DrgO4MWH43LYO5BEpqCEUH5QTl1+CY GAgEppe5uNfew== From: =?UTF-8?q?N=C3=ADcolas=20F=2E=20R=2E=20A=2E=20Prado?= To: Mark Brown , Bjorn Andersson Cc: kernel@collabora.com, AngeloGioacchino Del Regno , Chen-Yu Tsai , =?UTF-8?q?N=C3=ADcolas=20F=2E=20R=2E=20A=2E=20Prado?= , Andy Gross , Konrad Dybcio , Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 7/8] arm64: dts: qcom: sc7180-trogdor: Add missing supplies for rt5682 Date: Wed, 2 Nov 2022 14:20:01 -0400 Message-Id: <20221102182002.255282-8-nfraprado@collabora.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221102182002.255282-1-nfraprado@collabora.com> References: <20221102182002.255282-1-nfraprado@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The DBVDD and LDO1-IN supplies for rt5682 are required but are missing. They are supplied by the same power rail as AVDD. Add them. Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: N=C3=ADcolas F. R. A. Prado --- Changes in v2: - Made names uppercase arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot= /dts/qcom/sc7180-trogdor.dtsi index 1a1c346d619c..2adb2fbfebae 100644 --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi @@ -768,6 +768,8 @@ alc5682: codec@1a { interrupts =3D <28 IRQ_TYPE_EDGE_BOTH>; =20 AVDD-supply =3D <&pp1800_alc5682>; + DBVDD-supply =3D <&pp1800_alc5682>; + LDO1-IN-supply =3D <&pp1800_alc5682>; MICVDD-supply =3D <&pp3300_codec>; VBAT-supply =3D <&pp3300_audio>; =20 --=20 2.38.1 From nobody Fri Apr 10 10:55:19 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 304BDC433FE for ; Wed, 2 Nov 2022 18:21:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231362AbiKBSUy (ORCPT ); Wed, 2 Nov 2022 14:20:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45960 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231484AbiKBSUX (ORCPT ); Wed, 2 Nov 2022 14:20:23 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 13A412F39C; Wed, 2 Nov 2022 11:20:22 -0700 (PDT) Received: from notapiano.myfiosgateway.com (unknown [IPv6:2600:4041:5b1a:cd00:524d:e95d:1a9c:492a]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by madras.collabora.co.uk (Postfix) with ESMTPSA id 06A4166028F8; Wed, 2 Nov 2022 18:20:19 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1667413221; bh=/QzOMlinMw2KNMfW0WPe42TTNOsZDuKQIwgbcG/lv+I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CxOSZ5wZ5gas/AvmGFbr29AnR2CBbW8oShzREFwqzRR5fWmklTj5KVLayT1xwVnfP ef6J4cFRQbZcV/SMwM6MSstFV0hZpdJGgAKb+NdbcF9+cStkD5kWiUSJ81Bp/8XJVh EiTyrXyURJGVXF7cQ2mvhgWOkl0XfcIJL7xWbP+k6ZnGI6ps0lyWDADXjZrmJ9qpIf DJJgg5Wy1pOqcVxY8tst05lrB2mZ3PgZv78b7oL4Irj2u+dAWBNhpsaVEBTPg0Pjy9 YLUy3HJ8fDHs7KiVM9kLLtFLrA4h5RzIe0vpzbgfVq6DTpSntXeaajTwX4lVXxOx0u 1OHIkDELuYQlQ== From: =?UTF-8?q?N=C3=ADcolas=20F=2E=20R=2E=20A=2E=20Prado?= To: Mark Brown , Bjorn Andersson Cc: kernel@collabora.com, AngeloGioacchino Del Regno , Chen-Yu Tsai , =?UTF-8?q?N=C3=ADcolas=20F=2E=20R=2E=20A=2E=20Prado?= , Andy Gross , Konrad Dybcio , Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 8/8] arm64: dts: qcom: sc7180-trogdor: Remove VBAT supply from rt5682s Date: Wed, 2 Nov 2022 14:20:02 -0400 Message-Id: <20221102182002.255282-9-nfraprado@collabora.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221102182002.255282-1-nfraprado@collabora.com> References: <20221102182002.255282-1-nfraprado@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org These devicetrees override a rt5682 node to use the rt5682s compatible, however, unlike rt5682, rt5682s doesn't have a VBAT supply. Remove the inexistent supply in the rt5682s nodes. Signed-off-by: N=C3=ADcolas F. R. A. Prado --- (no changes since v1) arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown.dtsi | 1 + .../dts/qcom/sc7180-trogdor-wormdingler-rev1-boe-rt5682s.dts | 1 + .../dts/qcom/sc7180-trogdor-wormdingler-rev1-inx-rt5682s.dts | 1 + 3 files changed, 3 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown.dtsi b/arch= /arm64/boot/dts/qcom/sc7180-trogdor-kingoftown.dtsi index 74f0e07ea5cf..e0fb83a9a0b1 100644 --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown.dtsi @@ -11,6 +11,7 @@ =20 &alc5682 { compatible =3D "realtek,rt5682s"; + /delete-property/ VBAT-supply; realtek,dmic1-clk-pin =3D <2>; realtek,dmic-clk-rate-hz =3D <2048000>; }; diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev1-boe-r= t5682s.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev1-boe-r= t5682s.dts index aa605885c371..6225ab8329c3 100644 --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev1-boe-rt5682s.= dts +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev1-boe-rt5682s.= dts @@ -19,6 +19,7 @@ / { =20 &alc5682 { compatible =3D "realtek,rt5682s"; + /delete-property/ VBAT-supply; realtek,dmic1-clk-pin =3D <2>; realtek,dmic-clk-rate-hz =3D <2048000>; }; diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev1-inx-r= t5682s.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev1-inx-r= t5682s.dts index 7116c44c8d85..b40b068dad6a 100644 --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev1-inx-rt5682s.= dts +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev1-inx-rt5682s.= dts @@ -19,6 +19,7 @@ / { =20 &alc5682 { compatible =3D "realtek,rt5682s"; + /delete-property/ VBAT-supply; realtek,dmic1-clk-pin =3D <2>; realtek,dmic-clk-rate-hz =3D <2048000>; }; --=20 2.38.1