From nobody Thu Apr 9 01:41:12 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED24BC4332F for ; Tue, 1 Nov 2022 19:15:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230298AbiKATPK (ORCPT ); Tue, 1 Nov 2022 15:15:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43504 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229534AbiKATPG (ORCPT ); Tue, 1 Nov 2022 15:15:06 -0400 Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [IPv6:2a00:1450:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7AE90167F6 for ; Tue, 1 Nov 2022 12:15:05 -0700 (PDT) Received: by mail-ej1-x634.google.com with SMTP id f27so39543477eje.1 for ; Tue, 01 Nov 2022 12:15:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=D/oBXqxDLFWq3xQv029eFhBNmCMw5i5DAryxQ4apvwg=; b=OZv+ITK/ZUL27cndkP0A26xz4Q7jyC4NJwrQeMhoFL3e9xZ5ctFxL520vVXl2y+hS3 jSQ6By4kG2U7FjQczlJmpsLLv7CsHs3bbqiJfmBQ4PCY7VLDCEMx7FFFm43UVGpG/49W 3WMd48nfmsSB09LTfSabYekkuyr3LwVlyn5Z7Qqzest2+o0T4pzXeyVs5YacocWckmT3 p/NYCy1ZhxAggbwp/qHj+ZK/97YXkBpp6gHU3gpeApNmor6B6/kaHJUtyueOUvYM4lQ2 TwqrTo8zrMz289HvYWmaC65eI6fauNUSJcsb7cTykQVz6lFeCfsTuDx41lfyVqezPbj0 s+xA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=D/oBXqxDLFWq3xQv029eFhBNmCMw5i5DAryxQ4apvwg=; b=hF+HRasF+hC/h7OCskmb1RP6E+ZXoGoCoc15WwAARKM4lNepxrGOU4sfFcROIBNRNu fiwmC2qDTIF6kUkK50cPBmzUj6gOUYsxwcGIcJFHRCq1pwNOFZcSawf9Fp0rzkuljbXx M6CCUepxnYEurGuf0WtNCoAbTR48+Zdn1UYrtyu+lUJw6/8V86UIiB/ZAMwbyF7FUfNK gXqJYwuA6tEg878DBpWZFFbaYk6Qy84tv1ArE9Hesqu6qp3eEFaD4/Ebma/6xrTBiPTU Yd+v8WO0ifD5kIFkKXXYaTu7PFVIce1FmT7CwpYLPISTZZzyqJTgE0MeC5EN7NXzYIsf 6LnA== X-Gm-Message-State: ACrzQf27f86/RYP6FXa2/4BMwlcS+Z9MJr46AqbAETdsJj6jXZKx1Rt3 4EiGLP56SDYsVQNzs9XwoZU= X-Google-Smtp-Source: AMsMyM4GO/oQ6X+UJVquAq+E2CgDpiAEIZAGsQH3VAdG+7fTqvJq9zzGBB7QDRashLoOud2lpcqHYg== X-Received: by 2002:a17:906:5dda:b0:78d:ed96:2127 with SMTP id p26-20020a1709065dda00b0078ded962127mr19010501ejv.373.1667330104094; Tue, 01 Nov 2022 12:15:04 -0700 (PDT) Received: from localhost.localdomain (ip5f5abb7a.dynamic.kabel-deutschland.de. [95.90.187.122]) by smtp.gmail.com with ESMTPSA id hw20-20020a170907a0d400b007ade5cc6e7asm1643853ejc.39.2022.11.01.12.15.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Nov 2022 12:15:03 -0700 (PDT) From: Michael Straube To: gregkh@linuxfoundation.org Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH 1/2] staging: r8188eu: remove extern from function prototypes Date: Tue, 1 Nov 2022 20:14:57 +0100 Message-Id: <20221101191458.8619-2-straube.linux@gmail.com> X-Mailer: git-send-email 2.38.0 In-Reply-To: <20221101191458.8619-1-straube.linux@gmail.com> References: <20221101191458.8619-1-straube.linux@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Declaring function prototypes extern is redundant and triggers checkpatch warnings. Remove all extern from function prototypes. Signed-off-by: Michael Straube Tested-by: Philipp Hortmann # Edimax N150 --- .../staging/r8188eu/include/osdep_service.h | 2 +- drivers/staging/r8188eu/include/rtw_mlme_ext.h | 4 ++-- drivers/staging/r8188eu/include/sta_info.h | 18 +++++++++--------- 3 files changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/staging/r8188eu/include/osdep_service.h b/drivers/stag= ing/r8188eu/include/osdep_service.h index ec2631455f08..f8ed04f32cae 100644 --- a/drivers/staging/r8188eu/include/osdep_service.h +++ b/drivers/staging/r8188eu/include/osdep_service.h @@ -66,7 +66,7 @@ static inline int rtw_netif_queue_stopped(struct net_devi= ce *pnetdev) netif_tx_queue_stopped(netdev_get_tx_queue(pnetdev, 3)); } =20 -extern int RTW_STATUS_CODE(int error_code); +int RTW_STATUS_CODE(int error_code); =20 void *rtw_malloc2d(int h, int w, int size); =20 diff --git a/drivers/staging/r8188eu/include/rtw_mlme_ext.h b/drivers/stagi= ng/r8188eu/include/rtw_mlme_ext.h index ce5b57e23e53..e234a3b9af6f 100644 --- a/drivers/staging/r8188eu/include/rtw_mlme_ext.h +++ b/drivers/staging/r8188eu/include/rtw_mlme_ext.h @@ -388,7 +388,7 @@ struct mlme_ext_priv { void init_mlme_ext_priv(struct adapter *adapter); int init_hw_mlme_ext(struct adapter *padapter); void free_mlme_ext_priv (struct mlme_ext_priv *pmlmeext); -extern struct xmit_frame *alloc_mgtxmitframe(struct xmit_priv *pxmitpriv); +struct xmit_frame *alloc_mgtxmitframe(struct xmit_priv *pxmitpriv); =20 unsigned char networktype_to_raid(unsigned char network_type); u8 judge_network_type(struct adapter *padapter, unsigned char *rate, int l= en); @@ -483,7 +483,7 @@ void report_add_sta_event(struct adapter *padapter, uns= igned char *addr, int cam_idx); =20 void beacon_timing_control(struct adapter *padapter); -extern u8 set_tx_beacon_cmd(struct adapter *padapter); +u8 set_tx_beacon_cmd(struct adapter *padapter); unsigned int setup_beacon_frame(struct adapter *padapter, unsigned char *beacon_frame); void update_mgnt_tx_rate(struct adapter *padapter, u8 rate); diff --git a/drivers/staging/r8188eu/include/sta_info.h b/drivers/staging/r= 8188eu/include/sta_info.h index f76e086b5701..55ea5edc2914 100644 --- a/drivers/staging/r8188eu/include/sta_info.h +++ b/drivers/staging/r8188eu/include/sta_info.h @@ -295,19 +295,19 @@ static inline u32 wifi_mac_hash(u8 *mac) return x; } =20 -extern int _rtw_init_sta_priv(struct sta_priv *pstapriv); -extern void _rtw_free_sta_priv(struct sta_priv *pstapriv); +int _rtw_init_sta_priv(struct sta_priv *pstapriv); +void _rtw_free_sta_priv(struct sta_priv *pstapriv); =20 #define stainfo_offset_valid(offset) (offset < NUM_STA && offset >=3D 0) int rtw_stainfo_offset(struct sta_priv *stapriv, struct sta_info *sta); struct sta_info *rtw_get_stainfo_by_offset(struct sta_priv *stapriv, int o= ff); =20 -extern struct sta_info *rtw_alloc_stainfo(struct sta_priv *stapriv, u8 *hw= addr); -extern u32 rtw_free_stainfo(struct adapter *adapt, struct sta_info *psta); -extern void rtw_free_all_stainfo(struct adapter *adapt); -extern struct sta_info *rtw_get_stainfo(struct sta_priv *stapriv, u8 *hwad= dr); -extern u32 rtw_init_bcmc_stainfo(struct adapter *adapt); -extern struct sta_info *rtw_get_bcmc_stainfo(struct adapter *padapter); -extern u8 rtw_access_ctrl(struct adapter *padapter, u8 *mac_addr); +struct sta_info *rtw_alloc_stainfo(struct sta_priv *stapriv, u8 *hwaddr); +u32 rtw_free_stainfo(struct adapter *adapt, struct sta_info *psta); +void rtw_free_all_stainfo(struct adapter *adapt); +struct sta_info *rtw_get_stainfo(struct sta_priv *stapriv, u8 *hwaddr); +u32 rtw_init_bcmc_stainfo(struct adapter *adapt); +struct sta_info *rtw_get_bcmc_stainfo(struct adapter *padapter); +u8 rtw_access_ctrl(struct adapter *padapter, u8 *mac_addr); =20 #endif /* _STA_INFO_H_ */ --=20 2.38.0 From nobody Thu Apr 9 01:41:12 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06C04C43217 for ; Tue, 1 Nov 2022 19:15:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230391AbiKATPO (ORCPT ); Tue, 1 Nov 2022 15:15:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43536 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230262AbiKATPI (ORCPT ); Tue, 1 Nov 2022 15:15:08 -0400 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C11F31D0D5 for ; Tue, 1 Nov 2022 12:15:06 -0700 (PDT) Received: by mail-ej1-x631.google.com with SMTP id t25so39554736ejb.8 for ; Tue, 01 Nov 2022 12:15:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=URSBztTq5HXujid4PUnbsPAmYdL6Ka0hNq1mm6n6cno=; b=fqX5yYexYI0j5kK909nrQwP2vwkyAGRQl0POVblf3X8XEadNzCO8lJzlbIQ3rqONRl KEpwUe1BPjJETcDhiB0DF+sECLDvw43PywmMPEyv21fxleB6TXKwUFW/A+0wSWaACvwU frmADMZngwXzQQhG8jArGThluWuUIcuTGNazV6cOW87OK5P5ORYmRo5q2AA+GuJ0OqSI gYepMIRrCxZ+nRDm1zDqyQC/g+mQPVcw7We4M2HoIfEsIFXcgPn7/FMmERxUjeOY9cgr l5oSEkrQGpjkhDAevijaOEjkYbvLvbDmwiyt0U0G9Lnz2v6Me+1zTR15rOA8nybhvFwI bv4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=URSBztTq5HXujid4PUnbsPAmYdL6Ka0hNq1mm6n6cno=; b=3wXf+iKbmuigcpq3LjU8zfDC/OSL+bBTKSTHviPWNNdiHY8JYe1FGUDa1y8CSrqPYK epotC1seX7LXEuf9f7OZG826MY9bRPO8zhKrDX6rFwf59NQprmgDJN/QwGJAIAKCRulT Wq6SdmLuqKXclFHOsNuOgXkww8SlnX+g8JiU4j7OiV5ffImZ13waErAXG8CgZ5rMtooQ sH3dlWZ1OMPP5aBxCC/hXdR+ZHi/o9Em5b/WNb/q5YvjIRdgcsaXXBlh1MUlous8OK+5 9x2oHLidUmswatyaYrwYudbOyXwcRtIUrcQlt0LD1yPRZ5bTWjJWN+hWwDMM6tPwNTH9 LSnw== X-Gm-Message-State: ACrzQf0IYa6MXrE/YYPJieTIWfITkK/X3i3uuqi18HWqwQ2QBeTA54OU a8K9wlpCGtN4KuvGfU9KIoQ= X-Google-Smtp-Source: AMsMyM5CXH16D7IbYQTiafXplecV8l3pNJWjj7aQ8TMiJc9+p785pNwbUydD/vDmaOjJy7oyr4/a5A== X-Received: by 2002:a17:906:974f:b0:7aa:f705:e580 with SMTP id o15-20020a170906974f00b007aaf705e580mr18916152ejy.530.1667330105418; Tue, 01 Nov 2022 12:15:05 -0700 (PDT) Received: from localhost.localdomain (ip5f5abb7a.dynamic.kabel-deutschland.de. [95.90.187.122]) by smtp.gmail.com with ESMTPSA id hw20-20020a170907a0d400b007ade5cc6e7asm1643853ejc.39.2022.11.01.12.15.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Nov 2022 12:15:05 -0700 (PDT) From: Michael Straube To: gregkh@linuxfoundation.org Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH 2/2] staging: r8188eu: convert rtw_free_stainfo() to void Date: Tue, 1 Nov 2022 20:14:58 +0100 Message-Id: <20221101191458.8619-3-straube.linux@gmail.com> X-Mailer: git-send-email 2.38.0 In-Reply-To: <20221101191458.8619-1-straube.linux@gmail.com> References: <20221101191458.8619-1-straube.linux@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The function rtw_free_stainfo() returns always _SUCCESS and none of its callers uses the return value. We can safely make the function void. Yet another tiny step towards getting rid of _FAIL / _SUCCESS. Signed-off-by: Michael Straube Tested-by: Philipp Hortmann # Edimax N150 --- drivers/staging/r8188eu/core/rtw_sta_mgt.c | 8 ++------ drivers/staging/r8188eu/include/sta_info.h | 2 +- 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/staging/r8188eu/core/rtw_sta_mgt.c b/drivers/staging/r= 8188eu/core/rtw_sta_mgt.c index 51324e708697..b4aee8623099 100644 --- a/drivers/staging/r8188eu/core/rtw_sta_mgt.c +++ b/drivers/staging/r8188eu/core/rtw_sta_mgt.c @@ -242,7 +242,7 @@ struct sta_info *rtw_alloc_stainfo(struct sta_priv *pst= apriv, u8 *hwaddr) } =20 /* using pstapriv->sta_hash_lock to protect */ -u32 rtw_free_stainfo(struct adapter *padapter, struct sta_info *psta) +void rtw_free_stainfo(struct adapter *padapter, struct sta_info *psta) { int i; struct __queue *pfree_sta_queue; @@ -252,7 +252,7 @@ u32 rtw_free_stainfo(struct adapter *padapter, struct s= ta_info *psta) struct sta_priv *pstapriv =3D &padapter->stapriv; =20 if (!psta) - goto exit; + return; =20 pfree_sta_queue =3D &pstapriv->free_sta_queue; =20 @@ -356,10 +356,6 @@ u32 rtw_free_stainfo(struct adapter *padapter, struct = sta_info *psta) spin_lock_bh(&pfree_sta_queue->lock); list_add_tail(&psta->list, get_list_head(pfree_sta_queue)); spin_unlock_bh(&pfree_sta_queue->lock); - -exit: - - return _SUCCESS; } =20 /* free all stainfo which in sta_hash[all] */ diff --git a/drivers/staging/r8188eu/include/sta_info.h b/drivers/staging/r= 8188eu/include/sta_info.h index 55ea5edc2914..e42f4b4c6e24 100644 --- a/drivers/staging/r8188eu/include/sta_info.h +++ b/drivers/staging/r8188eu/include/sta_info.h @@ -303,7 +303,7 @@ int rtw_stainfo_offset(struct sta_priv *stapriv, struct= sta_info *sta); struct sta_info *rtw_get_stainfo_by_offset(struct sta_priv *stapriv, int o= ff); =20 struct sta_info *rtw_alloc_stainfo(struct sta_priv *stapriv, u8 *hwaddr); -u32 rtw_free_stainfo(struct adapter *adapt, struct sta_info *psta); +void rtw_free_stainfo(struct adapter *adapt, struct sta_info *psta); void rtw_free_all_stainfo(struct adapter *adapt); struct sta_info *rtw_get_stainfo(struct sta_priv *stapriv, u8 *hwaddr); u32 rtw_init_bcmc_stainfo(struct adapter *adapt); --=20 2.38.0