From nobody Wed Apr 8 22:49:42 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7167AECAAA1 for ; Sun, 30 Oct 2022 17:34:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229905AbiJ3ReW (ORCPT ); Sun, 30 Oct 2022 13:34:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37826 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229763AbiJ3Rdx (ORCPT ); Sun, 30 Oct 2022 13:33:53 -0400 Received: from viti.kaiser.cx (viti.kaiser.cx [IPv6:2a01:238:43fe:e600:cd0c:bd4a:7a3:8e9f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1F7BAA44F for ; Sun, 30 Oct 2022 10:33:52 -0700 (PDT) Received: from ipservice-092-217-067-184.092.217.pools.vodafone-ip.de ([92.217.67.184] helo=martin-debian-2.paytec.ch) by viti.kaiser.cx with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1opCBx-000469-Ey; Sun, 30 Oct 2022 18:33:49 +0100 From: Martin Kaiser To: Greg Kroah-Hartman Cc: Larry Finger , Phillip Potter , Michael Straube , Pavel Skripkin , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Martin Kaiser Subject: [PATCH v2 11/13] staging: r8188eu: remove return value from on_action_public_default Date: Sun, 30 Oct 2022 18:33:24 +0100 Message-Id: <20221030173326.1588647-12-martin@kaiser.cx> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221030173326.1588647-1-martin@kaiser.cx> References: <20221030173326.1588647-1-martin@kaiser.cx> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The only caller of on_action_public_default does not check the return value. We can make it a void function. Signed-off-by: Martin Kaiser --- drivers/staging/r8188eu/core/rtw_mlme_ext.c | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/drivers/staging/r8188eu/core/rtw_mlme_ext.c b/drivers/staging/= r8188eu/core/rtw_mlme_ext.c index b395457a6a60..f5923792f067 100644 --- a/drivers/staging/r8188eu/core/rtw_mlme_ext.c +++ b/drivers/staging/r8188eu/core/rtw_mlme_ext.c @@ -3788,22 +3788,15 @@ static void on_action_public_vendor(struct recv_fra= me *precv_frame) on_action_public_p2p(precv_frame); } =20 -static unsigned int on_action_public_default(struct recv_frame *precv_fram= e) +static void on_action_public_default(struct recv_frame *precv_frame) { - unsigned int ret =3D _FAIL; u8 *pframe =3D precv_frame->rx_data; u8 *frame_body =3D pframe + sizeof(struct ieee80211_hdr_3addr); u8 token; =20 token =3D frame_body[2]; =20 - if (rtw_action_public_decache(precv_frame, token) =3D=3D _FAIL) - goto exit; - - ret =3D _SUCCESS; - -exit: - return ret; + rtw_action_public_decache(precv_frame, token); } =20 static void on_action_public(struct adapter *padapter, struct recv_frame *= precv_frame) --=20 2.30.2