From nobody Wed Apr 8 21:16:18 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C8E2C433FE for ; Sat, 29 Oct 2022 16:30:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229851AbiJ2Qaw (ORCPT ); Sat, 29 Oct 2022 12:30:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35614 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229833AbiJ2Qaq (ORCPT ); Sat, 29 Oct 2022 12:30:46 -0400 Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1C5F849B6A for ; Sat, 29 Oct 2022 09:30:44 -0700 (PDT) Received: by mail-wm1-x335.google.com with SMTP id v130-20020a1cac88000000b003bcde03bd44so8299470wme.5 for ; Sat, 29 Oct 2022 09:30:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=pSxCGUJ2fS47/D5KQNutWHx6IqYinz5fCVnWfoUaNh4=; b=NNB+j7ovS20wgFCS3LKpn7ZIfvCQH882G1PISCxKthqgKtxL6MewW7kolSgbo8N5xv rpQaKMBLpl/ypz9W2fj5OQ4syq/tJs6IoJXV+yvwektecUpkD4W4sA3CDjA+pBmyKdt8 EDiWBNlz+UChXA/VlSYvFR430I10m4sk26DuM3005yoaXdeXDdySOAPxL1BxEniT+nM/ +qzhVyR4E+qVoKlYWp7wXpNSPBZ8oZKeELGgqScgz7tlpKKv0y0bydg9fgAo3itHdy0Q 4U14xQ0YfaShKP9SZ8LXiYTQLHh6wVBKDeBbJDFc3AAZkkf/Q1EGTjgMbTJ1hhRz3Llf StxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pSxCGUJ2fS47/D5KQNutWHx6IqYinz5fCVnWfoUaNh4=; b=hHJWam1/QzyAWww2no10GrraaWik3kZ2U0MHukzmPk0shP3K+BIASrGGZ7REnxiwsU w7XzbAkh9jMoDmrFJm/dIIAqXNd2lj7yYPau2omF/Fb7cGoBxjpCtT36OeT5dcUD7IIC It8vu9wzjZeGNBEhIFIOsoN/Pu4V19YCs+LxxUVLz9Xfm3tnU8W+ueiBFX5YE9cB/mwb hrG+cyWieHeV6dI9A+VWse9XqClz/RKJy/r+CKFLVev5jL9Ab2RbQsziCz6QRuAsbXvc o20s2jOjb4phmdlxnGIzzkQOaJuIBA1kpfyl/IJa2yAPeKbw03dWeeSHI5D9/p/GHXAC TTSA== X-Gm-Message-State: ACrzQf1y6t2IkqL8Ytw8azB8bn8+KF4hoCjGLBw8hZ01ZzqVRepLtOhJ FThlBHN6Llu2slGrZrk2Hhs= X-Google-Smtp-Source: AMsMyM4RxAJCS8QHD/Ad91l/iYUypGOD9Xexasu+SVgpMMeF7iqFqGU24AoGws7gNjpHQESYfiO6gA== X-Received: by 2002:a05:600c:1e26:b0:3cf:5238:13fc with SMTP id ay38-20020a05600c1e2600b003cf523813fcmr9321919wmb.151.1667061043217; Sat, 29 Oct 2022 09:30:43 -0700 (PDT) Received: from localhost.localdomain ([111.88.98.191]) by smtp.gmail.com with ESMTPSA id cc6-20020a5d5c06000000b002364835caacsm1860417wrb.112.2022.10.29.09.30.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Oct 2022 09:30:42 -0700 (PDT) From: Osama Muhammad To: gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, Osama Muhammad , Samuel Thibault Subject: [PATCH] Accessiblity: speakup_txprt: specifying the default driver parameters among the module params Date: Sat, 29 Oct 2022 21:30:33 +0500 Message-Id: <20221029163033.18337-1-osmtendev@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" This is an enhancement which allows to specify the default driver parameters among the module parameters. Adding default variables to the speakup_txprt module allows to easily set that at boot, rather than setting the sys variables after boot. More details can be found here: https://github.com/linux-speakup/speakup/issues/7 Signed-off-by: Osama Muhammad Reviewed-by: Samuel Thibault --- drivers/accessibility/speakup/speakup_txprt.c | 45 +++++++++++++++---- 1 file changed, 37 insertions(+), 8 deletions(-) diff --git a/drivers/accessibility/speakup/speakup_txprt.c b/drivers/access= ibility/speakup/speakup_txprt.c index 9e781347f7eb..4d0a0d4c41f0 100644 --- a/drivers/accessibility/speakup/speakup_txprt.c +++ b/drivers/accessibility/speakup/speakup_txprt.c @@ -16,14 +16,29 @@ #define SYNTH_CLEAR 0x18 #define PROCSPEECH '\r' /* process speech char */ =20 -static struct var_t vars[] =3D { - { CAPS_START, .u.s =3D {"\x05P8" } }, - { CAPS_STOP, .u.s =3D {"\x05P5" } }, - { RATE, .u.n =3D {"\x05R%d", 5, 0, 9, 0, 0, NULL } }, - { PITCH, .u.n =3D {"\x05P%d", 5, 0, 9, 0, 0, NULL } }, - { VOL, .u.n =3D {"\x05V%d", 5, 0, 9, 0, 0, NULL } }, - { TONE, .u.n =3D {"\x05T%c", 12, 0, 25, 61, 0, NULL } }, - { DIRECT, .u.n =3D {NULL, 0, 0, 1, 0, 0, NULL } }, + + + +enum default_vars_id { + CAPS_START_ID =3D 0, CAPS_STOP_ID, + RATE_ID, PITCH_ID, + VOL_ID, TONE_ID, + DIRECT_ID, V_LAST_VAR_ID, + NB_ID +}; + + + + + +static struct var_t vars[NB_ID] =3D { + [CAPS_START_ID] =3D { CAPS_START, .u.s =3D {"\x05P8" } }, + [CAPS_STOP_ID] =3D { CAPS_STOP, .u.s =3D {"\x05P5" } }, + [RATE_ID] =3D { RATE, .u.n =3D {"\x05R%d", 5, 0, 9, 0, 0, NULL } }, + [PITCH_ID] =3D { PITCH, .u.n =3D {"\x05P%d", 5, 0, 9, 0, 0, NULL } }, + [VOL_ID] =3D { VOL, .u.n =3D {"\x05V%d", 5, 0, 9, 0, 0, NULL } }, + [TONE_ID] =3D { TONE, .u.n =3D {"\x05T%c", 12, 0, 25, 61, 0, NULL } }, + [DIRECT_ID] =3D { DIRECT, .u.n =3D {NULL, 0, 0, 1, 0, 0, NULL } }, V_LAST_VAR }; =20 @@ -112,10 +127,24 @@ static struct spk_synth synth_txprt =3D { module_param_named(ser, synth_txprt.ser, int, 0444); module_param_named(dev, synth_txprt.dev_name, charp, 0444); module_param_named(start, synth_txprt.startup, short, 0444); +module_param_named(rate, vars[RATE_ID].u.n.default_val, int, 0444); +module_param_named(pitch, vars[PITCH_ID].u.n.default_val, int, 0444); +module_param_named(vol, vars[VOL_ID].u.n.default_val, int, 0444); +module_param_named(tone, vars[TONE_ID].u.n.default_val, int, 0444); +module_param_named(direct, vars[DIRECT_ID].u.n.default_val, int, 0444); + + =20 MODULE_PARM_DESC(ser, "Set the serial port for the synthesizer (0-based)."= ); MODULE_PARM_DESC(dev, "Set the device e.g. ttyUSB0, for the synthesizer."); MODULE_PARM_DESC(start, "Start the synthesizer once it is loaded."); +MODULE_PARM_DESC(rate, "Set the rate variable on load."); +MODULE_PARM_DESC(pitch, "Set the pitch variable on load."); +MODULE_PARM_DESC(vol, "Set the vol variable on load."); +MODULE_PARM_DESC(tone, "Set the tone variable on load."); +MODULE_PARM_DESC(direct, "Set the direct variable on load."); + + =20 module_spk_synth(synth_txprt); =20 --=20 2.25.1