From nobody Wed Apr 8 20:00:50 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 461BEFA3741 for ; Sat, 29 Oct 2022 01:54:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229602AbiJ2Byh (ORCPT ); Fri, 28 Oct 2022 21:54:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43436 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229456AbiJ2Bye (ORCPT ); Fri, 28 Oct 2022 21:54:34 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1BF5FCDA; Fri, 28 Oct 2022 18:54:28 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id AFB00B82DD5; Sat, 29 Oct 2022 01:54:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A501FC433C1; Sat, 29 Oct 2022 01:54:24 +0000 (UTC) Authentication-Results: smtp.kernel.org; dkim=pass (1024-bit key) header.d=zx2c4.com header.i=@zx2c4.com header.b="kZbxGOQv" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1667008462; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=SxtuEWeYOJFtWLwr3J1ri5ErnHaNd0SKCg1EYxarznQ=; b=kZbxGOQv3smAq0zOS/NIscB97Oo1xyp6tYHNhM/+YUBW8znCrlcPC3/J9LH5WAhdCpYFdc nPFnyUhP0Iy0ns6vejg9b6ZQq2CNW7MR6uYXT2b7SUCQ8BsWJBrLo/s9iJE9hN/p+VAoR8 AQgQMDWvfF5fL7jRKaQycUwPegc2sU0= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id 184a9951 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Sat, 29 Oct 2022 01:54:21 +0000 (UTC) From: "Jason A. Donenfeld" To: linux-kernel@vger.kernel.org Cc: "Jason A. Donenfeld" , Michael Ellerman , Heiko Carstens , linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org Subject: [PATCH v2] random: do not include from random.h Date: Sat, 29 Oct 2022 03:08:57 +0200 Message-Id: <20221029010857.161574-1-Jason@zx2c4.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The header is a random.c private detail, not something to be called by other code. As such, don't make it automatically available by way of random.h. Cc: Michael Ellerman Cc: Heiko Carstens Cc: linuxppc-dev@lists.ozlabs.org Cc: linux-s390@vger.kernel.org Signed-off-by: Jason A. Donenfeld Reviewed-by: Christophe Leroy --- arch/powerpc/kernel/setup-common.c | 1 + arch/s390/kernel/setup.c | 1 + drivers/char/random.c | 1 + include/linux/random.h | 2 -- 4 files changed, 3 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/kernel/setup-common.c b/arch/powerpc/kernel/setup= -common.c index 6d041993a45d..9b10e57040c6 100644 --- a/arch/powerpc/kernel/setup-common.c +++ b/arch/powerpc/kernel/setup-common.c @@ -59,6 +59,7 @@ #include #include #include +#include #include #include #include diff --git a/arch/s390/kernel/setup.c b/arch/s390/kernel/setup.c index ab19ddb09d65..b53a45735a5d 100644 --- a/arch/s390/kernel/setup.c +++ b/arch/s390/kernel/setup.c @@ -52,6 +52,7 @@ #include #include =20 +#include #include #include #include diff --git a/drivers/char/random.c b/drivers/char/random.c index e3cf4f51ed58..a7afd17db075 100644 --- a/drivers/char/random.c +++ b/drivers/char/random.c @@ -55,6 +55,7 @@ #include #include #include +#include #include #include #include diff --git a/include/linux/random.h b/include/linux/random.h index 2bdd3add3400..47e7cf126e8f 100644 --- a/include/linux/random.h +++ b/include/linux/random.h @@ -151,8 +151,6 @@ declare_get_random_var_wait(long, unsigned long) */ #include =20 -#include - #ifdef CONFIG_SMP int random_prepare_cpu(unsigned int cpu); int random_online_cpu(unsigned int cpu); --=20 2.38.1