From nobody Wed Apr 8 20:04:32 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC983C38A02 for ; Fri, 28 Oct 2022 20:56:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230047AbiJ1U4B (ORCPT ); Fri, 28 Oct 2022 16:56:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35542 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229997AbiJ1Uzx (ORCPT ); Fri, 28 Oct 2022 16:55:53 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5C20A1D1009; Fri, 28 Oct 2022 13:55:50 -0700 (PDT) Received: from notapiano.myfiosgateway.com (zone.collabora.co.uk [167.235.23.81]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by madras.collabora.co.uk (Postfix) with ESMTPSA id 18D78660293A; Fri, 28 Oct 2022 21:55:46 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1666990548; bh=/xWER+x0oIFofm2IpHy5fUUgY7g0hKyTCznvNF7+CqA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TnrQ1htkoHEWLyVfQvnS1zDqwnVJLfaspdiMRoVtYHz6yeWXdJimx7MDgfuvbG2x9 On+v13qBR8Bbq7mbl6dYsbLnoCQdhFdD7vmVXGdVfOOnvNdCTpzrIR9an02sCDaOyR zrOexNFlp61rZ/ekhsw1QswkvJZvROGorR+j6DHE997IjpOBpsPM+KrCs6KI0h8PT4 IQBzoVzkTtndgGiY2HE3lzEWtiuAXrR3/27AH1DPOMQ1J8oqFyLSnlGLadRvfVEcMe F3VA/UrlLhlXi+lRx1PH35hgPxG69uddO1xdYrLXl3HX7vcaQxLz7HO1WsRGdq16+N I2DFlrcDgoziA== From: =?UTF-8?q?N=C3=ADcolas=20F=2E=20R=2E=20A=2E=20Prado?= To: Mark Brown , Bjorn Andersson Cc: kernel@collabora.com, AngeloGioacchino Del Regno , =?UTF-8?q?N=C3=ADcolas=20F=2E=20R=2E=20A=2E=20Prado?= , Derek Fang , Krzysztof Kozlowski , Liam Girdwood , Rob Herring , alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/8] ASoC: dt-bindings: realtek,rt5682s: Add AVDD and MICVDD supplies Date: Fri, 28 Oct 2022 16:55:33 -0400 Message-Id: <20221028205540.3197304-2-nfraprado@collabora.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221028205540.3197304-1-nfraprado@collabora.com> References: <20221028205540.3197304-1-nfraprado@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The rt5682s codec has two supplies - AVDD and MICVDD - which are already used by sc7180-trogdor-kingoftown.dtsi. Document them in the binding. Acked-by: Krzysztof Kozlowski Signed-off-by: N=C3=ADcolas F. R. A. Prado Reviewed-by: AngeloGioacchino Del Regno --- Commit adapted from [1], changes: - Made supplies required - Added description for supplies [1] https://lore.kernel.org/all/20221024220015.1759428-3-nfraprado@collabor= a.com .../devicetree/bindings/sound/realtek,rt5682s.yaml | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml b= /Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml index 1c0b06d82369..b7338bfc0f5a 100644 --- a/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml +++ b/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml @@ -90,11 +90,20 @@ properties: "#sound-dai-cells": const: 1 =20 + AVDD-supply: + description: Regulator supplying analog power through the AVDD pin. + + MICVDD-supply: + description: Regulator supplying power for the microphone bias through= the + MICVDD pin. + additionalProperties: false =20 required: - compatible - reg + - AVDD-supply + - MICVDD-supply =20 examples: - | @@ -120,5 +129,8 @@ examples: =20 clocks =3D <&osc>; clock-names =3D "mclk"; + + AVDD-supply =3D <&avdd_reg>; + MICVDD-supply =3D <&micvdd_reg>; }; }; --=20 2.38.1 From nobody Wed Apr 8 20:04:32 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B40CFA3740 for ; Fri, 28 Oct 2022 20:56:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229917AbiJ1U4E (ORCPT ); Fri, 28 Oct 2022 16:56:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35596 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230003AbiJ1Uzz (ORCPT ); Fri, 28 Oct 2022 16:55:55 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 46CA11D2B6D; Fri, 28 Oct 2022 13:55:52 -0700 (PDT) Received: from notapiano.myfiosgateway.com (zone.collabora.co.uk [167.235.23.81]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by madras.collabora.co.uk (Postfix) with ESMTPSA id 511DE6602942; Fri, 28 Oct 2022 21:55:49 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1666990551; bh=dgNVES+PG7HYw90A/f6Jhk6U5cFEmEyu1X+wMPSSjEk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=oaRdgjikT/hfU/s0FaK1hkwIVF9Y1l3kfEWLM3nrpKFDOtkGCt4iiQhaNF5w0vWVU zIdCEi74XlLewBLxA31M+O93kT6m6IHkaOqnJQBYeULCbVEfEui8tcb+9PyppGF/Qf SqiT6TbpVrmc/4K1bPbOy33UnzjCgqiEKisZpp6WhYqtPjE3Ojyk/tEewx+fMb2SgK QtwcSj+Nc1Pj0FNTvGETnpg2g7ADwR5RT0hg68udxeztOW5gIgbM+oX8TMFZ1xCKLJ eBHJAO0I3Ox7tEZ3VT5jxjTUjO2WYyLgBPGRPxHoff+zoCgJLI9eqKtF0NS+Kcqw89 zfJ+AeGsHwAcQ== From: =?UTF-8?q?N=C3=ADcolas=20F=2E=20R=2E=20A=2E=20Prado?= To: Mark Brown , Bjorn Andersson Cc: kernel@collabora.com, AngeloGioacchino Del Regno , =?UTF-8?q?N=C3=ADcolas=20F=2E=20R=2E=20A=2E=20Prado?= , Derek Fang , Krzysztof Kozlowski , Liam Girdwood , Rob Herring , alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/8] ASoC: dt-bindings: realtek,rt5682s: Add dbvdd and ldo1-in supplies Date: Fri, 28 Oct 2022 16:55:34 -0400 Message-Id: <20221028205540.3197304-3-nfraprado@collabora.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221028205540.3197304-1-nfraprado@collabora.com> References: <20221028205540.3197304-1-nfraprado@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The rt5682s codec has two additional power supply pins, DBVDD and LDO1_IN, that aren't currently described in the binding. Add them. Signed-off-by: N=C3=ADcolas F. R. A. Prado Acked-by: Krzysztof Kozlowski Reviewed-by: AngeloGioacchino Del Regno --- .../devicetree/bindings/sound/realtek,rt5682s.yaml | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml b= /Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml index b7338bfc0f5a..5b2bbf6f9156 100644 --- a/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml +++ b/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml @@ -97,6 +97,13 @@ properties: description: Regulator supplying power for the microphone bias through= the MICVDD pin. =20 + dbvdd-supply: + description: Regulator supplying I/O power through the DBVDD pin. + + ldo1-in-supply: + description: Regulator supplying power to the digital core and charge = pump + through the LDO1_IN pin. + additionalProperties: false =20 required: @@ -104,6 +111,8 @@ required: - reg - AVDD-supply - MICVDD-supply + - dbvdd-supply + - ldo1-in-supply =20 examples: - | @@ -132,5 +141,7 @@ examples: =20 AVDD-supply =3D <&avdd_reg>; MICVDD-supply =3D <&micvdd_reg>; + dbvdd-supply =3D <&dbvdd_reg>; + ldo1-in-supply =3D <&ldo1_in_reg>; }; }; --=20 2.38.1 From nobody Wed Apr 8 20:04:32 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5900CECAAA1 for ; Fri, 28 Oct 2022 20:56:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229891AbiJ1U4H (ORCPT ); Fri, 28 Oct 2022 16:56:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35640 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230013AbiJ1Uz4 (ORCPT ); Fri, 28 Oct 2022 16:55:56 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8924E1DDDFF; Fri, 28 Oct 2022 13:55:54 -0700 (PDT) Received: from notapiano.myfiosgateway.com (zone.collabora.co.uk [167.235.23.81]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by madras.collabora.co.uk (Postfix) with ESMTPSA id 877906602940; Fri, 28 Oct 2022 21:55:51 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1666990553; bh=r1qaS5ViUxHsg1AZWvTvqTeEqXfMJSJaHVFIn2x377M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Be5H31LH2WXgTiryfnYQhUfs1ziaP8O4tktnP6GMZ9lHvDHyDw2tANpsISZUTjfkq OcI8IdOUoPhFlnB3qhBKE+zTOFr8qvc6PGHUIHAF/tihmeyKrhB1OVbew/pCENPxhR leaM04Iv+RZx14OV/Nmu1BEDuiKsqYU3yFZn1zGc04GgfsNi/nqNwIuv1gANRlFMwA jryI7hRCxCgixD9PKbC/dQfE6IqYOk/SrDVapZBOtEoJBDvARQQcJI9ipqohMCMm9K ShWaLByQEudq5HXvmL7kzSonT2c3WSyQ8NanSXY5N5YFwdQbujlpjvNySmzHTMKBk+ BcKXmrXvDlLhg== From: =?UTF-8?q?N=C3=ADcolas=20F=2E=20R=2E=20A=2E=20Prado?= To: Mark Brown , Bjorn Andersson Cc: kernel@collabora.com, AngeloGioacchino Del Regno , =?UTF-8?q?N=C3=ADcolas=20F=2E=20R=2E=20A=2E=20Prado?= , Krzysztof Kozlowski , Liam Girdwood , Rob Herring , alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/8] ASoC: dt-bindings: rt5682: Add AVDD, MICVDD and VBAT supplies Date: Fri, 28 Oct 2022 16:55:35 -0400 Message-Id: <20221028205540.3197304-4-nfraprado@collabora.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221028205540.3197304-1-nfraprado@collabora.com> References: <20221028205540.3197304-1-nfraprado@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The rt5682 codec has three supplies - AVDD, MICVDD and VBAT - which are already used by sc7180-trogdor.dtsi. Document them in the binding. Acked-by: Krzysztof Kozlowski Signed-off-by: N=C3=ADcolas F. R. A. Prado --- Commit adapted from [1], changes: - Made supplies required - Improved supplies descriptions [1] https://lore.kernel.org/all/20221024220015.1759428-5-nfraprado@collabor= a.com Documentation/devicetree/bindings/sound/rt5682.txt | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/Documentation/devicetree/bindings/sound/rt5682.txt b/Documenta= tion/devicetree/bindings/sound/rt5682.txt index 6b87db68337c..89e6245b870e 100644 --- a/Documentation/devicetree/bindings/sound/rt5682.txt +++ b/Documentation/devicetree/bindings/sound/rt5682.txt @@ -8,6 +8,15 @@ Required properties: =20 - reg : The I2C address of the device. =20 +- AVDD-supply: phandle to the regulator supplying analog power through the + AVDD pin + +- MICVDD-supply: phandle to the regulator supplying power for the micropho= ne + bias through the MICVDD pin. Either MICVDD or VBAT should be present. + +- VBAT-supply: phandle to the regulator supplying battery power through the + VBAT pin. Either MICVDD or VBAT should be present. + Optional properties: =20 - interrupts : The CODEC's interrupt output. @@ -75,4 +84,7 @@ rt5682 { =20 clocks =3D <&osc>; clock-names =3D "mclk"; + + AVDD-supply =3D <&avdd_reg>; + MICVDD-supply =3D <&micvdd_reg>; }; --=20 2.38.1 From nobody Wed Apr 8 20:04:32 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05BB0ECAAA1 for ; Fri, 28 Oct 2022 20:56:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230131AbiJ1U4L (ORCPT ); Fri, 28 Oct 2022 16:56:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35712 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230010AbiJ1Uz6 (ORCPT ); Fri, 28 Oct 2022 16:55:58 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 75F591EA541; Fri, 28 Oct 2022 13:55:56 -0700 (PDT) Received: from notapiano.myfiosgateway.com (zone.collabora.co.uk [167.235.23.81]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by madras.collabora.co.uk (Postfix) with ESMTPSA id 9DDD76602946; Fri, 28 Oct 2022 21:55:53 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1666990555; bh=kjJv2wI4r1COdPJDLysFujzo37yIvD0eiCbT/D7WY8Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gVADpfkI9YN8wvlcRgrsvTvdm8VyxolhpHN7+2z3ao+LKiotKKSHsYNVuoUFAh/X5 ncUKhS0W2QJK0rnAK9M2Sp2D6+GfW+EtzDfDgpQyywPigP79gyWm1kGgGYzFhydyMP kjYlMenwb/GMAlTOrL1tgeoPOoLr7LMJPPIu4xH9IvcsHqDk6AXdcxs5SI4Mgc0OOw xxUN+QMiWsSbzESkpU+7viNdCpv1BUrC0GXVNOezS/xbb2CyuLjhaisxxTmgBgDqqc /M8/Awa1tJIQTDSnYKD1ENE4fwv8exUmDkeFZPoln8BPcQ5AFYuMIrp8nO2cb/Z/3n WH75CERAEuSFA== From: =?UTF-8?q?N=C3=ADcolas=20F=2E=20R=2E=20A=2E=20Prado?= To: Mark Brown , Bjorn Andersson Cc: kernel@collabora.com, AngeloGioacchino Del Regno , =?UTF-8?q?N=C3=ADcolas=20F=2E=20R=2E=20A=2E=20Prado?= , Krzysztof Kozlowski , Liam Girdwood , Rob Herring , alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 4/8] ASoC: dt-bindings: rt5682: Add dbvdd and ldo1-in supplies Date: Fri, 28 Oct 2022 16:55:36 -0400 Message-Id: <20221028205540.3197304-5-nfraprado@collabora.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221028205540.3197304-1-nfraprado@collabora.com> References: <20221028205540.3197304-1-nfraprado@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The rt5682 codec has two additional power supply pins, DBVDD and LDO1_IN, that aren't currently described in the binding. Add them. Signed-off-by: N=C3=ADcolas F. R. A. Prado Acked-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/sound/rt5682.txt | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/Documentation/devicetree/bindings/sound/rt5682.txt b/Documenta= tion/devicetree/bindings/sound/rt5682.txt index 89e6245b870e..948109ff0db3 100644 --- a/Documentation/devicetree/bindings/sound/rt5682.txt +++ b/Documentation/devicetree/bindings/sound/rt5682.txt @@ -17,6 +17,12 @@ Required properties: - VBAT-supply: phandle to the regulator supplying battery power through the VBAT pin. Either MICVDD or VBAT should be present. =20 +- dbvdd-supply: phandle to the regulator supplying I/O power through the D= BVDD + pin. + +- ldo1-in-supply: phandle to the regulator supplying power to the digital = core + and charge pump through the LDO1_IN pin. + Optional properties: =20 - interrupts : The CODEC's interrupt output. @@ -87,4 +93,6 @@ rt5682 { =20 AVDD-supply =3D <&avdd_reg>; MICVDD-supply =3D <&micvdd_reg>; + dbvdd-supply =3D <&dbvdd_reg>; + ldo1-in-supply =3D <&ldo1_in_reg>; }; --=20 2.38.1 From nobody Wed Apr 8 20:04:32 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D60EECAAA1 for ; Fri, 28 Oct 2022 20:56:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229845AbiJ1U4Q (ORCPT ); Fri, 28 Oct 2022 16:56:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35542 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230055AbiJ1U4C (ORCPT ); Fri, 28 Oct 2022 16:56:02 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BADF5226E7E for ; Fri, 28 Oct 2022 13:55:58 -0700 (PDT) Received: from notapiano.myfiosgateway.com (zone.collabora.co.uk [167.235.23.81]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by madras.collabora.co.uk (Postfix) with ESMTPSA id B45B7660294B; Fri, 28 Oct 2022 21:55:55 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1666990557; bh=fWR6lgaHeOPHW1FSsPg4QG/1KgRcjLHEyF+Wsu51etk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UrmysWN2I9Qqpva8V2G9/hL5C9jyElZSwIVdheQjvOtBk3gQCViqJgDYmils7P/pZ eOWqWMsy2u2qZ/kU8sKUykuSbFvINlb1MgLt+qy0rx0njLcGBNxdic9cGyX1zzYe1W WWiZU+htGxfrXsql80TI6Vx+TUyljCwi1ysLqfm159j9awR5ENR17JpW6ICMdiAh53 bponcNnEUG+c/bCRIQ42WjekH5YQgEn9JLJDz0biUcGsLcB0KhSBN5Qnp8P8qF78WQ 6Wj8FC3Hq2N0DZRFiKk0zRShwOhwXL9xV+plvKI7i5zZiFIt8YhZndIZXF1lVh/V+R xEKm5UboxXncg== From: =?UTF-8?q?N=C3=ADcolas=20F=2E=20R=2E=20A=2E=20Prado?= To: Mark Brown , Bjorn Andersson Cc: kernel@collabora.com, AngeloGioacchino Del Regno , =?UTF-8?q?N=C3=ADcolas=20F=2E=20R=2E=20A=2E=20Prado?= , Jaroslav Kysela , Liam Girdwood , Oder Chiou , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: [PATCH 5/8] ASoC: rt5682s: Support dbvdd and ldo1-in supplies Date: Fri, 28 Oct 2022 16:55:37 -0400 Message-Id: <20221028205540.3197304-6-nfraprado@collabora.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221028205540.3197304-1-nfraprado@collabora.com> References: <20221028205540.3197304-1-nfraprado@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add support for the dbvdd and ldo1-in supplies. Signed-off-by: N=C3=ADcolas F. R. A. Prado Reviewed-by: AngeloGioacchino Del Regno --- sound/soc/codecs/rt5682s.c | 22 ++++++++++++++++++++++ sound/soc/codecs/rt5682s.h | 2 ++ 2 files changed, 24 insertions(+) diff --git a/sound/soc/codecs/rt5682s.c b/sound/soc/codecs/rt5682s.c index 80c673aa14db..de686004e504 100644 --- a/sound/soc/codecs/rt5682s.c +++ b/sound/soc/codecs/rt5682s.c @@ -44,6 +44,8 @@ static const struct rt5682s_platform_data i2s_default_pla= tform_data =3D { static const char *rt5682s_supply_names[RT5682S_NUM_SUPPLIES] =3D { [RT5682S_SUPPLY_AVDD] =3D "AVDD", [RT5682S_SUPPLY_MICVDD] =3D "MICVDD", + [RT5682S_SUPPLY_DBVDD] =3D "dbvdd", + [RT5682S_SUPPLY_LDO1_IN] =3D "ldo1-in", }; =20 static const struct reg_sequence patch_list[] =3D { @@ -3089,6 +3091,14 @@ static void rt5682s_i2c_disable_regulators(void *dat= a) if (ret) dev_err(dev, "Failed to disable supply AVDD: %d\n", ret); =20 + ret =3D regulator_disable(rt5682s->supplies[RT5682S_SUPPLY_DBVDD].consume= r); + if (ret) + dev_err(dev, "Failed to disable supply dbvdd: %d\n", ret); + + ret =3D regulator_disable(rt5682s->supplies[RT5682S_SUPPLY_LDO1_IN].consu= mer); + if (ret) + dev_err(dev, "Failed to disable supply ldo1-in: %d\n", ret); + usleep_range(1000, 1500); =20 ret =3D regulator_disable(rt5682s->supplies[RT5682S_SUPPLY_MICVDD].consum= er); @@ -3150,6 +3160,18 @@ static int rt5682s_i2c_probe(struct i2c_client *i2c) return ret; } =20 + ret =3D regulator_enable(rt5682s->supplies[RT5682S_SUPPLY_DBVDD].consumer= ); + if (ret) { + dev_err(&i2c->dev, "Failed to enable supply dbvdd: %d\n", ret); + return ret; + } + + ret =3D regulator_enable(rt5682s->supplies[RT5682S_SUPPLY_LDO1_IN].consum= er); + if (ret) { + dev_err(&i2c->dev, "Failed to enable supply ldo1-in: %d\n", ret); + return ret; + } + if (gpio_is_valid(rt5682s->pdata.ldo1_en)) { if (devm_gpio_request_one(&i2c->dev, rt5682s->pdata.ldo1_en, GPIOF_OUT_INIT_HIGH, "rt5682s")) diff --git a/sound/soc/codecs/rt5682s.h b/sound/soc/codecs/rt5682s.h index 45464a041765..67f86a38a1cc 100644 --- a/sound/soc/codecs/rt5682s.h +++ b/sound/soc/codecs/rt5682s.h @@ -1438,6 +1438,8 @@ struct pll_calc_map { enum { RT5682S_SUPPLY_AVDD, RT5682S_SUPPLY_MICVDD, + RT5682S_SUPPLY_DBVDD, + RT5682S_SUPPLY_LDO1_IN, RT5682S_NUM_SUPPLIES, }; =20 --=20 2.38.1 From nobody Wed Apr 8 20:04:32 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1D03C38A02 for ; Fri, 28 Oct 2022 20:56:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229824AbiJ1U4U (ORCPT ); Fri, 28 Oct 2022 16:56:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35590 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230070AbiJ1U4D (ORCPT ); Fri, 28 Oct 2022 16:56:03 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9CCC522D59C for ; Fri, 28 Oct 2022 13:56:00 -0700 (PDT) Received: from notapiano.myfiosgateway.com (zone.collabora.co.uk [167.235.23.81]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by madras.collabora.co.uk (Postfix) with ESMTPSA id CD1676602943; Fri, 28 Oct 2022 21:55:57 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1666990559; bh=k0ciXJ9TnsI96EclJ+3I0qJrPTH22yg0wvdKWox0Yts=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Dr/5K/hxbGJrVT4XPuyjGzz/3Uum/9Fd9mrf8EQhK/6ZcWFGej3jAAgOHmJK//bUU TQ5J3NxsnHW67K1TKUI6HCXxr6VYdZNYNkXy6U3Mi7Q2Or18yPfN+v1v5XDd6c5lt1 QwaBjBwtRR4uwm9gcArc0HucMg1BUNbGteR9UQEtJzbgGpk1P+dMokd3vbreQuEZ6u ceUiW+a+fnsAAT+As/738oHDRssJPvywt3jXdgwz+vNUYCQkAdrUG9p49oIXFdM8MR P++AX6xwtUG1mvI5Ro4y/msZiEOpqecj3RnAKuER9ICKw2cU0wjSEbrRiXLioin/47 3BIwOoyt9X33g== From: =?UTF-8?q?N=C3=ADcolas=20F=2E=20R=2E=20A=2E=20Prado?= To: Mark Brown , Bjorn Andersson Cc: kernel@collabora.com, AngeloGioacchino Del Regno , =?UTF-8?q?N=C3=ADcolas=20F=2E=20R=2E=20A=2E=20Prado?= , Jaroslav Kysela , Liam Girdwood , Oder Chiou , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: [PATCH 6/8] ASoC: rt5682: Support dbvdd and ldo1-in supplies Date: Fri, 28 Oct 2022 16:55:38 -0400 Message-Id: <20221028205540.3197304-7-nfraprado@collabora.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221028205540.3197304-1-nfraprado@collabora.com> References: <20221028205540.3197304-1-nfraprado@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add support for the dbvdd and ldo1-in supplies. Signed-off-by: N=C3=ADcolas F. R. A. Prado Reviewed-by: AngeloGioacchino Del Regno --- sound/soc/codecs/rt5682.c | 2 ++ sound/soc/codecs/rt5682.h | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/sound/soc/codecs/rt5682.c b/sound/soc/codecs/rt5682.c index 2df95e792900..f0a400285dcf 100644 --- a/sound/soc/codecs/rt5682.c +++ b/sound/soc/codecs/rt5682.c @@ -35,6 +35,8 @@ const char *rt5682_supply_names[RT5682_NUM_SUPPLIES] =3D { "AVDD", "MICVDD", "VBAT", + "dbvdd", + "ldo1-in", }; EXPORT_SYMBOL_GPL(rt5682_supply_names); =20 diff --git a/sound/soc/codecs/rt5682.h b/sound/soc/codecs/rt5682.h index 52ff0d9c36c5..d568c6993c33 100644 --- a/sound/soc/codecs/rt5682.h +++ b/sound/soc/codecs/rt5682.h @@ -1424,7 +1424,7 @@ enum { RT5682_CLK_SEL_I2S2_ASRC, }; =20 -#define RT5682_NUM_SUPPLIES 3 +#define RT5682_NUM_SUPPLIES 5 =20 struct rt5682_priv { struct snd_soc_component *component; --=20 2.38.1 From nobody Wed Apr 8 20:04:32 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2B1AECAAA1 for ; Fri, 28 Oct 2022 20:56:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229629AbiJ1U4Z (ORCPT ); Fri, 28 Oct 2022 16:56:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35854 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230081AbiJ1U4E (ORCPT ); Fri, 28 Oct 2022 16:56:04 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1BF8B2413D7; Fri, 28 Oct 2022 13:56:02 -0700 (PDT) Received: from notapiano.myfiosgateway.com (zone.collabora.co.uk [167.235.23.81]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by madras.collabora.co.uk (Postfix) with ESMTPSA id E34E06602944; Fri, 28 Oct 2022 21:55:59 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1666990561; bh=qWdkIlb4uY0ldwod8O1L1+MBmgoTBnCHuEAzyFzvduk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CatTo8ntRCB35RCQqr7MIKSSx49eqvxGewJ+wINf+RK1+ORKjUX9Jor0ULSHiw3du 078Gf8xZKL8H2a42ftkNkxwapfbRuBgz+naGO1Fqj/+yejaSKFbODdUlgyLK6/bBuM QnVAmZ6WZdyzTi3RgW1t15Idv734HsfKlIJy8uT11CaKLrVyTN3baPzMTWjvyffsFA f75fckeGkna97+EeEwgZKv7ftpnpRDVf26MS00Tj+vfRT0a4jZ4gvlINr8bl0aAA0I GJW8AoaH3p+WmY6SO5gqw5a+bRjwTKrThJaewc40QRwSUNPov0GUEfj1wyA6VsMBcq x/Xfbo/bpB24Q== From: =?UTF-8?q?N=C3=ADcolas=20F=2E=20R=2E=20A=2E=20Prado?= To: Mark Brown , Bjorn Andersson Cc: kernel@collabora.com, AngeloGioacchino Del Regno , =?UTF-8?q?N=C3=ADcolas=20F=2E=20R=2E=20A=2E=20Prado?= , Andy Gross , Konrad Dybcio , Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 7/8] arm64: dts: qcom: sc7180-trogdor: Add missing supplies for rt5682 Date: Fri, 28 Oct 2022 16:55:39 -0400 Message-Id: <20221028205540.3197304-8-nfraprado@collabora.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221028205540.3197304-1-nfraprado@collabora.com> References: <20221028205540.3197304-1-nfraprado@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The dbvdd and ldo1-in supplies for rt5682 are required but are missing. They are supplied by the same power rail as AVDD. Add them. Signed-off-by: N=C3=ADcolas F. R. A. Prado Reviewed-by: AngeloGioacchino Del Regno --- arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot= /dts/qcom/sc7180-trogdor.dtsi index 1a1c346d619c..1df507ffb267 100644 --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi @@ -768,6 +768,8 @@ alc5682: codec@1a { interrupts =3D <28 IRQ_TYPE_EDGE_BOTH>; =20 AVDD-supply =3D <&pp1800_alc5682>; + dbvdd-supply =3D <&pp1800_alc5682>; + ldo1-in-supply =3D <&pp1800_alc5682>; MICVDD-supply =3D <&pp3300_codec>; VBAT-supply =3D <&pp3300_audio>; =20 --=20 2.38.1 From nobody Wed Apr 8 20:04:32 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77CE9FA3740 for ; Fri, 28 Oct 2022 20:56:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229919AbiJ1U4f (ORCPT ); Fri, 28 Oct 2022 16:56:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35820 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230057AbiJ1U4G (ORCPT ); Fri, 28 Oct 2022 16:56:06 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 56D4B241B06; Fri, 28 Oct 2022 13:56:05 -0700 (PDT) Received: from notapiano.myfiosgateway.com (zone.collabora.co.uk [167.235.23.81]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by madras.collabora.co.uk (Postfix) with ESMTPSA id 2A4DC660293F; Fri, 28 Oct 2022 21:56:02 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1666990564; bh=N8cgOi4X/bGXGpJD1NivnBMWo59PYqBzjXyEcn5g/c4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Uz2gH1d5rmELMS/Cg98cAiOnfzWrfm5ZTh5bTWtLXZs9ilO5PTxCUudUwAnTebvYI 0hBv2FVkqhdFqHPMvJPLzNW11qU/6rkuO8xjiEu9QgUW5NaWg6oCH9dycm6vb4WkEH MkOiZj7rxyGa21PYU4VqaMkbN15EdkbVx72ATKkvy8kvpcFA+1IZ0P2pZVnCh8luhH wur8lMjO8lh1t3Iv5rLSchm61qFS2fC2X4Yow3/p80NROqi1a/fCgEQda/vbU2Ru7M hYPbN5Uazx9qqpSO7IyXF3jg137UjjnJ6Btij0r5v5xuWpFb7ebvbHKRtPjxmbDjQW hAVChXCXP7tWA== From: =?UTF-8?q?N=C3=ADcolas=20F=2E=20R=2E=20A=2E=20Prado?= To: Mark Brown , Bjorn Andersson Cc: kernel@collabora.com, AngeloGioacchino Del Regno , =?UTF-8?q?N=C3=ADcolas=20F=2E=20R=2E=20A=2E=20Prado?= , Andy Gross , Konrad Dybcio , Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 8/8] arm64: dts: qcom: sc7180-trogdor: Remove VBAT supply from rt5682s Date: Fri, 28 Oct 2022 16:55:40 -0400 Message-Id: <20221028205540.3197304-9-nfraprado@collabora.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221028205540.3197304-1-nfraprado@collabora.com> References: <20221028205540.3197304-1-nfraprado@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org These devicetrees override a rt5682 node to use the rt5682s compatible, however, unlike rt5682, rt5682s doesn't have a VBAT supply. Remove the inexistent supply in the rt5682s nodes. Signed-off-by: N=C3=ADcolas F. R. A. Prado --- arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown.dtsi | 1 + .../dts/qcom/sc7180-trogdor-wormdingler-rev1-boe-rt5682s.dts | 1 + .../dts/qcom/sc7180-trogdor-wormdingler-rev1-inx-rt5682s.dts | 1 + 3 files changed, 3 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown.dtsi b/arch= /arm64/boot/dts/qcom/sc7180-trogdor-kingoftown.dtsi index 74f0e07ea5cf..e0fb83a9a0b1 100644 --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown.dtsi @@ -11,6 +11,7 @@ =20 &alc5682 { compatible =3D "realtek,rt5682s"; + /delete-property/ VBAT-supply; realtek,dmic1-clk-pin =3D <2>; realtek,dmic-clk-rate-hz =3D <2048000>; }; diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev1-boe-r= t5682s.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev1-boe-r= t5682s.dts index aa605885c371..6225ab8329c3 100644 --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev1-boe-rt5682s.= dts +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev1-boe-rt5682s.= dts @@ -19,6 +19,7 @@ / { =20 &alc5682 { compatible =3D "realtek,rt5682s"; + /delete-property/ VBAT-supply; realtek,dmic1-clk-pin =3D <2>; realtek,dmic-clk-rate-hz =3D <2048000>; }; diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev1-inx-r= t5682s.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev1-inx-r= t5682s.dts index 7116c44c8d85..b40b068dad6a 100644 --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev1-inx-rt5682s.= dts +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev1-inx-rt5682s.= dts @@ -19,6 +19,7 @@ / { =20 &alc5682 { compatible =3D "realtek,rt5682s"; + /delete-property/ VBAT-supply; realtek,dmic1-clk-pin =3D <2>; realtek,dmic-clk-rate-hz =3D <2048000>; }; --=20 2.38.1