From nobody Sat Apr 11 12:14:37 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91EFEECAAA1 for ; Thu, 27 Oct 2022 21:29:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236914AbiJ0V3F (ORCPT ); Thu, 27 Oct 2022 17:29:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54216 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235686AbiJ0V3D (ORCPT ); Thu, 27 Oct 2022 17:29:03 -0400 Received: from mail-pg1-x54a.google.com (mail-pg1-x54a.google.com [IPv6:2607:f8b0:4864:20::54a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 88DFA62A8B for ; Thu, 27 Oct 2022 14:29:02 -0700 (PDT) Received: by mail-pg1-x54a.google.com with SMTP id p24-20020a63f458000000b0043cd718c49dso1404980pgk.15 for ; Thu, 27 Oct 2022 14:29:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=sogLxSdG4yhSyQPPmGTG1lTI5fUEQY8x224g/Iq10fc=; b=ZfPQ53qWiF9lKVX7A6P52Hq3jFTphhwqs712Act23LApJ68RGcZiAYyi9BwF+Zl+AV a0lM5zs8rBWPovdTteQVAHwN0wrzj990wBJBsnlaf4bKLExxEl9FQbxCP7mOphdTB0SB 4BKGGYsX66p9ToTP9xG8ipeq8gBa0QZo5COoWeUFYvDhXpLmgu9BxECYUW4mXuSITOpb +vpq9LhO5MIkI9j7dtDMgAQyZHeo61lmrhSg7EERHcZrYcWZ4EGm9iALoA36WiLjOGdO 4aats94IGSscqNdxVjuYSH/alw8dVwbFeaWq3H8BwPg0/SpFqo4IyJeTO2fvQ3cplfKt hhAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=sogLxSdG4yhSyQPPmGTG1lTI5fUEQY8x224g/Iq10fc=; b=ENsGXCC0RktqbCv63W+ygrjveZ1raKaHY+KCqDYdqgs4AmslvroU7TkERQwagdOoPe 7fDjTIuJy/k6xuTUjFGWySmovZf3vwDVDqReqyE49IEyZERy48NU3jgJUqbTWJnFtMxU GHF1/aqXAUWDqPNTz7g4M9StsQqWFDr1wbISeyTGN2nuhMzgoORFvtmgLrJtVa07d6D0 L85lYiIimaVxOKz+zZ8hB7I73eYyaPSVXeFxYaeBL3q9vnx3Go3dOY0rUw9FnalHyDiV tSsTZio7oQXKMmYkAK77LpJvgHEHiJ1y/soaYD0xMnYhGWkDO5p+xjraoBxirXbCwyOY 31Gg== X-Gm-Message-State: ACrzQf1Hg1600dCU0JUJw/VwEKYhXGvLvzxmGjI3axqAAiqG5oD9VfSC YSKfPj80X5NgLZzGjNf2RI3TbYaXoncTFA== X-Google-Smtp-Source: AMsMyM4uM4T1zCFb+ABPod5xJDsDwyQXMdmcaWbc/HvdOYvOkB3E/tAajIyRYpToivIpyzCGtz91zVTkXPrw3g== X-Received: from wonchungspecialist.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:1440]) (user=wonchung job=sendgmr) by 2002:a05:6a00:150e:b0:56c:83b3:d148 with SMTP id q14-20020a056a00150e00b0056c83b3d148mr7337251pfu.48.1666906142035; Thu, 27 Oct 2022 14:29:02 -0700 (PDT) Date: Thu, 27 Oct 2022 21:28:54 +0000 Mime-Version: 1.0 X-Mailer: git-send-email 2.38.1.273.g43a17bfeac-goog Message-ID: <20221027212854.1083686-1-wonchung@google.com> Subject: [PATCH v3] drm/sysfs: Link DRM connectors to corresponding Type-C connectors From: Won Chung To: wonchung@google.com, bleung@google.com, pmalani@chromium.org, heikki.krogerus@linux.intel.com, imre.deak@intel.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@linux.ie, airlied@gmail.com, daniel@ffwll.ch, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Create a symlink pointing to USB Type-C connector for DRM connectors when they are created. The link will be created only if the firmware is able to describe the connection beween the two connectors. Signed-off-by: Won Chung Acked-by: Heikki Krogerus --- Changes from v2: - Resending the patch to dri-devel list Changes from v1: - Fix multiple lines to single line drivers/gpu/drm/drm_sysfs.c | 40 +++++++++++++++++++++++++++++++++++++ 1 file changed, 40 insertions(+) diff --git a/drivers/gpu/drm/drm_sysfs.c b/drivers/gpu/drm/drm_sysfs.c index 430e00b16eec..6a9904fa9186 100644 --- a/drivers/gpu/drm/drm_sysfs.c +++ b/drivers/gpu/drm/drm_sysfs.c @@ -11,12 +11,14 @@ */ =20 #include +#include #include #include #include #include #include #include +#include #include =20 #include @@ -95,6 +97,34 @@ static char *drm_devnode(struct device *dev, umode_t *mo= de) return kasprintf(GFP_KERNEL, "dri/%s", dev_name(dev)); } =20 +static int typec_connector_bind(struct device *dev, + struct device *typec_connector, void *data) +{ + int ret; + + ret =3D sysfs_create_link(&dev->kobj, &typec_connector->kobj, "typec_conn= ector"); + if (ret) + return ret; + + ret =3D sysfs_create_link(&typec_connector->kobj, &dev->kobj, "drm_connec= tor"); + if (ret) + sysfs_remove_link(&dev->kobj, "typec_connector"); + + return ret; +} + +static void typec_connector_unbind(struct device *dev, + struct device *typec_connector, void *data) +{ + sysfs_remove_link(&typec_connector->kobj, "drm_connector"); + sysfs_remove_link(&dev->kobj, "typec_connector"); +} + +static const struct component_ops typec_connector_ops =3D { + .bind =3D typec_connector_bind, + .unbind =3D typec_connector_unbind, +}; + static CLASS_ATTR_STRING(version, S_IRUGO, "drm 1.1.0 20060810"); =20 /** @@ -355,6 +385,13 @@ int drm_sysfs_connector_add(struct drm_connector *conn= ector) if (connector->ddc) return sysfs_create_link(&connector->kdev->kobj, &connector->ddc->dev.kobj, "ddc"); + + if (dev_fwnode(kdev)) { + r =3D component_add(kdev, &typec_connector_ops); + if (r) + drm_err(dev, "failed to add component\n"); + } + return 0; =20 err_free: @@ -367,6 +404,9 @@ void drm_sysfs_connector_remove(struct drm_connector *c= onnector) if (!connector->kdev) return; =20 + if (dev_fwnode(connector->kdev)) + component_del(connector->kdev, &typec_connector_ops); + if (connector->ddc) sysfs_remove_link(&connector->kdev->kobj, "ddc"); =20 --=20 2.37.3.998.g577e59143f-goog