From nobody Wed Apr 8 15:52:29 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB83BFA3740 for ; Thu, 27 Oct 2022 18:05:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236080AbiJ0SFD (ORCPT ); Thu, 27 Oct 2022 14:05:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51546 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236350AbiJ0SEm (ORCPT ); Thu, 27 Oct 2022 14:04:42 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 80C9D160ECD for ; Thu, 27 Oct 2022 11:04:22 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 33169B8273A for ; Thu, 27 Oct 2022 18:04:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C0B8EC433C1; Thu, 27 Oct 2022 18:04:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1666893859; bh=Re061QOM1zSa4SDCeCrNjsAINlsDxks5xlguK2smzZM=; h=From:To:Cc:Subject:Date:From; b=MAnB/3Kscb3IH5sMmjEndAtFL5eaFb6jyqsw4Chj4n52vle3fXSVrnPIjuT/KFpq9 1tDMeF7EXE6QVvQ9/Lr6c78DUwwS/pJXpYBGqxI3Ody5kr0+btddiyB8YyYSbR/4Kc khArmFkwnpoi8QSdZlJRm/4GhiEqBrZdX8QpkVprrCpmNn8YZ9+rcFHKSE6l96X4kT ITLxNn5bZfEy5DtSbwAI0t/MT5N5g979aXhAgZqPZ0MMKqAv2q3/ojimU9bKM6yu+a VS6+D6pYs9kSlC8hWUCBk83xfcs4I/CtH1sju0ekXEYnOhIwI+KKo3A3rbRhm8nfYJ /eQ9uFQik5Oig== From: Jaegeuk Kim To: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Cc: Jaegeuk Kim Subject: [PATCH] f2fs: do not stop threads in irq context Date: Thu, 27 Oct 2022 11:04:16 -0700 Message-Id: <20221027180416.3786792-1-jaegeuk@kernel.org> X-Mailer: git-send-email 2.38.1.273.g43a17bfeac-goog MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Let's stop threads first to avoid irq context. Signed-off-by: Jaegeuk Kim --- fs/f2fs/super.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c index a241e4073f1d..14b4bb0f8ce6 100644 --- a/fs/f2fs/super.c +++ b/fs/f2fs/super.c @@ -3905,6 +3905,9 @@ static void f2fs_record_stop_reason(struct f2fs_sb_in= fo *sbi) struct f2fs_super_block *raw_super =3D F2FS_RAW_SUPER(sbi); int err; =20 + f2fs_stop_gc_thread(sbi); + f2fs_stop_discard_thread(sbi); + f2fs_down_write(&sbi->sb_lock); =20 spin_lock(&sbi->error_lock); @@ -4014,9 +4017,6 @@ void f2fs_handle_critical_error(struct f2fs_sb_info *= sbi, unsigned char reason, */ smp_wmb(); sb->s_flags |=3D SB_RDONLY; - - f2fs_stop_gc_thread(sbi); - f2fs_stop_discard_thread(sbi); } =20 static void flush_error_work(struct work_struct *work) --=20 2.38.1.273.g43a17bfeac-goog