From nobody Wed Apr 8 13:59:46 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BADE3C38A2D for ; Tue, 25 Oct 2022 19:13:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232237AbiJYTNx (ORCPT ); Tue, 25 Oct 2022 15:13:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53552 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229952AbiJYTNs (ORCPT ); Tue, 25 Oct 2022 15:13:48 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5E9E7BBE3F; Tue, 25 Oct 2022 12:13:48 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EF96761AFD; Tue, 25 Oct 2022 19:13:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 25457C433C1; Tue, 25 Oct 2022 19:13:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1666725227; bh=AdyKWW3kGsGFXnVfnmHp1ENXlUnPRsBFMxwcFLjmBrI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Hk/xayVVcKCpHaAzHXbaviYa6so4a/D3kV4UKD/14yg2QgkhwqQf3ZSwDlv7OWxsF pEQD2XT0EKxPtHgbfbjgznJNg5Zs/VwXrHjQnTC+Ntg+6aquFUqES3q0/xu136WYW+ GS0vljuz32rwaBQMR8l0AtbVomECjXfTx9q0DTYzf9sEZPU03P3xuzmkyKo1RLwuhv yoIHjwl8th4X0rnz3v4HlP9SXtu2Avyo3xoLciZl/3D+ZGy1LPzCHJK4XV/SwGIpYC sP1RusB8B8hLxUOqD0d8HCG8FM+GtbKw7SZU69lG/WXtsDy1KcOGKbcLCGjBTAmEa1 XZdx9Q4pyPyCQ== From: Bjorn Helgaas To: Lorenzo Pieralisi Cc: Rob Herring , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Bjorn Helgaas Subject: [PATCH 1/2] PCI: Drop of_match_ptr() to avoid unused variables Date: Tue, 25 Oct 2022 14:13:38 -0500 Message-Id: <20221025191339.667614-2-helgaas@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221025191339.667614-1-helgaas@kernel.org> References: <20221025191339.667614-1-helgaas@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Bjorn Helgaas We have stubs for most OF interfaces even when CONFIG_OF is not set, so we allow building of most controller drivers in that case for compile testing. When CONFIG_OF is not set, "of_match_ptr()" compiles to NULL, which leaves unused, resulting in errors like this: $ make W=3D1 drivers/pci/controller/pci-xgene.c:636:34: error: =E2=80=98xgene_pcie_mat= ch_table=E2=80=99 defined but not used [-Werror=3Dunused-const-variable=3D] Drop of_match_ptr() to avoid the unused variable warning. See also 1dff012f636d ("PCI: Drop of_match_ptr() to avoid unused variables"). Signed-off-by: Bjorn Helgaas --- drivers/pci/controller/pci-ftpci100.c | 2 +- drivers/pci/controller/pci-v3-semi.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pci/controller/pci-ftpci100.c b/drivers/pci/controller= /pci-ftpci100.c index 0cfd9d5a497c..ecd3009df586 100644 --- a/drivers/pci/controller/pci-ftpci100.c +++ b/drivers/pci/controller/pci-ftpci100.c @@ -553,7 +553,7 @@ static const struct of_device_id faraday_pci_of_match[]= =3D { static struct platform_driver faraday_pci_driver =3D { .driver =3D { .name =3D "ftpci100", - .of_match_table =3D of_match_ptr(faraday_pci_of_match), + .of_match_table =3D faraday_pci_of_match, .suppress_bind_attrs =3D true, }, .probe =3D faraday_pci_probe, diff --git a/drivers/pci/controller/pci-v3-semi.c b/drivers/pci/controller/= pci-v3-semi.c index 154a5398633c..d1f9ee4a1ede 100644 --- a/drivers/pci/controller/pci-v3-semi.c +++ b/drivers/pci/controller/pci-v3-semi.c @@ -902,7 +902,7 @@ static const struct of_device_id v3_pci_of_match[] =3D { static struct platform_driver v3_pci_driver =3D { .driver =3D { .name =3D "pci-v3-semi", - .of_match_table =3D of_match_ptr(v3_pci_of_match), + .of_match_table =3D v3_pci_of_match, .suppress_bind_attrs =3D true, }, .probe =3D v3_pci_probe, --=20 2.25.1