From nobody Wed Apr 8 08:01:02 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E2BDC67871 for ; Mon, 24 Oct 2022 23:42:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230229AbiJXXmK (ORCPT ); Mon, 24 Oct 2022 19:42:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36302 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230070AbiJXXlm (ORCPT ); Mon, 24 Oct 2022 19:41:42 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CE9D5192DB0; Mon, 24 Oct 2022 15:00:27 -0700 (PDT) Received: from notapiano.myfiosgateway.com (unknown [194.36.25.51]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by madras.collabora.co.uk (Postfix) with ESMTPSA id 049966602823; Mon, 24 Oct 2022 23:00:22 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1666648824; bh=d75fJH0ARJtURmP3T8+VteKCb9z0HW7yZAWSp5EIerU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Xpmnsd13nVFhEaTQPZgbYHf3o7odt8SGo6UH2G5nMif/BG2OP6Q1OwT/DwTGsOeqf ktD/4Ii4vd7yIqGQxhnGeWHjMNTDnNwoCQZGX4omRwq3yDjOVAJjqbOBF8UX42OglV UWuw43c/mVZ4NBEj9Zze6Of+cwucBjJRJjNFNBUR9FHifvMUAjkMWMEx7N0oTnYcvn OWkxToM4q9hyXtQxbIvNUr5zqpwWZH3RBwb14NoZSXtNnapaphsf9+FvHYqKu93+QU gehUqDGsjTwKNE9WmMGfSxpXVR6OSC8sF45tJ3URgg3iXwbluNkrJfUDD7bT1F/K3h 05dI1WgFuONXA== From: =?UTF-8?q?N=C3=ADcolas=20F=2E=20R=2E=20A=2E=20Prado?= To: Mark Brown Cc: AngeloGioacchino Del Regno , kernel@collabora.com, =?UTF-8?q?N=C3=ADcolas=20F=2E=20R=2E=20A=2E=20Prado?= , Derek Fang , Krzysztof Kozlowski , Liam Girdwood , Rob Herring , alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/4] ASoC: dt-bindings: realtek,rt5682s: Add #sound-dai-cells Date: Mon, 24 Oct 2022 18:00:12 -0400 Message-Id: <20221024220015.1759428-2-nfraprado@collabora.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221024220015.1759428-1-nfraprado@collabora.com> References: <20221024220015.1759428-1-nfraprado@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The rt5682s codec is a DAI provider with two interfaces - AIF1 and AIF2 - and therefore should have a #sound-dai-cells property that is equal to 1. Add it. Acked-by: Krzysztof Kozlowski Signed-off-by: N=C3=ADcolas F. R. A. Prado Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Chen-Yu Tsai --- Changes in v2: - Changed commit message - Changed value to 1 Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml b= /Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml index ca5b8987b749..1c0b06d82369 100644 --- a/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml +++ b/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml @@ -87,6 +87,9 @@ properties: maxItems: 2 description: Name given for DAI word clock and bit clock outputs. =20 + "#sound-dai-cells": + const: 1 + additionalProperties: false =20 required: --=20 2.38.1 From nobody Wed Apr 8 08:01:02 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46D5FC67871 for ; Mon, 24 Oct 2022 23:41:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229785AbiJXXlv (ORCPT ); Mon, 24 Oct 2022 19:41:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44382 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230199AbiJXXl3 (ORCPT ); Mon, 24 Oct 2022 19:41:29 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C6A3D29F13D; Mon, 24 Oct 2022 15:00:29 -0700 (PDT) Received: from notapiano.myfiosgateway.com (unknown [194.36.25.51]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by madras.collabora.co.uk (Postfix) with ESMTPSA id 6002A66026E6; Mon, 24 Oct 2022 23:00:25 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1666648827; bh=zH2yLaAyOCI8HWlnuIsMKt/wbk7W63NEAC2PrYHIQu4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hN3evVtjPXxYFgB91bDh1SQXIwQjNmNjTD5fUwYDtrR4pu3rNv3JwNveKdsTVHyp3 OCy+7bWb3wX07X4CFPH7gGcCL4rrSECV8UlZ4ko3si3GUMdPmuj6L084wCC5AlpP96 GHvxYvjMDleeoMN2Ay37cIOH14ngJukjKFHjqS96Ftm70UOjxG3y0aCmfMc0wugHFh 6GB0dI+/qqekdcQqGfiESiworEzu7X36uWPsLRr1YbS5KihfwA/rWpJt53ZASINSrl arQMfpSXATYqIhh/ncTeVb3bPythieLhBbc+tUEE5BzKLOtXgnLcGqoarhPdgiN++S LpES3IS0bGotg== From: =?UTF-8?q?N=C3=ADcolas=20F=2E=20R=2E=20A=2E=20Prado?= To: Mark Brown Cc: AngeloGioacchino Del Regno , kernel@collabora.com, =?UTF-8?q?N=C3=ADcolas=20F=2E=20R=2E=20A=2E=20Prado?= , Derek Fang , Krzysztof Kozlowski , Liam Girdwood , Rob Herring , alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 2/4] ASoC: dt-bindings: realtek,rt5682s: Add AVDD and MICVDD supplies Date: Mon, 24 Oct 2022 18:00:13 -0400 Message-Id: <20221024220015.1759428-3-nfraprado@collabora.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221024220015.1759428-1-nfraprado@collabora.com> References: <20221024220015.1759428-1-nfraprado@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The rt5682s codec can have two supplies: AVDD and MICVDD. They are already used by sc7180-trogdor-kingoftown.dtsi, so document them in the binding. Signed-off-by: N=C3=ADcolas F. R. A. Prado Acked-by: Krzysztof Kozlowski --- Changes in v2: - Added mention that property is already used in a DT to the commit message Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml b= /Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml index 1c0b06d82369..ac1dea5b4450 100644 --- a/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml +++ b/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml @@ -90,6 +90,10 @@ properties: "#sound-dai-cells": const: 1 =20 + AVDD-supply: true + + MICVDD-supply: true + additionalProperties: false =20 required: --=20 2.38.1 From nobody Wed Apr 8 08:01:02 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EE71C67871 for ; Mon, 24 Oct 2022 23:41:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229912AbiJXXl5 (ORCPT ); Mon, 24 Oct 2022 19:41:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53564 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229744AbiJXXlb (ORCPT ); Mon, 24 Oct 2022 19:41:31 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 58E9D2F70EF; Mon, 24 Oct 2022 15:00:32 -0700 (PDT) Received: from notapiano.myfiosgateway.com (unknown [194.36.25.51]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by madras.collabora.co.uk (Postfix) with ESMTPSA id C0E496602820; Mon, 24 Oct 2022 23:00:27 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1666648829; bh=yUOJmnlfdy5bC2kZgeZWbD0yF667HQA6aNkS15dlW6A=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GGQxoeeulNxtBsMzpjtPmZyyGa4mApgfpXJiUxsfMh8TjJFkSpE1FpW0wUBr6Xt69 3gZ3eY1j7ub80kQgEWBC//c94Ojomkwy0PVU7EunnRhexxGD5C68E3yef5fuLeG5+W srwyYfZg/MDqcf/2gs+731jRqJcm36f6Oe5mvY8Vj+4xATnTwllLTzUrmFRH1nhgZW /ayYlLCZnCnYFH/5rRLq/DuIf6ymFrcIX7SOLb5wcKmT7L1rsqsLZOp8GCkLqEqyNB pWfoMJYYX/XUuFsMt5mzA9BLAvt9JnDJkiM/AB07acH6xEKJ9fWEcKeIn+OGZ1rLwL 14iQFRP4iIGqQ== From: =?UTF-8?q?N=C3=ADcolas=20F=2E=20R=2E=20A=2E=20Prado?= To: Mark Brown Cc: AngeloGioacchino Del Regno , kernel@collabora.com, =?UTF-8?q?N=C3=ADcolas=20F=2E=20R=2E=20A=2E=20Prado?= , Krzysztof Kozlowski , Liam Girdwood , Rob Herring , alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 3/4] ASoC: dt-bindings: rt5682: Set sound-dai-cells to 1 Date: Mon, 24 Oct 2022 18:00:14 -0400 Message-Id: <20221024220015.1759428-4-nfraprado@collabora.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221024220015.1759428-1-nfraprado@collabora.com> References: <20221024220015.1759428-1-nfraprado@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit 0adccaf1eac9 ("ASoC: dt-bindings: rt5682: Add #sound-dai-cells") defined the sound-dai-cells property as 0. However, rt5682 has two DAIs, AIF1 and AIF2, and therefore should have sound-dai-cells set to 1. Fix it. Fixes: 0adccaf1eac9 ("ASoC: dt-bindings: rt5682: Add #sound-dai-cells") Signed-off-by: N=C3=ADcolas F. R. A. Prado Acked-by: Krzysztof Kozlowski Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Chen-Yu Tsai --- Changes in v2: - Added this commit Documentation/devicetree/bindings/sound/rt5682.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/sound/rt5682.txt b/Documenta= tion/devicetree/bindings/sound/rt5682.txt index c5f2b8febcee..6b87db68337c 100644 --- a/Documentation/devicetree/bindings/sound/rt5682.txt +++ b/Documentation/devicetree/bindings/sound/rt5682.txt @@ -46,7 +46,7 @@ Optional properties: =20 - realtek,dmic-clk-driving-high : Set the high driving of the DMIC clock o= ut. =20 -- #sound-dai-cells: Should be set to '<0>'. +- #sound-dai-cells: Should be set to '<1>'. =20 Pins on the device (for linking into audio routes) for RT5682: =20 --=20 2.38.1 From nobody Wed Apr 8 08:01:02 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC427C38A2D for ; Mon, 24 Oct 2022 23:42:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229685AbiJXXml (ORCPT ); Mon, 24 Oct 2022 19:42:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37224 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230383AbiJXXmN (ORCPT ); Mon, 24 Oct 2022 19:42:13 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C5F018541E; Mon, 24 Oct 2022 15:01:16 -0700 (PDT) Received: from notapiano.myfiosgateway.com (unknown [194.36.25.51]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by madras.collabora.co.uk (Postfix) with ESMTPSA id 09649660282D; Mon, 24 Oct 2022 23:00:29 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1666648831; bh=Cl6GfsphAxiCZ5E3D8HAUPBm74fyX9J6KcBotnOQmDA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ID3qXsFmihkJuT+GTXBzA5+5DC55otTvA1xCDJvqSYN6rB4jJkspdl773YLHV98sT Q8ommXuT/UfwNpHH2N/43mAyIh/NYP7yvEnu6HK/+o1Q7dOHlTVU4vkIVqsShm8xFi Wmbk67eDUYb/uO0sbBvMbiXFlmY2CdY/vwhE1lhU7j4JMz5Ovimt5Plu8psCiMe3kZ AvceS+K9Eqe6X7JCt5hY/86oLTaXjsJKBPXnKmhNx+zS2kDJzOZva1CZ/RFjlc78SC KPcvyfcCWuRbOhxu1MBuPnMFS0Hu827T5Zw8J87M5+mtj5oiapGqmtxg52+j4U4Bub nnYTwsN6eWEMA== From: =?UTF-8?q?N=C3=ADcolas=20F=2E=20R=2E=20A=2E=20Prado?= To: Mark Brown Cc: AngeloGioacchino Del Regno , kernel@collabora.com, =?UTF-8?q?N=C3=ADcolas=20F=2E=20R=2E=20A=2E=20Prado?= , Krzysztof Kozlowski , Liam Girdwood , Rob Herring , alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 4/4] ASoC: dt-bindings: rt5682: Add AVDD, MICVDD and VBAT supplies Date: Mon, 24 Oct 2022 18:00:15 -0400 Message-Id: <20221024220015.1759428-5-nfraprado@collabora.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221024220015.1759428-1-nfraprado@collabora.com> References: <20221024220015.1759428-1-nfraprado@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The rt5682 codec can have three supplies: AVDD, MICVDD and VBAT. They are already used by sc7180-trogdor.dtsi, so document them in the binding. Signed-off-by: N=C3=ADcolas F. R. A. Prado Acked-by: Krzysztof Kozlowski --- Changes in v2: - Added mention that property is already used in a DT to the commit message Documentation/devicetree/bindings/sound/rt5682.txt | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/Documentation/devicetree/bindings/sound/rt5682.txt b/Documenta= tion/devicetree/bindings/sound/rt5682.txt index 6b87db68337c..c07a1fc7b122 100644 --- a/Documentation/devicetree/bindings/sound/rt5682.txt +++ b/Documentation/devicetree/bindings/sound/rt5682.txt @@ -48,6 +48,12 @@ Optional properties: =20 - #sound-dai-cells: Should be set to '<1>'. =20 +- AVDD-supply: phandle to the regulator supplying AVDD + +- MICVDD-supply: phandle to the regulator supplying MICVDD + +- VBAT-supply: phandle to the regulator supplying VBAT + Pins on the device (for linking into audio routes) for RT5682: =20 * DMIC L1 --=20 2.38.1