From nobody Fri Dec 19 06:16:02 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30FA8FA373E for ; Mon, 24 Oct 2022 14:12:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231272AbiJXOMh (ORCPT ); Mon, 24 Oct 2022 10:12:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46324 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235862AbiJXOJU (ORCPT ); Mon, 24 Oct 2022 10:09:20 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 26D80C5101; Mon, 24 Oct 2022 05:51:23 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1424C612F3; Mon, 24 Oct 2022 12:51:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F3AA4C433D6; Mon, 24 Oct 2022 12:51:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666615877; bh=KpUOntgOBSl9iQrjVWZMtJsc9co7McfrbWqSjTYI6Fs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=o3tcI6xRDGCJuJ+GNVyXwguoam1gAUlStpDOXEBjcG28E7JEEN8dEky0xNoYm2aEB njngdeSA/afC8r3CkT7Pyx5Wm9U8gb0Dqd31x2p+L4x7NNYE1mPgtKvUHl6F1eQxTw w3hu+f755JinswXvg3sjz1zxPZ1q5emK/Lr7Mu+o= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jacob Keller , Tony Nguyen , Sasha Levin , Gurucharan Subject: [PATCH 5.15 417/530] ice: set tx_tstamps when creating new Tx rings via ethtool Date: Mon, 24 Oct 2022 13:32:41 +0200 Message-Id: <20221024113103.964838222@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221024113044.976326639@linuxfoundation.org> References: <20221024113044.976326639@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Jacob Keller [ Upstream commit b3b173745c8cab1e24d6821488b60abed3acb24d ] When the user changes the number of queues via ethtool, the driver allocates new rings. This allocation did not initialize tx_tstamps. This results in the tx_tstamps field being zero (due to kcalloc allocation), and would result in a NULL pointer dereference when attempting a transmit timestamp on the new ring. Signed-off-by: Jacob Keller Tested-by: Gurucharan (A Contingent worker at Int= el) Signed-off-by: Tony Nguyen Signed-off-by: Sasha Levin --- drivers/net/ethernet/intel/ice/ice_ethtool.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/intel/ice/ice_ethtool.c b/drivers/net/eth= ernet/intel/ice/ice_ethtool.c index 9b9c2b885486..f10d9c377c74 100644 --- a/drivers/net/ethernet/intel/ice/ice_ethtool.c +++ b/drivers/net/ethernet/intel/ice/ice_ethtool.c @@ -2788,6 +2788,7 @@ ice_set_ringparam(struct net_device *netdev, struct e= thtool_ringparam *ring) tx_rings[i].count =3D new_tx_cnt; tx_rings[i].desc =3D NULL; tx_rings[i].tx_buf =3D NULL; + tx_rings[i].tx_tstamps =3D &pf->ptp.port.tx; err =3D ice_setup_tx_ring(&tx_rings[i]); if (err) { while (i--) --=20 2.35.1