From nobody Wed Apr 8 06:29:21 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C70CC38A2D for ; Mon, 24 Oct 2022 08:50:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230437AbiJXIuA (ORCPT ); Mon, 24 Oct 2022 04:50:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36490 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230200AbiJXIt4 (ORCPT ); Mon, 24 Oct 2022 04:49:56 -0400 Received: from mail-oi1-x232.google.com (mail-oi1-x232.google.com [IPv6:2607:f8b0:4864:20::232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1E0F523167 for ; Mon, 24 Oct 2022 01:49:45 -0700 (PDT) Received: by mail-oi1-x232.google.com with SMTP id p127so10133390oih.9 for ; Mon, 24 Oct 2022 01:49:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dikvD5+bFGXRs81xXMLBNykCJfKHBwW8mLASTTcU7RI=; b=Eyb1XzP245evTp1QRz4N5vez7+pwTB8t0DRShOyMY8LQOTZrVNt36tLRMwwU3Vm1KJ mcEDAMNV3LTJzC3XHcK4KvzmLLg2Pem3T6vzJxdfK7b1Qu4mhtpHlh+c+lfDLO/GcpnU pJ6zUcoqq4Ed5pf7l3WrEXfbGurZHkcgMxXtfg1LPJ6SHp39C3erHSTEskXfxfn8lARA pyzPirhfCxKF3kplc2xAD4rgJoX8LpeMG1v+t15LegwG+q7Iau408lyfXqi0fswOzGpX 565KECnxNzF1mp0fgngifBUWFltsFatVYHI6/Yhh+o24eVXl616jqcUyNRNWG0BBguO7 QT4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dikvD5+bFGXRs81xXMLBNykCJfKHBwW8mLASTTcU7RI=; b=KvLOYsB+mjamaBKcF1rC5eKIq1wk9eGUgHFItSLUObaSSfZAp0lkvzSP8eojks3d/V V+Sa0jzGuVJZxsATTF7EwYjID7mnRQrJVwBEjCK0hQtG68xZlfhbmxqWk7wFIdyjip8j T0jqTDAhfqJS9/zgpv2NsLt2hQAaTNpfwwqlWa34ktodXSU7lr7UC9h4UYZRAmDyf4De yLVn5pGY6YRnr22xSuKDbQqLbTpt1IwN8ibuipPyDFBl2iElAnHSI2KC08seL9MBMmPg zkyaB0g+XlWnqF8//CIcJBA6OAN9vvuE9TrLlATkw9gqscfDBm+AJLJTy05mtJIS53lj +MgA== X-Gm-Message-State: ACrzQf1uOlsUcL+PVeuxRu/DGjfqbVPsT/UxaNbDq5Cq97pTEnhJs5dk 50Xr8Hmdc4myfQrHIwZeKfM7sDHLxOXG1cuw X-Google-Smtp-Source: AMsMyM4+1oC9yP2SuFdweGgP7rQZsd/xjzk/U2nzMAcrDmUkwtFQBY/825AEFbphUE6jPrYYkxOvyw== X-Received: by 2002:a17:90b:4c52:b0:20d:7917:4cb3 with SMTP id np18-20020a17090b4c5200b0020d79174cb3mr73052031pjb.6.1666601374768; Mon, 24 Oct 2022 01:49:34 -0700 (PDT) Received: from uftrace.. ([14.5.161.231]) by smtp.gmail.com with ESMTPSA id r2-20020a63a542000000b00434e1d3b2ecsm17245124pgu.79.2022.10.24.01.49.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Oct 2022 01:49:34 -0700 (PDT) From: Kang Minchul To: Larry Finger , Phillip Potter , Pavel Skripkin Cc: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Kang Minchul Subject: [PATCH v2 1/4] staging: r8188eu: remove unnecessary variable in ioctl_linux Date: Mon, 24 Oct 2022 17:49:22 +0900 Message-Id: <20221024084925.262289-2-tegongkang@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221024084925.262289-1-tegongkang@gmail.com> References: <20221024084925.262289-1-tegongkang@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Returning value 0 directly instead of storing it in variable ret. This commit can prevent cocci warning as follows: Unneeded variable: "ret". Return "0" on line 3030 Signed-off-by: Kang Minchul --- drivers/staging/r8188eu/os_dep/ioctl_linux.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/r8188eu/os_dep/ioctl_linux.c b/drivers/staging= /r8188eu/os_dep/ioctl_linux.c index 2de2e1e32738..5e1ad7733127 100644 --- a/drivers/staging/r8188eu/os_dep/ioctl_linux.c +++ b/drivers/staging/r8188eu/os_dep/ioctl_linux.c @@ -2979,8 +2979,6 @@ static int rtw_p2p_set(struct net_device *dev, struct iw_request_info *info, union iwreq_data *wrqu, char *extra) { - int ret =3D 0; - if (!memcmp(extra, "enable =3D", 7)) { rtw_wext_p2p_enable(dev, info, wrqu, &extra[7]); } else if (!memcmp(extra, "setDN =3D", 6)) { @@ -3027,7 +3025,7 @@ static int rtw_p2p_set(struct net_device *dev, rtw_p2p_set_persistent(dev, info, wrqu, &extra[11]); } =20 - return ret; + return 0; } =20 static int rtw_p2p_get2(struct net_device *dev, --=20 2.34.1 From nobody Wed Apr 8 06:29:21 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88A74ECDFA1 for ; Mon, 24 Oct 2022 08:49:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230213AbiJXItp (ORCPT ); Mon, 24 Oct 2022 04:49:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35100 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229716AbiJXItl (ORCPT ); Mon, 24 Oct 2022 04:49:41 -0400 Received: from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com [IPv6:2607:f8b0:4864:20::102f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 459F113DC4 for ; Mon, 24 Oct 2022 01:49:38 -0700 (PDT) Received: by mail-pj1-x102f.google.com with SMTP id h14so7617050pjv.4 for ; Mon, 24 Oct 2022 01:49:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=blmSZ/5kJFI3zeITciWHkokHSMBiiI5BLOjMr13YsbM=; b=iD20G/+v1fWUxk/brs0rDpv3A0OKoznryR8gJpQ2Ct1RWo4GGVYbhyXumEsi0qtzsD bu0avEXUYwBBOq078+q+NKFflJCxd3fIRQE141D+nojSgq6MMDUIPOpJGd8ndQmdkE+j sliQXQZnyHyaTM6NPFDG18Yk+qdkkL8wQiVzPv6kJywbOUYcl53N9MLEorH0zUcmClsc LktkWjzILnbKoVh7fjwQzv1zG8W/gOlymJ/awVLz6SvHkKt8Dk1TXNDm0J1I4sF4o5l2 68PCrolAVXSJqK9JuVHgJXxowqctXmXE4voyT0nIm1Z0ca+WcIQZyZQw77L4y4IY1DNI gRXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=blmSZ/5kJFI3zeITciWHkokHSMBiiI5BLOjMr13YsbM=; b=yVteaHSiKHGfgixvEpFybYxWHd+EsbxLtIhKrBOQRWzaRW6gB445LGScsB3IDgHWTH s7niF9q1wpSVqpMNStNU6Ac2w3Fz4E+GsIkYvMuCwClJg47Rxt+xFprVTIwgNfGcUrE6 l1r1CY5/mQD1wAn+zzzaGtFcsocFzzRad/GXmjJrfEpuUliY8bCfUpCrFv8m4ESPv2qb IJGETfCUTh415+/N0Bo+1fF/zzl9xUqkj1S4z+iv+viqE+65n6OLJKg80V6uplkBJtOo l935lb1+KFZdhIIEYEt9kRYBO7thT5gNvyxQGJUVRX2zuQ92Arj1oihNTt7MRJx4njlV wAFA== X-Gm-Message-State: ACrzQf0HZGJ8u+/1DrzEAUMA9/5nHBLIWY4Wb0wTE2zl13+B6kX50shJ nwuRpcxhGSC0h9WBDcxBTD0= X-Google-Smtp-Source: AMsMyM5aYq4JVmyu990he+dAyalPgz9Z6iKvjICG1HRHf+BjVQ5Rczv+OanEopUJ0OpP5ta9aAHkkg== X-Received: by 2002:a17:90b:3e8a:b0:20d:4632:e487 with SMTP id rj10-20020a17090b3e8a00b0020d4632e487mr37883228pjb.78.1666601377670; Mon, 24 Oct 2022 01:49:37 -0700 (PDT) Received: from uftrace.. ([14.5.161.231]) by smtp.gmail.com with ESMTPSA id r2-20020a63a542000000b00434e1d3b2ecsm17245124pgu.79.2022.10.24.01.49.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Oct 2022 01:49:37 -0700 (PDT) From: Kang Minchul To: Larry Finger , Phillip Potter , Pavel Skripkin Cc: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Kang Minchul Subject: [PATCH v2 2/4] staging: r8188eu: make amsdu_to_msdu void function Date: Mon, 24 Oct 2022 17:49:23 +0900 Message-Id: <20221024084925.262289-3-tegongkang@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221024084925.262289-1-tegongkang@gmail.com> References: <20221024084925.262289-1-tegongkang@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" This commit makes amsdu_to_msdu into void function in order to prevent cocci warning as follows: Unneeded variable: "ret". Return "_SUCCESS" on line 1516 Signed-off-by: Kang Minchul --- Changes since v1: * made function amsdu_to_msdu void drivers/staging/r8188eu/core/rtw_recv.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/staging/r8188eu/core/rtw_recv.c b/drivers/staging/r818= 8eu/core/rtw_recv.c index bb5c3b3888e0..a0d7cf08f933 100644 --- a/drivers/staging/r8188eu/core/rtw_recv.c +++ b/drivers/staging/r8188eu/core/rtw_recv.c @@ -1404,7 +1404,7 @@ struct recv_frame *recvframe_chk_defrag(struct adapte= r *padapter, struct recv_fr return prtnframe; } =20 -static int amsdu_to_msdu(struct adapter *padapter, struct recv_frame *prfr= ame) +static void amsdu_to_msdu(struct adapter *padapter, struct recv_frame *prf= rame) { int a_len, padding_len; u16 eth_type, nSubframe_Length; @@ -1415,7 +1415,6 @@ static int amsdu_to_msdu(struct adapter *padapter, st= ruct recv_frame *prframe) =20 struct recv_priv *precvpriv =3D &padapter->recvpriv; struct __queue *pfree_recv_queue =3D &precvpriv->free_recv_queue; - int ret =3D _SUCCESS; =20 nr_subframes =3D 0; =20 @@ -1512,8 +1511,6 @@ static int amsdu_to_msdu(struct adapter *padapter, st= ruct recv_frame *prframe) =20 prframe->len =3D 0; rtw_free_recvframe(prframe, pfree_recv_queue);/* free this recv_frame */ - - return ret; } =20 static bool check_indicate_seq(struct recv_reorder_ctrl *preorder_ctrl, u1= 6 seq_num) --=20 2.34.1 From nobody Wed Apr 8 06:29:21 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2BDBECDFA1 for ; Mon, 24 Oct 2022 08:49:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230016AbiJXItr (ORCPT ); Mon, 24 Oct 2022 04:49:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35234 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230315AbiJXItm (ORCPT ); Mon, 24 Oct 2022 04:49:42 -0400 Received: from mail-pl1-x62a.google.com (mail-pl1-x62a.google.com [IPv6:2607:f8b0:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8787119C20 for ; Mon, 24 Oct 2022 01:49:41 -0700 (PDT) Received: by mail-pl1-x62a.google.com with SMTP id jo13so4296960plb.13 for ; Mon, 24 Oct 2022 01:49:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=NnolCiMBjl8qX8ASTYaNnJALNGKZaQCXHfWumAnTsTM=; b=gm46cR8stv769f/3qrG5mY89pnjak1s16VZzjmmrodfvPJ0t1TxqRTEAzeUemmns9O zl49OqL3wnKxo6MhOV53Hnaq/lS0cldqq6ZxQdBjruuvkO52R4OZxw4caNmr3CXA0NAO uwLvJoeEtsXEvJjjeJCZ3RSf4ZW0i2GHnp38JwbWol8Ppeo9mPzeXdbFARvpOrUaCzR6 j2cpfxE4W97id6cWrjzpIafnfIR49aaRHOFXcQXVQ0xyIRJPAAHGZ3dX46E+gTSg2uFU h1vyQtrt5bfWPK6NlBlPC1XIILP4TFTWH/+DaN4nxJbOt+fvEdapGmM3rSxprpdyouFy Z/2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NnolCiMBjl8qX8ASTYaNnJALNGKZaQCXHfWumAnTsTM=; b=6C4hXNpNmVJoGiyrIN5mK+N6F3R2yo9t1k4tEHV/+UE+w/aEogAJM4SZQGVVwXshf3 9udjY67M4/a8r7bZmFzzWgw6zcyVRKkgUzGTdNS/TIuhduKFFClQOvR7FcCNkfr4pdJC NkLM+pj6QnNlcB5D5FXq9z6QEkE1cFbarvN3A5jqNYELdWnkJm+OL9cqHM4BqfoTe2W8 OHB7ZYnU3mbB211SWRfiRy3T6ief8cRWEltM/CkJPexbAqaimJBZIgtatFck9TyDl/pq dUUokNK2FFp3aI72/lCmS8Zt3nv2yN407Pt0KnimtgtPmkt3sB6N2yoxr+7LKwaWNAKb 0PSw== X-Gm-Message-State: ACrzQf3Frj2RuL0ldLR61xvfy1NMXWHfT+1i5mHqcl5YIaqcnWvwPVvL MTj1Rq5FZpm7Cz51AwaNoFw= X-Google-Smtp-Source: AMsMyM74znPayAddrI2+CSTk5wXaI+z62KCXc9qxsLsYFeyzdCfgZMKIK3SI+7qWwF4sMamU2Z/qhw== X-Received: by 2002:a17:90b:1804:b0:213:1a9c:5ae with SMTP id lw4-20020a17090b180400b002131a9c05aemr3094555pjb.81.1666601380700; Mon, 24 Oct 2022 01:49:40 -0700 (PDT) Received: from uftrace.. ([14.5.161.231]) by smtp.gmail.com with ESMTPSA id r2-20020a63a542000000b00434e1d3b2ecsm17245124pgu.79.2022.10.24.01.49.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Oct 2022 01:49:40 -0700 (PDT) From: Kang Minchul To: Larry Finger , Phillip Potter , Pavel Skripkin Cc: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Kang Minchul Subject: [PATCH v2 3/4] staging: r8188eu: remove unnecessary variable in rtl8188eu_xmit Date: Mon, 24 Oct 2022 17:49:24 +0900 Message-Id: <20221024084925.262289-4-tegongkang@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221024084925.262289-1-tegongkang@gmail.com> References: <20221024084925.262289-1-tegongkang@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Return 0 directly instead of storing it in a variable. This can prevent cocci warning as follows: Unneeded variable: "pull". Return "0" on line 298 Signed-off-by: Kang Minchul --- drivers/staging/r8188eu/hal/rtl8188eu_xmit.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/r8188eu/hal/rtl8188eu_xmit.c b/drivers/staging= /r8188eu/hal/rtl8188eu_xmit.c index 8e4a5acc0b18..6d1f56d1f9d7 100644 --- a/drivers/staging/r8188eu/hal/rtl8188eu_xmit.c +++ b/drivers/staging/r8188eu/hal/rtl8188eu_xmit.c @@ -149,7 +149,6 @@ static void fill_txdesc_phy(struct pkt_attrib *pattrib,= __le32 *pdw) =20 static s32 update_txdesc(struct xmit_frame *pxmitframe, u8 *pmem, s32 sz, = u8 bagg_pkt) { - int pull =3D 0; uint qsel; u8 data_rate, pwr_status, offset; struct adapter *adapt =3D pxmitframe->padapter; @@ -295,7 +294,7 @@ static s32 update_txdesc(struct xmit_frame *pxmitframe,= u8 *pmem, s32 sz, u8 bag ODM_SetTxAntByTxInfo_88E(&haldata->odmpriv, pmem, pattrib->mac_id); =20 rtl8188eu_cal_txdesc_chksum(ptxdesc); - return pull; + return 0; } =20 /* for non-agg data frame or management frame */ --=20 2.34.1 From nobody Wed Apr 8 06:29:21 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DB66ECDFA1 for ; Mon, 24 Oct 2022 08:49:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230427AbiJXItv (ORCPT ); Mon, 24 Oct 2022 04:49:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35682 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230204AbiJXItq (ORCPT ); Mon, 24 Oct 2022 04:49:46 -0400 Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [IPv6:2607:f8b0:4864:20::1034]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4F21F220ED for ; Mon, 24 Oct 2022 01:49:44 -0700 (PDT) Received: by mail-pj1-x1034.google.com with SMTP id i3-20020a17090a3d8300b00212cf2e2af9so7389762pjc.1 for ; Mon, 24 Oct 2022 01:49:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=QLIdpQp6TVzjpS8r5yHeQWkGEgLDOWAXXPd+wr6BFps=; b=NbR/+wMAJQsAS4ZCKdqO+slx+4imwFJZNzwyLXfJPz7S5F4F9AHmCKCAvC3992TKJX P2VXGagRVkNQeqtFAu6h6GthBQLnzJgNUWB0h56lDk7XG9kwO7rqtmaBdNZHPITemAUW KcBl2uajkOEBlYyKbmFR84ceoVP7ZG8RhljhE/ici8ifbk6yZ8uxZqXX+PlkVxS8s2Ol LLrP1D+kjozTtOCtb4AKBErS9WgINjkGJ91XSI6x3em6bzYruThflg9sLZmsWr+1kV7f xBiTCdrWAThidPtDmU9M4vnlzNuXk+/vdolKTJ0WRW3GP2DbJPATiM2fLgGviDcEfBNv lOWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QLIdpQp6TVzjpS8r5yHeQWkGEgLDOWAXXPd+wr6BFps=; b=wGEpp3bVw7/13jx/HvFdc6LGuJVORTpdRZqmQmFXQuFuSeNoUmxr7xbcVya/eBHQ9U dD1KRIpCeZ76ht27lkIHh5DJrW0hU8+bTk7T+54GdNnYluSnhaO0g2UX1pMhRQF93PsN flx52s8RhSuOA2N8Vj7X4ceEiPdjtDFkTuGaZmTenPgL4beTdeF5NH31kk1hVsaLU29J MK7rAzoOoYWdJMRSyNuxuZ9rVVNfEvLGZB7s4CFnNwXm2wOR12tu/WjhnH0PcjXsC0JD sx2HHDo0QQ/1XkfR6wlZ3n2x7Bbmd6og/g+V3IUc1TVnEQ/3Vk7DmbzBFsc8pH2Rds1x O8zA== X-Gm-Message-State: ACrzQf3ZrKAxPX1L+yg7G5kt5oxS9REg1XRXMfUMbQD88IsU3QztSrbG AtrIVds7GJ9+MhJApNOpgIg= X-Google-Smtp-Source: AMsMyM7ZLCkRXSidqosRcQ06v3NCGHk+w05g/OrqK02EJHcJm83MwhUE1n8FqFuDno4QHlKchkDGqQ== X-Received: by 2002:a17:902:8490:b0:186:a7f8:63b5 with SMTP id c16-20020a170902849000b00186a7f863b5mr4498076plo.57.1666601383534; Mon, 24 Oct 2022 01:49:43 -0700 (PDT) Received: from uftrace.. ([14.5.161.231]) by smtp.gmail.com with ESMTPSA id r2-20020a63a542000000b00434e1d3b2ecsm17245124pgu.79.2022.10.24.01.49.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Oct 2022 01:49:43 -0700 (PDT) From: Kang Minchul To: Larry Finger , Phillip Potter , Pavel Skripkin Cc: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Kang Minchul Subject: [PATCH v2 4/4] staging: r8188eu: remove unnecessary variable in rtw_ap Date: Mon, 24 Oct 2022 17:49:25 +0900 Message-Id: <20221024084925.262289-5-tegongkang@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221024084925.262289-1-tegongkang@gmail.com> References: <20221024084925.262289-1-tegongkang@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Return 0 directly instead of storing it in a variable. This can prevent cocci warning as follows: Unneeded variable: "ret". Return "0" on line 1031 Signed-off-by: Kang Minchul --- drivers/staging/r8188eu/core/rtw_ap.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/r8188eu/core/rtw_ap.c b/drivers/staging/r8188e= u/core/rtw_ap.c index 24eb8dce9bfe..9eaf345e6a00 100644 --- a/drivers/staging/r8188eu/core/rtw_ap.c +++ b/drivers/staging/r8188eu/core/rtw_ap.c @@ -1020,7 +1020,6 @@ u8 ap_free_sta(struct adapter *padapter, struct sta_i= nfo *psta, int rtw_sta_flush(struct adapter *padapter) { struct list_head *phead, *plist; - int ret =3D 0; struct sta_info *psta =3D NULL; struct sta_priv *pstapriv =3D &padapter->stapriv; struct mlme_ext_priv *pmlmeext =3D &padapter->mlmeextpriv; @@ -1028,7 +1027,7 @@ int rtw_sta_flush(struct adapter *padapter) u8 bc_addr[ETH_ALEN] =3D {0xff, 0xff, 0xff, 0xff, 0xff, 0xff}; =20 if ((pmlmeinfo->state & 0x03) !=3D WIFI_FW_AP_STATE) - return ret; + return 0; =20 spin_lock_bh(&pstapriv->asoc_list_lock); phead =3D &pstapriv->asoc_list; @@ -1051,7 +1050,7 @@ int rtw_sta_flush(struct adapter *padapter) =20 associated_clients_update(padapter, true); =20 - return ret; + return 0; } =20 /* called > TSR LEVEL for USB or SDIO Interface*/ --=20 2.34.1