From nobody Sat Feb 7 13:02:57 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30A17C3A59D for ; Sat, 22 Oct 2022 07:55:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232096AbiJVHyC (ORCPT ); Sat, 22 Oct 2022 03:54:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56530 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231980AbiJVHvu (ORCPT ); Sat, 22 Oct 2022 03:51:50 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 626F3AC299; Sat, 22 Oct 2022 00:46:35 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 4CE6EB82E29; Sat, 22 Oct 2022 07:45:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9132AC433D7; Sat, 22 Oct 2022 07:45:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666424735; bh=4WtSWs0+NqxbJeJz/1Xlp9+z0YYStOt8rbByNslallE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QpTDnVYPT3SmCaBETY2mrYyBfDSg+YAW5xOfiaQ2PVUGwSjN0PV4GrtVPHqZZXnJL bCjBUdo3cIfhMv3qMymqO+NJMZ5J0bSz3ubFtkSlJ7NKwPOam/BYAHeQBG2ZjViJbp Oy+DrPWBBDSyVD4RC76bu60IH44GL+t/KmFb648Y= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Florian Westphal , Antoine Tenart , Sasha Levin Subject: [PATCH 5.19 256/717] netfilter: conntrack: fix the gc rescheduling delay Date: Sat, 22 Oct 2022 09:22:15 +0200 Message-Id: <20221022072500.034465258@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221022072415.034382448@linuxfoundation.org> References: <20221022072415.034382448@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Antoine Tenart [ Upstream commit 95eabdd207024312876d0ebed90b4c977e050e85 ] Commit 2cfadb761d3d ("netfilter: conntrack: revisit gc autotuning") changed the eviction rescheduling to the use average expiry of scanned entries (within 1-60s) by doing: for (...) { expires =3D clamp(nf_ct_expires(tmp), ...); next_run +=3D expires; next_run /=3D 2; } The issue is the above will make the average ('next_run' here) more dependent on the last expiration values than the firsts (for sets > 2). Depending on the expiration values used to compute the average, the result can be quite different than what's expected. To fix this we can do the following: for (...) { expires =3D clamp(nf_ct_expires(tmp), ...); next_run +=3D (expires - next_run) / ++count; } Fixes: 2cfadb761d3d ("netfilter: conntrack: revisit gc autotuning") Cc: Florian Westphal Signed-off-by: Antoine Tenart Signed-off-by: Florian Westphal Signed-off-by: Sasha Levin --- net/netfilter/nf_conntrack_core.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/net/netfilter/nf_conntrack_core.c b/net/netfilter/nf_conntrack= _core.c index 369aeabb94fe..6fdbffc85222 100644 --- a/net/netfilter/nf_conntrack_core.c +++ b/net/netfilter/nf_conntrack_core.c @@ -67,6 +67,7 @@ struct conntrack_gc_work { struct delayed_work dwork; u32 next_bucket; u32 avg_timeout; + u32 count; u32 start_time; bool exiting; bool early_drop; @@ -1468,6 +1469,7 @@ static void gc_worker(struct work_struct *work) unsigned int expired_count =3D 0; unsigned long next_run; s32 delta_time; + long count; =20 gc_work =3D container_of(work, struct conntrack_gc_work, dwork.work); =20 @@ -1477,10 +1479,12 @@ static void gc_worker(struct work_struct *work) =20 if (i =3D=3D 0) { gc_work->avg_timeout =3D GC_SCAN_INTERVAL_INIT; + gc_work->count =3D 1; gc_work->start_time =3D start_time; } =20 next_run =3D gc_work->avg_timeout; + count =3D gc_work->count; =20 end_time =3D start_time + GC_SCAN_MAX_DURATION; =20 @@ -1500,8 +1504,8 @@ static void gc_worker(struct work_struct *work) =20 hlist_nulls_for_each_entry_rcu(h, n, &ct_hash[i], hnnode) { struct nf_conntrack_net *cnet; - unsigned long expires; struct net *net; + long expires; =20 tmp =3D nf_ct_tuplehash_to_ctrack(h); =20 @@ -1515,6 +1519,7 @@ static void gc_worker(struct work_struct *work) =20 gc_work->next_bucket =3D i; gc_work->avg_timeout =3D next_run; + gc_work->count =3D count; =20 delta_time =3D nfct_time_stamp - gc_work->start_time; =20 @@ -1530,8 +1535,8 @@ static void gc_worker(struct work_struct *work) } =20 expires =3D clamp(nf_ct_expires(tmp), GC_SCAN_INTERVAL_MIN, GC_SCAN_INT= ERVAL_CLAMP); + expires =3D (expires - (long)next_run) / ++count; next_run +=3D expires; - next_run /=3D 2u; =20 if (nf_conntrack_max95 =3D=3D 0 || gc_worker_skip_ct(tmp)) continue; @@ -1572,6 +1577,7 @@ static void gc_worker(struct work_struct *work) delta_time =3D nfct_time_stamp - end_time; if (delta_time > 0 && i < hashsz) { gc_work->avg_timeout =3D next_run; + gc_work->count =3D count; gc_work->next_bucket =3D i; next_run =3D 0; goto early_exit; --=20 2.35.1