From nobody Wed Apr 8 03:24:17 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BAEFC433FE for ; Fri, 21 Oct 2022 16:50:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230358AbiJUQum (ORCPT ); Fri, 21 Oct 2022 12:50:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41946 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229867AbiJUQuV (ORCPT ); Fri, 21 Oct 2022 12:50:21 -0400 Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F2472247E1D; Fri, 21 Oct 2022 09:50:16 -0700 (PDT) Received: by mail-ed1-x52b.google.com with SMTP id t16so8118816edd.2; Fri, 21 Oct 2022 09:50:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=k7Y+/ddtJyLJ3y+Tsy2pWfsNMuVl2yzDPLL4Knpi5uQ=; b=JmR6uqmrN8Zk9EGQSPo9yTgif7RPsu0jbccyDDVVqODFTNKicFsGDxRFa0Wjy27em7 3dpc8lFlDhmBZuoiU3Kk3/Buvwl73Nq2iRVI8829rWrjPKMzc6KpC5hppZgcfGogHpY5 fuRHYL1S9+U/zcvN34WLJN0AsSUfJLs3RLfjMo2jmRhqMdZ9t7KKtZUJMQtXFq6fHV4o klaoBnf8yaVEfbrow3fX39Ztd+UomzbbFCd353vR7CiXlu4qcxNrX5mplW94ZgCtUS+T 5xgTG5QjNKqPCnoLHwGP4zwgpm8g7mS4H5fyyr4PVXypRX2d9rFzGPUJm9pRPhfY6ifI zvZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=k7Y+/ddtJyLJ3y+Tsy2pWfsNMuVl2yzDPLL4Knpi5uQ=; b=nYt/xOuWNS4XNpaJSOgpA1hECqviDUPb91/Pc4UK9Cq2atfEq8Qvw4n+nlMKIxIM54 vqfyGvK7VHk2FTJQlt5r2xk+1v+j29C7fK9XM0W9vC5MAdPD/MXy77oy48wNhZAoP162 d7v7qfY/uyw3qewmtdjuc/0uYryuPgOOX6FWKU/WpKkiqlKyKMJyYjNQooMwmBxHhOkA Ocs9YtL29lpXy7GwM4EFQUDkbxjH6/Hnx+BVs8nOSOTdfFfGgMdpCjDsw0zTIHld1Rq1 FS378AuLu8awqlkKCQqQUp/Zw794yA0m5aqVtdaq3lLQqyD7YIlUqOz6civxSZt4dD5N +uiQ== X-Gm-Message-State: ACrzQf3jf+N/mFXtVPJD7P7QvrzV4qqeI4s7afom8L9CYTVzXu67AcDl 1yQdNR6SVnPAlyDcadjh6w2bDf7sm3o= X-Google-Smtp-Source: AMsMyM7PEbB5sDis0Y+27YOf+g8iO7Gyj4F+7+fFzUCdfbUx1vW4WpdsvPIz4kgK9QLZiviWRrH6hQ== X-Received: by 2002:a17:907:7203:b0:792:56d7:2851 with SMTP id dr3-20020a170907720300b0079256d72851mr12035419ejc.268.1666371015000; Fri, 21 Oct 2022 09:50:15 -0700 (PDT) Received: from localhost.localdomain (dynamic-2a01-0c22-7b0b-4500-0000-0000-0000-0e63.c22.pool.telefonica.de. [2a01:c22:7b0b:4500::e63]) by smtp.googlemail.com with ESMTPSA id l23-20020aa7d957000000b0044ef2ac2650sm13725331eds.90.2022.10.21.09.50.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Oct 2022 09:50:14 -0700 (PDT) From: Martin Blumenstingl To: linux@roeck-us.net, linux-hwmon@vger.kernel.org Cc: jdelvare@suse.com, linux-kernel@vger.kernel.org, Martin Blumenstingl Subject: [PATCH v3 1/2] hwmon: (jc42) Convert register access and caching to regmap/regcache Date: Fri, 21 Oct 2022 18:49:59 +0200 Message-Id: <20221021165000.1865615-2-martin.blumenstingl@googlemail.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221021165000.1865615-1-martin.blumenstingl@googlemail.com> References: <20221021165000.1865615-1-martin.blumenstingl@googlemail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Switch the jc42 driver to use an I2C regmap to access the registers. Also move over to regmap's built-in caching instead of adding a custom caching implementation. This works for JC42_REG_TEMP_UPPER, JC42_REG_TEMP_LOWER and JC42_REG_TEMP_CRITICAL as these values never change except when explicitly written. The cache For JC42_REG_TEMP is dropped (regmap can't cache it because it's volatile, meaning it can change at any time) as well for simplicity and consistency with other drivers. Signed-off-by: Martin Blumenstingl --- drivers/hwmon/Kconfig | 1 + drivers/hwmon/jc42.c | 214 +++++++++++++++++++++++------------------- 2 files changed, 116 insertions(+), 99 deletions(-) diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig index 7ac3daaf59ce..d3bccc8176c5 100644 --- a/drivers/hwmon/Kconfig +++ b/drivers/hwmon/Kconfig @@ -799,6 +799,7 @@ config SENSORS_IT87 config SENSORS_JC42 tristate "JEDEC JC42.4 compliant memory module temperature sensors" depends on I2C + select REGMAP_I2C help If you say yes here, you get support for JEDEC JC42.4 compliant temperature sensors, which are used on many DDR3 memory modules for diff --git a/drivers/hwmon/jc42.c b/drivers/hwmon/jc42.c index 30888feaf589..8d70960d5444 100644 --- a/drivers/hwmon/jc42.c +++ b/drivers/hwmon/jc42.c @@ -19,6 +19,7 @@ #include #include #include +#include =20 /* Addresses to scan */ static const unsigned short normal_i2c[] =3D { @@ -199,31 +200,13 @@ static struct jc42_chips jc42_chips[] =3D { { STM_MANID, STTS3000_DEVID, STTS3000_DEVID_MASK }, }; =20 -enum temp_index { - t_input =3D 0, - t_crit, - t_min, - t_max, - t_num_temp -}; - -static const u8 temp_regs[t_num_temp] =3D { - [t_input] =3D JC42_REG_TEMP, - [t_crit] =3D JC42_REG_TEMP_CRITICAL, - [t_min] =3D JC42_REG_TEMP_LOWER, - [t_max] =3D JC42_REG_TEMP_UPPER, -}; - /* Each client has this additional data */ struct jc42_data { - struct i2c_client *client; - struct mutex update_lock; /* protect register access */ + struct regmap *regmap; bool extended; /* true if extended range supported */ bool valid; - unsigned long last_updated; /* In jiffies */ u16 orig_config; /* original configuration */ u16 config; /* current configuration */ - u16 temp[t_num_temp];/* Temperatures */ }; =20 #define JC42_TEMP_MIN_EXTENDED (-40000) @@ -248,74 +231,84 @@ static int jc42_temp_from_reg(s16 reg) return reg * 125 / 2; } =20 -static struct jc42_data *jc42_update_device(struct device *dev) -{ - struct jc42_data *data =3D dev_get_drvdata(dev); - struct i2c_client *client =3D data->client; - struct jc42_data *ret =3D data; - int i, val; - - mutex_lock(&data->update_lock); - - if (time_after(jiffies, data->last_updated + HZ) || !data->valid) { - for (i =3D 0; i < t_num_temp; i++) { - val =3D i2c_smbus_read_word_swapped(client, temp_regs[i]); - if (val < 0) { - ret =3D ERR_PTR(val); - goto abort; - } - data->temp[i] =3D val; - } - data->last_updated =3D jiffies; - data->valid =3D true; - } -abort: - mutex_unlock(&data->update_lock); - return ret; -} - static int jc42_read(struct device *dev, enum hwmon_sensor_types type, u32 attr, int channel, long *val) { - struct jc42_data *data =3D jc42_update_device(dev); - int temp, hyst; - - if (IS_ERR(data)) - return PTR_ERR(data); + struct jc42_data *data =3D dev_get_drvdata(dev); + unsigned int regval; + int ret, temp, hyst; =20 switch (attr) { case hwmon_temp_input: - *val =3D jc42_temp_from_reg(data->temp[t_input]); + ret =3D regmap_read(data->regmap, JC42_REG_TEMP, ®val); + if (ret) + return ret; + + *val =3D jc42_temp_from_reg(regval); return 0; case hwmon_temp_min: - *val =3D jc42_temp_from_reg(data->temp[t_min]); + ret =3D regmap_read(data->regmap, JC42_REG_TEMP_LOWER, ®val); + if (ret) + return ret; + + *val =3D jc42_temp_from_reg(regval); return 0; case hwmon_temp_max: - *val =3D jc42_temp_from_reg(data->temp[t_max]); + ret =3D regmap_read(data->regmap, JC42_REG_TEMP_UPPER, ®val); + if (ret) + return ret; + + *val =3D jc42_temp_from_reg(regval); return 0; case hwmon_temp_crit: - *val =3D jc42_temp_from_reg(data->temp[t_crit]); + ret =3D regmap_read(data->regmap, JC42_REG_TEMP_CRITICAL, + ®val); + if (ret) + return ret; + + *val =3D jc42_temp_from_reg(regval); return 0; case hwmon_temp_max_hyst: - temp =3D jc42_temp_from_reg(data->temp[t_max]); + ret =3D regmap_read(data->regmap, JC42_REG_TEMP_UPPER, ®val); + if (ret) + return ret; + + temp =3D jc42_temp_from_reg(regval); hyst =3D jc42_hysteresis[(data->config & JC42_CFG_HYST_MASK) >> JC42_CFG_HYST_SHIFT]; *val =3D temp - hyst; return 0; case hwmon_temp_crit_hyst: - temp =3D jc42_temp_from_reg(data->temp[t_crit]); + ret =3D regmap_read(data->regmap, JC42_REG_TEMP_CRITICAL, + ®val); + if (ret) + return ret; + + temp =3D jc42_temp_from_reg(regval); hyst =3D jc42_hysteresis[(data->config & JC42_CFG_HYST_MASK) >> JC42_CFG_HYST_SHIFT]; *val =3D temp - hyst; return 0; case hwmon_temp_min_alarm: - *val =3D (data->temp[t_input] >> JC42_ALARM_MIN_BIT) & 1; + ret =3D regmap_read(data->regmap, JC42_REG_TEMP, ®val); + if (ret) + return ret; + + *val =3D (regval >> JC42_ALARM_MIN_BIT) & 1; return 0; case hwmon_temp_max_alarm: - *val =3D (data->temp[t_input] >> JC42_ALARM_MAX_BIT) & 1; + ret =3D regmap_read(data->regmap, JC42_REG_TEMP, ®val); + if (ret) + return ret; + + *val =3D (regval >> JC42_ALARM_MAX_BIT) & 1; return 0; case hwmon_temp_crit_alarm: - *val =3D (data->temp[t_input] >> JC42_ALARM_CRIT_BIT) & 1; + ret =3D regmap_read(data->regmap, JC42_REG_TEMP, ®val); + if (ret) + return ret; + + *val =3D (regval >> JC42_ALARM_CRIT_BIT) & 1; return 0; default: return -EOPNOTSUPP; @@ -326,29 +319,29 @@ static int jc42_write(struct device *dev, enum hwmon_= sensor_types type, u32 attr, int channel, long val) { struct jc42_data *data =3D dev_get_drvdata(dev); - struct i2c_client *client =3D data->client; + unsigned int regval; int diff, hyst; int ret; =20 - mutex_lock(&data->update_lock); - switch (attr) { case hwmon_temp_min: - data->temp[t_min] =3D jc42_temp_to_reg(val, data->extended); - ret =3D i2c_smbus_write_word_swapped(client, temp_regs[t_min], - data->temp[t_min]); + ret =3D regmap_write(data->regmap, JC42_REG_TEMP_LOWER, + jc42_temp_to_reg(val, data->extended)); break; case hwmon_temp_max: - data->temp[t_max] =3D jc42_temp_to_reg(val, data->extended); - ret =3D i2c_smbus_write_word_swapped(client, temp_regs[t_max], - data->temp[t_max]); + ret =3D regmap_write(data->regmap, JC42_REG_TEMP_UPPER, + jc42_temp_to_reg(val, data->extended)); break; case hwmon_temp_crit: - data->temp[t_crit] =3D jc42_temp_to_reg(val, data->extended); - ret =3D i2c_smbus_write_word_swapped(client, temp_regs[t_crit], - data->temp[t_crit]); + ret =3D regmap_write(data->regmap, JC42_REG_TEMP_CRITICAL, + jc42_temp_to_reg(val, data->extended)); break; case hwmon_temp_crit_hyst: + ret =3D regmap_read(data->regmap, JC42_REG_TEMP_CRITICAL, + ®val); + if (ret) + return ret; + /* * JC42.4 compliant chips only support four hysteresis values. * Pick best choice and go from there. @@ -356,7 +349,7 @@ static int jc42_write(struct device *dev, enum hwmon_se= nsor_types type, val =3D clamp_val(val, (data->extended ? JC42_TEMP_MIN_EXTENDED : JC42_TEMP_MIN) - 6000, JC42_TEMP_MAX); - diff =3D jc42_temp_from_reg(data->temp[t_crit]) - val; + diff =3D jc42_temp_from_reg(regval) - val; hyst =3D 0; if (diff > 0) { if (diff < 2250) @@ -368,17 +361,14 @@ static int jc42_write(struct device *dev, enum hwmon_= sensor_types type, } data->config =3D (data->config & ~JC42_CFG_HYST_MASK) | (hyst << JC42_CFG_HYST_SHIFT); - ret =3D i2c_smbus_write_word_swapped(data->client, - JC42_REG_CONFIG, - data->config); + ret =3D regmap_write(data->regmap, JC42_REG_CONFIG, + data->config); break; default: ret =3D -EOPNOTSUPP; break; } =20 - mutex_unlock(&data->update_lock); - return ret; } =20 @@ -470,51 +460,79 @@ static const struct hwmon_chip_info jc42_chip_info = =3D { .info =3D jc42_info, }; =20 +static bool jc42_readable_reg(struct device *dev, unsigned int reg) +{ + return (reg >=3D JC42_REG_CAP && reg <=3D JC42_REG_DEVICEID) || + reg =3D=3D JC42_REG_SMBUS; +} + +static bool jc42_writable_reg(struct device *dev, unsigned int reg) +{ + return (reg >=3D JC42_REG_CONFIG && reg <=3D JC42_REG_TEMP_CRITICAL) || + reg =3D=3D JC42_REG_SMBUS; +} + +static bool jc42_volatile_reg(struct device *dev, unsigned int reg) +{ + return reg =3D=3D JC42_REG_CONFIG || reg =3D=3D JC42_REG_TEMP; +} + +static const struct regmap_config jc42_regmap_config =3D { + .reg_bits =3D 8, + .val_bits =3D 16, + .val_format_endian =3D REGMAP_ENDIAN_BIG, + .max_register =3D JC42_REG_SMBUS, + .writeable_reg =3D jc42_writable_reg, + .readable_reg =3D jc42_readable_reg, + .volatile_reg =3D jc42_volatile_reg, + .cache_type =3D REGCACHE_RBTREE, +}; + static int jc42_probe(struct i2c_client *client) { struct device *dev =3D &client->dev; struct device *hwmon_dev; + unsigned int config, cap; struct jc42_data *data; - int config, cap; + int ret; =20 data =3D devm_kzalloc(dev, sizeof(struct jc42_data), GFP_KERNEL); if (!data) return -ENOMEM; =20 - data->client =3D client; + data->regmap =3D devm_regmap_init_i2c(client, &jc42_regmap_config); + if (IS_ERR(data->regmap)) + return PTR_ERR(data->regmap); + i2c_set_clientdata(client, data); - mutex_init(&data->update_lock); =20 - cap =3D i2c_smbus_read_word_swapped(client, JC42_REG_CAP); - if (cap < 0) - return cap; + ret =3D regmap_read(data->regmap, JC42_REG_CAP, &cap); + if (ret) + return ret; =20 data->extended =3D !!(cap & JC42_CAP_RANGE); =20 if (device_property_read_bool(dev, "smbus-timeout-disable")) { - int smbus; - /* * Not all chips support this register, but from a * quick read of various datasheets no chip appears * incompatible with the below attempt to disable * the timeout. And the whole thing is opt-in... */ - smbus =3D i2c_smbus_read_word_swapped(client, JC42_REG_SMBUS); - if (smbus < 0) - return smbus; - i2c_smbus_write_word_swapped(client, JC42_REG_SMBUS, - smbus | SMBUS_STMOUT); + ret =3D regmap_set_bits(data->regmap, JC42_REG_SMBUS, + SMBUS_STMOUT); + if (ret) + return ret; } =20 - config =3D i2c_smbus_read_word_swapped(client, JC42_REG_CONFIG); - if (config < 0) - return config; + ret =3D regmap_read(data->regmap, JC42_REG_CONFIG, &config); + if (ret) + return ret; =20 data->orig_config =3D config; if (config & JC42_CFG_SHUTDOWN) { config &=3D ~JC42_CFG_SHUTDOWN; - i2c_smbus_write_word_swapped(client, JC42_REG_CONFIG, config); + regmap_write(data->regmap, JC42_REG_CONFIG, config); } data->config =3D config; =20 @@ -535,7 +553,7 @@ static void jc42_remove(struct i2c_client *client) =20 config =3D (data->orig_config & ~JC42_CFG_HYST_MASK) | (data->config & JC42_CFG_HYST_MASK); - i2c_smbus_write_word_swapped(client, JC42_REG_CONFIG, config); + regmap_write(data->regmap, JC42_REG_CONFIG, config); } } =20 @@ -546,8 +564,7 @@ static int jc42_suspend(struct device *dev) struct jc42_data *data =3D dev_get_drvdata(dev); =20 data->config |=3D JC42_CFG_SHUTDOWN; - i2c_smbus_write_word_swapped(data->client, JC42_REG_CONFIG, - data->config); + regmap_write(data->regmap, JC42_REG_CONFIG, data->config); return 0; } =20 @@ -556,8 +573,7 @@ static int jc42_resume(struct device *dev) struct jc42_data *data =3D dev_get_drvdata(dev); =20 data->config &=3D ~JC42_CFG_SHUTDOWN; - i2c_smbus_write_word_swapped(data->client, JC42_REG_CONFIG, - data->config); + regmap_write(data->regmap, JC42_REG_CONFIG, data->config); return 0; } =20 --=20 2.38.1