From nobody Wed Apr 8 01:34:11 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7ADDFC4332F for ; Fri, 21 Oct 2022 13:52:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230235AbiJUNwl (ORCPT ); Fri, 21 Oct 2022 09:52:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54832 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230022AbiJUNwj (ORCPT ); Fri, 21 Oct 2022 09:52:39 -0400 Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7C73F2770A3 for ; Fri, 21 Oct 2022 06:52:37 -0700 (PDT) Received: by mail-wr1-x429.google.com with SMTP id b4so4999771wrs.1 for ; Fri, 21 Oct 2022 06:52:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=5O7PA/UB0OdXE7dXrXIrsXAZW/RFj0PvgjoW5rSjTWQ=; b=f6xY4wXmsxFdeCWN8Gt+tP/hipqP0SEBlgwLm4amn3uZ8snNJv2Hw9gi3xCWG3caOD V6vhB3WpxQDiROMGVjzxKAJ1U4C/4pQ7AZOW64SX2pyiWqSarDU2Se4zbX4n6tfm4o6h 4JBZyxe6wdalJqNg/zSpjVp/dNuOA4npYZI1Ogxd3q5Fva+KOH9Ey+eKuOv4avA5HLaA Eus1LnXOClGGQjxoYVgpYngMdAaH/RJ5g1JpBVANuOH4g9qQEw879kCg5cp1Xj8gAy0R cs5f8pnfSqg8Uu1r98E0THB4lHg+AKmwOGGf02mbCm1+tiwZZZiL3JbxIawf27Ez/VqM FFag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5O7PA/UB0OdXE7dXrXIrsXAZW/RFj0PvgjoW5rSjTWQ=; b=NUF3/V+CJtpd9w3nWf2QzExF9mrkhC3exiuwrirASOlZrpJSKM+GWDM7heRcYFxbkC ESz6uT/b7buQQnmJcwfmcQBRsZmQNSLZswcfkZFsaZiOpgGx23h+iebbdiiR825ZxdJI 6IEUazON0S0YGZc054fEcP3J9mwxUJkqJj+XpzLEQOSvS6g9piD1Up+pTdZGfCSMr3Lj h/OEHrwyQ5Ut2rjjJ+2TYsLujCjeqDHKZD2tgzvof49qPqwU/tLOZ8d1Muz3s/rLq1Ia HWEh7OzBPqkPyHxGvdCiHr6Z6xqSi2+viaDvVl2Ux0YJkZelLatcd6Mr5w6n2CyUIsWe pNiQ== X-Gm-Message-State: ACrzQf0EzBlwCRtS3+hUuWXLsp5jLJxRWMhNDibFxX2qqIa3PMckxLuA RVzBIvtWNG1F6JmwurIIgro= X-Google-Smtp-Source: AMsMyM5QMeNQ/E5TkuLkq423LPgBKWzCOhRuxDXIQgm+SLKf2/XYgljrkVNyLjiR5ZqfXCEtNohRyQ== X-Received: by 2002:a05:6000:2c4:b0:231:1b8:154 with SMTP id o4-20020a05600002c400b0023101b80154mr13343553wry.378.1666360356003; Fri, 21 Oct 2022 06:52:36 -0700 (PDT) Received: from localhost.localdomain ([117.102.55.205]) by smtp.gmail.com with ESMTPSA id z6-20020a05600c0a0600b003c6b7f55673sm3720138wmp.2.2022.10.21.06.52.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Oct 2022 06:52:35 -0700 (PDT) From: Osama Muhammad To: samuel.thibault@ens-lyon.org Cc: gregkh@linuxfoundation.org, speakup@linux-speakup.org, linux-kernel@vger.kernel.org, okash.khawaja@gmail.com, Osama Muhammad Subject: [PATCH] Accessiblity: speakup_apollo: specifying the default driver parameters among the module params Date: Fri, 21 Oct 2022 18:52:16 +0500 Message-Id: <20221021135216.249406-1-osmtendev@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" This is an enhancement which allows to specify the default driver parameters among the module parameters. Adding default variables to the speakup_apollo module allows to easily set that at boot, rather than setting the sys variables after boot. More details can be found here: https://github.com/linux-speakup/speakup/issues/7 Signed-off-by: Osama Muhammad Reviewed-by: Samuel Thibault --- .../accessibility/speakup/speakup_apollo.c | 46 +++++++++++++++---- 1 file changed, 37 insertions(+), 9 deletions(-) diff --git a/drivers/accessibility/speakup/speakup_apollo.c b/drivers/acces= sibility/speakup/speakup_apollo.c index c84a7e0864b7..d2fbb3f57221 100644 --- a/drivers/accessibility/speakup/speakup_apollo.c +++ b/drivers/accessibility/speakup/speakup_apollo.c @@ -24,15 +24,28 @@ =20 static void do_catch_up(struct spk_synth *synth); =20 -static struct var_t vars[] =3D { - { CAPS_START, .u.s =3D {"cap, " } }, - { CAPS_STOP, .u.s =3D {"" } }, - { RATE, .u.n =3D {"@W%d", 6, 1, 9, 0, 0, NULL } }, - { PITCH, .u.n =3D {"@F%x", 10, 0, 15, 0, 0, NULL } }, - { VOL, .u.n =3D {"@A%x", 10, 0, 15, 0, 0, NULL } }, - { VOICE, .u.n =3D {"@V%d", 1, 1, 6, 0, 0, NULL } }, - { LANG, .u.n =3D {"@=3D%d,", 1, 1, 4, 0, 0, NULL } }, - { DIRECT, .u.n =3D {NULL, 0, 0, 1, 0, 0, NULL } }, + + +enum default_vars_id { + CAPS_START_ID =3D 0, CAPS_STOP_ID, + RATE_ID, PITCH_ID, + VOL_ID, VOICE_ID, LANG_ID, + DIRECT_ID, V_LAST_VAR_ID, + NB_ID +}; + + + + +static struct var_t vars[NB_ID] =3D { + [CAPS_START_ID] =3D { CAPS_START, .u.s =3D {"cap, " } }, + [CAPS_STOP_ID] =3D { CAPS_STOP, .u.s =3D {"" } }, + [RATE_ID] =3D { RATE, .u.n =3D {"@W%d", 6, 1, 9, 0, 0, NULL } }, + [PITCH_ID] =3D { PITCH, .u.n =3D {"@F%x", 10, 0, 15, 0, 0, NULL } }, + [VOL_ID] =3D { VOL, .u.n =3D {"@A%x", 10, 0, 15, 0, 0, NULL } }, + [VOICE_ID] =3D { VOICE, .u.n =3D {"@V%d", 1, 1, 6, 0, 0, NULL } }, + [LANG_ID] =3D { LANG, .u.n =3D {"@=3D%d,", 1, 1, 4, 0, 0, NULL } }, + [DIRECT_ID] =3D { DIRECT, .u.n =3D {NULL, 0, 0, 1, 0, 0, NULL } }, V_LAST_VAR }; =20 @@ -193,10 +206,25 @@ static void do_catch_up(struct spk_synth *synth) module_param_named(ser, synth_apollo.ser, int, 0444); module_param_named(dev, synth_apollo.dev_name, charp, 0444); module_param_named(start, synth_apollo.startup, short, 0444); +module_param_named(rate, vars[RATE_ID].u.n.default_val, int, 0444); +module_param_named(pitch, vars[PITCH_ID].u.n.default_val, int, 0444); +module_param_named(vol, vars[VOL_ID].u.n.default_val, int, 0444); +module_param_named(voice, vars[VOICE_ID].u.n.default_val, int, 0444); +module_param_named(lang, vars[LANG_ID].u.n.default_val, int, 0444); +module_param_named(direct, vars[DIRECT_ID].u.n.default_val, int, 0444); + =20 MODULE_PARM_DESC(ser, "Set the serial port for the synthesizer (0-based)."= ); MODULE_PARM_DESC(dev, "Set the device e.g. ttyUSB0, for the synthesizer."); MODULE_PARM_DESC(start, "Start the synthesizer once it is loaded."); +MODULE_PARM_DESC(rate, "Set the rate variable on load."); +MODULE_PARM_DESC(pitch, "Set the pitch variable on load."); +MODULE_PARM_DESC(vol, "Set the vol variable on load."); +MODULE_PARM_DESC(voice, "Set the voice variable on load."); +MODULE_PARM_DESC(lang, "Set the lang variable on load."); +MODULE_PARM_DESC(direct, "Set the direct variable on load."); + + =20 module_spk_synth(synth_apollo); =20 --=20 2.25.1