From nobody Sun Oct 19 06:06:10 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D27EC433FE for ; Wed, 19 Oct 2022 10:57:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234725AbiJSK5D (ORCPT ); Wed, 19 Oct 2022 06:57:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49728 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234677AbiJSK4J (ORCPT ); Wed, 19 Oct 2022 06:56:09 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C942B76756; Wed, 19 Oct 2022 03:27:28 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 41D96B824C1; Wed, 19 Oct 2022 09:11:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B2C18C433D7; Wed, 19 Oct 2022 09:11:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666170666; bh=pP8jj1BLaAqsUYAH8uUEPMkH+VEo8jVb7LcvIKD0S1A=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qCprGu7Ba2xwEjihypSobcR9TNEKpi8lspjLhQqW5xNj7ShbK5+2o1IxaKXQrb9ZZ MvJJ/soMtByPPiZa/YGucilwDQnUwoqEI/f3uJ2i7AA6B0ypJTR7MLXhqPw6QdSVRz 00CLQJQRCdo1F96LcUJXxYJYyXCOn3NGIrdYYDBs= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, kernel test robot , Dan Carpenter , sunliming , Alex Deucher , Sasha Levin Subject: [PATCH 6.0 740/862] drm/amd/display: Fix variable dereferenced before check Date: Wed, 19 Oct 2022 10:33:47 +0200 Message-Id: <20221019083322.652970141@linuxfoundation.org> X-Mailer: git-send-email 2.38.0 In-Reply-To: <20221019083249.951566199@linuxfoundation.org> References: <20221019083249.951566199@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: sunliming [ Upstream commit 45a92f45f4578ff89da7dc5ef50bab4ef870f3b7 ] Fixes the following smatch warning: drivers/gpu/drm/amd/amdgpu/../display/dc/dc_dmub_srv.c:311 dc_dmub_srv_p_st= ate_delegate() warn: variable dereferenced before check 'dc' (see line 309) Reported-by: kernel test robot Reported-by: Dan Carpenter Signed-off-by: sunliming Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c b/drivers/gpu/drm= /amd/display/dc/dc_dmub_srv.c index 76c05ff12e95..755c4f9de6da 100644 --- a/drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c +++ b/drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c @@ -323,11 +323,13 @@ bool dc_dmub_srv_p_state_delegate(struct dc *dc, bool= should_manage_pstate, stru struct dmub_cmd_fw_assisted_mclk_switch_config *config_data =3D &cmd.fw_a= ssisted_mclk_switch.config_data; int i =3D 0; int ramp_up_num_steps =3D 1; // TODO: Ramp is currently disabled. Reenabl= e it. - uint8_t visual_confirm_enabled =3D dc->debug.visual_confirm =3D=3D VISUAL= _CONFIRM_FAMS; + uint8_t visual_confirm_enabled; =20 if (dc =3D=3D NULL) return false; =20 + visual_confirm_enabled =3D dc->debug.visual_confirm =3D=3D VISUAL_CONFIRM= _FAMS; + // Format command. cmd.fw_assisted_mclk_switch.header.type =3D DMUB_CMD__FW_ASSISTED_MCLK_SW= ITCH; cmd.fw_assisted_mclk_switch.header.sub_type =3D DMUB_CMD__FAMS_SETUP_FW_C= TRL; --=20 2.35.1