From nobody Fri Oct 17 10:31:36 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0DE1C4332F for ; Wed, 19 Oct 2022 12:20:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230272AbiJSMT4 (ORCPT ); Wed, 19 Oct 2022 08:19:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38868 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233121AbiJSMTE (ORCPT ); Wed, 19 Oct 2022 08:19:04 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B60BE1D67C; Wed, 19 Oct 2022 04:54:28 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 3A516B82312; Wed, 19 Oct 2022 08:45:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8CBEDC433D6; Wed, 19 Oct 2022 08:45:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666169136; bh=jg4ohn3/1jVyZ03iJkHbsTt2BOLdGqdLWdeUndyq9E0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PijNbsh6PjC6zD3jcv433tEkVqMZfLab3Fs2Azw8esvOkVJIvwZb82ByyIvVvxn+I TD87vMS0Y1JItZzxq4VkCXP2V5xelM0j3bIi0q9/KNLrlVSsrVUx8pdMC0waxLz7OU iFdoNeeSxeE/Dc9TDm3pLs2hpRZyDmsS6j03+IJY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dmitry Osipenko , Nicolas Dufresne , Samuel Holland , Paul Kocialkowski , Hans Verkuil , Mauro Carvalho Chehab Subject: [PATCH 6.0 170/862] media: cedrus: Set the platform driver data earlier Date: Wed, 19 Oct 2022 10:24:17 +0200 Message-Id: <20221019083257.464093108@linuxfoundation.org> X-Mailer: git-send-email 2.38.0 In-Reply-To: <20221019083249.951566199@linuxfoundation.org> References: <20221019083249.951566199@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Dmitry Osipenko commit 708938f8495147fe2e77a9a3e1015d8e6899323e upstream. The cedrus_hw_resume() crashes with NULL deference on driver probe if runtime PM is disabled because it uses platform data that hasn't been set up yet. Fix this by setting the platform data earlier during probe. Cc: stable@vger.kernel.org Fixes: 50e761516f2b (media: platform: Add Cedrus VPU decoder driver) Signed-off-by: Dmitry Osipenko Signed-off-by: Nicolas Dufresne Reviewed-by: Samuel Holland Acked-by: Paul Kocialkowski Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Greg Kroah-Hartman --- drivers/staging/media/sunxi/cedrus/cedrus.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/drivers/staging/media/sunxi/cedrus/cedrus.c +++ b/drivers/staging/media/sunxi/cedrus/cedrus.c @@ -448,6 +448,8 @@ static int cedrus_probe(struct platform_ if (!dev) return -ENOMEM; =20 + platform_set_drvdata(pdev, dev); + dev->vfd =3D cedrus_video_device; dev->dev =3D &pdev->dev; dev->pdev =3D pdev; @@ -521,8 +523,6 @@ static int cedrus_probe(struct platform_ goto err_m2m_mc; } =20 - platform_set_drvdata(pdev, dev); - return 0; =20 err_m2m_mc: