From nobody Tue Apr 7 19:04:13 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AA2EC433FE for ; Tue, 18 Oct 2022 11:37:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230324AbiJRLhG (ORCPT ); Tue, 18 Oct 2022 07:37:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33728 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230215AbiJRLgt (ORCPT ); Tue, 18 Oct 2022 07:36:49 -0400 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9B2EC8768E for ; Tue, 18 Oct 2022 04:35:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666092956; x=1697628956; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=I7mUpTnORPvv75eTCJTRzwfjLc/N5wp2MuStyApPKRw=; b=iIKa+IywDQuadHIW7b3wKvJHuWHinekRHjR0670pSaQaUZqdu+NHVfKz 0RdEN7R4c2bUOyOKGt5/zRZg+sl0uVmy5KIzuDqpt+xhiJGjlde8FMVq8 85/gNztgeLxuBbQaV0iA8xTbFNEOl/pYvLbSoVNiEKj1gv+6wvoiQsEHb 2W6gPh8GYh2r861sWbLVk5eayOnh0tsvWKr9nmWS2F4utsqyRe9fyMGXX SackRN9NPOYJszgE6lY1RwvDWNBbJbG22HKGccmV0Edg2EJKYCrdhIijC kniM9N7c1BD7r8SRMvV0MZJqdmYomcv7tAyintrlquu/YBlsljr9Mwd+4 A==; X-IronPort-AV: E=McAfee;i="6500,9779,10503"; a="392382163" X-IronPort-AV: E=Sophos;i="5.95,193,1661842800"; d="scan'208";a="392382163" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Oct 2022 04:34:24 -0700 X-IronPort-AV: E=McAfee;i="6500,9779,10503"; a="691763237" X-IronPort-AV: E=Sophos;i="5.95,193,1661842800"; d="scan'208";a="691763237" Received: from vhavel-mobl.ger.corp.intel.com (HELO box.shutemov.name) ([10.252.51.115]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Oct 2022 04:34:19 -0700 Received: by box.shutemov.name (Postfix, from userid 1000) id 91A72104BAD; Tue, 18 Oct 2022 14:34:04 +0300 (+03) From: "Kirill A. Shutemov" To: Dave Hansen , Andy Lutomirski , Peter Zijlstra Cc: x86@kernel.org, Kostya Serebryany , Andrey Ryabinin , Andrey Konovalov , Alexander Potapenko , Taras Madan , Dmitry Vyukov , "H . J . Lu" , Andi Kleen , Rick Edgecombe , Bharata B Rao , Jacob Pan , Ashok Raj , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Weihong Zhang , "Kirill A . Shutemov" Subject: [PATCHv10 15/15] selftests/x86/lam: Add ARCH_FORCE_TAGGED_SVM test cases for linear-address masking Date: Tue, 18 Oct 2022 14:33:58 +0300 Message-Id: <20221018113358.7833-16-kirill.shutemov@linux.intel.com> X-Mailer: git-send-email 2.38.0 In-Reply-To: <20221018113358.7833-1-kirill.shutemov@linux.intel.com> References: <20221018113358.7833-1-kirill.shutemov@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Weihong Zhang By default do not allow to enable both LAM and use SVM in the same process. The new ARCH_FORCE_TAGGED_SVM arch_prctl() overrides the limitation. Add new test cases for the new arch_prctl: Defore using ARCH_FORCE_TAGGED_SVM, should not allow to enable LAM/SVM coexisting. the test cases should be negative. The test depands on idxd driver and iommu. before test, need add "intel_iommu=3Don,sm_on" in kernel command line and insmod idxd driver. Signed-off-by: Weihong Zhang Signed-off-by: Kirill A. Shutemov --- tools/testing/selftests/x86/lam.c | 237 +++++++++++++++++++++++++++++- 1 file changed, 235 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/x86/lam.c b/tools/testing/selftests/x8= 6/lam.c index cfc9073c0262..4b9da41de5c8 100644 --- a/tools/testing/selftests/x86/lam.c +++ b/tools/testing/selftests/x86/lam.c @@ -30,6 +30,7 @@ #define ARCH_GET_UNTAG_MASK 0x4001 #define ARCH_ENABLE_TAGGED_ADDR 0x4002 #define ARCH_GET_MAX_TAG_BITS 0x4003 +#define ARCH_FORCE_TAGGED_SVM 0x4004 =20 /* Specified test function bits */ #define FUNC_MALLOC 0x1 @@ -38,8 +39,9 @@ #define FUNC_SYSCALL 0x8 #define FUNC_URING 0x10 #define FUNC_INHERITE 0x20 +#define FUNC_PASID 0x40 =20 -#define TEST_MASK 0x3f +#define TEST_MASK 0x7f =20 #define LOW_ADDR (0x1UL << 30) #define HIGH_ADDR (0x3UL << 48) @@ -55,11 +57,19 @@ #define URING_QUEUE_SZ 1 #define URING_BLOCK_SZ 2048 =20 +/* Pasid test define */ +#define LAM_CMD_BIT 0x1 +#define PAS_CMD_BIT 0x2 +#define SVM_CMD_BIT 0x4 + +#define PAS_CMD(cmd1, cmd2, cmd3) (((cmd3) << 8) | ((cmd2) << 4) | ((cmd1)= << 0)) + struct testcases { unsigned int later; int expected; /* 2: SIGSEGV Error; 1: other errors */ unsigned long lam; uint64_t addr; + uint64_t cmd; int (*test_func)(struct testcases *test); const char *msg; }; @@ -556,7 +566,7 @@ int do_uring(unsigned long lam) struct file_io *fi; struct stat st; int ret =3D 1; - char path[PATH_MAX]; + char path[PATH_MAX] =3D {0}; =20 /* get current process path */ if (readlink("/proc/self/exe", path, PATH_MAX) <=3D 0) @@ -852,6 +862,226 @@ static void cmd_help(void) printf("\t-h: help\n"); } =20 +/* Check for file existence */ +uint8_t file_Exists(const char *fileName) +{ + struct stat buffer; + + uint8_t ret =3D (stat(fileName, &buffer) =3D=3D 0); + + return ret; +} + +/* Sysfs idxd files */ +const char *dsa_configs[] =3D { + "echo 1 > /sys/bus/dsa/devices/dsa0/wq0.1/group_id", + "echo shared > /sys/bus/dsa/devices/dsa0/wq0.1/mode", + "echo 10 > /sys/bus/dsa/devices/dsa0/wq0.1/priority", + "echo 16 > /sys/bus/dsa/devices/dsa0/wq0.1/size", + "echo 15 > /sys/bus/dsa/devices/dsa0/wq0.1/threshold", + "echo user > /sys/bus/dsa/devices/dsa0/wq0.1/type", + "echo MyApp1 > /sys/bus/dsa/devices/dsa0/wq0.1/name", + "echo 1 > /sys/bus/dsa/devices/dsa0/engine0.1/group_id", + "echo dsa0 > /sys/bus/dsa/drivers/idxd/bind", + /* bind files and devices, generated a device file in /dev */ + "echo wq0.1 > /sys/bus/dsa/drivers/user/bind", +}; + +/* DSA device file */ +const char *dsaDeviceFile =3D "/dev/dsa/wq0.1"; +/* file for io*/ +const char *dsaPasidEnable =3D "/sys/bus/dsa/devices/dsa0/pasid_enabled"; + +/* + * DSA depends on kernel cmdline "intel_iommu=3Don,sm_on" + * return pasid_enabled (0: disable 1:enable) + */ +int Check_DSA_Kernel_Setting(void) +{ + char command[256] =3D ""; + char buf[256] =3D ""; + char *ptr; + int rv =3D -1; + + snprintf(command, sizeof(command) - 1, "cat %s", dsaPasidEnable); + + FILE *cmd =3D popen(command, "r"); + + if (cmd) { + while (fgets(buf, sizeof(buf) - 1, cmd) !=3D NULL); + + pclose(cmd); + rv =3D strtol(buf, &ptr, 16); + } + + return rv; +} + +/* + * Config DSA's sysfs files as shared DSA's WQ. + * Generated a device file /dev/dsa/wq0.1 + * Return: 0 OK; 1 Failed; 3 Skip(SVM disabled). + */ +int Dsa_Init_Sysfs(void) +{ + uint len =3D ARRAY_SIZE(dsa_configs); + const char **p =3D dsa_configs; + + if (file_Exists(dsaDeviceFile) =3D=3D 1) + return 0; + + /* check the idxd driver */ + if (file_Exists(dsaPasidEnable) !=3D 1) { + printf("Please make sure idxd driver was loaded\n"); + return 3; + } + + /* Check SVM feature */ + if (Check_DSA_Kernel_Setting() !=3D 1) { + printf("Please enable SVM.(Add intel_iommu=3Don,sm_on in kernel cmdline)= \n"); + return 3; + } + + /* Check the idxd device file on /dev/dsa/ */ + for (int i =3D 0; i < len; i++) { + if (system(p[i])) + return 1; + } + + /* After config, /dev/dsa/wq0.1 should be generated */ + return (file_Exists(dsaDeviceFile) !=3D 1); +} + +/* + * Open DSA device file, triger API: iommu_sva_alloc_pasid + */ +void *allocate_dsa_pasid(void) +{ + int fd; + void *wq; + + fd =3D open(dsaDeviceFile, O_RDWR); + if (fd < 0) { + perror("open"); + return MAP_FAILED; + } + + wq =3D mmap(NULL, 0x1000, PROT_WRITE, + MAP_SHARED | MAP_POPULATE, fd, 0); + if (wq =3D=3D MAP_FAILED) + perror("mmap"); + + return wq; +} + +int set_force_svm(void) +{ + int ret =3D 0; + + ret =3D syscall(SYS_arch_prctl, ARCH_FORCE_TAGGED_SVM); + + return ret; +} + +int handle_pasid(struct testcases *test) +{ + uint tmp =3D test->cmd; + uint runed =3D 0x0; + int ret =3D 0; + void *wq =3D NULL; + + ret =3D Dsa_Init_Sysfs(); + if (ret !=3D 0) + return ret; + + for (int i =3D 0; i < 3; i++) { + int err =3D 0; + + if (tmp & 0x1) { + /* run set lam mode*/ + if ((runed & 0x1) =3D=3D 0) { + err =3D set_lam(LAM_U57_BITS); + runed =3D runed | 0x1; + } else + err =3D 1; + } else if (tmp & 0x4) { + /* run force svm */ + if ((runed & 0x4) =3D=3D 0) { + err =3D set_force_svm(); + runed =3D runed | 0x4; + } else + err =3D 1; + } else if (tmp & 0x2) { + /* run allocate pasid */ + if ((runed & 0x2) =3D=3D 0) { + runed =3D runed | 0x2; + wq =3D allocate_dsa_pasid(); + if (wq =3D=3D MAP_FAILED) + err =3D 1; + } else + err =3D 1; + } + + ret =3D ret + err; + if (ret > 0) + break; + + tmp =3D tmp >> 4; + } + + if (wq !=3D MAP_FAILED && wq !=3D NULL) + if (munmap(wq, 0x1000)) + printf("munmap failed %d\n", errno); + + if (runed !=3D 0x7) + ret =3D 1; + + return (ret !=3D 0); +} + +/* + * Pasid test depends on idxd and SVM, kernel should enable iommu and sm. + * command line(intel_iommu=3Don,sm_on) + */ +static struct testcases pasid_cases[] =3D { + { + .expected =3D 1, + .cmd =3D PAS_CMD(LAM_CMD_BIT, PAS_CMD_BIT, SVM_CMD_BIT), + .test_func =3D handle_pasid, + .msg =3D "PASID: [Negative] Execute LAM, PASID, SVM in sequence\n", + }, + { + .expected =3D 0, + .cmd =3D PAS_CMD(LAM_CMD_BIT, SVM_CMD_BIT, PAS_CMD_BIT), + .test_func =3D handle_pasid, + .msg =3D "PASID: Execute LAM, SVM, PASID in sequence\n", + }, + { + .expected =3D 1, + .cmd =3D PAS_CMD(PAS_CMD_BIT, LAM_CMD_BIT, SVM_CMD_BIT), + .test_func =3D handle_pasid, + .msg =3D "PASID: [Negative] Execute PASID, LAM, SVM in sequence\n", + }, + { + .expected =3D 0, + .cmd =3D PAS_CMD(PAS_CMD_BIT, SVM_CMD_BIT, LAM_CMD_BIT), + .test_func =3D handle_pasid, + .msg =3D "PASID: Execute PASID, SVM, LAM in sequence\n", + }, + { + .expected =3D 0, + .cmd =3D PAS_CMD(SVM_CMD_BIT, LAM_CMD_BIT, PAS_CMD_BIT), + .test_func =3D handle_pasid, + .msg =3D "PASID: Execute SVM, LAM, PASID in sequence\n", + }, + { + .expected =3D 0, + .cmd =3D PAS_CMD(SVM_CMD_BIT, PAS_CMD_BIT, LAM_CMD_BIT), + .test_func =3D handle_pasid, + .msg =3D "PASID: Execute SVM, PASID, LAM in sequence\n", + }, +}; + int main(int argc, char **argv) { int c =3D 0; @@ -910,6 +1140,9 @@ int main(int argc, char **argv) if (tests & FUNC_INHERITE) run_test(inheritance_cases, ARRAY_SIZE(inheritance_cases)); =20 + if (tests & FUNC_PASID) + run_test(pasid_cases, ARRAY_SIZE(pasid_cases)); + ksft_set_plan(tests_cnt); =20 return ksft_exit_pass(); --=20 2.38.0