From nobody Tue Apr 7 14:25:06 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23961C433FE for ; Mon, 17 Oct 2022 10:46:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230233AbiJQKqU (ORCPT ); Mon, 17 Oct 2022 06:46:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51542 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230204AbiJQKqN (ORCPT ); Mon, 17 Oct 2022 06:46:13 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id A3EAC1A04D for ; Mon, 17 Oct 2022 03:46:12 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9D33D1FC4; Mon, 17 Oct 2022 03:46:18 -0700 (PDT) Received: from e122027.arm.com (unknown [10.57.1.201]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 345FD3F67D; Mon, 17 Oct 2022 03:46:11 -0700 (PDT) From: Steven Price To: Alyssa Rosenzweig , =?UTF-8?q?Adri=C3=A1n=20Larumbe?= Cc: Steven Price , Rob Herring , Tomeu Vizoso , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Robin Murphy Subject: [PATCH v2 1/2] drm/panfrost: Remove type name from internal structs Date: Mon, 17 Oct 2022 11:46:01 +0100 Message-Id: <20221017104602.142992-2-steven.price@arm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221017104602.142992-1-steven.price@arm.com> References: <20221017104602.142992-1-steven.price@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The two structs internal to struct panfrost_dump_object_header were named, but sadly that is incompatible with C++, causing an error: "an anonymous union may only have public non-static data members". However nothing refers to struct pan_reg_hdr and struct pan_bomap_hdr and there's no need to export these definitions, so lets drop them. This fixes the C++ build error with the minimum change in userspace API. Reported-by: Adri=C3=A1n Larumbe Fixes: 730c2bf4ad39 ("drm/panfrost: Add support for devcoredump") Signed-off-by: Steven Price --- include/uapi/drm/panfrost_drm.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/uapi/drm/panfrost_drm.h b/include/uapi/drm/panfrost_dr= m.h index eac87310b348..bd77254be121 100644 --- a/include/uapi/drm/panfrost_drm.h +++ b/include/uapi/drm/panfrost_drm.h @@ -242,7 +242,7 @@ struct panfrost_dump_object_header { __le32 file_offset; =20 union { - struct pan_reg_hdr { + struct { __le64 jc; __le32 gpu_id; __le32 major; @@ -250,7 +250,7 @@ struct panfrost_dump_object_header { __le64 nbos; } reghdr; =20 - struct pan_bomap_hdr { + struct { __le32 valid; __le64 iova; __le32 data[2]; --=20 2.34.1