From nobody Tue Apr 7 12:47:40 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B60EC4332F for ; Mon, 17 Oct 2022 09:07:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229779AbiJQJHz (ORCPT ); Mon, 17 Oct 2022 05:07:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48360 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230048AbiJQJHw (ORCPT ); Mon, 17 Oct 2022 05:07:52 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 8B44ECC8 for ; Mon, 17 Oct 2022 02:07:51 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2882C1042; Mon, 17 Oct 2022 02:07:57 -0700 (PDT) Received: from lakrids.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 49EB23F792; Mon, 17 Oct 2022 02:07:50 -0700 (PDT) From: Mark Rutland To: linux-kernel@vger.kernel.org Cc: mark.rutland@arm.com, mhiramat@kernel.org, rostedt@goodmis.org Subject: [PATCH] tracing: fix dynevent test requirements Date: Mon, 17 Oct 2022 10:07:41 +0100 Message-Id: <20221017090741.2881918-1-mark.rutland@arm.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Currently a couple of dynevent tests will always report UNSUPPORTED and not run, even when support is actually present. In commit: 95c104c378dc7d4c ("tracing: Auto generate event name when creating a grou= p of events") The README text for synthetic events was changed from: "e[:[/]] . []\n" To: "e[:[/][]] . []\n" ... but the dynevent selftests were not updated accodingly, and still search for the old text in their "requires" lines. Consequently, they fail to match the new text, and the tests report the feature is UNSUPPORTED. For example: | # ./ftracetest -vv test.d/dynevent/test_duplicates.tc | =3D=3D=3D Ftrace unit tests =3D=3D=3D | [1] Generic dynamic event - check if duplicate events are caughtRequired = feature pattern "e[:[/]] . [<= args>]" is not in README. | [UNSUPPORTED] | | | # of passed: 0 | # of failed: 0 | # of unresolved: 0 | # of untested: 0 | # of unsupported: 1 | # of xfailed: 0 | # of undefined(test bug): 0 Update the patterns to match, allowing the tests to run: | # ./ftracetest -vv test.d/dynevent/test_duplicates.tc | =3D=3D=3D Ftrace unit tests =3D=3D=3D | [1] Generic dynamic event - check if duplicate events are caught | [PASS] | | | # of passed: 1 | # of failed: 0 | # of unresolved: 0 | # of untested: 0 | # of unsupported: 0 | # of xfailed: 0 | # of undefined(test bug): 0 Fixes: 95c104c378dc7d4c ("tracing: Auto generate event name when creating a= group of events") Signed-off-by: Mark Rutland Cc: Masami Hiramatsu Cc: Steven Rostedt --- .../testing/selftests/ftrace/test.d/dynevent/test_duplicates.tc | 2 +- .../test.d/trigger/inter-event/trigger-synthetic-eprobe.tc | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/ftrace/test.d/dynevent/test_duplicates= .tc b/tools/testing/selftests/ftrace/test.d/dynevent/test_duplicates.tc index db522577ff78..d3a79da215c8 100644 --- a/tools/testing/selftests/ftrace/test.d/dynevent/test_duplicates.tc +++ b/tools/testing/selftests/ftrace/test.d/dynevent/test_duplicates.tc @@ -1,7 +1,7 @@ #!/bin/sh # SPDX-License-Identifier: GPL-2.0 # description: Generic dynamic event - check if duplicate events are caught -# requires: dynamic_events "e[:[/]] . []":README +# requires: dynamic_events "e[:[/][]] . []":README =20 echo 0 > events/enable =20 diff --git a/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trig= ger-synthetic-eprobe.tc b/tools/testing/selftests/ftrace/test.d/trigger/int= er-event/trigger-synthetic-eprobe.tc index 914fe2e5d030..6461c375694f 100644 --- a/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-syn= thetic-eprobe.tc +++ b/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-syn= thetic-eprobe.tc @@ -1,7 +1,7 @@ #!/bin/sh # SPDX-License-Identifier: GPL-2.0 # description: event trigger - test inter-event histogram trigger eprobe o= n synthetic event -# requires: dynamic_events synthetic_events events/syscalls/sys_enter_open= at/hist "e[:[/]] . []":= README +# requires: dynamic_events synthetic_events events/syscalls/sys_enter_open= at/hist "e[:[/][]] . []= ":README =20 echo 0 > events/enable =20 --=20 2.30.2