From nobody Tue Apr 7 09:39:01 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81FC2C433FE for ; Fri, 14 Oct 2022 08:20:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229976AbiJNIUB (ORCPT ); Fri, 14 Oct 2022 04:20:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50220 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229808AbiJNIT5 (ORCPT ); Fri, 14 Oct 2022 04:19:57 -0400 Received: from out2.migadu.com (out2.migadu.com [188.165.223.204]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A29EF36BF5 for ; Fri, 14 Oct 2022 01:19:54 -0700 (PDT) X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=momi.ca; s=key1; t=1665735592; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tS+unZ61Ew2be46UlZsqdr1CsmOCzbnZoR3P7F47Lbs=; b=TBuVvzpRiCuhI6csA8qTNEqEsiEu/T1+JDblw46EiSFPu+ihly8nh/55ODoHGQSZ8Ac3Ij d8V9VREjUvzm7V/9oFHqoXw3BpXocUO5u0Vu/mVPgxkbCzfRW+7I86TwO8//FQJzqJ0t1q uQFi+zF3T6a5VmXo92QFTzfxUwE+B+sooZps2RDth/BDfZv+y3M/WSpSMuj8DTDSG3vQrB vdu0Y8ziRpcx3ToGHNgwLekAjx3MExwVtL72VJCkRNnc7Svg0R90bja6yhQp0lZuxe9Rso 7GI6R0eDIwn+DRj7NSvkInJ7OuhConl5xMj4bIyo4SMfX+DyvFauWx9LE2V4Aw== From: Anjandev Momi To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: Anjandev Momi Subject: [PATCH 1/4] Staging: rtl8192e: remove unnecessary parentheses Date: Fri, 14 Oct 2022 01:18:37 -0700 Message-Id: <20221014081839.23902-2-anjan@momi.ca> In-Reply-To: <20221014081839.23902-1-anjan@momi.ca> References: <20221014081839.23902-1-anjan@momi.ca> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" This patch removes the following CHECK generated by checkpatch.pl: ./drivers/staging/rtl8192e/rtl819x_BAProc.c:116: CHECK: Unnecessary parentheses around pBA->ba_start_seq_ctrl ./drivers/staging/rtl8192e/rtl819x_BAProc.c:261: CHECK: Unnecessary parentheses around '&pTS' ./drivers/staging/rtl8192e/rtl819x_BAProc.c:346: CHECK: Unnecessary parentheses around '&pTS' Signed-off-by: Anjandev Momi --- drivers/staging/rtl8192e/rtl819x_BAProc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rt= l8192e/rtl819x_BAProc.c index 7d04966af..bd7efb8f1 100644 --- a/drivers/staging/rtl8192e/rtl819x_BAProc.c +++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c @@ -113,7 +113,7 @@ static struct sk_buff *rtllib_ADDBA(struct rtllib_devic= e *ieee, u8 *Dst, tag +=3D 2; =20 if (type =3D=3D ACT_ADDBAREQ) { - memcpy(tag, (u8 *)&(pBA->ba_start_seq_ctrl), 2); + memcpy(tag, (u8 *)&pBA->ba_start_seq_ctrl, 2); tag +=3D 2; } =20 @@ -258,7 +258,7 @@ int rtllib_rx_ADDBAReq(struct rtllib_device *ieee, stru= ct sk_buff *skb) ieee->pHTInfo->bCurrentHTSupport); goto OnADDBAReq_Fail; } - if (!GetTs(ieee, (struct ts_common_info **)(&pTS), dst, + if (!GetTs(ieee, (struct ts_common_info **)&pTS, dst, (u8)(pBaParamSet->field.tid), RX_DIR, true)) { rc =3D ADDBA_STATUS_REFUSED; netdev_warn(ieee->dev, "%s(): can't get TS\n", __func__); @@ -343,7 +343,7 @@ int rtllib_rx_ADDBARsp(struct rtllib_device *ieee, stru= ct sk_buff *skb) goto OnADDBARsp_Reject; } =20 - if (!GetTs(ieee, (struct ts_common_info **)(&pTS), dst, + if (!GetTs(ieee, (struct ts_common_info **)&pTS, dst, (u8)(pBaParamSet->field.tid), TX_DIR, false)) { netdev_warn(ieee->dev, "%s(): can't get TS\n", __func__); ReasonCode =3D DELBA_REASON_UNKNOWN_BA; --=20 2.36.2 From nobody Tue Apr 7 09:39:01 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37A9BC4332F for ; Fri, 14 Oct 2022 08:20:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230043AbiJNIUK (ORCPT ); Fri, 14 Oct 2022 04:20:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50878 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230004AbiJNIUD (ORCPT ); Fri, 14 Oct 2022 04:20:03 -0400 Received: from out2.migadu.com (out2.migadu.com [IPv6:2001:41d0:2:aacc::]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 84EE7402CB for ; Fri, 14 Oct 2022 01:20:00 -0700 (PDT) X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=momi.ca; s=key1; t=1665735598; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fyLseoL57wgNMMvR1FlVSHdo9PICI/PgDQQI+8vT/LE=; b=G28mxB3rjSY1keMsTDXow1WvVXT4Fkvyz0JglBEqZwZwPgSxXIgEsjYYaG/45hS5qrYP0G Hps0z+7lxE2d4UXA/mNvARYYmFssYjgn59cZyPdx3OyMDcqwaJfH756ieyG6/vIrcZ2f1c K83gH70Tu570FJjDhioWVqxOgTw27Z3+ZLO5hf8N0j2KsBjkwd55fauW7jDOrVIleJx7oT cXf9bfY2Jyoa4xcGl9qjiUT4mk/BB5Ma0BXoPBOCZvuXyTKwtoH/DP/TT0tFAamVjvrdYe qvf2Y8o9piAqvKr13l3AZiwfaph/KOZ9l3zwbnayMCk+N3n0k55WLqH+IlmfsQ== From: Anjandev Momi To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: Anjandev Momi Subject: [PATCH 2/4] Staging: rtl8192e: remove multiple blank lines Date: Fri, 14 Oct 2022 01:18:38 -0700 Message-Id: <20221014081839.23902-3-anjan@momi.ca> In-Reply-To: <20221014081839.23902-1-anjan@momi.ca> References: <20221014081839.23902-1-anjan@momi.ca> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" This patch removes the following checks generated by checkpatch.pl: ./drivers/staging/rtl8192e/rtl819x_BAProc.c:164: CHECK: Please don't use multiple blank lines ./drivers/staging/rtl8192e/rtl819x_BAProc.c:383: CHECK: Please don't use multiple blank lines Signed-off-by: Anjandev Momi --- drivers/staging/rtl8192e/rtl819x_BAProc.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rt= l8192e/rtl819x_BAProc.c index bd7efb8f1..f36c24c2a 100644 --- a/drivers/staging/rtl8192e/rtl819x_BAProc.c +++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c @@ -161,7 +161,6 @@ static struct sk_buff *rtllib_DELBA(struct rtllib_devic= e *ieee, u8 *dst, *tag++ =3D ACT_CAT_BA; *tag++ =3D ACT_DELBA; =20 - put_unaligned_le16(DelbaParamSet.short_data, tag); tag +=3D 2; =20 @@ -380,7 +379,6 @@ int rtllib_rx_ADDBARsp(struct rtllib_device *ieee, stru= ct sk_buff *skb) goto OnADDBARsp_Reject; } =20 - pAdmittedBA->dialog_token =3D *pDialogToken; pAdmittedBA->ba_timeout_value =3D *pBaTimeoutVal; pAdmittedBA->ba_start_seq_ctrl =3D pPendingBA->ba_start_seq_ctrl; --=20 2.36.2 From nobody Tue Apr 7 09:39:01 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F34CFC4332F for ; Fri, 14 Oct 2022 08:20:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230086AbiJNIUS (ORCPT ); Fri, 14 Oct 2022 04:20:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51582 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230000AbiJNIUN (ORCPT ); Fri, 14 Oct 2022 04:20:13 -0400 Received: from out0.migadu.com (out0.migadu.com [94.23.1.103]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9B8C27C325 for ; Fri, 14 Oct 2022 01:20:09 -0700 (PDT) X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=momi.ca; s=key1; t=1665735607; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=C5ZEHK9P/ZG0BqPTjgVcsSPihw9Ksc6WFf5Jc3M19kI=; b=fvEpm/UNqh96B87kriDrg4upSvkKWMijzBB4rYj0U8TFR56UmAh9TNvrWSkdUtKvxWGLGQ QtFCY61K4zG7QseFDrExg+YQ9la54vKvxR8uAziAkSMcI3gxlZmBs570fgL1sWQr2kdCZc ODrfv67poI4OUxHGZgNgGWPgfEnWX8ybOj0dU/tQ8HGPJIvdV2+oKDA5jpblkY65TUOSXh hq+ZTvU2RNQt2wDGEpFtqHL2HSjeZGge9+9qigGRL4UdBf3e+VjgzJeS3xM7wDOc0bFRHm 4WSDJTapCZ/cRz+/OGlyb5JM2bihRDKbX3xx0mrILowkZm4BqtnC24EozgpJ3w== From: Anjandev Momi To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: Anjandev Momi Subject: [PATCH 3/4] Staging: rtl8192e: make alignment match open parenthesis Date: Fri, 14 Oct 2022 01:18:39 -0700 Message-Id: <20221014081839.23902-4-anjan@momi.ca> In-Reply-To: <20221014081839.23902-1-anjan@momi.ca> References: <20221014081839.23902-1-anjan@momi.ca> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" This patch removes the following checks generated by checkpatch.pl: ./drivers/staging/rtl8192e/rtl819x_BAProc.c:261: CHECK: Alignment should match open parenthesis ./drivers/staging/rtl8192e/rtl819x_BAProc.c:284: CHECK: Alignment should match open parenthesis ./drivers/staging/rtl8192e/rtl819x_BAProc.c:421: CHECK: Alignment should match open parenthesis ./drivers/staging/rtl8192e/rtl819x_BAProc.c:441: CHECK: Alignment should match open parenthesis Signed-off-by: Anjandev Momi --- drivers/staging/rtl8192e/rtl819x_BAProc.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rt= l8192e/rtl819x_BAProc.c index f36c24c2a..8d92b3426 100644 --- a/drivers/staging/rtl8192e/rtl819x_BAProc.c +++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c @@ -258,7 +258,7 @@ int rtllib_rx_ADDBAReq(struct rtllib_device *ieee, stru= ct sk_buff *skb) goto OnADDBAReq_Fail; } if (!GetTs(ieee, (struct ts_common_info **)&pTS, dst, - (u8)(pBaParamSet->field.tid), RX_DIR, true)) { + (u8)(pBaParamSet->field.tid), RX_DIR, true)) { rc =3D ADDBA_STATUS_REFUSED; netdev_warn(ieee->dev, "%s(): can't get TS\n", __func__); goto OnADDBAReq_Fail; @@ -281,7 +281,7 @@ int rtllib_rx_ADDBAReq(struct rtllib_device *ieee, stru= ct sk_buff *skb) pBA->ba_start_seq_ctrl =3D *pBaStartSeqCtrl; =20 if (ieee->GetHalfNmodeSupportByAPsHandler(ieee->dev) || - (ieee->pHTInfo->IOTAction & HT_IOT_ACT_ALLOW_PEER_AGG_ONE_PKT)) + (ieee->pHTInfo->IOTAction & HT_IOT_ACT_ALLOW_PEER_AGG_ONE_PKT)) pBA->ba_param_set.field.buffer_size =3D 1; else pBA->ba_param_set.field.buffer_size =3D 32; @@ -418,7 +418,7 @@ int rtllib_rx_DELBA(struct rtllib_device *ieee, struct = sk_buff *skb) } =20 if (!ieee->current_network.qos_data.active || - !ieee->pHTInfo->bCurrentHTSupport) { + !ieee->pHTInfo->bCurrentHTSupport) { netdev_warn(ieee->dev, "received DELBA while QOS or HT is not supported(%d, %d)\n", ieee->current_network. qos_data.active, @@ -438,7 +438,7 @@ int rtllib_rx_DELBA(struct rtllib_device *ieee, struct = sk_buff *skb) struct rx_ts_record *pRxTs; =20 if (!GetTs(ieee, (struct ts_common_info **)&pRxTs, dst, - (u8)pDelBaParamSet->field.tid, RX_DIR, false)) { + (u8)pDelBaParamSet->field.tid, RX_DIR, false)) { netdev_warn(ieee->dev, "%s(): can't get TS for RXTS. dst:%pM TID:%d\n", __func__, dst, --=20 2.36.2 From nobody Tue Apr 7 09:39:01 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA180C433FE for ; Fri, 14 Oct 2022 08:20:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229932AbiJNIUt (ORCPT ); Fri, 14 Oct 2022 04:20:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53122 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229541AbiJNIUa (ORCPT ); Fri, 14 Oct 2022 04:20:30 -0400 Received: from out0.migadu.com (out0.migadu.com [IPv6:2001:41d0:2:267::]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6483436BD0 for ; Fri, 14 Oct 2022 01:20:25 -0700 (PDT) X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=momi.ca; s=key1; t=1665735623; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1Bw0wTiwP6eGlELX8NIJk0Tm4ksdmqLG9LGmsYlRymk=; b=DxnwpwKzDp7ZA1Sfmx+f9x4RwPJ9BqtIQyWWVDppD26mzTUot0WFd4+BsYIFhVyHCDtvDm +HlPJI/iCP5NquLwXcnTjXuP8FO94iN8I7aqxy8I65hTVpHM3A7Bu8Axt8iLQvoz0wpau8 YHvTPNcJKS/qxDLP6dFE6CFdsDEe3hQbS43FgQ4AtxmwN7gJz8bqnVO8FZmrQas9ibpVyf f6jBIfixz1/hrhjg4Ep/BjBwg+b+0NUH9R9zEX6E7sR135jYd1LgKWnrGjTcKyOdBffTJC px68uDru0ZN784DbabN3Q1RxPWCTeXjHw/YWD8ydf5WHQ3RP9p3Yt+U0knjrXA== From: Anjandev Momi To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: Anjandev Momi Subject: [PATCH 4/4] Staging: rtl8192e: add blank line after function declaration Date: Fri, 14 Oct 2022 01:18:40 -0700 Message-Id: <20221014081839.23902-5-anjan@momi.ca> In-Reply-To: <20221014081839.23902-1-anjan@momi.ca> References: <20221014081839.23902-1-anjan@momi.ca> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" This patch removes the following check generated by checkpatch.pl ./drivers/staging/rtl8192e/rtl819x_BAProc.c:65: CHECK: Please use a blank line after function/struct/union/enum declarations Signed-off-by: Anjandev Momi --- drivers/staging/rtl8192e/rtl819x_BAProc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rt= l8192e/rtl819x_BAProc.c index 8d92b3426..67918ef41 100644 --- a/drivers/staging/rtl8192e/rtl819x_BAProc.c +++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c @@ -62,6 +62,7 @@ void ResetBaEntry(struct ba_record *pBA) pBA->dialog_token =3D 0; pBA->ba_start_seq_ctrl.short_data =3D 0; } + static struct sk_buff *rtllib_ADDBA(struct rtllib_device *ieee, u8 *Dst, struct ba_record *pBA, u16 StatusCode, u8 type) --=20 2.36.2