From nobody Fri Dec 19 17:14:39 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D701BC433FE for ; Thu, 20 Oct 2022 08:51:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229498AbiJTIvy (ORCPT ); Thu, 20 Oct 2022 04:51:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57414 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230121AbiJTIvi (ORCPT ); Thu, 20 Oct 2022 04:51:38 -0400 Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D4A6D188118 for ; Thu, 20 Oct 2022 01:51:17 -0700 (PDT) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 6252232000D7; Thu, 20 Oct 2022 04:51:14 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Thu, 20 Oct 2022 04:51:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1666255873; x= 1666342273; bh=1vlWw3HWcseVhvxGIduvYvORASnSFa/0anA5xMkzYTs=; b=g QElMFuJcDsgncugOjpbYGI1H9ih9YvRSBLbN3k5TIgGyuVRoy2mi456VQ7FNC8UR GO0b78y1FoXrQI2Jjm7jhMYonJ0iM6IR2rPKIHaFEZN6+ho89RAT7rj16+yOJiQq sJOg1+PQCH6uY/jdddErH2ZUiuUcGSfIO67KzVAZcfVOj3LeMmDydHy5/TWKC1n8 wqlx/BWw74vY38QOChFlhc8zalGvc7RFhfiJ7j9Odv/5Y/G8gwXA/gqhUdeCVb2d 2kjejGC0ZLg+nSecnWKrshQ5XXndF97CvgEXXcGXjLTObypxCd5rrdRgW2sg6lso pVySV5jV+IGWJO003Yxjg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1666255873; x= 1666342273; bh=1vlWw3HWcseVhvxGIduvYvORASnSFa/0anA5xMkzYTs=; b=s lJTVlCthi+dMq65myMAszoI5FjYJIVPe1qSwkyCsKrCUILT+NoR+8JIlcWErSNs3 m6Sgjzjy7uMOPNq2SombqDABPUD/yBn3OoSD5fsGnlEIrznAgijrpcarlxqvkuKT UJ8zHf/RDclQVRGTpxSoz5rt2Hiyz0y+dPeeVQxeMYHvnevJQhfCrD+N6l/vUAL4 KN7stVXpm96mqvKEH2PY8M0BZc53djxCbVmqvnswn2Hck3rIYtkhzX5OwWxMfu+/ rhitaV7G1XpG3XfXfb6r7HZXAtMkC53jvME+pCHqkblC3deBEIdHsIE+Vncixbfu H6/WBZo8lxH0KWfoCQauQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeeliedgtdejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephfffufggtgfgkfhfjgfvvefosehtkeertdertdejnecuhfhrohhmpeforgig ihhmvgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrf grthhtvghrnhepudduudfhveejteefgedvffdvvedvjedugedukeejhedtlefhffevtefh jeeltdevnecuvehluhhsthgvrhfuihiivgepudenucfrrghrrghmpehmrghilhhfrhhomh epmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Feedback-ID: i8771445c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 20 Oct 2022 04:51:13 -0400 (EDT) From: Maxime Ripard Date: Thu, 20 Oct 2022 10:30:50 +0200 Subject: [PATCH v2 6/7] drm/vc4: dpi: Change the default DPI format to being 18bpp, not 24. MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20221013-rpi-dpi-improvements-v2-6-7691903fb9c8@cerno.tech> References: <20221013-rpi-dpi-improvements-v2-0-7691903fb9c8@cerno.tech> In-Reply-To: <20221013-rpi-dpi-improvements-v2-0-7691903fb9c8@cerno.tech> To: Emma Anholt , Maxime Ripard , Rob Herring , Daniel Vetter , Eric Anholt , David Airlie Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Joerg Quinten , Chris Morgan , Dave Stevenson , Laurent Pinchart , Maxime Ripard X-Mailer: b4 0.10.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1321; i=maxime@cerno.tech; h=from:subject:message-id; bh=Cj2SqCiv0e+hjTKV6Xz2WDeMWOb4ZCwlvcwXbXBSakE=; b=owGbwMvMwCX2+D1vfrpE4FHG02pJDMmB7BZPrb6beAiELopZJFi288SeAy/UTnglpW9cUPDMuLVI UeBMRykLgxgXg6yYIkuMsPmSuFOzXney8c2DmcPKBDKEgYtTACayUIeR4ZHri38VJRdLzsifNmN0X2 NYtZRty77Vt/xsv65qVlfIW8Pwz6T9WnyjeWjenk3PYr9IWglfNi/37Ep66pqn8elxz1cNVgA= X-Developer-Key: i=maxime@cerno.tech; a=openpgp; fpr=BE5675C37E818C8B5764241C254BCFC56BF6CE8D Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dave Stevenson DPI hasn't really been used up until now, so the default has been meaningless. In theory we should be able to pass the desired format for the adjacent bridge chip through, but framework seems to be missing for that. As the main device to use DPI is the VGA666 or Adafruit Kippah, both of which use RGB666, change the default to being RGB666 instead of RGB888. Signed-off-by: Dave Stevenson Reviewed-by: Laurent Pinchart Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_dpi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_dpi.c b/drivers/gpu/drm/vc4/vc4_dpi.c index ecbe4cd87036..fdae02760b6d 100644 --- a/drivers/gpu/drm/vc4/vc4_dpi.c +++ b/drivers/gpu/drm/vc4/vc4_dpi.c @@ -150,8 +150,8 @@ static void vc4_dpi_encoder_enable(struct drm_encoder *= encoder) } drm_connector_list_iter_end(&conn_iter); =20 - /* Default to 24bit if no connector or format found. */ - dpi_c |=3D VC4_SET_FIELD(DPI_FORMAT_24BIT_888_RGB, DPI_FORMAT); + /* Default to 18bit if no connector or format found. */ + dpi_c |=3D VC4_SET_FIELD(DPI_FORMAT_18BIT_666_RGB_1, DPI_FORMAT); =20 if (connector) { if (connector->display_info.num_bus_formats) { --=20 b4 0.10.1