From nobody Fri Dec 19 04:23:32 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E55A8C43219 for ; Thu, 20 Oct 2022 08:51:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230434AbiJTIvI (ORCPT ); Thu, 20 Oct 2022 04:51:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56016 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229678AbiJTIvB (ORCPT ); Thu, 20 Oct 2022 04:51:01 -0400 Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4B675179389 for ; Thu, 20 Oct 2022 01:50:56 -0700 (PDT) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 6FA2A3200583; Thu, 20 Oct 2022 04:50:53 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Thu, 20 Oct 2022 04:50:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1666255853; x= 1666342253; bh=w9fLnwph45TF4TFvLOs558TwHHV6wwwwUgEx8H1VCC8=; b=M pjF6/f3TeD8o2nODqxzZRhrXDnT98v2FhlCtNWJUwyA+M6IOme8yKZ+eeqKDENJZ ogGiCtVAWf4E5NoyIJk/3zC3A+PoZicr63s6GGd38VUJQrlxzvnpeIhcNNzXW7vt PMeuwUJcaOre+b3MhCl4cJs6w5X5S+6+fcbr+D34gU4w13fNGwB+DQhwIWrGYcfP ttq4huy5c/FDaEKypkbETS1Jws2B5EDi6aSVfGBvWcGVIjupT0+ELX92EAn8pomS Jf8mfBq1P+Xn5LxjRh/N70rCBcn/+eGiBZO0oZ/51zR6XtmNjI0S18oeqeWB3RO6 q0Iwtm3h23iyIb4N50dgg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1666255853; x= 1666342253; bh=w9fLnwph45TF4TFvLOs558TwHHV6wwwwUgEx8H1VCC8=; b=S s19u63NKZrJJKcEAJCnMbZxjt4UWfQS2PARGNTwHmtuDasfXLO0okYGw7Pv51Edv juvbn9U6nAf5jSGmgMUfLUixdwl+LWJOWOUb8G9Dnw/tiTRx2zyf2bJspQPb0EY9 USRWlZZ8lNQuEZwYBKKaN0vgHfUKUGOS81riFR4w4+uE0XLf7B+eFTMd66pN0yKv w+Dvh6Qbxfb3/TjqAkxYzIxyrTQDWwtOdr7YafKdJCma9rg+Gcm3g+CK3c62wAQY mybMESLuhAKRr5a1GPs6QBFcDB5TkX5Kf+Qeco8LTgtDGJ67W0h2GV7/SRNnqzg8 1NdD2ID5nKB4EPmEO16fQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeeliedgtdekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephfffufggtgfgkfhfjgfvvefosehtkeertdertdejnecuhfhrohhmpeforgig ihhmvgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrf grthhtvghrnhepudduudfhveejteefgedvffdvvedvjedugedukeejhedtlefhffevtefh jeeltdevnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh epmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Feedback-ID: i8771445c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 20 Oct 2022 04:50:52 -0400 (EDT) From: Maxime Ripard Date: Thu, 20 Oct 2022 10:30:45 +0200 Subject: [PATCH v2 1/7] media: uapi: add MEDIA_BUS_FMT_RGB565_1X24_CPADHI MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20221013-rpi-dpi-improvements-v2-1-7691903fb9c8@cerno.tech> References: <20221013-rpi-dpi-improvements-v2-0-7691903fb9c8@cerno.tech> In-Reply-To: <20221013-rpi-dpi-improvements-v2-0-7691903fb9c8@cerno.tech> To: Emma Anholt , Maxime Ripard , Rob Herring , Daniel Vetter , Eric Anholt , David Airlie Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Joerg Quinten , Chris Morgan , Dave Stevenson , Laurent Pinchart , Maxime Ripard X-Mailer: b4 0.10.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=2439; i=maxime@cerno.tech; h=from:subject:message-id; bh=W7JgRSJCAGYWl+FNKphNaQremlGGiWyzZAhBKVcV0Jk=; b=owGbwMvMwCX2+D1vfrpE4FHG02pJDMmB7Ba93xoXzudPsFxdsuhN/zau5ZZO8esmrfi7Nr71SLDi 8YRnHaUsDGJcDLJiiiwxwuZL4k7Net3JxjcPZg4rE8gQBi5OAZgIzwpGhvON39YayAU/9jq8ap/Bpc ups35Pu/Fy7knfu7b7dr5tCHRjZDjlqZli/XvXK59dHtr+5vemTJpqvJmrJjHk/gd3h947s7gB X-Developer-Key: i=maxime@cerno.tech; a=openpgp; fpr=BE5675C37E818C8B5764241C254BCFC56BF6CE8D Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Chris Morgan Add the MEDIA_BUS_FMT_RGB565_1X24_CPADHI format used by the Geekworm MZP280 panel for the Raspberry Pi. Signed-off-by: Chris Morgan Signed-off-by: Maxime Ripard Reviewed-by: Laurent Pinchart --- .../userspace-api/media/v4l/subdev-formats.rst | 37 ++++++++++++++++++= ++++ include/uapi/linux/media-bus-format.h | 3 +- 2 files changed, 39 insertions(+), 1 deletion(-) diff --git a/Documentation/userspace-api/media/v4l/subdev-formats.rst b/Doc= umentation/userspace-api/media/v4l/subdev-formats.rst index d21d532eee15..1e61c02aa788 100644 --- a/Documentation/userspace-api/media/v4l/subdev-formats.rst +++ b/Documentation/userspace-api/media/v4l/subdev-formats.rst @@ -986,6 +986,43 @@ The following tables list existing packed RGB formats. - g\ :sub:`2` - g\ :sub:`1` - g\ :sub:`0` + * .. _MEDIA-BUS-FMT-RGB565-1X24_CPADHI: + + - MEDIA_BUS_FMT_RGB565_1X24_CPADHI + - 0x1022 + - + - + - + - + - + - + - + - + - + - 0 + - 0 + - 0 + - r\ :sub:`4` + - r\ :sub:`3` + - r\ :sub:`2` + - r\ :sub:`1` + - r\ :sub:`0` + - 0 + - 0 + - g\ :sub:`5` + - g\ :sub:`4` + - g\ :sub:`3` + - g\ :sub:`2` + - g\ :sub:`1` + - g\ :sub:`0` + - 0 + - 0 + - 0 + - b\ :sub:`4` + - b\ :sub:`3` + - b\ :sub:`2` + - b\ :sub:`1` + - b\ :sub:`0` * .. _MEDIA-BUS-FMT-RGB666-1X24_CPADHI: =20 - MEDIA_BUS_FMT_RGB666_1X24_CPADHI diff --git a/include/uapi/linux/media-bus-format.h b/include/uapi/linux/med= ia-bus-format.h index ec3323dbb927..b0a945eb7040 100644 --- a/include/uapi/linux/media-bus-format.h +++ b/include/uapi/linux/media-bus-format.h @@ -34,13 +34,14 @@ =20 #define MEDIA_BUS_FMT_FIXED 0x0001 =20 -/* RGB - next is 0x1022 */ +/* RGB - next is 0x1023 */ #define MEDIA_BUS_FMT_RGB444_1X12 0x1016 #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_BE 0x1001 #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_LE 0x1002 #define MEDIA_BUS_FMT_RGB555_2X8_PADHI_BE 0x1003 #define MEDIA_BUS_FMT_RGB555_2X8_PADHI_LE 0x1004 #define MEDIA_BUS_FMT_RGB565_1X16 0x1017 +#define MEDIA_BUS_FMT_RGB565_1X24_CPADHI 0x1022 #define MEDIA_BUS_FMT_BGR565_2X8_BE 0x1005 #define MEDIA_BUS_FMT_BGR565_2X8_LE 0x1006 #define MEDIA_BUS_FMT_RGB565_2X8_BE 0x1007 --=20 b4 0.10.1 From nobody Fri Dec 19 04:23:32 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5E7DC43219 for ; Thu, 20 Oct 2022 08:51:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230017AbiJTIvL (ORCPT ); Thu, 20 Oct 2022 04:51:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56042 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229904AbiJTIvC (ORCPT ); Thu, 20 Oct 2022 04:51:02 -0400 Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 49D1E176B9E for ; Thu, 20 Oct 2022 01:51:00 -0700 (PDT) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 8DFB7320091A; Thu, 20 Oct 2022 04:50:57 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Thu, 20 Oct 2022 04:50:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1666255857; x= 1666342257; bh=6BmxZWAyjtGIjNyaQNkRjZBqzpz5NoPfZAD21+NUfLw=; b=M D89TI7Ups78H9gI7Mv+rcE1wiLyWwo9n0oTn7mS7pyanBRF17tZiVvVqnUHRnEVY SpePLxMuH2X9HNccggAWQvkGfv5LTaSwyMe7zw+W11abhxj8L7wNBfcdGKxiTMZ6 /96oYhTzV4moq1srWhDrey4jl6BMD3rDm0HspRtWAGZRffsFfWSGHUDl/G1RQzrN sCblUhydwlvK7MiZ6BaaVWOocTXpm4n/3NBzGZ71LervA/tyyslVJq6bv0CZI4Ye 19ktdZbaWL4glE0dmNohA7GvVIS0Ut9xyA+3LmVfa35IEgc6v7Nl/xH+V63BQMc0 vVh0PRWNAPnlAGzjjHWIg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1666255857; x= 1666342257; bh=6BmxZWAyjtGIjNyaQNkRjZBqzpz5NoPfZAD21+NUfLw=; b=O fhjH82+kiE0rqZzxg6qRwhz8U7hpIn3nz5FPpjwl9dqdSxBlIGN9WiM7rf1K1TWw Kk3wlYKeAR4V4C/ZyeqqqcW3jDPui0kixy0GXz+6ZPHqAjekgH1T7fL6MfpYe92E jzQIK6aAEBo8w0swutlkzonYRaBSEcDg5S/QFBue6OwDzGbZJdbxZVV6Gd9NhnV1 FqJnZLbvc96+Db7UvXWOJnpBxLcd8v/XYCoWTbDkkLQaDXgJZENfixgZfcgcnJlv nx4jUudTrxPLse5rHoVgj/FyF63jYN+kGuYMeDiuvGaJT31FJguCATYhyf6Q4sWJ PZ2LTMEeSDZSWcBNLm+eg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeeliedgtdekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephfffufggtgfgkfhfjgfvvefosehtkeertdertdejnecuhfhrohhmpeforgig ihhmvgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrf grthhtvghrnhepudduudfhveejteefgedvffdvvedvjedugedukeejhedtlefhffevtefh jeeltdevnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh epmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Feedback-ID: i8771445c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 20 Oct 2022 04:50:56 -0400 (EDT) From: Maxime Ripard Date: Thu, 20 Oct 2022 10:30:46 +0200 Subject: [PATCH v2 2/7] media: uapi: add MEDIA_BUS_FMT_BGR666_1X18 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20221013-rpi-dpi-improvements-v2-2-7691903fb9c8@cerno.tech> References: <20221013-rpi-dpi-improvements-v2-0-7691903fb9c8@cerno.tech> In-Reply-To: <20221013-rpi-dpi-improvements-v2-0-7691903fb9c8@cerno.tech> To: Emma Anholt , Maxime Ripard , Rob Herring , Daniel Vetter , Eric Anholt , David Airlie Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Joerg Quinten , Chris Morgan , Dave Stevenson , Laurent Pinchart , Maxime Ripard X-Mailer: b4 0.10.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=2403; i=maxime@cerno.tech; h=from:subject:message-id; bh=szjBqRq1RvNKILPE+9E7yhnpqEgZLZ5Nn5mxleAdPwg=; b=owGbwMvMwCX2+D1vfrpE4FHG02pJDMmB7BaflXmDGda4h/+r2b1Yvd1e8KfIDgW3p882zVjs/7K8 nG1xRykLgxgXg6yYIkuMsPmSuFOzXney8c2DmcPKBDKEgYtTACZiHMTw301Rfe/SZ2dbO43erlH0Pt KROEv/eXYh+/OTbUJbvm1SPcjIsPv3zgtrtPk2xP6z6bKtarBW4hKbcuvTtIt9YSb6WgePcgEA X-Developer-Key: i=maxime@cerno.tech; a=openpgp; fpr=BE5675C37E818C8B5764241C254BCFC56BF6CE8D Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Joerg Quinten Add the BGR666 format MEDIA_BUS_FMT_BGR666_1X18 supported by the RaspberryPi. Signed-off-by: Joerg Quinten Signed-off-by: Maxime Ripard Reviewed-by: Laurent Pinchart --- .../userspace-api/media/v4l/subdev-formats.rst | 37 ++++++++++++++++++= ++++ include/uapi/linux/media-bus-format.h | 3 +- 2 files changed, 39 insertions(+), 1 deletion(-) diff --git a/Documentation/userspace-api/media/v4l/subdev-formats.rst b/Doc= umentation/userspace-api/media/v4l/subdev-formats.rst index 1e61c02aa788..68f8d7d37984 100644 --- a/Documentation/userspace-api/media/v4l/subdev-formats.rst +++ b/Documentation/userspace-api/media/v4l/subdev-formats.rst @@ -912,6 +912,43 @@ The following tables list existing packed RGB formats. - g\ :sub:`5` - g\ :sub:`4` - g\ :sub:`3` + * .. _MEDIA-BUS-FMT-BGR666-1X18: + + - MEDIA_BUS_FMT_BGR666_1X18 + - 0x1023 + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - b\ :sub:`5` + - b\ :sub:`4` + - b\ :sub:`3` + - b\ :sub:`2` + - b\ :sub:`1` + - b\ :sub:`0` + - g\ :sub:`5` + - g\ :sub:`4` + - g\ :sub:`3` + - g\ :sub:`2` + - g\ :sub:`1` + - g\ :sub:`0` + - r\ :sub:`5` + - r\ :sub:`4` + - r\ :sub:`3` + - r\ :sub:`2` + - r\ :sub:`1` + - r\ :sub:`0` * .. _MEDIA-BUS-FMT-RGB666-1X18: =20 - MEDIA_BUS_FMT_RGB666_1X18 diff --git a/include/uapi/linux/media-bus-format.h b/include/uapi/linux/med= ia-bus-format.h index b0a945eb7040..2ee0b38c0a71 100644 --- a/include/uapi/linux/media-bus-format.h +++ b/include/uapi/linux/media-bus-format.h @@ -34,7 +34,7 @@ =20 #define MEDIA_BUS_FMT_FIXED 0x0001 =20 -/* RGB - next is 0x1023 */ +/* RGB - next is 0x1024 */ #define MEDIA_BUS_FMT_RGB444_1X12 0x1016 #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_BE 0x1001 #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_LE 0x1002 @@ -46,6 +46,7 @@ #define MEDIA_BUS_FMT_BGR565_2X8_LE 0x1006 #define MEDIA_BUS_FMT_RGB565_2X8_BE 0x1007 #define MEDIA_BUS_FMT_RGB565_2X8_LE 0x1008 +#define MEDIA_BUS_FMT_BGR666_1X18 0x1023 #define MEDIA_BUS_FMT_RGB666_1X18 0x1009 #define MEDIA_BUS_FMT_RBG888_1X24 0x100e #define MEDIA_BUS_FMT_RGB666_1X24_CPADHI 0x1015 --=20 b4 0.10.1 From nobody Fri Dec 19 04:23:32 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BB73C43219 for ; Thu, 20 Oct 2022 08:51:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231139AbiJTIvO (ORCPT ); Thu, 20 Oct 2022 04:51:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56198 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229773AbiJTIvF (ORCPT ); Thu, 20 Oct 2022 04:51:05 -0400 Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 255F01781FF for ; Thu, 20 Oct 2022 01:51:04 -0700 (PDT) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id D9CE532000D7; Thu, 20 Oct 2022 04:51:01 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Thu, 20 Oct 2022 04:51:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1666255861; x= 1666342261; bh=PKJ8/FJVazKu0rZJdSAHPWz1uZunYeVSN11ubuL5dWc=; b=V MzVtaUkg7Y3PWdnsLOiEmUAX0nF4RrS/0WEYbBy90H8KPh258WUpD6S/dRII4g09 MupOIzPHfjlKOxZ/KX/kJhpjmP3hirvvsO2l/sKL6lgzBSO7boF8CaHdQd/HdBUQ E5dQawfdGa5Lxf1tfuEqceJ/fSrK4mmsBrt3ZVcTkCLcKDLUu7bwIp/hNXxweP3o eqkP6qxOcCqRhynQaLGSM+38GxwVxvCitTffMGdDcvdA0jOBsR/0Yx60QVkuYMfX ZHeZFV0iB0HKSv9Z9sgU1bDMGSrDmC58F5rJg27NZbFnPzEpJQvorJOEXEOYsTl3 BUkDivw1T/bpDK4++i8Ow== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1666255861; x= 1666342261; bh=PKJ8/FJVazKu0rZJdSAHPWz1uZunYeVSN11ubuL5dWc=; b=J 8j1JY2EpwA4+43ebhjFQT5/9ysUSeAmwUSZbwYVjAUn8yBEkT0ywh0EaT5/Wp0jo o6IqCDElU4x93hjtY1jZ81+POPy6pfoTCPftGbWcUERMh+pkFkyq4osNVaxGqZ7M Lqx1HN+Uujwf9teiq5NRThb+O0m3aQfXtOOyMLqEiJIGLE/16lw2LOmj168nmeKC QNj+T7JBRGa77tv1fRzEFB3YJav5fYY8787Zt7xWYbuSCRrZN+v+H4Vfl4DSdOU6 7PYKmvC8v8EtTVBkV1/nTF8OCRDfKWaGMr4QdoHoFRTfTg4sKL3GVWp8fZyZdqGA Oty0FJ0ja0p9g8ysyfwDA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeeliedgtdekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephfffufggtgfgkfhfjgfvvefosehtkeertdertdejnecuhfhrohhmpeforgig ihhmvgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrf grthhtvghrnhepudduudfhveejteefgedvffdvvedvjedugedukeejhedtlefhffevtefh jeeltdevnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh epmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Feedback-ID: i8771445c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 20 Oct 2022 04:51:00 -0400 (EDT) From: Maxime Ripard Date: Thu, 20 Oct 2022 10:30:47 +0200 Subject: [PATCH v2 3/7] media: uapi: add MEDIA_BUS_FMT_BGR666_1X24_CPADHI MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20221013-rpi-dpi-improvements-v2-3-7691903fb9c8@cerno.tech> References: <20221013-rpi-dpi-improvements-v2-0-7691903fb9c8@cerno.tech> In-Reply-To: <20221013-rpi-dpi-improvements-v2-0-7691903fb9c8@cerno.tech> To: Emma Anholt , Maxime Ripard , Rob Herring , Daniel Vetter , Eric Anholt , David Airlie Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Joerg Quinten , Chris Morgan , Dave Stevenson , Laurent Pinchart , Maxime Ripard X-Mailer: b4 0.10.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=2458; i=maxime@cerno.tech; h=from:subject:message-id; bh=sMF/6xWvN1j3OHomDCM8BkX4bvf8ec1/O5U3k7n2Q1s=; b=owGbwMvMwCX2+D1vfrpE4FHG02pJDMmB7BZzTOs3/BBI4AjcGvPnxvYN0qft/rL/ruHtXvxiEkPK 6obXHaUsDGJcDLJiiiwxwuZL4k7Net3JxjcPZg4rE8gQBi5OAZjI6SkMfyUk1isu553M2hF9pmtGTL h4+dHXqVuLg0yUit4aNorYPGVkmO1ktfr020lhC/6defthwqTH7Qt5Q87cKI32b3v5m1dpJjsA X-Developer-Key: i=maxime@cerno.tech; a=openpgp; fpr=BE5675C37E818C8B5764241C254BCFC56BF6CE8D Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Joerg Quinten Add the BGR666 format MEDIA_BUS_FMT_BGR666_1X24_CPADHI supported by the RaspberryPi. Signed-off-by: Joerg Quinten Signed-off-by: Maxime Ripard --- .../userspace-api/media/v4l/subdev-formats.rst | 37 ++++++++++++++++++= ++++ include/uapi/linux/media-bus-format.h | 3 +- 2 files changed, 39 insertions(+), 1 deletion(-) diff --git a/Documentation/userspace-api/media/v4l/subdev-formats.rst b/Doc= umentation/userspace-api/media/v4l/subdev-formats.rst index 68f8d7d37984..604a30e2f890 100644 --- a/Documentation/userspace-api/media/v4l/subdev-formats.rst +++ b/Documentation/userspace-api/media/v4l/subdev-formats.rst @@ -1023,6 +1023,43 @@ The following tables list existing packed RGB format= s. - g\ :sub:`2` - g\ :sub:`1` - g\ :sub:`0` + * .. _MEDIA-BUS-FMT-BGR666-1X24_CPADHI: + + - MEDIA_BUS_FMT_BGR666_1X24_CPADHI + - 0x1024 + - + - + - + - + - + - + - + - + - + - 0 + - 0 + - b\ :sub:`5` + - b\ :sub:`4` + - b\ :sub:`3` + - b\ :sub:`2` + - b\ :sub:`1` + - b\ :sub:`0` + - 0 + - 0 + - g\ :sub:`5` + - g\ :sub:`4` + - g\ :sub:`3` + - g\ :sub:`2` + - g\ :sub:`1` + - g\ :sub:`0` + - 0 + - 0 + - r\ :sub:`5` + - r\ :sub:`4` + - r\ :sub:`3` + - r\ :sub:`2` + - r\ :sub:`1` + - r\ :sub:`0` * .. _MEDIA-BUS-FMT-RGB565-1X24_CPADHI: =20 - MEDIA_BUS_FMT_RGB565_1X24_CPADHI diff --git a/include/uapi/linux/media-bus-format.h b/include/uapi/linux/med= ia-bus-format.h index 2ee0b38c0a71..d4228d038b54 100644 --- a/include/uapi/linux/media-bus-format.h +++ b/include/uapi/linux/media-bus-format.h @@ -34,7 +34,7 @@ =20 #define MEDIA_BUS_FMT_FIXED 0x0001 =20 -/* RGB - next is 0x1024 */ +/* RGB - next is 0x1025 */ #define MEDIA_BUS_FMT_RGB444_1X12 0x1016 #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_BE 0x1001 #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_LE 0x1002 @@ -49,6 +49,7 @@ #define MEDIA_BUS_FMT_BGR666_1X18 0x1023 #define MEDIA_BUS_FMT_RGB666_1X18 0x1009 #define MEDIA_BUS_FMT_RBG888_1X24 0x100e +#define MEDIA_BUS_FMT_BGR666_1X24_CPADHI 0x1024 #define MEDIA_BUS_FMT_RGB666_1X24_CPADHI 0x1015 #define MEDIA_BUS_FMT_RGB666_1X7X3_SPWG 0x1010 #define MEDIA_BUS_FMT_BGR888_1X24 0x1013 --=20 b4 0.10.1 From nobody Fri Dec 19 04:23:32 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBF96C43217 for ; Thu, 20 Oct 2022 08:51:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229834AbiJTIvX (ORCPT ); Thu, 20 Oct 2022 04:51:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56434 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229678AbiJTIvJ (ORCPT ); Thu, 20 Oct 2022 04:51:09 -0400 Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 77D3B179393 for ; Thu, 20 Oct 2022 01:51:08 -0700 (PDT) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 131773200583; Thu, 20 Oct 2022 04:51:06 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Thu, 20 Oct 2022 04:51:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1666255865; x= 1666342265; bh=Wp89GBtaW7MK+d6la9pPlll3p7zimHiYkS2UgGO+ZZU=; b=l chM0eOx3Dw4kP0ES8W12SwG48TR/QoerJb08GDo6xtOFNEIWlWzHYt5+FBSGQFXa jzbM1/1UjqOEw/c3GgM4PnKzBwelSSqKka4QLesQyfTH3VaFeKWxtjOklGn0KnRJ 5c4fnQ0O/OwurmaNt92FEO10YHAjis/FDROTb4RoPimtKIEYqpNJOJ4lk/xs2cUI ulswPthWwA5xtdHU78u69fsqcQMNbRZu8e1YiITmz6Uug7RKs8sy1nvRZ+YE5cEg JAifJZMjqlzXt40C3LTPUnGK3vcV3nLgrtwhUABvue8lML8Itvg2uquQjY/jApyB If6dysu0Cs94rx8yKCu5A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1666255865; x= 1666342265; bh=Wp89GBtaW7MK+d6la9pPlll3p7zimHiYkS2UgGO+ZZU=; b=g HzCu5KQFMzB+LY0FxHpyzzpecUYLUIqTKXUF3lWOdLS4kNOWo4SzJN7fJOlJIhyF oRk7W6kXPeeAUnJLPpe+tGhlhzaAPJXq0MMXqb5YMo7lUCYeCCZ/RwrGEo1RpI0Z gvqH+9LOsAiI1esWkxlq1v+c8nXemxsi0aYsL4SCekaMhUggAlOZwOquXGzbl+wv 4nApoO6kX0h7SaTWBtarn/BZ/JaxzXyqDagQAO0mDj4qIpDJ15e7DmOJy4jlm5+o ak+QxXxDxwww8XsBSTD+9gPxYDRlEDOO9nzVDT3lZzECAB+7iaJHmi8ojE/OnihW R/2lgc6EN2oDtaSNJQ/3w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeeliedgtdejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephfffufggtgfgkfhfjgfvvefosehtkeertdertdejnecuhfhrohhmpeforgig ihhmvgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrf grthhtvghrnhepudduudfhveejteefgedvffdvvedvjedugedukeejhedtlefhffevtefh jeeltdevnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh epmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Feedback-ID: i8771445c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 20 Oct 2022 04:51:05 -0400 (EDT) From: Maxime Ripard Date: Thu, 20 Oct 2022 10:30:48 +0200 Subject: [PATCH v2 4/7] drm/vc4: dpi: Support RGB565 format MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20221013-rpi-dpi-improvements-v2-4-7691903fb9c8@cerno.tech> References: <20221013-rpi-dpi-improvements-v2-0-7691903fb9c8@cerno.tech> In-Reply-To: <20221013-rpi-dpi-improvements-v2-0-7691903fb9c8@cerno.tech> To: Emma Anholt , Maxime Ripard , Rob Herring , Daniel Vetter , Eric Anholt , David Airlie Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Joerg Quinten , Chris Morgan , Dave Stevenson , Laurent Pinchart , Maxime Ripard X-Mailer: b4 0.10.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1170; i=maxime@cerno.tech; h=from:subject:message-id; bh=frMUS74NDFOUKqROpfuyhXgF/ifuNk0VZpwfF7mFoNs=; b=owGbwMvMwCX2+D1vfrpE4FHG02pJDMmB7Ba75V9qzzon6dGyNU19yR7dub8VA3+udztx2E9D1VhD eeeijlIWBjEuBlkxRZYYYfMlcadmve5k45sHM4eVCWQIAxenAExEK4KR4bJshJ+gbmtsw6YTy169Ch Crf9a7jaM7/+/tskDP1PKb2xgZ/rVFnLvtIHV787SliV1HvS7qHE+UmnBvr+mv6DT35L+PeQE= X-Developer-Key: i=maxime@cerno.tech; a=openpgp; fpr=BE5675C37E818C8B5764241C254BCFC56BF6CE8D Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Chris Morgan The RGB565 format with padding over 24 bits (MEDIA_BUS_FMT_RGB565_1X24_CPADHI) is supported by the vc4 DPI controller. This is what the Geekworm MZP280 DPI display uses, so let's add support for it in the DPI controller driver. Reviewed-by: Dave Stevenson Signed-off-by: Chris Morgan Reviewed-by: Laurent Pinchart Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_dpi.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/vc4/vc4_dpi.c b/drivers/gpu/drm/vc4/vc4_dpi.c index 1f8f44b7b5a5..7da3dd1db50e 100644 --- a/drivers/gpu/drm/vc4/vc4_dpi.c +++ b/drivers/gpu/drm/vc4/vc4_dpi.c @@ -182,6 +182,10 @@ static void vc4_dpi_encoder_enable(struct drm_encoder = *encoder) dpi_c |=3D VC4_SET_FIELD(DPI_FORMAT_16BIT_565_RGB_3, DPI_FORMAT); break; + case MEDIA_BUS_FMT_RGB565_1X24_CPADHI: + dpi_c |=3D VC4_SET_FIELD(DPI_FORMAT_16BIT_565_RGB_2, + DPI_FORMAT); + break; default: DRM_ERROR("Unknown media bus format %d\n", bus_format); --=20 b4 0.10.1 From nobody Fri Dec 19 04:23:32 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C365C4332F for ; Thu, 20 Oct 2022 08:51:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229778AbiJTIv2 (ORCPT ); Thu, 20 Oct 2022 04:51:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56626 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230423AbiJTIvN (ORCPT ); Thu, 20 Oct 2022 04:51:13 -0400 Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8727717A966 for ; Thu, 20 Oct 2022 01:51:12 -0700 (PDT) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 467B832003D3; Thu, 20 Oct 2022 04:51:10 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 20 Oct 2022 04:51:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1666255869; x= 1666342269; bh=yGORwJBsPkh/b0PObL5kDZslL3mkGzpnk9pANWLtbFs=; b=R F/e6nG1oGtWtLKwmv1Hp22kktKRLUsE7aSbDaNaQr16hto4FkwVnx8KfnmY/I3mF A8fKilcRPBH9qaZIBZtLzwIW4yzTujN2lmSbZchyal8Xpj77qC+rIfVsv6vcikEd eN7arcVaYrd8QF2A8CxZWOgAvfDuS/kbOmbaGdYxwDVk4Fxoi7+DfK7WsBWaURAT L5xRwllSWb3PbZK3nWC3L3k/H5ybqLrJCMB6uVVb8gK0WJnTBJGu4mdzrj2J4axo 7NISld44ljdxO2E9kg/SMOtrnrXOsTzD2W/BbbLp7aMgbA/fHMDnRDM2huT3cj4b E0mX9qfh+8YCMN3KADgUw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1666255869; x= 1666342269; bh=yGORwJBsPkh/b0PObL5kDZslL3mkGzpnk9pANWLtbFs=; b=F LIQ4pRWVfCRPaYwqglWHkdxKORDesBGtz5XS4fL0F78BHpSZUHw2Fw7CDk+qBLYM Ne1ZzXXMGFxqZkB0AC0ikUCWfxfujicxCnr/vW8dZHU+OSt/1+wCCYjGeyny7Zw2 W3sTRyKYfb7FI6/Nj8M/uI1cO9pCAr2V/AgvZyCmTB8e+KnkOUzFJLiHxEzcG8lv UkVKvHGcRVlrKnieDKoegyalzYL28oaiJAvpgdim9aG0/EU0OSN2l2EDXt6G3php sbWlHc7nYDZDYx7EZYrzXdlmiKz+KT+QQ6olULouN8hI+te7qry8c9u70PsVs0Pc h0bZE6eQ9s/gFrHOKfzCg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeeliedgtdekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephfffufggtgfgkfhfjgfvvefosehtkeertdertdejnecuhfhrohhmpeforgig ihhmvgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrf grthhtvghrnhepudduudfhveejteefgedvffdvvedvjedugedukeejhedtlefhffevtefh jeeltdevnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh epmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Feedback-ID: i8771445c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 20 Oct 2022 04:51:09 -0400 (EDT) From: Maxime Ripard Date: Thu, 20 Oct 2022 10:30:49 +0200 Subject: [PATCH v2 5/7] drm/vc4: dpi: Support BGR666 formats MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20221013-rpi-dpi-improvements-v2-5-7691903fb9c8@cerno.tech> References: <20221013-rpi-dpi-improvements-v2-0-7691903fb9c8@cerno.tech> In-Reply-To: <20221013-rpi-dpi-improvements-v2-0-7691903fb9c8@cerno.tech> To: Emma Anholt , Maxime Ripard , Rob Herring , Daniel Vetter , Eric Anholt , David Airlie Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Joerg Quinten , Chris Morgan , Dave Stevenson , Laurent Pinchart , Maxime Ripard X-Mailer: b4 0.10.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1285; i=maxime@cerno.tech; h=from:subject:message-id; bh=C2A769Ttl36FCHI2s5BdHwC3a6/7DNTBsfWdG3Cv96g=; b=owGbwMvMwCX2+D1vfrpE4FHG02pJDMmB7BbBN0M3V35rW1HuL19zU2zu0bnLupbHxEeaTta7ISj5 tiK+o5SFQYyLQVZMkSVG2HxJ3KlZrzvZ+ObBzGFlAhnCwMUpABNRWcbIsPLk7IRtmgobuNW+1Gxw9d 7y3GlhJdcMq8999cem/GwvXsPwP7jsuZTc6jk5i8S/2Vx1i7rsbHz3xVuuTWH/eXf8frx1ASsA X-Developer-Key: i=maxime@cerno.tech; a=openpgp; fpr=BE5675C37E818C8B5764241C254BCFC56BF6CE8D Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Joerg Quinten The VC4 DPI output can support multiple BGR666 variants, but they were never added to the driver. Let's add the the support for those formats. Signed-off-by: Joerg Quinten Reviewed-by: Laurent Pinchart Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_dpi.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/vc4/vc4_dpi.c b/drivers/gpu/drm/vc4/vc4_dpi.c index 7da3dd1db50e..ecbe4cd87036 100644 --- a/drivers/gpu/drm/vc4/vc4_dpi.c +++ b/drivers/gpu/drm/vc4/vc4_dpi.c @@ -170,10 +170,16 @@ static void vc4_dpi_encoder_enable(struct drm_encoder= *encoder) dpi_c |=3D VC4_SET_FIELD(DPI_ORDER_BGR, DPI_ORDER); break; + case MEDIA_BUS_FMT_BGR666_1X24_CPADHI: + dpi_c |=3D VC4_SET_FIELD(DPI_ORDER_BGR, DPI_ORDER); + fallthrough; case MEDIA_BUS_FMT_RGB666_1X24_CPADHI: dpi_c |=3D VC4_SET_FIELD(DPI_FORMAT_18BIT_666_RGB_2, DPI_FORMAT); break; + case MEDIA_BUS_FMT_BGR666_1X18: + dpi_c |=3D VC4_SET_FIELD(DPI_ORDER_BGR, DPI_ORDER); + fallthrough; case MEDIA_BUS_FMT_RGB666_1X18: dpi_c |=3D VC4_SET_FIELD(DPI_FORMAT_18BIT_666_RGB_1, DPI_FORMAT); --=20 b4 0.10.1 From nobody Fri Dec 19 04:23:32 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D701BC433FE for ; Thu, 20 Oct 2022 08:51:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229498AbiJTIvy (ORCPT ); Thu, 20 Oct 2022 04:51:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57414 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230121AbiJTIvi (ORCPT ); Thu, 20 Oct 2022 04:51:38 -0400 Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D4A6D188118 for ; Thu, 20 Oct 2022 01:51:17 -0700 (PDT) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 6252232000D7; Thu, 20 Oct 2022 04:51:14 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Thu, 20 Oct 2022 04:51:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1666255873; x= 1666342273; bh=1vlWw3HWcseVhvxGIduvYvORASnSFa/0anA5xMkzYTs=; b=g QElMFuJcDsgncugOjpbYGI1H9ih9YvRSBLbN3k5TIgGyuVRoy2mi456VQ7FNC8UR GO0b78y1FoXrQI2Jjm7jhMYonJ0iM6IR2rPKIHaFEZN6+ho89RAT7rj16+yOJiQq sJOg1+PQCH6uY/jdddErH2ZUiuUcGSfIO67KzVAZcfVOj3LeMmDydHy5/TWKC1n8 wqlx/BWw74vY38QOChFlhc8zalGvc7RFhfiJ7j9Odv/5Y/G8gwXA/gqhUdeCVb2d 2kjejGC0ZLg+nSecnWKrshQ5XXndF97CvgEXXcGXjLTObypxCd5rrdRgW2sg6lso pVySV5jV+IGWJO003Yxjg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1666255873; x= 1666342273; bh=1vlWw3HWcseVhvxGIduvYvORASnSFa/0anA5xMkzYTs=; b=s lJTVlCthi+dMq65myMAszoI5FjYJIVPe1qSwkyCsKrCUILT+NoR+8JIlcWErSNs3 m6Sgjzjy7uMOPNq2SombqDABPUD/yBn3OoSD5fsGnlEIrznAgijrpcarlxqvkuKT UJ8zHf/RDclQVRGTpxSoz5rt2Hiyz0y+dPeeVQxeMYHvnevJQhfCrD+N6l/vUAL4 KN7stVXpm96mqvKEH2PY8M0BZc53djxCbVmqvnswn2Hck3rIYtkhzX5OwWxMfu+/ rhitaV7G1XpG3XfXfb6r7HZXAtMkC53jvME+pCHqkblC3deBEIdHsIE+Vncixbfu H6/WBZo8lxH0KWfoCQauQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeeliedgtdejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephfffufggtgfgkfhfjgfvvefosehtkeertdertdejnecuhfhrohhmpeforgig ihhmvgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrf grthhtvghrnhepudduudfhveejteefgedvffdvvedvjedugedukeejhedtlefhffevtefh jeeltdevnecuvehluhhsthgvrhfuihiivgepudenucfrrghrrghmpehmrghilhhfrhhomh epmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Feedback-ID: i8771445c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 20 Oct 2022 04:51:13 -0400 (EDT) From: Maxime Ripard Date: Thu, 20 Oct 2022 10:30:50 +0200 Subject: [PATCH v2 6/7] drm/vc4: dpi: Change the default DPI format to being 18bpp, not 24. MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20221013-rpi-dpi-improvements-v2-6-7691903fb9c8@cerno.tech> References: <20221013-rpi-dpi-improvements-v2-0-7691903fb9c8@cerno.tech> In-Reply-To: <20221013-rpi-dpi-improvements-v2-0-7691903fb9c8@cerno.tech> To: Emma Anholt , Maxime Ripard , Rob Herring , Daniel Vetter , Eric Anholt , David Airlie Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Joerg Quinten , Chris Morgan , Dave Stevenson , Laurent Pinchart , Maxime Ripard X-Mailer: b4 0.10.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1321; i=maxime@cerno.tech; h=from:subject:message-id; bh=Cj2SqCiv0e+hjTKV6Xz2WDeMWOb4ZCwlvcwXbXBSakE=; b=owGbwMvMwCX2+D1vfrpE4FHG02pJDMmB7BZPrb6beAiELopZJFi288SeAy/UTnglpW9cUPDMuLVI UeBMRykLgxgXg6yYIkuMsPmSuFOzXney8c2DmcPKBDKEgYtTACayUIeR4ZHri38VJRdLzsifNmN0X2 NYtZRty77Vt/xsv65qVlfIW8Pwz6T9WnyjeWjenk3PYr9IWglfNi/37Ep66pqn8elxz1cNVgA= X-Developer-Key: i=maxime@cerno.tech; a=openpgp; fpr=BE5675C37E818C8B5764241C254BCFC56BF6CE8D Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dave Stevenson DPI hasn't really been used up until now, so the default has been meaningless. In theory we should be able to pass the desired format for the adjacent bridge chip through, but framework seems to be missing for that. As the main device to use DPI is the VGA666 or Adafruit Kippah, both of which use RGB666, change the default to being RGB666 instead of RGB888. Signed-off-by: Dave Stevenson Reviewed-by: Laurent Pinchart Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_dpi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_dpi.c b/drivers/gpu/drm/vc4/vc4_dpi.c index ecbe4cd87036..fdae02760b6d 100644 --- a/drivers/gpu/drm/vc4/vc4_dpi.c +++ b/drivers/gpu/drm/vc4/vc4_dpi.c @@ -150,8 +150,8 @@ static void vc4_dpi_encoder_enable(struct drm_encoder *= encoder) } drm_connector_list_iter_end(&conn_iter); =20 - /* Default to 24bit if no connector or format found. */ - dpi_c |=3D VC4_SET_FIELD(DPI_FORMAT_24BIT_888_RGB, DPI_FORMAT); + /* Default to 18bit if no connector or format found. */ + dpi_c |=3D VC4_SET_FIELD(DPI_FORMAT_18BIT_666_RGB_1, DPI_FORMAT); =20 if (connector) { if (connector->display_info.num_bus_formats) { --=20 b4 0.10.1 From nobody Fri Dec 19 04:23:32 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 057E0C4332F for ; Thu, 20 Oct 2022 08:52:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230401AbiJTIwC (ORCPT ); Thu, 20 Oct 2022 04:52:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57570 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231196AbiJTIvo (ORCPT ); Thu, 20 Oct 2022 04:51:44 -0400 Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 231C018C962 for ; Thu, 20 Oct 2022 01:51:22 -0700 (PDT) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 6F4C6320091A; Thu, 20 Oct 2022 04:51:18 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Thu, 20 Oct 2022 04:51:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1666255878; x= 1666342278; bh=xhtPz8Dqfioscgg3yoemS47J761NmMtmupbcefOZt74=; b=p IVewE0Z001+xXD14v17px7/vL/VxtVJrbQt+NJ6J9T8W/JvZY0/LJ6bkUmDm6fQw QoQvlOtwBp8Wa1wAuf1PRQK4Z8Zp29IQIZB0mSL7Cp7I05vGgLvFNY6gM64dWcQC ngCxUgzgTA8G5i4wmUP9xT4M+5QoERh+3tM4kOe4B0ynR+ZU+AZ4ZzCEU36bgYGW bzlcrKflb9qW41WBomCSmi/vV6lN15P4q1R5rWIWHT2Su8Maw1gUQpbjrmB1wExd 7mN6PhxI2fEGXrNrvlHXn+DJRLjk0u9F/vtiNMF1OBVngXkVvSimJE/cptsALTQR n1cc3r6b85CeX8OeaHnCQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1666255878; x= 1666342278; bh=xhtPz8Dqfioscgg3yoemS47J761NmMtmupbcefOZt74=; b=C YXW505xbvqJ2G9zUNNnOvQMxGHFv/58s3C41nZicrHh0R89cuLhDmM3wtW6XplC1 Zt0Er0ad66JMQN6UcG2uB4KaaSCpo1KTE1J8AZuJB5RlJ5eulFmaOKwdgFfhTQLm PTemKkm88XPxWlbkAu8KDRNv00ZYkwLjV5diX1YOeWjhhyGkuIeMomzIhmUD91BF KH/RMl90dh1L2nYyT9szLoHDXQOs/Tw/lo4gRlf0iNW9KHJF5RXlE/N9aI6s5By7 dH+WPRjIgVe2+MPgGqsZYtXd/V6NMpsH5FWAtOeayZ7U1TDRYC1pilO6xXBhcEtL 08tne4wslk6/9tzqyokeg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeeliedgtdekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephfffufggtgfgkfhfjgfvvefosehtkeertdertdejnecuhfhrohhmpeforgig ihhmvgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrf grthhtvghrnhepudduudfhveejteefgedvffdvvedvjedugedukeejhedtlefhffevtefh jeeltdevnecuvehluhhsthgvrhfuihiivgepudenucfrrghrrghmpehmrghilhhfrhhomh epmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Feedback-ID: i8771445c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 20 Oct 2022 04:51:17 -0400 (EDT) From: Maxime Ripard Date: Thu, 20 Oct 2022 10:30:51 +0200 Subject: [PATCH v2 7/7] drm/vc4: dpi: Fix format mapping for RGB565 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20221013-rpi-dpi-improvements-v2-7-7691903fb9c8@cerno.tech> References: <20221013-rpi-dpi-improvements-v2-0-7691903fb9c8@cerno.tech> In-Reply-To: <20221013-rpi-dpi-improvements-v2-0-7691903fb9c8@cerno.tech> To: Emma Anholt , Maxime Ripard , Rob Herring , Daniel Vetter , Eric Anholt , David Airlie Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Joerg Quinten , Chris Morgan , Dave Stevenson , Laurent Pinchart , Maxime Ripard X-Mailer: b4 0.10.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1022; i=maxime@cerno.tech; h=from:subject:message-id; bh=43Ff0zFIOvU8ONzBI2sMboXcyvjpYfdtbjUUqEZ+IMo=; b=owGbwMvMwCX2+D1vfrpE4FHG02pJDMmB7BZun+9cOHhhZkG26VLBhMoqro9zxHQ+PCx667xsuZma k/aijlIWBjEuBlkxRZYYYfMlcadmve5k45sHM4eVCWQIAxenAEzkNyfDH44Js/RL30h/b5r/keNHVN 69AHY+vat1EfyvqnU+Tz7wroCRYe/BjROqBet2JGWJf3k4TzZpjwfzZlad31VF87ebilinsQIA X-Developer-Key: i=maxime@cerno.tech; a=openpgp; fpr=BE5675C37E818C8B5764241C254BCFC56BF6CE8D Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dave Stevenson The mapping is incorrect for RGB565_1X16 as it should be DPI_FORMAT_18BIT_666_RGB_1 instead of DPI_FORMAT_18BIT_666_RGB_3. Fixes: 08302c35b59d ("drm/vc4: Add DPI driver") Signed-off-by: Dave Stevenson Reviewed-by: Laurent Pinchart Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_dpi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/vc4/vc4_dpi.c b/drivers/gpu/drm/vc4/vc4_dpi.c index fdae02760b6d..a7bebfa5d5b0 100644 --- a/drivers/gpu/drm/vc4/vc4_dpi.c +++ b/drivers/gpu/drm/vc4/vc4_dpi.c @@ -185,7 +185,7 @@ static void vc4_dpi_encoder_enable(struct drm_encoder *= encoder) DPI_FORMAT); break; case MEDIA_BUS_FMT_RGB565_1X16: - dpi_c |=3D VC4_SET_FIELD(DPI_FORMAT_16BIT_565_RGB_3, + dpi_c |=3D VC4_SET_FIELD(DPI_FORMAT_16BIT_565_RGB_1, DPI_FORMAT); break; case MEDIA_BUS_FMT_RGB565_1X24_CPADHI: --=20 b4 0.10.1