From nobody Tue Apr 7 04:59:56 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39752C4332F for ; Wed, 12 Oct 2022 04:10:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229716AbiJLEKR (ORCPT ); Wed, 12 Oct 2022 00:10:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57510 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229656AbiJLEKH (ORCPT ); Wed, 12 Oct 2022 00:10:07 -0400 Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [IPv6:2607:f8b0:4864:20::1034]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1F93E1F9C0 for ; Tue, 11 Oct 2022 21:10:03 -0700 (PDT) Received: by mail-pj1-x1034.google.com with SMTP id x1-20020a17090ab00100b001fda21bbc90so866736pjq.3 for ; Tue, 11 Oct 2022 21:10:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=YMYmfDXtL0KG/q4RUcOljekTDXhrXEWn1lhT/Gvet50=; b=KWuAptyXrV9UyQlEdIeE0PJ8h7lVIvj+GqsN3AFoOJIv2PKcs6CkTnyHETGMJ09JJ9 OdZ3nHPANP8OmWj/wUfATpxihKgVo4ymZEx2yAiYbQEEipllFCFf3oAo37Izx8ndnVw2 amoKih8BI0s+gMumoGvtlWR2cg/C85IaasecI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YMYmfDXtL0KG/q4RUcOljekTDXhrXEWn1lhT/Gvet50=; b=gZwWu+Sq67kEQDfjKnS93HTvg7p4GxZGmv3HSdeHE6e7f9JfpNjrRZXVdh6esYVpOt 5Mk4AeUXwmZhcFz1rflGNHzaXUtqZn5MikvF/zMjsVRX6bG+EL6hZvpGrEBnUeOY5yHI gBgEP2Ev7VB1XNPfnFrRKVZuX5AiYyeujXEvngRdyN2r36aVLzgYvOrmWkuPMb/Ui7He ErwYjOh4aeQFctx9w4JtFHoPFfmsDYqNsnc1CWzND6oV06joQVftA7+lecETxXbG2bO4 DI0mrwCGq5iNxOsNlXR7l0g+E7NfD8oBshLXdvI1f1O7XUxtdTcytn830pa8BRn+Rwi1 KAoQ== X-Gm-Message-State: ACrzQf0NfPO8yHNyxpHR8FPyZRERhMnGc/ulQZAxFBIm5C2F1Zn3YH90 +GlqPbEG39Nvc3sX4WviyEpStg== X-Google-Smtp-Source: AMsMyM6YKrTSotw4huVpc/eDK4nwlkXh8m/Ck3eOLUC6Z7mm63RnNBMc0yDbhwrbsa7DX+1k7UvCTA== X-Received: by 2002:a17:90b:1a88:b0:20d:8df0:ac64 with SMTP id ng8-20020a17090b1a8800b0020d8df0ac64mr685583pjb.140.1665547803039; Tue, 11 Oct 2022 21:10:03 -0700 (PDT) Received: from localhost ([2401:fa00:9:14:4704:5b50:96e5:620f]) by smtp.gmail.com with UTF8SMTPSA id m15-20020a170902f64f00b00172751a2fa4sm3325863plg.80.2022.10.11.21.10.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Oct 2022 21:10:02 -0700 (PDT) From: Dan Callaghan To: chrome-platform@lists.linux.dev Cc: LKML , =?UTF-8?q?Sami=20Ky=C3=B6stil=C3=A4?= , Benson Leung , Tzung-Bi Shih , Dan Callaghan Subject: [PATCH v5 1/1] platform/chrome: add a driver for HPS Date: Wed, 12 Oct 2022 15:09:18 +1100 Message-Id: <20221012040918.272582-2-dcallagh@chromium.org> X-Mailer: git-send-email 2.38.0.rc1.362.ged0d419d3c-goog In-Reply-To: <20221012040918.272582-1-dcallagh@chromium.org> References: <20221012040918.272582-1-dcallagh@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sami Ky=C3=B6stil=C3=A4 This patch introduces a driver for the ChromeOS human presence sensor (aka. HPS). The driver supports a sensor connected to the I2C bus and identified as "GOOG0020" in the ACPI tables. When loaded, the driver exports the sensor to userspace through a character device. This device only supports power management, i.e., communication with the sensor must be done through regular I2C transmissions from userspace. Power management is implemented by enabling the respective power GPIO while at least one userspace process holds an open fd on the character device. By default, the device is powered down if there are no active clients. Note that the driver makes no effort to preserve the state of the sensor between power down and power up events. Userspace is responsible for reinitializing any needed state once power has been restored. The device firmware, I2C protocol and other documentation is available at https://chromium.googlesource.com/chromiumos/platform/hps-firmware. Signed-off-by: Sami Ky=C3=B6stil=C3=A4 Signed-off-by: Dan Callaghan --- Changes in v5: - Updated MAINTAINERS. Changes in v4: - Simplified open/release pm logic. - Renamed device to "cros-hps". - Stylistics cleanups. Changes in v3: - Moved from drivers/misc to drivers/platform/chrome. Changes in v2: - Removed custom ioctl interface. - Reworked to use miscdev. MAINTAINERS | 6 + drivers/platform/chrome/Kconfig | 10 ++ drivers/platform/chrome/Makefile | 1 + drivers/platform/chrome/cros_hps_i2c.c | 151 +++++++++++++++++++++++++ 4 files changed, 168 insertions(+) create mode 100644 drivers/platform/chrome/cros_hps_i2c.c diff --git a/MAINTAINERS b/MAINTAINERS index c1e4977cb1c3..13bfab399219 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -4903,6 +4903,12 @@ S: Maintained F: drivers/platform/chrome/cros_usbpd_notify.c F: include/linux/platform_data/cros_usbpd_notify.h =20 +CHROMEOS HPS DRIVER +M: Dan Callaghan +R: Sami Ky=C3=B6stil=C3=A4 +S: Maintained +F: drivers/platform/chrome/cros_hps_i2c.c + CHRONTEL CH7322 CEC DRIVER M: Joe Tessler L: linux-media@vger.kernel.org diff --git a/drivers/platform/chrome/Kconfig b/drivers/platform/chrome/Kcon= fig index 6b954c5acadb..c1ca247987d2 100644 --- a/drivers/platform/chrome/Kconfig +++ b/drivers/platform/chrome/Kconfig @@ -228,6 +228,16 @@ config CROS_EC_TYPEC To compile this driver as a module, choose M here: the module will be called cros_ec_typec. =20 +config CROS_HPS_I2C + tristate "ChromeOS HPS device" + depends on HID && I2C && PM + help + Say Y here if you want to enable support for the ChromeOS + human presence sensor (HPS), attached via I2C. The driver supports a + sensor connected to the I2C bus and exposes it as a character device. + To save power, the sensor is automatically powered down when no + clients are accessing it. + config CROS_USBPD_LOGGER tristate "Logging driver for USB PD charger" depends on CHARGER_CROS_USBPD diff --git a/drivers/platform/chrome/Makefile b/drivers/platform/chrome/Mak= efile index 2950610101f1..f6068d077a40 100644 --- a/drivers/platform/chrome/Makefile +++ b/drivers/platform/chrome/Makefile @@ -27,6 +27,7 @@ obj-$(CONFIG_CROS_EC_DEBUGFS) +=3D cros_ec_debugfs.o cros-ec-sensorhub-objs :=3D cros_ec_sensorhub.o cros_ec_sensorhub_ring.o obj-$(CONFIG_CROS_EC_SENSORHUB) +=3D cros-ec-sensorhub.o obj-$(CONFIG_CROS_EC_SYSFS) +=3D cros_ec_sysfs.o +obj-$(CONFIG_CROS_HPS_I2C) +=3D cros_hps_i2c.o obj-$(CONFIG_CROS_USBPD_LOGGER) +=3D cros_usbpd_logger.o obj-$(CONFIG_CROS_USBPD_NOTIFY) +=3D cros_usbpd_notify.o =20 diff --git a/drivers/platform/chrome/cros_hps_i2c.c b/drivers/platform/chro= me/cros_hps_i2c.c new file mode 100644 index 000000000000..a5505951f989 --- /dev/null +++ b/drivers/platform/chrome/cros_hps_i2c.c @@ -0,0 +1,151 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Driver for the ChromeOS human presence sensor (HPS), attached via I2C. + * + * The driver exposes HPS as a character device, although currently no rea= d or + * write operations are supported. Instead, the driver only controls the p= ower + * state of the sensor, keeping it on only while userspace holds an open f= ile + * descriptor to the HPS device. + * + * Copyright 2022 Google LLC. + */ + +#include +#include +#include +#include +#include +#include +#include + +#define HPS_ACPI_ID "GOOG0020" + +struct hps_drvdata { + struct i2c_client *client; + struct miscdevice misc_device; + struct gpio_desc *enable_gpio; +}; + +static void hps_set_power(struct hps_drvdata *hps, bool state) +{ + gpiod_set_value_cansleep(hps->enable_gpio, state); +} + +static int hps_open(struct inode *inode, struct file *file) +{ + struct hps_drvdata *hps =3D container_of(file->private_data, + struct hps_drvdata, misc_device); + struct device *dev =3D &hps->client->dev; + + return pm_runtime_resume_and_get(dev); +} + +static int hps_release(struct inode *inode, struct file *file) +{ + struct hps_drvdata *hps =3D container_of(file->private_data, + struct hps_drvdata, misc_device); + struct device *dev =3D &hps->client->dev; + + return pm_runtime_put(dev); +} + +static const struct file_operations hps_fops =3D { + .owner =3D THIS_MODULE, + .open =3D hps_open, + .release =3D hps_release, +}; + +static int hps_i2c_probe(struct i2c_client *client) +{ + struct hps_drvdata *hps; + int ret; + + hps =3D devm_kzalloc(&client->dev, sizeof(*hps), GFP_KERNEL); + if (!hps) + return -ENOMEM; + + memset(&hps->misc_device, 0, sizeof(hps->misc_device)); + hps->misc_device.parent =3D &client->dev; + hps->misc_device.minor =3D MISC_DYNAMIC_MINOR; + hps->misc_device.name =3D "cros-hps"; + hps->misc_device.fops =3D &hps_fops; + + i2c_set_clientdata(client, hps); + hps->client =3D client; + hps->enable_gpio =3D devm_gpiod_get(&client->dev, "enable", GPIOD_OUT_HIG= H); + if (IS_ERR(hps->enable_gpio)) { + ret =3D PTR_ERR(hps->enable_gpio); + dev_err(&client->dev, "failed to get enable gpio: %d\n", ret); + return ret; + } + + ret =3D misc_register(&hps->misc_device); + if (ret) { + dev_err(&client->dev, "failed to initialize misc device: %d\n", ret); + return ret; + } + + hps_set_power(hps, false); + pm_runtime_enable(&client->dev); + return 0; +} + +static int hps_i2c_remove(struct i2c_client *client) +{ + struct hps_drvdata *hps =3D i2c_get_clientdata(client); + + pm_runtime_disable(&client->dev); + misc_deregister(&hps->misc_device); + hps_set_power(hps, true); + return 0; +} + +static int hps_suspend(struct device *dev) +{ + struct i2c_client *client =3D to_i2c_client(dev); + struct hps_drvdata *hps =3D i2c_get_clientdata(client); + + hps_set_power(hps, false); + return 0; +} + +static int hps_resume(struct device *dev) +{ + struct i2c_client *client =3D to_i2c_client(dev); + struct hps_drvdata *hps =3D i2c_get_clientdata(client); + + hps_set_power(hps, true); + return 0; +} +static UNIVERSAL_DEV_PM_OPS(hps_pm_ops, hps_suspend, hps_resume, NULL); + +static const struct i2c_device_id hps_i2c_id[] =3D { + { "cros-hps", 0 }, + { } +}; +MODULE_DEVICE_TABLE(i2c, hps_i2c_id); + +#ifdef CONFIG_ACPI +static const struct acpi_device_id hps_acpi_id[] =3D { + { HPS_ACPI_ID, 0 }, + { } +}; +MODULE_DEVICE_TABLE(acpi, hps_acpi_id); +#endif /* CONFIG_ACPI */ + +static struct i2c_driver hps_i2c_driver =3D { + .probe_new =3D hps_i2c_probe, + .remove =3D hps_i2c_remove, + .id_table =3D hps_i2c_id, + .driver =3D { + .name =3D "cros-hps", + .pm =3D &hps_pm_ops, + .acpi_match_table =3D ACPI_PTR(hps_acpi_id), + }, +}; +module_i2c_driver(hps_i2c_driver); + +MODULE_ALIAS("acpi:" HPS_ACPI_ID); +MODULE_AUTHOR("Sami Ky=C3=B6stil=C3=A4 "); +MODULE_DESCRIPTION("Driver for ChromeOS HPS"); +MODULE_LICENSE("GPL"); --=20 2.38.0.rc1.362.ged0d419d3c-goog