From nobody Tue Apr 7 01:53:18 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CC3AC433F5 for ; Sun, 9 Oct 2022 03:40:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229793AbiJIDkn (ORCPT ); Sat, 8 Oct 2022 23:40:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41770 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229726AbiJIDka (ORCPT ); Sat, 8 Oct 2022 23:40:30 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7BEE22ED47 for ; Sat, 8 Oct 2022 20:40:29 -0700 (PDT) Received: from dggpemm500020.china.huawei.com (unknown [172.30.72.53]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4MlSNz0jrszHtsW; Sun, 9 Oct 2022 11:35:31 +0800 (CST) Received: from dggpemm500007.china.huawei.com (7.185.36.183) by dggpemm500020.china.huawei.com (7.185.36.49) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Sun, 9 Oct 2022 11:40:27 +0800 Received: from huawei.com (10.175.103.91) by dggpemm500007.china.huawei.com (7.185.36.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Sun, 9 Oct 2022 11:40:27 +0800 From: Yang Yingliang To: CC: , , Subject: [PATCH -next 2/3] platform/loongarch: laptop: add missing generic_subdriver_exit() in generic_acpi_laptop_init() Date: Sun, 9 Oct 2022 11:40:08 +0800 Message-ID: <20221009034009.60026-3-yangyingliang@huawei.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221009034009.60026-1-yangyingliang@huawei.com> References: <20221009034009.60026-1-yangyingliang@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.103.91] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggpemm500007.china.huawei.com (7.185.36.183) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Add missing generic_subdriver_exit() in generic_acpi_laptop_init() in error path. Fixes: ee7fa5029de8 ("LoongArch: Add ACPI-based generic laptop driver") Signed-off-by: Yang Yingliang --- drivers/platform/loongarch/loongson-laptop.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/platform/loongarch/loongson-laptop.c b/drivers/platfor= m/loongarch/loongson-laptop.c index d9f82c3991c0..a9fdfac50f35 100644 --- a/drivers/platform/loongarch/loongson-laptop.c +++ b/drivers/platform/loongarch/loongson-laptop.c @@ -582,6 +582,8 @@ static int __init generic_acpi_laptop_init(void) for (i =3D 0; i < ARRAY_SIZE(generic_sub_drivers); i++) { ret =3D generic_subdriver_init(&generic_sub_drivers[i]); if (ret < 0) { + while (--i >=3D 0) + generic_subdriver_exit(&generic_sub_drivers[i]); input_free_device(generic_inputdev); return ret; } @@ -589,6 +591,8 @@ static int __init generic_acpi_laptop_init(void) =20 ret =3D input_register_device(generic_inputdev); if (ret < 0) { + while (--i >=3D 0) + generic_subdriver_exit(&generic_sub_drivers[i]); input_free_device(generic_inputdev); pr_err("Unable to register input device\n"); return ret; --=20 2.25.1