From nobody Mon Apr 6 21:11:28 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C72AC433F5 for ; Thu, 6 Oct 2022 23:58:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231910AbiJFX6f (ORCPT ); Thu, 6 Oct 2022 19:58:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50362 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230307AbiJFX6c (ORCPT ); Thu, 6 Oct 2022 19:58:32 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ADF855E546 for ; Thu, 6 Oct 2022 16:58:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:In-Reply-To:References; bh=JXxcTYDoAGII65LnrbB+UX9xMILlYKLpThy0M/qjUrA=; b=u6NDsCY6ojetrDLaH6P5z7lomQ fPpI5aiePWSfZP+ifNNKx+uUflhPHW4ddFXTI7hYy/yYzTP9grhLlJFuv79LZjiYp1XvPYfgA825F SHcyi+Zzpk5/CAtoDTAeMT0Uu53eNALT2F4Cv0v5ntjnAAaKVWNE5Iu+G6AYnyO5vL1qbSpnsDShE hpS/2HThCGIYh6rmd7UTlKNAy+CT+PALGnbjvaE9lWCVrhTO/NdS/tcs1e70pAPhCb/X3otX1gZBg LYN0G1i1wVDkWttDP5ac0+uqaxbAl3y1xscu+lyry7xGlgKOsyCU2KVerJVc2GYNWVm58g7cgsvKC Qs4ZyL/A==; Received: from [2601:1c2:d80:3110::a2e7] (helo=casper.infradead.org) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1ogal5-001XLB-Bp; Thu, 06 Oct 2022 23:58:32 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , kernel test robot , Mark Brown , Liam Girdwood , Ricard Wanderlof , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org Subject: [PATCH v2] ASoC: codec: tlv320adc3xxx: add GPIOLIB dependency Date: Thu, 6 Oct 2022 16:58:22 -0700 Message-Id: <20221006235822.30074-1-rdunlap@infradead.org> X-Mailer: git-send-email 2.37.3 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Fix build errors when CONFIG_GPIOLIB is not enabled: ../sound/soc/codecs/tlv320adc3xxx.c: In function 'adc3xxx_i2c_probe': ../sound/soc/codecs/tlv320adc3xxx.c:1352:28: error: implicit declaration of= function 'devm_gpiod_get'; did you mean 'devm_gpio_free'? [-Werror=3Dimpli= cit-function-declaration] 1352 | adc3xxx->rst_pin =3D devm_gpiod_get(dev, "reset", GPIOD_OUT= _LOW); ../sound/soc/codecs/tlv320adc3xxx.c:1352:57: error: 'GPIOD_OUT_LOW' undecla= red (first use in this function); did you mean 'GPIOF_INIT_LOW'? 1352 | adc3xxx->rst_pin =3D devm_gpiod_get(dev, "reset", GPIOD_OUT= _LOW); CC lib/dynamic_debug.o ../sound/soc/codecs/tlv320adc3xxx.c:1400:9: error: implicit declaration of = function 'gpiod_set_value_cansleep'; did you mean 'gpio_set_value_cansleep'= ? [-Werror=3Dimplicit-function-declaration] 1400 | gpiod_set_value_cansleep(adc3xxx->rst_pin, 1); Fixes: e9a3b57efd28 ("ASoC: codec: tlv320adc3xxx: New codec driver") Signed-off-by: Randy Dunlap Reported-by: kernel test robot Cc: Mark Brown Cc: Liam Girdwood Cc: Ricard Wanderlof Cc: Jaroslav Kysela Cc: Takashi Iwai Cc: alsa-devel@alsa-project.org --- v2: use correct Subject keywords sound/soc/codecs/Kconfig | 1 + 1 file changed, 1 insertion(+) --- a/sound/soc/codecs/Kconfig +++ b/sound/soc/codecs/Kconfig @@ -1629,6 +1629,7 @@ config SND_SOC_TFA989X config SND_SOC_TLV320ADC3XXX tristate "Texas Instruments TLV320ADC3001/3101 audio ADC" depends on I2C + depends on GPIOLIB help Enable support for Texas Instruments TLV320ADC3001 and TLV320ADC3101 ADCs.