From nobody Sat Sep 21 11:47:02 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EEA9C433FE for ; Thu, 6 Oct 2022 11:10:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231374AbiJFLKZ (ORCPT ); Thu, 6 Oct 2022 07:10:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34300 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231454AbiJFLJz (ORCPT ); Thu, 6 Oct 2022 07:09:55 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4F3515586 for ; Thu, 6 Oct 2022 04:09:40 -0700 (PDT) Received: from IcarusMOD.eternityproject.eu (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 5A61766022F9; Thu, 6 Oct 2022 12:09:39 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1665054579; bh=HaMjBUnn0XP2R6tqIgzWDxijRENloQ+oZZWaIxT+XMY=; h=From:To:Cc:Subject:Date:From; b=S2XPIqIl4XEBq6BBtHS99Mn2AoFFc3pEx/KdumCdajL2VmOl3rb9C3ZR2yOlk1ohK sde1jTKKH/VMrsPwr6Xo87H+UMccKSW9IH9c82dF3JdDick1uv7FV7BuVesSsiYIcZ yceziv4oW/eeB9RwRPCPhRu8BA8oXWQNJqU4wgz+pqlPW2SZ+hbajlc57DrTa4aE9H S6Qxlc+AKDF6LMQ2OO8FkrLJiV3u0ubg0SS72pzltyAXEN047IbmT1QHSdHyN2SKdw kP+SgBt3oKCPoW3Df//T/Yp3UNBNWs0EmSP1TiTgTWKaegS/7vFXQKFO82ayI6+g34 1YZ8DMvB7UpGw== From: AngeloGioacchino Del Regno To: matthias.bgg@gmail.com Cc: linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, AngeloGioacchino Del Regno Subject: [PATCH] soc: mediatek: mtk-devapc: Switch to devm_clk_get_enabled() Date: Thu, 6 Oct 2022 13:09:35 +0200 Message-Id: <20221006110935.59695-1-angelogioacchino.delregno@collabora.com> X-Mailer: git-send-email 2.37.2 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" This driver does exactly devm_clk_get() and clk_prepare_enable() right after, which is exactly what devm_clk_get_enabled() does: clean that up by switching to the latter. This commit brings no functional changes. Signed-off-by: AngeloGioacchino Del Regno --- drivers/soc/mediatek/mtk-devapc.c | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/drivers/soc/mediatek/mtk-devapc.c b/drivers/soc/mediatek/mtk-d= evapc.c index fc13334db1b1..bad139cb117e 100644 --- a/drivers/soc/mediatek/mtk-devapc.c +++ b/drivers/soc/mediatek/mtk-devapc.c @@ -276,19 +276,14 @@ static int mtk_devapc_probe(struct platform_device *p= dev) if (!devapc_irq) return -EINVAL; =20 - ctx->infra_clk =3D devm_clk_get(&pdev->dev, "devapc-infra-clock"); + ctx->infra_clk =3D devm_clk_get_enabled(&pdev->dev, "devapc-infra-clock"); if (IS_ERR(ctx->infra_clk)) return -EINVAL; =20 - if (clk_prepare_enable(ctx->infra_clk)) - return -EINVAL; - ret =3D devm_request_irq(&pdev->dev, devapc_irq, devapc_violation_irq, IRQF_TRIGGER_NONE, "devapc", ctx); - if (ret) { - clk_disable_unprepare(ctx->infra_clk); + if (ret) return ret; - } =20 platform_set_drvdata(pdev, ctx); =20 @@ -303,8 +298,6 @@ static int mtk_devapc_remove(struct platform_device *pd= ev) =20 stop_devapc(ctx); =20 - clk_disable_unprepare(ctx->infra_clk); - return 0; } =20 --=20 2.37.2