From nobody Sat Apr 27 16:30:48 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9FCBC433F5 for ; Sat, 1 Oct 2022 03:23:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233224AbiJADXF (ORCPT ); Fri, 30 Sep 2022 23:23:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34970 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233175AbiJADWU (ORCPT ); Fri, 30 Sep 2022 23:22:20 -0400 Received: from mail-pg1-x531.google.com (mail-pg1-x531.google.com [IPv6:2607:f8b0:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2ED1A4BA54; Fri, 30 Sep 2022 20:15:07 -0700 (PDT) Received: by mail-pg1-x531.google.com with SMTP id u69so5632960pgd.2; Fri, 30 Sep 2022 20:15:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=WS8+aHrpEJcPx+GL0ClM0OpEIxuUEQEiHn73/H2YPtI=; b=OifcXVKgL/Y2MR8NT6VuBy0ERXN+g28z9Z0Tn9ortQcDze37w0ZylmrF7KACE9WIkA L65S0lgi3brOlvLdjUKvd+FsCfN1tI2Y51nePP5mDgt9wP5McLaSYSindE63TCH/jfmf mk6e2IRb0K9ypp/aRAlcv9v/gNPW6QRuCXtnIXjrxQilcvkNUM2QHzoP+1pdO19OU8lq gVSbeIl1HkMxJKfoNYxWc2r04Qz3zJoV+777ZfqCPjaiIY7kgeXHM2TXLXCojhH8JupY lqDkePVV/P/1GE+otFYBWtZrtjxktKyqsYgzkKIbFDt5PPChDNAGd81mFMpRNh+60C9c u5wQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=WS8+aHrpEJcPx+GL0ClM0OpEIxuUEQEiHn73/H2YPtI=; b=OwvHDqRj6EWeHuS0JnbSyEGSsK5gUY9iFxRP2zbUSat5r6Vkl5/9Iwx5CIcWYRi1H8 y6rmH72wZRK0S8PA2mJCyOVbZTKcGvjmjLTqRO3SPKvIy14T/GsS+9+lpIFMxUKZZpi+ pjjCxdmm/kHpoYD2gjY3urCO5uBdFK9npWJ4IWAG5kOnHI9HI6GquQ7MtpktYVxltr0n DPbkPz8+aaW4ZRp82tnlVBB8aRqLw9ipzE4RtelA85nSAWIlWg2ivpr56CQ42e1MYfFk bpzFyjGtJNSJnxeFdGQ1YAScLPO1BYsBKXQ4xSDlANHrRLd7SF1zKZtFt9tf70Dey5ga GTfQ== X-Gm-Message-State: ACrzQf3TR1mdFe0Q4j4siYhRSjYYxTMmOPEFYm/SVlQIskypnfcBaFzj lkdSJpyYsrFh2VvZyYlO4HFQncaUaUZoio5q X-Google-Smtp-Source: AMsMyM7Ya4zNiDzlQhvFBKSCqIoTqCJ+bIjL9mMOIXZ59mxgEuLN8Ft5BFS06JWUhvZx9/87kUmDWg== X-Received: by 2002:a05:6a02:4a:b0:447:f9d7:4e32 with SMTP id az10-20020a056a02004a00b00447f9d74e32mr608935pgb.412.1664594041901; Fri, 30 Sep 2022 20:14:01 -0700 (PDT) Received: from skynet-linux.local ([2406:7400:61:5d7c:3fe4:8f6d:b1b6:f2bf]) by smtp.googlemail.com with ESMTPSA id cp1-20020a170902e78100b00172a567d910sm2627371plb.289.2022.09.30.20.13.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Sep 2022 20:14:01 -0700 (PDT) From: Sireesh Kodali To: devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, linux-kernel@vger.kernel.org Cc: andersson@kernel.org, krzysztof.kozlowski+dt@linaro.org, Vladimir Lypak , Sireesh Kodali , Andy Gross , Konrad Dybcio , Mathieu Poirier Subject: [PATCH v6 1/5] remoteproc: qcom: qcom_wcnss: Add support for pronto-v3 Date: Sat, 1 Oct 2022 08:43:40 +0530 Message-Id: <20221001031345.31293-2-sireeshkodali1@gmail.com> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20221001031345.31293-1-sireeshkodali1@gmail.com> References: <20221001031345.31293-1-sireeshkodali1@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Vladimir Lypak Pronto-v3 is similar to pronto-v2. It requires two power domains, one regulator, and it requires the xo clock. It is used on the MSM8953 platform. Signed-off-by: Vladimir Lypak Signed-off-by: Sireesh Kodali Reviewed-by: Stephan Gerhold --- drivers/remoteproc/qcom_wcnss.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/drivers/remoteproc/qcom_wcnss.c b/drivers/remoteproc/qcom_wcns= s.c index 68f37296b151..f599d5d5719d 100644 --- a/drivers/remoteproc/qcom_wcnss.c +++ b/drivers/remoteproc/qcom_wcnss.c @@ -141,6 +141,17 @@ static const struct wcnss_data pronto_v2_data =3D { .num_vregs =3D 1, }; =20 +static const struct wcnss_data pronto_v3_data =3D { + .pmu_offset =3D 0x1004, + .spare_offset =3D 0x1088, + + .pd_names =3D { "mx", "cx" }, + .vregs =3D (struct wcnss_vreg_info[]) { + { "vddpx", 1800000, 1800000, 0 }, + }, + .num_vregs =3D 1, +}; + static int wcnss_load(struct rproc *rproc, const struct firmware *fw) { struct qcom_wcnss *wcnss =3D (struct qcom_wcnss *)rproc->priv; @@ -675,6 +686,7 @@ static const struct of_device_id wcnss_of_match[] =3D { { .compatible =3D "qcom,riva-pil", &riva_data }, { .compatible =3D "qcom,pronto-v1-pil", &pronto_v1_data }, { .compatible =3D "qcom,pronto-v2-pil", &pronto_v2_data }, + { .compatible =3D "qcom,pronto-v3-pil", &pronto_v3_data }, { }, }; MODULE_DEVICE_TABLE(of, wcnss_of_match); --=20 2.37.3 From nobody Sat Apr 27 16:30:48 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96A47C4332F for ; Sat, 1 Oct 2022 03:23:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233257AbiJADXY (ORCPT ); Fri, 30 Sep 2022 23:23:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44892 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233073AbiJADWk (ORCPT ); Fri, 30 Sep 2022 23:22:40 -0400 Received: from mail-pg1-x52e.google.com (mail-pg1-x52e.google.com [IPv6:2607:f8b0:4864:20::52e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0F3B04E86D; Fri, 30 Sep 2022 20:15:08 -0700 (PDT) Received: by mail-pg1-x52e.google.com with SMTP id 3so5634737pga.1; Fri, 30 Sep 2022 20:15:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=82U9NeXnPS+kW6Poqqq2gO0P70vxCu3R4EQor8v8/Ag=; b=cOI5zFg6UZ6Jh4KEnmBl8Dh6zSDYcQtGAPSd0l5V6PshZWh6rdoYXtpMYjZNvowYmq I4/Y76JWl+1UkZXf+cHvihvmXN60go1QxlYPXl9SE7G8+jFmEKR20pdIEwRK3HHvxKl0 xg0Jupbc4fRlXcOwrM4wClzKW2IzHaKhIdkLpG98jJ0AyfGhrdzHn9C9MdFMhvj8f8is 0XQHQ+F/1CKCYbBJmMLpRkvK73Y12kQhicfbIIMcnzNLhq+NrS3w5rwrb9nuzoXC6/me zXlzbBbM7lLwhUVtldAYZbfq/u1OuM9B5C4Tc1DUcJDZTtf/nAjy35BRzhT8A9wtqQ4+ paoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=82U9NeXnPS+kW6Poqqq2gO0P70vxCu3R4EQor8v8/Ag=; b=w7NTjRNUCBn/WX8v+Q0VOmoFX1vEr3k0yJXvCa8z8TTJHkPbZqayzD4w475/JM9Ffz fU+hJLKYYDl2Ux5OyI3FhPxO7gxKMPhW7q4fTjAJBxjs/OTLWqHb8Zw1uK7exmmCADcK 7Ps1KiA9ksvzmXdz/47yComNWXWGJ6PhpeVRnhxS/9dx9F1F7P+Y0ttr8FTpL324NK/y DZebFjrqVkb4CjUlECWyk4GOcxfaVtgzb1nXX91GrO+uZ0KA/qXzHcGXnVZ+x3xjK30A QaM5fvLXuKsZc2P5LH8iSYFjbE3jj4A/+P8AcNfLiIRCloizaPVK0LXcdkRaCixSdvRt JkJQ== X-Gm-Message-State: ACrzQf15E/Y8ly9GXEKf5VeFVGQFybCju6sTz/H6gdb0oojrBRa2SrEv GUR4y32pGqUQ/sAmWRNCt/wLZAoZ5K58RH6P X-Google-Smtp-Source: AMsMyM6FB107qC+IVnga8sMPtSnJ2MZ9Yo/qZk+qhXmy7ecWH3fHLN3Iv3WvMkwsepMKioYFL1MYaw== X-Received: by 2002:a63:1606:0:b0:43c:b5e1:5c52 with SMTP id w6-20020a631606000000b0043cb5e15c52mr10439835pgl.250.1664594048335; Fri, 30 Sep 2022 20:14:08 -0700 (PDT) Received: from skynet-linux.local ([2406:7400:61:5d7c:3fe4:8f6d:b1b6:f2bf]) by smtp.googlemail.com with ESMTPSA id cp1-20020a170902e78100b00172a567d910sm2627371plb.289.2022.09.30.20.14.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Sep 2022 20:14:07 -0700 (PDT) From: Sireesh Kodali To: devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, linux-kernel@vger.kernel.org Cc: andersson@kernel.org, krzysztof.kozlowski+dt@linaro.org, Sireesh Kodali , Krzysztof Kozlowski , Andy Gross , Konrad Dybcio , Mathieu Poirier , Rob Herring Subject: [PATCH v6 2/5] dt-bindings: remoteproc: qcom: Convert wcnss documentation to YAML Date: Sat, 1 Oct 2022 08:43:41 +0530 Message-Id: <20221001031345.31293-3-sireeshkodali1@gmail.com> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20221001031345.31293-1-sireeshkodali1@gmail.com> References: <20221001031345.31293-1-sireeshkodali1@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" This is a direct conversion of the existing txt documentation to YAML. It is in preparation for the addition of pronto-v3 to the docs. This patch doesn't document any of the existing subnodes/properties that are not documented in the existing txt file. That is done in a separate patch. Signed-off-by: Sireesh Kodali Reviewed-by: Krzysztof Kozlowski --- .../bindings/remoteproc/qcom,wcnss-pil.txt | 177 ------------ .../bindings/remoteproc/qcom,wcnss-pil.yaml | 269 ++++++++++++++++++ 2 files changed, 269 insertions(+), 177 deletions(-) delete mode 100644 Documentation/devicetree/bindings/remoteproc/qcom,wcnss= -pil.txt create mode 100644 Documentation/devicetree/bindings/remoteproc/qcom,wcnss= -pil.yaml diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.tx= t b/Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.txt deleted file mode 100644 index ac423f4c3f1b..000000000000 --- a/Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.txt +++ /dev/null @@ -1,177 +0,0 @@ -Qualcomm WCNSS Peripheral Image Loader - -This document defines the binding for a component that loads and boots fir= mware -on the Qualcomm WCNSS core. - -- compatible: - Usage: required - Value type: - Definition: must be one of: - "qcom,riva-pil", - "qcom,pronto-v1-pil", - "qcom,pronto-v2-pil" - -- reg: - Usage: required - Value type: - Definition: must specify the base address and size of the CCU, DXE and - PMU register blocks - -- reg-names: - Usage: required - Value type: - Definition: must be "ccu", "dxe", "pmu" - -- interrupts-extended: - Usage: required - Value type: - Definition: must list the watchdog and fatal IRQs and may specify the - ready, handover and stop-ack IRQs - -- interrupt-names: - Usage: required - Value type: - Definition: should be "wdog", "fatal", optionally followed by "ready", - "handover", "stop-ack" - -- firmware-name: - Usage: optional - Value type: - Definition: must list the relative firmware image path for the - WCNSS core. Defaults to "wcnss.mdt". - -- vddmx-supply: (deprecated for qcom,pronto-v1/2-pil) -- vddcx-supply: (deprecated for qcom,pronto-v1/2-pil) -- vddpx-supply: - Usage: required - Value type: - Definition: reference to the regulators to be held on behalf of the - booting of the WCNSS core - -- power-domains: - Usage: required (for qcom,pronto-v1/2-pil) - Value type: - Definition: reference to the power domains to be held on behalf of the - booting of the WCNSS core - -- power-domain-names: - Usage: required (for qcom,pronto-v1/2-pil) - Value type: - Definition: must be "cx", "mx" - -- qcom,smem-states: - Usage: optional - Value type: - Definition: reference to the SMEM state used to indicate to WCNSS that - it should shut down - -- qcom,smem-state-names: - Usage: optional - Value type: - Definition: should be "stop" - -- memory-region: - Usage: required - Value type: - Definition: reference to reserved-memory node for the remote processor - see ../reserved-memory/reserved-memory.txt - -=3D SUBNODES -A required subnode of the WCNSS PIL is used to describe the attached rf mo= dule -and its resource dependencies. It is described by the following properties: - -- compatible: - Usage: required - Value type: - Definition: must be one of: - "qcom,wcn3620", - "qcom,wcn3660", - "qcom,wcn3660b", - "qcom,wcn3680" - -- clocks: - Usage: required - Value type: - Definition: should specify the xo clock and optionally the rf clock - -- clock-names: - Usage: required - Value type: - Definition: should be "xo", optionally followed by "rf" - -- vddxo-supply: -- vddrfa-supply: -- vddpa-supply: -- vdddig-supply: - Usage: required - Value type: - Definition: reference to the regulators to be held on behalf of the - booting of the WCNSS core - - -The wcnss node can also have an subnode named "smd-edge" that describes th= e SMD -edge, channels and devices related to the WCNSS. -See ../soc/qcom/qcom,smd.yaml for details on how to describe the SMD edge. - -=3D EXAMPLE -The following example describes the resources needed to boot control the W= CNSS, -with attached WCN3680, as it is commonly found on MSM8974 boards. - -pronto@fb204000 { - compatible =3D "qcom,pronto-v2-pil"; - reg =3D <0xfb204000 0x2000>, <0xfb202000 0x1000>, <0xfb21b000 0x3000>; - reg-names =3D "ccu", "dxe", "pmu"; - - interrupts-extended =3D <&intc 0 149 1>, - <&wcnss_smp2p_slave 0 0>, - <&wcnss_smp2p_slave 1 0>, - <&wcnss_smp2p_slave 2 0>, - <&wcnss_smp2p_slave 3 0>; - interrupt-names =3D "wdog", "fatal", "ready", "handover", "stop-ack"; - - power-domains =3D <&rpmpd MSM8974_VDDCX>, <&rpmpd MSM8974_VDDMX>; - power-domain-names =3D "cx", "mx"; - - vddpx-supply =3D <&pm8941_s3>; - - qcom,smem-states =3D <&wcnss_smp2p_out 0>; - qcom,smem-state-names =3D "stop"; - - memory-region =3D <&wcnss_region>; - - pinctrl-names =3D "default"; - pinctrl-0 =3D <&wcnss_pin_a>; - - iris { - compatible =3D "qcom,wcn3680"; - - clocks =3D <&rpmcc RPM_CXO_CLK_SRC>, <&rpmcc RPM_CXO_A2>; - clock-names =3D "xo", "rf"; - - vddxo-supply =3D <&pm8941_l6>; - vddrfa-supply =3D <&pm8941_l11>; - vddpa-supply =3D <&pm8941_l19>; - vdddig-supply =3D <&pm8941_s3>; - }; - - smd-edge { - interrupts =3D <0 142 1>; - - qcom,ipc =3D <&apcs 8 17>; - qcom,smd-edge =3D <6>; - qcom,remote-pid =3D <4>; - - label =3D "pronto"; - - wcnss { - compatible =3D "qcom,wcnss"; - qcom,smd-channels =3D "WCNSS_CTRL"; - - qcom,mmio =3D <&pronto>; - - bt { - compatible =3D "qcom,wcnss-bt"; - }; - }; - }; -}; diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.ya= ml b/Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.yaml new file mode 100644 index 000000000000..c22a6090220f --- /dev/null +++ b/Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.yaml @@ -0,0 +1,269 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/remoteproc/qcom,wcnss-pil.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Qualcomm WCNSS Peripheral Image Loader + +maintainers: + - Bjorn Andersson + +description: + This document defines the binding for a component that loads and boots + firmware on the Qualcomm WCNSS core. + +properties: + compatible: + enum: + - qcom,riva-pil + - qcom,pronto-v1-pil + - qcom,pronto-v2-pil + + reg: + maxItems: 3 + description: + The base address and size of the CCU, DXE and PMU register blocks + + reg-names: + items: + - const: ccu + - const: dxe + - const: pmu + + interrupts: + minItems: 2 + maxItems: 5 + + interrupt-names: + minItems: 2 + items: + - const: wdog + - const: fatal + - const: ready + - const: handover + - const: stop-ack + + firmware-name: + $ref: /schemas/types.yaml#/definitions/string + description: + Relative firmware image path for the WCNSS core. Defaults to + "wcnss.mdt". + + vddpx-supply: + description: + PX regulator to be held on behalf of the booting of the WCNSS core + + vddmx-supply: + description: + MX regulator to be held on behalf of the booting of the WCNSS core. + + vddcx-supply: + description: + CX regulator to be held on behalf of the booting of the WCNSS core. + + power-domains: + maxItems: 2 + + power-domain-names: + items: + - const: cx + - const: mx + + qcom,smem-states: + $ref: /schemas/types.yaml#/definitions/phandle-array + description: + States used by the AP to signal the WCNSS core that it should shutdo= wn + items: + - description: Stop the modem + + qcom,smem-state-names: + description: The names of the state bits used for SMP2P output + items: + - const: stop + + memory-region: + maxItems: 1 + description: reserved-memory for the WCNSS core + + smd-edge: + $ref: /schemas/remoteproc/qcom,smd-edge.yaml# + description: + Qualcomm Shared Memory subnode which represents communication edge, + channels and devices related to the ADSP. + + iris: + type: object + description: + The iris subnode of the WCNSS PIL is used to describe the attached R= F module + and its resource dependencies. + + properties: + compatible: + enum: + - qcom,wcn3620 + - qcom,wcn3660 + - qcom,wcn3660b + - qcom,wcn3680 + + clocks: + minItems: 1 + items: + - description: XO clock + - description: RF clock + + clock-names: + minItems: 1 + items: + - const: xo + - const: rf + + vddxo-supply: + description: + Reference to the regulator to be held on behalf of the booting W= CNSS + core + + vddrfa-supply: + description: + Reference to the regulator to be held on behalf of the booting W= CNSS + core + + vddpa-supply: + description: + Reference to the regulator to be held on behalf of the booting W= CNSS + core + + vdddig-supply: + description: + Reference to the regulator to be held on behalf of the booting W= CNSS + core + + required: + - compatible + - clocks + - clock-names + - vddxo-supply + - vddrfa-supply + - vddpa-supply + - vdddig-supply + + additionalProperties: false + +required: + - compatible + - reg + - reg-names + - interrupts + - interrupt-names + - iris + - vddpx-supply + - memory-region + - smd-edge + +additionalProperties: false + +allOf: + - if: + properties: + compatible: + contains: + const: qcom,riva-pil + then: + required: + - vddcx-supply + - vddmx-supply + + - if: + properties: + compatible: + contains: + enum: + - qcom,pronto-v1-pil + - qcom,pronto-v2-pil + then: + properties: + vddmx-supply: + deprecated: true + description: Deprecated for qcom,pronto-v1/2-pil + + vddcx-supply: + deprecated: true + description: Deprecated for qcom,pronto-v1/2-pil + + required: + - power-domains + - power-domain-names + +examples: + - | + #include + #include + #include + pronto@a21b000 { + compatible =3D "qcom,pronto-v2-pil"; + reg =3D <0x0a204000 0x2000>, <0x0a202000 0x1000>, <0x0a21b000 0x30= 00>; + reg-names =3D "ccu", "dxe", "pmu"; + + interrupts-extended =3D <&intc GIC_SPI 149 IRQ_TYPE_EDGE_RISING>, + <&wcnss_smp2p_in 0 IRQ_TYPE_EDGE_RISING>, + <&wcnss_smp2p_in 1 IRQ_TYPE_EDGE_RISING>, + <&wcnss_smp2p_in 2 IRQ_TYPE_EDGE_RISING>, + <&wcnss_smp2p_in 3 IRQ_TYPE_EDGE_RISING>; + interrupt-names =3D "wdog", "fatal", "ready", "handover", "stop-ac= k"; + + power-domains =3D <&rpmpd MSM8916_VDDCX>, <&rpmpd MSM8916_VDDMX>; + power-domain-names =3D "cx", "mx"; + + vddpx-supply =3D <&pm8916_l7>; + + qcom,smem-states =3D <&wcnss_smp2p_out 0>; + qcom,smem-state-names =3D "stop"; + + memory-region =3D <&wcnss_region>; + + pinctrl-names =3D "default"; + pinctrl-0 =3D <&wcnss_pin_a>; + + iris { + compatible =3D "qcom,wcn3620"; + vddxo-supply =3D <&pm8916_l7>; + vddrfa-supply =3D <&pm8916_s3>; + vddpa-supply =3D <&pm8916_l9>; + vdddig-supply =3D <&pm8916_l5>; + + clocks =3D <&rpmcc RPM_SMD_RF_CLK2>; + clock-names =3D "xo"; + }; + + smd-edge { + interrupts =3D ; + + qcom,ipc =3D <&apcs 8 17>; + qcom,smd-edge =3D <6>; + qcom,remote-pid =3D <4>; + + label =3D "pronto"; + + wcnss_ctrl: wcnss { + compatible =3D "qcom,wcnss"; + qcom,smd-channels =3D "WCNSS_CTRL"; + + qcom,mmio =3D <&pronto>; + + bluetooth { + compatible =3D "qcom,wcnss-bt"; + }; + + wifi { + compatible =3D "qcom,wcnss-wlan"; + + interrupts =3D , + ; + interrupt-names =3D "tx", "rx"; + + qcom,smem-states =3D <&apps_smsm 10>, <&apps_smsm 9>; + qcom,smem-state-names =3D "tx-enable", "tx-rings-empty= "; + }; + }; + }; + }; --=20 2.37.3 From nobody Sat Apr 27 16:30:48 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D477BC433FE for ; Sat, 1 Oct 2022 03:23:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232427AbiJADXm (ORCPT ); Fri, 30 Sep 2022 23:23:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45190 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233115AbiJADWo (ORCPT ); Fri, 30 Sep 2022 23:22:44 -0400 Received: from mail-pg1-x531.google.com (mail-pg1-x531.google.com [IPv6:2607:f8b0:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A84245927B; Fri, 30 Sep 2022 20:15:11 -0700 (PDT) Received: by mail-pg1-x531.google.com with SMTP id q9so5610296pgq.8; Fri, 30 Sep 2022 20:15:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=OjbUXeviY6YCLLqqd/ejLKx1ctiYSztmp1vKiw+VYlw=; b=kv/hMCBpwPx1AS03mHziigBRB2G8MlK0iEWkbLMeubLTLIntN3tDV4Qu5L0dSGLR2p SneA9do1ja78xR//Dg0n+xHqssgt+6nc9wrGpjppU3+8ct1qUR0SkWN8U4d861VYA0Kf 6aPDNdl7jdT1QOCWVZzl3rmVv5Q64UkJvViFtSSabvLl9tLbFM5qoFQj173TerYMrdki XCj2S22kiRYxgoR5S1snJhDipcfuLtpvcdX3EhDHIVt2nED0qFYP6SU0rBnH+lSW22st WjN4SyYs/KRZBeEKDAJX2Uh0HlT9FpZ3pOwUoYffjKSKnW9mVyv7Dx0rmWtB0OfzqyBQ 9O+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=OjbUXeviY6YCLLqqd/ejLKx1ctiYSztmp1vKiw+VYlw=; b=2ARzBb5xSc/ACf8YYPf8Mjo8vb3W8Z0qWvv239R+7lq1IciRAhvTQBeHdcccreuaTK LtP7Kx9VrYV5cYn75IXiqo3Pnaal9Uv/acik1iAYsSBctpQOQo/WLRYpsSQ0e8UNfaQC a5j3GFJTw5YaXnEbnnhKGdUip+kuQ2OYN78g3RoWfIlrn4p4tVJenw2NYruFSH6bZ9o+ l6KB2YpnEkBAEQwgMLk5hbqR126xgfZmfiwxAAebv70J34e2OmZnqZnXWm9BRcWM+cbA 1gfmmnIpxMfiyWC1pf42QeZgRceUUIn5R7mqL+kMsY+H5OY3sRdVnxHX6DRFfsdpFujf cI0g== X-Gm-Message-State: ACrzQf2J9SmIzqx2tCdS4QbHGwSpmNs3zndpzc1nO9B1OikqBrql21ZA 5XQTzVpl3f609kDCwUUxHM3UF5ivmyDlMFSw X-Google-Smtp-Source: AMsMyM7YGaMrIxgxfaY+uyPMm8aET9qoU3uwamwCRMeldo9Hs1JCPZc2JVNho+pSrnI8/R3Tccv0YQ== X-Received: by 2002:a63:6cc3:0:b0:43c:7585:1ec with SMTP id h186-20020a636cc3000000b0043c758501ecmr10179937pgc.571.1664594052863; Fri, 30 Sep 2022 20:14:12 -0700 (PDT) Received: from skynet-linux.local ([2406:7400:61:5d7c:3fe4:8f6d:b1b6:f2bf]) by smtp.googlemail.com with ESMTPSA id cp1-20020a170902e78100b00172a567d910sm2627371plb.289.2022.09.30.20.14.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Sep 2022 20:14:12 -0700 (PDT) From: Sireesh Kodali To: devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, linux-kernel@vger.kernel.org Cc: andersson@kernel.org, krzysztof.kozlowski+dt@linaro.org, Sireesh Kodali , Krzysztof Kozlowski , Andy Gross , Konrad Dybcio , Mathieu Poirier , Rob Herring Subject: [PATCH v6 3/5] dt-bindings: remoteproc: qcom: wcnss: Add qcom,pronto compatible Date: Sat, 1 Oct 2022 08:43:42 +0530 Message-Id: <20221001031345.31293-4-sireeshkodali1@gmail.com> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20221001031345.31293-1-sireeshkodali1@gmail.com> References: <20221001031345.31293-1-sireeshkodali1@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" This is not a fallback compatible, it must be present in addition to "qcom,pronto-v*". It is also not documented in qcom,wcnss-pil.txt. This is the reason for documenting it in a separate commit. This compatible is used in the wcn36xx driver to determine which register must be accessed. However it isn't immediately clear why the wcn36xx driver relies on this extra compatible string rather than just looking for "qcom,pronto-v*". Signed-off-by: Sireesh Kodali Reviewed-by: Krzysztof Kozlowski --- .../bindings/remoteproc/qcom,wcnss-pil.yaml | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.ya= ml b/Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.yaml index c22a6090220f..0eb2617e3482 100644 --- a/Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.yaml +++ b/Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.yaml @@ -15,10 +15,15 @@ description: =20 properties: compatible: - enum: - - qcom,riva-pil - - qcom,pronto-v1-pil - - qcom,pronto-v2-pil + description: + Append "qcom,pronto" if the device is actually pronto, and not riva + oneOf: + - items: + - enum: + - qcom,pronto-v1-pil + - qcom,pronto-v2-pil + - const: qcom,pronto + - const: qcom,riva-pil =20 reg: maxItems: 3 @@ -200,7 +205,7 @@ examples: #include #include pronto@a21b000 { - compatible =3D "qcom,pronto-v2-pil"; + compatible =3D "qcom,pronto-v2-pil", "qcom,pronto"; reg =3D <0x0a204000 0x2000>, <0x0a202000 0x1000>, <0x0a21b000 0x30= 00>; reg-names =3D "ccu", "dxe", "pmu"; =20 --=20 2.37.3 From nobody Sat Apr 27 16:30:48 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 411CAC433F5 for ; Sat, 1 Oct 2022 03:23:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232764AbiJADXw (ORCPT ); Fri, 30 Sep 2022 23:23:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45216 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232606AbiJADWo (ORCPT ); Fri, 30 Sep 2022 23:22:44 -0400 Received: from mail-pf1-x432.google.com (mail-pf1-x432.google.com [IPv6:2607:f8b0:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B35B16F555; Fri, 30 Sep 2022 20:15:13 -0700 (PDT) Received: by mail-pf1-x432.google.com with SMTP id g130so5178364pfb.8; Fri, 30 Sep 2022 20:15:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=juW9wu13y489Hph7sR+dhrqUMWDs6TD8KFYBRB4JbO4=; b=UkOShts6IW9u9T3yFTtjI42gi0TloGaPV7bC/5ddCl9hAmmPunhkNDifa3/wCzAVFW 6A1IZTMl1PxRXBs/zAPJ2TiwprwX93nBQ8mSS+eqQdc84vnX+zBCswUO0XVr6BhwPY3V KpcB40QjlrkAy+0HpYoXWXh8H6ORb0zRQJlHBpXFCHt6kSAKPV+Vnwd7yKOt4MdXXY6Z PEvOHoT1od5DKOOGtR9m92YgTgLLfFGx7yTG/z7lMYK4R8VWq6TS1nkj2aJ5HmBYhL4s CSLBcLBSaOUeUombfP8ac/a4sOqlxS7+kKKQdo/ZMijWKbFcqgZSrTPQBEkmy3Wx1ZoV oD8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=juW9wu13y489Hph7sR+dhrqUMWDs6TD8KFYBRB4JbO4=; b=e56wSsfiJY62y3oVkQwUkwC0yhMv8A/VsfWkYHAZSzJHo33nSzXLXfFEUb2OjsBaGQ gUZ7pYB1amCRNqSkIrKuUs9E/IH4m4pxC1JXi2XpL5vw6sj6Y80CceOhKKioFcT0b5WN 0lFqKw1tSzC6rQ2ZLqdIXyHzsHD/+7XkSeqO5b5j8X2tIwpiSdoSgwpusNsu9ojV6XOQ W/itZNt2dP843PeE2nDvC2K3/CsatSJREG/fbHSZFC6w/CINs5sTcA2hVbFL7j/IQo6Y W4WPhxjrFeiUYAqUWvZjyjUQIWhth5Sh9/dLiOlprTsuTKmYAneP+J7wD5qYn352kx6B 5mYA== X-Gm-Message-State: ACrzQf1fdGS36M1qxnN0iorc/SrSmIH1rUapOotleKRSywTMLuAU8V6L 0udHF4EwcZawXwG75SrmJZYFX7ASFoYFLadG X-Google-Smtp-Source: AMsMyM5D4l9JsGqXgs9A63E6didLWcsPaoFzBxMa/D8qX5FCUImVpo7wKrQKlyj/Z2649h6to7tzFA== X-Received: by 2002:aa7:880f:0:b0:558:12e9:178e with SMTP id c15-20020aa7880f000000b0055812e9178emr12167552pfo.23.1664594057305; Fri, 30 Sep 2022 20:14:17 -0700 (PDT) Received: from skynet-linux.local ([2406:7400:61:5d7c:3fe4:8f6d:b1b6:f2bf]) by smtp.googlemail.com with ESMTPSA id cp1-20020a170902e78100b00172a567d910sm2627371plb.289.2022.09.30.20.14.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Sep 2022 20:14:16 -0700 (PDT) From: Sireesh Kodali To: devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, linux-kernel@vger.kernel.org Cc: andersson@kernel.org, krzysztof.kozlowski+dt@linaro.org, Sireesh Kodali , Krzysztof Kozlowski , Andy Gross , Konrad Dybcio , Mathieu Poirier , Rob Herring Subject: [PATCH v6 4/5] dt-bindings: remoteproc: qcom: wcnss: Add compatible for pronto v3 Date: Sat, 1 Oct 2022 08:43:43 +0530 Message-Id: <20221001031345.31293-5-sireeshkodali1@gmail.com> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20221001031345.31293-1-sireeshkodali1@gmail.com> References: <20221001031345.31293-1-sireeshkodali1@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The pronto v3 remoteproc is similar to pronto v2. It is found on the MSM8953 platform, which is used by SDM450, SDM625, SDM626, APQ8053 and other SoCs. Since the configuration is same on all SoCs, a single compatible is used. Signed-off-by: Sireesh Kodali Reviewed-by: Krzysztof Kozlowski --- .../bindings/remoteproc/qcom,wcnss-pil.yaml | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.ya= ml b/Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.yaml index 0eb2617e3482..2ba2b6cf11fb 100644 --- a/Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.yaml +++ b/Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.yaml @@ -22,6 +22,7 @@ properties: - enum: - qcom,pronto-v1-pil - qcom,pronto-v2-pil + - qcom,pronto-v3-pil - const: qcom,pronto - const: qcom,riva-pil =20 @@ -199,6 +200,21 @@ allOf: - power-domains - power-domain-names =20 + - if: + properties: + compatible: + contains: + enum: + - qcom,pronto-v3-pil + then: + properties: + vddmx-supply: false + vddcx-supply: false + + required: + - power-domains + - power-domain-names + examples: - | #include --=20 2.37.3 From nobody Sat Apr 27 16:30:48 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECAF7C433FE for ; Sat, 1 Oct 2022 03:23:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232362AbiJADXe (ORCPT ); Fri, 30 Sep 2022 23:23:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45100 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233113AbiJADWn (ORCPT ); Fri, 30 Sep 2022 23:22:43 -0400 Received: from mail-pl1-x634.google.com (mail-pl1-x634.google.com [IPv6:2607:f8b0:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F2AC885AB6; Fri, 30 Sep 2022 20:15:19 -0700 (PDT) Received: by mail-pl1-x634.google.com with SMTP id f23so5441276plr.6; Fri, 30 Sep 2022 20:15:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=5Bev8D6ZYJiqDjBpp+o/3o3sID8wHikuW24dd+pn+/w=; b=PGe1+HcPTAw6H/e/EvSr1dQxZUhqMjOFMEr7JegNTuuF3B6VllEtzC6cY1vS6ObK/6 Mv5MSa+H3Zjk126gmSaI7WsLGWb8Msya+uraVcpAKYwvvJcjt6gOkNmx1tm4dSk7boSv pz50WfKjdDOZbUCloD7aiRKLueQBTTVdrKxIAzjfGAzyElXA8eiCSdsYv4WT63QZATY7 fcKsr5ffvsuAn2L2Ga/GQ00wPzn4jM1eiZkFt1+WIxQAzHNvtT878nS6ZbToHr5Qqbxb 49V5IizKhGY++oixBP7xfGY8JDbQEp3gNLehA8WD9QuFYSMUFCGDBzI/rddaXYYeshV9 XQGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=5Bev8D6ZYJiqDjBpp+o/3o3sID8wHikuW24dd+pn+/w=; b=JlKaDQObG8lc7U2ym4o2d7lK6Mj6/dJO1RY5/YkVXzss4gwVIgh1TF9GPX6mQbJO4r 4JZ1WTn6byInbhPI+OeTzLTNcEW0zj/V2ekDuPcYCo9g+AQOsHFcFaujjxC3kCWXWgQV ELqLGNkOrLMWXa3w4BfVCbjT/YB9BCXeBWSFWxoomn+OHybBMwXJ0M8pYD4Hd0EL20zB hOgTR1W9/8Bd6tR1Iuqiz4lmYv/dHrB2dZ1YfR1CYlTeQdf1o1YTlTHcnU7yrdgOeFsi PFSd+1YDE3VG8F6i4D4uZBfZizS6S+DQNGr/AXLa2axjCj2ZgeXkN2+sGjGpaz3xe+BS 1M6g== X-Gm-Message-State: ACrzQf3ZN91yfYodsOIBdvQs1qfaqiUlQjS7jysU7eeHPD1L25IFGkeD c9MPvTzkFXEQCmC4cYNS+PkirY1tvdSrOzdl X-Google-Smtp-Source: AMsMyM44ANcunkldxLZFZ73zNKxVK1ToZcJq26NjvxGQy1aPM74t/R3klkbu5we1SvAQ6FGhKHCazA== X-Received: by 2002:a17:902:f684:b0:178:84d:ddc5 with SMTP id l4-20020a170902f68400b00178084dddc5mr12184099plg.62.1664594061730; Fri, 30 Sep 2022 20:14:21 -0700 (PDT) Received: from skynet-linux.local ([2406:7400:61:5d7c:3fe4:8f6d:b1b6:f2bf]) by smtp.googlemail.com with ESMTPSA id cp1-20020a170902e78100b00172a567d910sm2627371plb.289.2022.09.30.20.14.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Sep 2022 20:14:21 -0700 (PDT) From: Sireesh Kodali To: devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, linux-kernel@vger.kernel.org Cc: andersson@kernel.org, krzysztof.kozlowski+dt@linaro.org, Sireesh Kodali , Krzysztof Kozlowski , Andy Gross , Konrad Dybcio , Mathieu Poirier , Rob Herring Subject: [PATCH v6 5/5] dt-bindings: remoteproc: wcnss-pil: Make supplies optionally required Date: Sat, 1 Oct 2022 08:43:44 +0530 Message-Id: <20221001031345.31293-6-sireeshkodali1@gmail.com> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20221001031345.31293-1-sireeshkodali1@gmail.com> References: <20221001031345.31293-1-sireeshkodali1@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" On MSM8974, power domains are not yet supported. The platform uses regulators. This patch marks either the power-domains or *-supply as required (instead of always requiring the power domains). Signed-off-by: Sireesh Kodali Reviewed-by: Krzysztof Kozlowski --- .../devicetree/bindings/remoteproc/qcom,wcnss-pil.yaml | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.ya= ml b/Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.yaml index 2ba2b6cf11fb..45eb42bd3c2c 100644 --- a/Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.yaml +++ b/Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.yaml @@ -196,9 +196,13 @@ allOf: deprecated: true description: Deprecated for qcom,pronto-v1/2-pil =20 - required: - - power-domains - - power-domain-names + oneOf: + - required: + - power-domains + - power-domain-names + - required: + - vddmx-supply + - vddcx-supply =20 - if: properties: --=20 2.37.3