From nobody Mon Apr 6 14:55:31 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 208EFC433F5 for ; Fri, 30 Sep 2022 00:50:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229941AbiI3Aud (ORCPT ); Thu, 29 Sep 2022 20:50:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50110 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229792AbiI3AuZ (ORCPT ); Thu, 29 Sep 2022 20:50:25 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F18F1564C3 for ; Thu, 29 Sep 2022 17:50:22 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 02C2C621F5 for ; Fri, 30 Sep 2022 00:50:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 48575C43470; Fri, 30 Sep 2022 00:50:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664499021; bh=zB8G1Z7pEhfGomLi8IipgwDv6tydTM4idiFu0sDQK/Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RfDM6tRDl9nDSLXTYnWKvRI8R5FbmaW+PCjml/5KwCOvwhkyiQPOIyRVQ3GPFgTDq zA4N8cH7SUHToIId7ZoWcStOqluA4g8BbeONFtEdC0ImgxY9YMS8XWg1cgOiRGVU97 SoZdLPGTZjfR32/pgM2f28KdI6uK0B+rkNJsYlqtIBiWzHzgyCYyGTAtcAcrunJop4 m2XLqfmhQ/jI+smB8XolxljyUGviVXifVgSwXJhovCJwuQt3ByY5US6j0v8g3gPIsg mHTwPO7K5ftXeZcEo0Qoty+mZPqBjhuGw/L9RQFMrwCvoixAQZ4Byp0VeJue5A7MCe dSizEtBsLpgPg== From: Stephen Boyd To: Greg Kroah-Hartman Cc: David Collins , linux-kernel@vger.kernel.org, patches@lists.linux.dev, Fenglin Wu Subject: [PATCH 5/9] spmi: pmic-arb: check apid against limits before calling irq handler Date: Thu, 29 Sep 2022 17:50:14 -0700 Message-Id: <20220930005019.2663064-6-sboyd@kernel.org> X-Mailer: git-send-email 2.38.0.rc1.362.ged0d419d3c-goog In-Reply-To: <20220930005019.2663064-1-sboyd@kernel.org> References: <20220930005019.2663064-1-sboyd@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: David Collins Check that the apid for an SPMI interrupt falls between the min_apid and max_apid that can be handled by the APPS processor before invoking the per-apid interrupt handler: periph_interrupt(). This avoids an access violation in rare cases where the status bit is set for an interrupt that is not owned by the APPS processor. Signed-off-by: David Collins Signed-off-by: Fenglin Wu Link: https://lore.kernel.org/r/1655004286-11493-5-git-send-email-quic_feng= linw@quicinc.com Signed-off-by: Stephen Boyd --- drivers/spmi/spmi-pmic-arb.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/spmi/spmi-pmic-arb.c b/drivers/spmi/spmi-pmic-arb.c index 2bc3b88f35c9..e19eaec30aa5 100644 --- a/drivers/spmi/spmi-pmic-arb.c +++ b/drivers/spmi/spmi-pmic-arb.c @@ -625,21 +625,26 @@ static void pmic_arb_chained_irq(struct irq_desc *des= c) struct spmi_pmic_arb *pmic_arb =3D irq_desc_get_handler_data(desc); const struct pmic_arb_ver_ops *ver_ops =3D pmic_arb->ver_ops; struct irq_chip *chip =3D irq_desc_get_chip(desc); - int first =3D pmic_arb->min_apid >> 5; - int last =3D pmic_arb->max_apid >> 5; + int first =3D pmic_arb->min_apid; + int last =3D pmic_arb->max_apid; u8 ee =3D pmic_arb->ee; u32 status, enable, handled =3D 0; int i, id, apid; =20 chained_irq_enter(chip, desc); =20 - for (i =3D first; i <=3D last; ++i) { + for (i =3D first >> 5; i <=3D last >> 5; ++i) { status =3D readl_relaxed( ver_ops->owner_acc_status(pmic_arb, ee, i)); while (status) { id =3D ffs(status) - 1; status &=3D ~BIT(id); apid =3D id + i * 32; + if (apid < first || apid > last) { + WARN_ONCE(true, "spurious spmi irq received for apid=3D%d\n", + apid); + continue; + } enable =3D readl_relaxed( ver_ops->acc_enable(pmic_arb, apid)); if (enable & SPMI_PIC_ACC_ENABLE_BIT) --=20 https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git/ https://git.kernel.org/pub/scm/linux/kernel/git/sboyd/spmi.git