From nobody Mon Apr 6 13:29:24 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C20E2C32771 for ; Wed, 28 Sep 2022 07:22:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233174AbiI1HWr (ORCPT ); Wed, 28 Sep 2022 03:22:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50484 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233482AbiI1HWV (ORCPT ); Wed, 28 Sep 2022 03:22:21 -0400 Received: from mail-yw1-x114a.google.com (mail-yw1-x114a.google.com [IPv6:2607:f8b0:4864:20::114a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 80EDCD62FC for ; Wed, 28 Sep 2022 00:22:17 -0700 (PDT) Received: by mail-yw1-x114a.google.com with SMTP id 00721157ae682-3508d8c60ceso101407087b3.18 for ; Wed, 28 Sep 2022 00:22:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:references:mime-version:message-id:in-reply-to :date:from:to:cc:subject:date; bh=kyButVpLUDmoK22yP9Tz8dG8x/bX/1WzYYTdRXgfVks=; b=nt1st7/BkdP2mNLSR4upYTuJ97yt67jFbSIOqYDJCdQIfZkRMkj42vbVuM2lEk3eOV TldUDa3mUUkrx95oVYqol3UT+anm30n2JWqpiOEL9p4E4+H1lp52gP9TR+siwfgahKJn bW60c1SwSTMUo2g/xzvfJwGtWk0nksXDdv0ILn9MhouPErw02VAflEspQP/kmYFBv6yS VfnNZH67UnGkJ8ncrbUAfQDgQCBgWl60Xn83K5sIRLyoqLGuIXdHT5GYSA0AyTFWAL9w /EmhQ/yWzwu6mz/OduP8SDFmR806RkQ+RY8lNEBl/+QavXvsmUkq4f5Y/9Tq6q9wmNYS HAmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:references:mime-version:message-id:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date; bh=kyButVpLUDmoK22yP9Tz8dG8x/bX/1WzYYTdRXgfVks=; b=FxNfFStiltMaaD4BIOLC9IFj7bXVUSRZMPH+N59tDfpcx4UC8HfWzK934Gm4sC3+HM 40JZChsZZ5c4ww4rma987a60AzD/wKsuhXI7ZHvQuImqSFypixaHiscGMUINtVBWzPEz IbPJtayBzDjIBmzva5AFOoebbHo9D+LM8licTDHHajvThSk1YQRb63YdLXCs7VBGaXjq wolckgX1+dGFLTU8MKauiWPc5VR8q+zxb84rrSbcr39hwhUssjkFIi77X7ULqnHnzLod DG5Hq3YdM7VDNJ8hAwiW2zNt6JkkcA2kt1bbqCKCxw/6ONCYjaXMeL2PYltbgyT/mn0Q qbRQ== X-Gm-Message-State: ACrzQf0tx9Eh/RW0lL0BFli2VJ5d2XabVg5fOeI6TcBUlXN0cCJxdNbp AuwHJWnUKbVty3zJWf4mH/fkCbmf8qMX X-Google-Smtp-Source: AMsMyM6Kxupad9S1uMBq0IatbSrlKAE295hYThk2/2sn6a5M4JIcNaREH8vvz65Mun59fckETCG0KgATwBD1 X-Received: from irogers.svl.corp.google.com ([2620:15c:2d4:203:7099:1ccb:612a:5ad6]) (user=irogers job=sendgmr) by 2002:a25:9804:0:b0:6a8:e064:ef9a with SMTP id a4-20020a259804000000b006a8e064ef9amr27993713ybo.62.1664349736769; Wed, 28 Sep 2022 00:22:16 -0700 (PDT) Date: Wed, 28 Sep 2022 00:21:45 -0700 In-Reply-To: <20220928072204.1613330-1-irogers@google.com> Message-Id: <20220928072204.1613330-4-irogers@google.com> Mime-Version: 1.0 References: <20220928072204.1613330-1-irogers@google.com> X-Mailer: git-send-email 2.37.3.998.g577e59143f-goog Subject: [PATCH v1 03/22] perf metrics: Don't scale counts going into metrics From: Ian Rogers To: Zhengjun Xing , Kan Liang , Andi Kleen , perry.taylor@intel.com, caleb.biggers@intel.com, kshipra.bopardikar@intel.com, samantha.alt@intel.com, ahmad.yasin@intel.com, Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , John Garry , James Clark , Kajol Jain , Thomas Richter , Miaoqian Lin , Florian Fischer , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Stephane Eranian , Ian Rogers Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Counts are scaled prior to going into saved_value, reverse the scaling so that metrics don't double scale values. Signed-off-by: Ian Rogers --- tools/perf/util/stat-shadow.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/tools/perf/util/stat-shadow.c b/tools/perf/util/stat-shadow.c index 9e1eddeff21b..b5cedd37588f 100644 --- a/tools/perf/util/stat-shadow.c +++ b/tools/perf/util/stat-shadow.c @@ -865,11 +865,16 @@ static int prepare_metric(struct evsel **metric_event= s, if (!v) break; stats =3D &v->stats; - scale =3D 1.0; + /* + * If an event was scaled during stat gathering, reverse + * the scale before computing the metric. + */ + scale =3D 1.0 / metric_events[i]->scale; + source_count =3D evsel__source_count(metric_events[i]); =20 if (v->metric_other) - metric_total =3D v->metric_total; + metric_total =3D v->metric_total * scale; } n =3D strdup(evsel__metric_id(metric_events[i])); if (!n) --=20 2.37.3.998.g577e59143f-goog