From nobody Tue Dec 16 04:27:41 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF8ACC32771 for ; Mon, 26 Sep 2022 11:47:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238707AbiIZLq7 (ORCPT ); Mon, 26 Sep 2022 07:46:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53474 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238581AbiIZLoE (ORCPT ); Mon, 26 Sep 2022 07:44:04 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D426472B5D; Mon, 26 Sep 2022 03:46:33 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 54D90B802C5; Mon, 26 Sep 2022 10:46:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 94D88C433D7; Mon, 26 Sep 2022 10:46:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1664189192; bh=+H+3e6MavXuunQEspWLbj9AiqmKe3ZMHaTE84jFSCDM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EnCIi6URDlBnYO1VALuZUGVmWoe97NcCm1tt/yA4a6OE7wIwGhch9RTDZf1XJFH+B NXB5Ij6irR8d29jSDOVhg4Y8H+X/GRw1RE6TXFPnL6VdOHtReHI9/kZrP5QTO7/Y6D 1kkdf0+Oijd1VH5mRbfh7SOdgCdZJw1LVIq9NOpI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Cristian Marussi , Sudeep Holla , Sasha Levin Subject: [PATCH 5.19 072/207] firmware: arm_scmi: Fix the asynchronous reset requests Date: Mon, 26 Sep 2022 12:11:01 +0200 Message-Id: <20220926100809.810922623@linuxfoundation.org> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20220926100806.522017616@linuxfoundation.org> References: <20220926100806.522017616@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Cristian Marussi [ Upstream commit b75c83d9b961fd3abf7310f8d36d5e6e9f573efb ] SCMI Reset protocol specification allows the asynchronous reset request only when an autonomous reset action is specified. Reset requests based on explicit assert/deassert of signals should not be served asynchronously. Current implementation will instead issue an asynchronous request in any case, as long as the reset domain had advertised to support asynchronous resets. Avoid requesting the asynchronous resets when the reset action is not of the autonomous type, even if the target reset domain does, in general, support the asynchronous requests. Link: https://lore.kernel.org/r/20220817172731.1185305-6-cristian.marussi@a= rm.com Fixes: 95a15d80aa0d ("firmware: arm_scmi: Add RESET protocol in SCMI v2.0") Signed-off-by: Cristian Marussi Signed-off-by: Sudeep Holla Signed-off-by: Sasha Levin --- drivers/firmware/arm_scmi/reset.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/firmware/arm_scmi/reset.c b/drivers/firmware/arm_scmi/= reset.c index b0494165b1cb..e9afa8cab730 100644 --- a/drivers/firmware/arm_scmi/reset.c +++ b/drivers/firmware/arm_scmi/reset.c @@ -172,7 +172,7 @@ static int scmi_domain_reset(const struct scmi_protocol= _handle *ph, u32 domain, return -EINVAL; =20 rdom =3D pi->dom_info + domain; - if (rdom->async_reset) + if (rdom->async_reset && flags & AUTONOMOUS_RESET) flags |=3D ASYNCHRONOUS_RESET; =20 ret =3D ph->xops->xfer_get_init(ph, RESET, sizeof(*dom), 0, &t); @@ -184,7 +184,7 @@ static int scmi_domain_reset(const struct scmi_protocol= _handle *ph, u32 domain, dom->flags =3D cpu_to_le32(flags); dom->reset_state =3D cpu_to_le32(state); =20 - if (rdom->async_reset) + if (flags & ASYNCHRONOUS_RESET) ret =3D ph->xops->do_xfer_with_response(ph, t); else ret =3D ph->xops->do_xfer(ph, t); --=20 2.35.1