From nobody Tue Dec 16 04:36:34 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D000C32771 for ; Mon, 26 Sep 2022 11:41:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238302AbiIZLlo (ORCPT ); Mon, 26 Sep 2022 07:41:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60656 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238287AbiIZLk6 (ORCPT ); Mon, 26 Sep 2022 07:40:58 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 76FC84D80C; Mon, 26 Sep 2022 03:45:29 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id AE98160BA5; Mon, 26 Sep 2022 10:44:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AF1E7C433C1; Mon, 26 Sep 2022 10:44:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1664189067; bh=EbzNcFdyCzwHoRdRE4DsMCPjZPvGEdjHYWMP72mW22s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=wYF5CPE5k+Flt8TuIRHmjzCqKoiGzRB8tfTFDKMVt7/haKfYgqqckT8ASySbIrZE3 Sr4RifuvUDXQY54xD+1sUz8PPaKSsBkEvnkzWJzcCzs4QHJ3f8s1nNngdiiUlCdrJg xgCGzykcONUaAFZ08UK2AAZ3jCSgR6x8E1V4f8ZE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Sinan Kaya , Haiyang Zhang , Dexuan Cui , Jakub Kicinski Subject: [PATCH 5.19 061/207] net: mana: Add rmb after checking owner bits Date: Mon, 26 Sep 2022 12:10:50 +0200 Message-Id: <20220926100809.340503618@linuxfoundation.org> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20220926100806.522017616@linuxfoundation.org> References: <20220926100806.522017616@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Haiyang Zhang commit 6fd2c68da55c552f86e401ebe40c4a619025ef69 upstream. Per GDMA spec, rmb is necessary after checking owner_bits, before reading EQ or CQ entries. Add rmb in these two places to comply with the specs. Cc: stable@vger.kernel.org Fixes: ca9c54d2d6a5 ("net: mana: Add a driver for Microsoft Azure Network A= dapter (MANA)") Reported-by: Sinan Kaya Signed-off-by: Haiyang Zhang Reviewed-by: Dexuan Cui Link: https://lore.kernel.org/r/1662928805-15861-1-git-send-email-haiyangz@= microsoft.com Signed-off-by: Jakub Kicinski Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/microsoft/mana/gdma_main.c | 10 ++++++++++ 1 file changed, 10 insertions(+) --- a/drivers/net/ethernet/microsoft/mana/gdma_main.c +++ b/drivers/net/ethernet/microsoft/mana/gdma_main.c @@ -370,6 +370,11 @@ static void mana_gd_process_eq_events(vo break; } =20 + /* Per GDMA spec, rmb is necessary after checking owner_bits, before + * reading eqe. + */ + rmb(); + mana_gd_process_eqe(eq); =20 eq->head++; @@ -1107,6 +1112,11 @@ static int mana_gd_read_cqe(struct gdma_ if (WARN_ON_ONCE(owner_bits !=3D new_bits)) return -1; =20 + /* Per GDMA spec, rmb is necessary after checking owner_bits, before + * reading completion info + */ + rmb(); + comp->wq_num =3D cqe->cqe_info.wq_num; comp->is_sq =3D cqe->cqe_info.is_sq; memcpy(comp->cqe_data, cqe->cqe_data, GDMA_COMP_DATA_SIZE);