From nobody Tue Dec 16 04:04:51 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95FDAC32771 for ; Mon, 26 Sep 2022 11:37:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235089AbiIZLhO (ORCPT ); Mon, 26 Sep 2022 07:37:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49114 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238081AbiIZLft (ORCPT ); Mon, 26 Sep 2022 07:35:49 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 338646EF04; Mon, 26 Sep 2022 03:43:50 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 81BD2B8095B; Mon, 26 Sep 2022 10:43:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D4C83C433C1; Mon, 26 Sep 2022 10:43:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1664189029; bh=hbX0O4j5USK+7RKpbhjOSEOCaH0sBE6gjVM88scBssA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Ru6Os3WQv+crTxS24IqmSwkuYbSEWls9F+cu75VkBzcWo/+Rbv9HDHwzv8KFYRIkO bP9udvc7Ni6U9I9Bp2pBLc8rNU6UlHB8wkKKL3rmJx6ffrAfu+YPT2RJRsQhD8YxWJ onzWpy9gjX1EPRX7oW2a95GSCo95TWe3jjsD4L+o= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Felix Fietkau , Kalle Valo Subject: [PATCH 5.19 050/207] wifi: mt76: fix reading current per-tid starting sequence number for aggregation Date: Mon, 26 Sep 2022 12:10:39 +0200 Message-Id: <20220926100808.862244223@linuxfoundation.org> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20220926100806.522017616@linuxfoundation.org> References: <20220926100806.522017616@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Felix Fietkau commit c3a510e2b53785df31d882a773c4c0780b4c825f upstream. The code was accidentally shifting register values down by tid % 32 instead= of (tid * field_size) % 32. Cc: stable@vger.kernel.org Fixes: a28bef561a5c ("mt76: mt7615: re-enable offloading of sequence number= assignment") Signed-off-by: Felix Fietkau Signed-off-by: Kalle Valo Link: https://lore.kernel.org/r/20220826182329.18155-1-nbd@nbd.name Signed-off-by: Greg Kroah-Hartman --- drivers/net/wireless/mediatek/mt76/mt7615/mac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/wireless/mediatek/mt76/mt7615/mac.c +++ b/drivers/net/wireless/mediatek/mt76/mt7615/mac.c @@ -1138,7 +1138,7 @@ u32 mt7615_mac_get_sta_tid_sn(struct mt7 offset %=3D 32; =20 val =3D mt76_rr(dev, addr); - val >>=3D (tid % 32); + val >>=3D offset; =20 if (offset > 20) { addr +=3D 4;