From nobody Thu Apr 2 15:06:39 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57507C6FA83 for ; Sun, 25 Sep 2022 11:06:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232683AbiIYLGh (ORCPT ); Sun, 25 Sep 2022 07:06:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59902 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232225AbiIYLGW (ORCPT ); Sun, 25 Sep 2022 07:06:22 -0400 Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ADE7E31ED9 for ; Sun, 25 Sep 2022 04:06:18 -0700 (PDT) Received: by mail-lf1-x131.google.com with SMTP id o2so6734431lfc.10 for ; Sun, 25 Sep 2022 04:06:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=c3vr9ZcVCz9cz4XS0JEceE2ICtAEiQioi8Jl3QwESv4=; b=jMdOMRCSdiINsgdxHOvy9wHBcF7bRjSjqJjTHA1FEq+LmhWXa54aYuTs3N7QSp8C+q /161jGZdpnmlk1alg9Z/Io/u/ByDy3FYP6UxCbVBcnJJVnwseYggOC2j5pGvIdu9yoEL 7Iwpy1ECYXUEdezqJgUWTk7ftYS5ZUS/e/rM0vUZtLK6TpAn/5X/tXw13IXxhHZwL4kH 3w6lkegER3vLyqVGu6M37s5BvLVMb26xLpo0RZrMY0HVn9MezZ4QMthShoXU8ThzXTOE 1cJwgrl3zvM9FZHqD2zrOlnPTRgubLyQVxrQjSYS0bbzHaBiO2B9rtkQNaB/MuSd4r6k qZug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=c3vr9ZcVCz9cz4XS0JEceE2ICtAEiQioi8Jl3QwESv4=; b=S8OVBat8fHqZ7WVFewDFoXc+g9djJMeeyxZF8A77GAp1+kRnnNZkoZ2O2DVnVGbEtB oXrMtNuJmS/QidoS5sakH3Hm+58y70Laip76XstRAspzzAT2LDDk072aPR6JxspB5vB3 esJV/X9g7Hci2fSYdoxJTg7AQ2yHx7GJF5SVM7lBm5zItUxkJhkNtgcB34lQ69eLOace JqZZ+OLRLU7AjLWgrHOh0H9lMY6Thth/00xo5sHNZ/1AGnV1dQyTdXHLBhHBkT9nKdCD UDGT2Smig/hVXlkJKD49iqtgy+jps97m6UM4Bzw6w6ptoGnvXD/5WfE+IfC4mumxwRFz o4/A== X-Gm-Message-State: ACrzQf3ODzK36qtgRIeID+wBOA3HsVeIoWh5XJi1EiXhAxUU3Od88o9o 0X0QJ/HxKuioGhr0DOGQBRBCvQ== X-Google-Smtp-Source: AMsMyM4JC1lcNK87LMmGzqJjfEddk8jD/YrDbuIGylz78nIuBbuzfAIBJ5M9k/y3RUqvYddCxvXufg== X-Received: by 2002:a19:5505:0:b0:497:ad71:39f4 with SMTP id n5-20020a195505000000b00497ad7139f4mr6660486lfe.226.1664103976886; Sun, 25 Sep 2022 04:06:16 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id u19-20020ac258d3000000b00492dadd8143sm2177265lfo.168.2022.09.25.04.06.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 25 Sep 2022 04:06:16 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 03/15] arm64: dts: qcom: sc8280xp: align TLMM pin configuration with DT schema Date: Sun, 25 Sep 2022 13:05:56 +0200 Message-Id: <20220925110608.145728-4-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220925110608.145728-1-krzysztof.kozlowski@linaro.org> References: <20220925110608.145728-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" DT schema expects TLMM pin configuration nodes to be named with '-state' suffix and their optional children with '-pins' suffix. qcom/sc8280xp-crd.dtb: pinctrl@f100000: kybd-default-state: 'oneOf' condi= tional failed, one must be fixed: 'pins' is a required property 'function' is a required property 'disable', 'int-n', 'reset' do not match any of the regexes: 'pinctrl-[= 0-9]+' 'disable', 'int-n', 'reset' do not match any of the regexes: '-pins$', = 'pinctrl-[0-9]+' Signed-off-by: Krzysztof Kozlowski Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/sc8280xp-crd.dts | 12 ++++++------ .../boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 12 ++++++------ 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts b/arch/arm64/boot/dt= s/qcom/sc8280xp-crd.dts index fea7d8273ccd..a2027f1d1d04 100644 --- a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts +++ b/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts @@ -374,19 +374,19 @@ &tlmm { gpio-reserved-ranges =3D <74 6>, <83 4>, <125 2>, <128 2>, <154 7>; =20 kybd_default: kybd-default-state { - disable { + disable-pins { pins =3D "gpio102"; function =3D "gpio"; output-low; }; =20 - int-n { + int-n-pins { pins =3D "gpio104"; function =3D "gpio"; bias-disable; }; =20 - reset { + reset-pins { pins =3D "gpio105"; function =3D "gpio"; bias-disable; @@ -410,7 +410,7 @@ qup2_i2c5_default: qup2-i2c5-default-state { }; =20 tpad_default: tpad-default-state { - int-n { + int-n-pins { pins =3D "gpio182"; function =3D "gpio"; bias-disable; @@ -418,13 +418,13 @@ int-n { }; =20 ts0_default: ts0-default-state { - int-n { + int-n-pins { pins =3D "gpio175"; function =3D "gpio"; bias-disable; }; =20 - reset-n { + reset-n-pins { pins =3D "gpio99"; function =3D "gpio"; output-high; diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts b/a= rch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts index b2b744bb8a53..68b61e8d03c0 100644 --- a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts +++ b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts @@ -350,19 +350,19 @@ &tlmm { gpio-reserved-ranges =3D <70 2>, <74 6>, <83 4>, <125 2>, <128 2>, <154 7= >; =20 kybd_default: kybd-default-state { - disable { + disable-pins { pins =3D "gpio102"; function =3D "gpio"; output-low; }; =20 - int-n { + int-n-pins { pins =3D "gpio104"; function =3D "gpio"; bias-disable; }; =20 - reset { + reset-pins { pins =3D "gpio105"; function =3D "gpio"; bias-disable; @@ -384,7 +384,7 @@ qup2_i2c5_default: qup2-i2c5-default-state { }; =20 tpad_default: tpad-default-state { - int-n { + int-n-pins { pins =3D "gpio182"; function =3D "gpio"; bias-disable; @@ -392,13 +392,13 @@ int-n { }; =20 ts0_default: ts0-default-state { - int-n { + int-n-pins { pins =3D "gpio175"; function =3D "gpio"; bias-disable; }; =20 - reset-n { + reset-n-pins { pins =3D "gpio99"; function =3D "gpio"; output-high; --=20 2.34.1