From nobody Mon Apr 6 12:13:29 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 767EDC04A95 for ; Sat, 24 Sep 2022 00:05:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233000AbiIXAFM (ORCPT ); Fri, 23 Sep 2022 20:05:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54514 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232959AbiIXAFE (ORCPT ); Fri, 23 Sep 2022 20:05:04 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 67A839DFAB; Fri, 23 Sep 2022 17:04:58 -0700 (PDT) From: John Ogness DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1663977896; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5V3Z6AhMdpsVP4d3DckyHZHpUKQGjS72cEceALWthyY=; b=YbT35guZgiSYqZPsZ7HEpaJ0sOvKpQbPePGoaeyTUm7H/wO1/IFAkSjQMkNg4HoC1rMjla jOG2WQmkJFxhuw2YenY92/zVcdEBo8eSRyStxb7OnII/aJAGAhnWzSRDfyJebHiDKEtYsH VNDjMh4g98gPQQl/3zb/cwRcC7g7EU9DyDPbTqF/6nqU9EH06kz9Dc6JPBe3Kgtp2H0HBH dzs1e8znzH4R2m53tahOEpKMFCwYjvzSFUCrkVqO/G6He6rIqI0eJfHtg/e0V6xFjFnvHn e5shoEqTJMDYCVlN2zoS/cBXquWRftl9TI/0+Iz99De6KVyJMNk7i3vBAsXKLA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1663977896; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5V3Z6AhMdpsVP4d3DckyHZHpUKQGjS72cEceALWthyY=; b=bbbCxJXlhztbHC/ejFyxV3FY+WbK3/0ecpHf3f2KN7q4Su9QrnsgmRYIkGnOJILcTg0FE5 gaPedLj1PMB++VDg== To: Petr Mladek Cc: Sergey Senozhatsky , Steven Rostedt , Thomas Gleixner , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: [PATCH printk 02/18] printk: Declare log_wait properly Date: Sat, 24 Sep 2022 02:10:38 +0206 Message-Id: <20220924000454.3319186-3-john.ogness@linutronix.de> In-Reply-To: <20220924000454.3319186-1-john.ogness@linutronix.de> References: <20220924000454.3319186-1-john.ogness@linutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Thomas Gleixner kernel/printk/printk.c:365:1: warning: symbol 'log_wait' was not declared. = Should it be static? Signed-off-by: Thomas Gleixner Signed-off-by: John Ogness Reviewed-by: Sergey Senozhatsky Reviewed-by: Petr Mladek --- fs/proc/kmsg.c | 2 -- include/linux/syslog.h | 3 +++ 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/fs/proc/kmsg.c b/fs/proc/kmsg.c index b38ad552887f..9d6950ac10fe 100644 --- a/fs/proc/kmsg.c +++ b/fs/proc/kmsg.c @@ -18,8 +18,6 @@ #include #include =20 -extern wait_queue_head_t log_wait; - static int kmsg_open(struct inode * inode, struct file * file) { return do_syslog(SYSLOG_ACTION_OPEN, NULL, 0, SYSLOG_FROM_PROC); diff --git a/include/linux/syslog.h b/include/linux/syslog.h index 86af908e2663..955f80e34d4f 100644 --- a/include/linux/syslog.h +++ b/include/linux/syslog.h @@ -8,6 +8,8 @@ #ifndef _LINUX_SYSLOG_H #define _LINUX_SYSLOG_H =20 +#include + /* Close the log. Currently a NOP. */ #define SYSLOG_ACTION_CLOSE 0 /* Open the log. Currently a NOP. */ @@ -35,5 +37,6 @@ #define SYSLOG_FROM_PROC 1 =20 int do_syslog(int type, char __user *buf, int count, int source); +extern wait_queue_head_t log_wait; =20 #endif /* _LINUX_SYSLOG_H */ --=20 2.30.2