[PATCH v3 1/2] dt-bindings: arm: qcom: Separete LTE/WIFI SKU for sc7280-evoker

Sheng-Liang Pan posted 2 patches 2 months ago
There is a newer version of this series
[PATCH v3 1/2] dt-bindings: arm: qcom: Separete LTE/WIFI SKU for sc7280-evoker
Posted by Sheng-Liang Pan 2 months ago
evoker will have WIFI/LTE SKU, separete it for each different setting.

Signed-off-by: Sheng-Liang Pan <sheng-liang.pan@quanta.corp-partner.google.com>
---

Changes in v3:
- none

Changes in v2:
- none

 Documentation/devicetree/bindings/arm/qcom.yaml | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index b6257683a700c..065d9cc4421e0 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -575,6 +575,11 @@ properties:
           - const: google,evoker
           - const: qcom,sc7280
 
+      - description: Google Evoker with LTE (newest rev)
+        items:
+          - const: google,evoker-sku512
+          - const: qcom,sc7280
+
       - description: Google Herobrine (newest rev)
         items:
           - const: google,herobrine
-- 
2.34.1
Re: [PATCH v3 1/2] dt-bindings: arm: qcom: Separete LTE/WIFI SKU for sc7280-evoker
Posted by Krzysztof Kozlowski 2 months ago
On 23/09/2022 11:42, Sheng-Liang Pan wrote:
> evoker will have WIFI/LTE SKU, separete it for each different setting.
> 
> Signed-off-by: Sheng-Liang Pan <sheng-liang.pan@quanta.corp-partner.google.com>
> ---
> 
> Changes in v3:
> - none

Don't sent the same version. Either fix what I asked for or keep
discussing the topic.

Ignoring comments will not get the patch merged.

Best regards,
Krzysztof
Re: [PATCH v3 1/2] dt-bindings: arm: qcom: Separete LTE/WIFI SKU for sc7280-evoker
Posted by Doug Anderson 2 months ago
Hi,

On Fri, Sep 23, 2022 at 5:15 AM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 23/09/2022 11:42, Sheng-Liang Pan wrote:
> > evoker will have WIFI/LTE SKU, separete it for each different setting.
> >
> > Signed-off-by: Sheng-Liang Pan <sheng-liang.pan@quanta.corp-partner.google.com>
> > ---
> >
> > Changes in v3:
> > - none
>
> Don't sent the same version. Either fix what I asked for or keep
> discussing the topic.
>
> Ignoring comments will not get the patch merged.

I agree with Krzysztof here. I can't see any difference between v2 and
v3, so I assume that you meant to fix his comment (spell "separete"
correctly in the commit message _and_ ${SUBJECT}) but somehow did
something wrong when sending v3.

In any case, other than the typo this looks fine to me. Feel free to
add my Reviewed-by when the typo is fixed.


-Doug